syzbot


possible deadlock in ocfs2_reserve_local_alloc_bits

Status: upstream: reported on 2024/09/27 17:46
Reported-by: syzbot+fa8da3e825fdf84780a0@syzkaller.appspotmail.com
First crash: 20h29m, last: 1h00m
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in ocfs2_reserve_local_alloc_bits ocfs2 C done 314 13m 37d 0/28 upstream: reported C repro on 2024/08/22 12:35
linux-6.1 possible deadlock in ocfs2_reserve_local_alloc_bits 1 10h09m 10h09m 0/3 upstream: reported on 2024/09/28 04:05

Sample crash report:
(syz.4.2245,12590,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,4) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz.4.2245/12590 is trying to acquire lock:
ffff88804d452648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff88804d452648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635

but task is already holding lock:
ffff8880630c4da0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811
       dqget+0x762/0xe90 fs/quota/dquot.c:986
       ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
       notify_change+0xc6d/0xf50 fs/attr.c:505
       chown_common+0x592/0x890 fs/open.c:680
       vfs_fchown fs/open.c:748 [inline]
       ksys_fchown+0xde/0x150 fs/open.c:759
       __do_sys_fchown fs/open.c:767 [inline]
       __se_sys_fchown fs/open.c:765 [inline]
       __x64_sys_fchown+0x76/0x80 fs/open.c:765
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:789 [inline]
       ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811
       dqget+0x762/0xe90 fs/quota/dquot.c:986
       ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
       notify_change+0xc6d/0xf50 fs/attr.c:505
       chown_common+0x592/0x890 fs/open.c:680
       vfs_fchown fs/open.c:748 [inline]
       ksys_fchown+0xde/0x150 fs/open.c:759
       __do_sys_fchown fs/open.c:767 [inline]
       __se_sys_fchown fs/open.c:765 [inline]
       __x64_sys_fchown+0x76/0x80 fs/open.c:765
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #5 (&dquot->dq_lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       dquot_commit+0x57/0x510 fs/quota/dquot.c:507
       ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6172
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
       __dquot_free_space+0x932/0xe40 fs/quota/dquot.c:1940
       dquot_free_space_nodirty include/linux/quotaops.h:376 [inline]
       dquot_free_space include/linux/quotaops.h:381 [inline]
       dquot_free_block include/linux/quotaops.h:392 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6158 [inline]
       ext4_free_blocks+0x1f6e/0x2ea0 fs/ext4/mballoc.c:6288
       ext4_remove_blocks fs/ext4/extents.c:2519 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2685 [inline]
       ext4_ext_remove_space+0x24da/0x4db0 fs/ext4/extents.c:2933
       ext4_ext_truncate+0x191/0x250 fs/ext4/extents.c:4450
       ext4_truncate+0x9fd/0x1130 fs/ext4/inode.c:4249
       ext4_evict_inode+0xba1/0x1100 fs/ext4/inode.c:289
       evict+0x529/0x930 fs/inode.c:622
       ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474
       ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4974
       mount_bdev+0x2c9/0x3f0 fs/super.c:1398
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1528
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3005
       do_mount fs/namespace.c:3348 [inline]
       __do_sys_mount fs/namespace.c:3556 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3533
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #4 (&ei->i_data_sem){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ext4_map_blocks+0x9a2/0x1c70 fs/ext4/inode.c:665
       mpage_map_one_extent fs/ext4/inode.c:2407 [inline]
       mpage_map_and_submit_extent fs/ext4/inode.c:2460 [inline]
       ext4_writepages+0x160e/0x3d10 fs/ext4/inode.c:2828
       do_writepages+0x481/0x730 mm/page-writeback.c:2386
       __writeback_single_inode+0x15b/0xe30 fs/fs-writeback.c:1647
       writeback_sb_inodes+0xbce/0x1a40 fs/fs-writeback.c:1930
       __writeback_inodes_wb+0x114/0x400 fs/fs-writeback.c:2001
       wb_writeback+0x465/0xc50 fs/fs-writeback.c:2106
       wb_check_background_flush fs/fs-writeback.c:2172 [inline]
       wb_do_writeback fs/fs-writeback.c:2260 [inline]
       wb_workfn+0xd07/0x1130 fs/fs-writeback.c:2288
       process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
       worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
       kthread+0x3f6/0x4f0 kernel/kthread.c:334
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287

-> #3 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882
       generic_shutdown_super+0x136/0x2c0 fs/super.c:475
       kill_block_super+0x7a/0xe0 fs/super.c:1425
       deactivate_locked_super+0xa0/0x110 fs/super.c:335
       cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
       task_work_run+0x129/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
       do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882
       generic_shutdown_super+0x136/0x2c0 fs/super.c:475
       kill_block_super+0x7a/0xe0 fs/super.c:1425
       deactivate_locked_super+0xa0/0x110 fs/super.c:335
       cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
       task_work_run+0x129/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
       do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (sb_internal#7){.+.+}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_mknod+0x15bb/0x2cd0 fs/ocfs2/namei.c:359
       ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672
       lookup_open fs/namei.c:3462 [inline]
       open_last_lookups fs/namei.c:3532 [inline]
       path_openat+0x130a/0x2f20 fs/namei.c:3739
       do_filp_open+0x21c/0x460 fs/namei.c:3769
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
       do_sys_open fs/open.c:1269 [inline]
       __do_sys_openat fs/open.c:1285 [inline]
       __se_sys_openat fs/open.c:1280 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1280
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:789 [inline]
       ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635
       ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
       ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
       ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669
       ocfs2_extend_allocation+0x4e8/0x1ba0 fs/ocfs2/file.c:588
       ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1030
       ocfs2_acquire_dquot+0x631/0xb40 fs/ocfs2/quota_global.c:836
       dqget+0x762/0xe90 fs/quota/dquot.c:986
       ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
       notify_change+0xc6d/0xf50 fs/attr.c:505
       chown_common+0x592/0x890 fs/open.c:680
       vfs_fchown fs/open.c:748 [inline]
       ksys_fchown+0xde/0x150 fs/open.c:759
       __do_sys_fchown fs/open.c:767 [inline]
       __se_sys_fchown fs/open.c:765 [inline]
       __x64_sys_fchown+0x76/0x80 fs/open.c:765
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6);

 *** DEADLOCK ***

5 locks held by syz.4.2245/12590:
 #0: ffff888078480460 (sb_writers#42){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421
 #1: ffff88804d6a9808 (&type->i_mutex_dir_key#34){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
 #1: ffff88804d6a9808 (&type->i_mutex_dir_key#34){+.+.}-{3:3}, at: chown_common+0x499/0x890 fs/open.c:674
 #2: ffff88804d6960a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x28c/0xb40 fs/ocfs2/quota_global.c:806
 #3: ffff8880630c5108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
 #3: ffff8880630c5108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
 #4: ffff8880630c4da0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314

stack backtrace:
CPU: 1 PID: 12590 Comm: syz.4.2245 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:789 [inline]
 ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635
 ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
 ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669
 ocfs2_extend_allocation+0x4e8/0x1ba0 fs/ocfs2/file.c:588
 ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1030
 ocfs2_acquire_dquot+0x631/0xb40 fs/ocfs2/quota_global.c:836
 dqget+0x762/0xe90 fs/quota/dquot.c:986
 ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
 notify_change+0xc6d/0xf50 fs/attr.c:505
 chown_common+0x592/0x890 fs/open.c:680
 vfs_fchown fs/open.c:748 [inline]
 ksys_fchown+0xde/0x150 fs/open.c:759
 __do_sys_fchown fs/open.c:767 [inline]
 __se_sys_fchown fs/open.c:765 [inline]
 __x64_sys_fchown+0x76/0x80 fs/open.c:765
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fc18fadfff9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fc18df58038 EFLAGS: 00000246 ORIG_RAX: 000000000000005d
RAX: ffffffffffffffda RBX: 00007fc18fc97f80 RCX: 00007fc18fadfff9
RDX: 0000000000000000 RSI: 000000000000ee00 RDI: 0000000000000003
RBP: 00007fc18fb52296 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fc18fc97f80 R15: 00007ffdc3d1b838
 </TASK>

Crashes (5):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/09/28 01:02 linux-5.15.y 3a5928702e71 440b26ec .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_reserve_local_alloc_bits
2024/09/28 01:01 linux-5.15.y 3a5928702e71 440b26ec .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_reserve_local_alloc_bits
2024/09/27 17:46 linux-5.15.y 3a5928702e71 440b26ec .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_reserve_local_alloc_bits
2024/09/27 17:45 linux-5.15.y 3a5928702e71 440b26ec .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ocfs2_reserve_local_alloc_bits
2024/09/28 13:14 linux-5.15.y 3a5928702e71 ba29ff75 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ocfs2_reserve_local_alloc_bits
* Struck through repros no longer work on HEAD.