syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.1078/9209 is trying to acquire lock:
ffff8880595b1818 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff8880595b1818 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_xattr_set+0xba4/0x13e0 fs/ocfs2/xattr.c:3622

but task is already holding lock:
ffff88805da506f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x476/0x13e0 fs/ocfs2/xattr.c:3583

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x30a/0x770 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x140f/0x2300 fs/ocfs2/namei.c:410
       ocfs2_mkdir+0x196/0x430 fs/ocfs2/namei.c:657
       vfs_mkdir+0x296/0x440 fs/namei.c:4121
       do_mkdirat+0x1dc/0x450 fs/namei.c:4144
       __do_sys_mkdirat fs/namei.c:4159 [inline]
       __se_sys_mkdirat fs/namei.c:4157 [inline]
       __x64_sys_mkdirat+0x89/0xa0 fs/namei.c:4157
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3a8/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_mknod+0xf1d/0x2300 fs/ocfs2/namei.c:361
       ocfs2_create+0x196/0x430 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3496 [inline]
       open_last_lookups fs/namei.c:3564 [inline]
       path_openat+0x12a0/0x3230 fs/namei.c:3794
       do_filp_open+0x1f5/0x430 fs/namei.c:3824
       do_sys_openat2+0x134/0x1d0 fs/open.c:1421
       do_sys_open fs/open.c:1436 [inline]
       __do_sys_open fs/open.c:1444 [inline]
       __se_sys_open fs/open.c:1440 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1440
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (sb_internal#6){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1633 [inline]
       sb_start_intwrite include/linux/fs.h:1755 [inline]
       ocfs2_start_trans+0x2a9/0x6f0 fs/ocfs2/journal.c:370
       ocfs2_remove_btree_range+0x849/0x15e0 fs/ocfs2/alloc.c:5752
       ocfs2_commit_truncate+0xb7f/0x2280 fs/ocfs2/alloc.c:7353
       ocfs2_truncate_for_delete fs/ocfs2/inode.c:623 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:790 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x1926/0x41e0 fs/ocfs2/inode.c:1219
       evict+0x4ca/0x8d0 fs/inode.c:705
       ocfs2_dentry_iput+0x24e/0x390 fs/ocfs2/dcache.c:418
       __dentry_kill+0x431/0x650 fs/dcache.c:611
       dentry_kill+0xb8/0x290 fs/dcache.c:-1
       dput+0xfe/0x1e0 fs/dcache.c:918
       do_renameat2+0x8f9/0xce0 fs/namei.c:5035
       __do_sys_rename fs/namei.c:5079 [inline]
       __se_sys_rename fs/namei.c:5077 [inline]
       __x64_sys_rename+0x86/0x90 fs/namei.c:5077
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2df1/0x7d40 kernel/locking/lockdep.c:5137
       lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_xattr_set+0xba4/0x13e0 fs/ocfs2/xattr.c:3622
       __vfs_setxattr+0x431/0x470 fs/xattr.c:201
       __vfs_setxattr_noperm+0x12d/0x5e0 fs/xattr.c:235
       vfs_setxattr+0x16b/0x2f0 fs/xattr.c:322
       do_setxattr fs/xattr.c:630 [inline]
       path_setxattr+0x3f3/0x5d0 fs/xattr.c:659
       __do_sys_lsetxattr fs/xattr.c:684 [inline]
       __se_sys_lsetxattr fs/xattr.c:680 [inline]
       __x64_sys_lsetxattr+0xb8/0xd0 fs/xattr.c:680
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);

 *** DEADLOCK ***

3 locks held by syz.4.1078/9209:
 #0: ffff88802677e418 (sb_writers#26){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:412
 #1: ffff88805da509d8 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff88805da509d8 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: vfs_setxattr+0x144/0x2f0 fs/xattr.c:321
 #2: ffff88805da506f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x476/0x13e0 fs/ocfs2/xattr.c:3583

stack backtrace:
CPU: 0 PID: 9209 Comm: syz.4.1078 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/18/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x18c/0x250 lib/dump_stack.c:106
 check_noncircular+0x2fc/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2df1/0x7d40 kernel/locking/lockdep.c:5137
 lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
 down_write+0x97/0x200 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:804 [inline]
 ocfs2_xattr_set+0xba4/0x13e0 fs/ocfs2/xattr.c:3622
 __vfs_setxattr+0x431/0x470 fs/xattr.c:201
 __vfs_setxattr_noperm+0x12d/0x5e0 fs/xattr.c:235
 vfs_setxattr+0x16b/0x2f0 fs/xattr.c:322
 do_setxattr fs/xattr.c:630 [inline]
 path_setxattr+0x3f3/0x5d0 fs/xattr.c:659
 __do_sys_lsetxattr fs/xattr.c:684 [inline]
 __se_sys_lsetxattr fs/xattr.c:680 [inline]
 __x64_sys_lsetxattr+0xb8/0xd0 fs/xattr.c:680
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x55/0xa0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fc549f9c819
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fc5481d5028 EFLAGS: 00000246 ORIG_RAX: 00000000000000bd
RAX: ffffffffffffffda RBX: 00007fc54a216090 RCX: 00007fc549f9c819
RDX: 00002000000001c0 RSI: 0000200000000180 RDI: 00002000000001c0
RBP: 00007fc54a032c91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000361 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fc54a216128 R14: 00007fc54a216090 R15: 00007ffd285a0b58
 </TASK>