syzbot

overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.2934/14463 is trying to acquire lock:
ffff888068d69c40 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}
, at: inode_lock include/linux/fs.h:1028 [inline]
, at: ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3653

but task is already holding lock:
ffff888068f69918 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0 fs/ocfs2/xattr.c:3614

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1537
       ocfs2_xattr_get+0xfa/0x270 fs/ocfs2/xattr.c:1368
       __vfs_getxattr+0x3f4/0x430 fs/xattr.c:423
       smk_fetch+0xb4/0x140 security/smack/smack_lsm.c:289
       smack_d_instantiate+0x757/0x990 security/smack/smack_lsm.c:3653
       security_d_instantiate+0x106/0x1d0 security/security.c:3601
       d_instantiate+0x57/0xc0 fs/dcache.c:2009
       ocfs2_mknod+0x1c98/0x2290 fs/ocfs2/namei.c:454
       ocfs2_mkdir+0x181/0x490 fs/ocfs2/namei.c:660
       vfs_mkdir+0x40b/0x630 fs/namei.c:5233
       filename_mkdirat+0x289/0x520 fs/namei.c:5266
       __do_sys_mkdirat fs/namei.c:5287 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5284
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1537
       ocfs2_start_trans+0x3ac/0x700 fs/ocfs2/journal.c:372
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1252 [inline]
       ocfs2_reserve_local_alloc_bits+0xb43/0x26f0 fs/ocfs2/localalloc.c:669
       ocfs2_reserve_clusters_with_limit+0x1b9/0xc20 fs/ocfs2/suballoc.c:1237
       ocfs2_expand_inline_dir fs/ocfs2/dir.c:2883 [inline]
       ocfs2_extend_dir+0x755/0x4a70 fs/ocfs2/dir.c:3228
       ocfs2_prepare_dir_for_insert+0x34af/0x5370 fs/ocfs2/dir.c:4346
       ocfs2_mknod+0xa1b/0x2290 fs/ocfs2/namei.c:298
       ocfs2_mkdir+0x181/0x490 fs/ocfs2/namei.c:660
       vfs_mkdir+0x40b/0x630 fs/namei.c:5233
       filename_mkdirat+0x289/0x520 fs/namei.c:5266
       __do_sys_mkdirat fs/namei.c:5287 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5284
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#6){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:370
       ocfs2_remove_btree_range+0x84c/0x1610 fs/ocfs2/alloc.c:5761
       ocfs2_commit_truncate+0xbc9/0x2340 fs/ocfs2/alloc.c:7375
       ocfs2_truncate_for_delete fs/ocfs2/inode.c:701 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:868 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x1023/0x44c0 fs/ocfs2/inode.c:1299
       evict+0x61e/0xb10 fs/inode.c:846
       d_delete_notify include/linux/fsnotify.h:377 [inline]
       vfs_rmdir+0x42d/0x6f0 fs/namei.c:5351
       filename_rmdir+0x292/0x520 fs/namei.c:5393
       __do_sys_rmdir fs/namei.c:5416 [inline]
       __se_sys_rmdir+0x2e/0x140 fs/namei.c:5413
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3653
       __vfs_setxattr+0x43c/0x480 fs/xattr.c:200
       __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:234
       vfs_setxattr+0x163/0x370 fs/xattr.c:321
       ovl_do_setxattr fs/overlayfs/overlayfs.h:317 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:329 [inline]
       ovl_make_workdir fs/overlayfs/super.c:728 [inline]
       ovl_get_workdir fs/overlayfs/super.c:840 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1453 [inline]
       ovl_fill_super+0x4b6b/0x5e50 fs/overlayfs/super.c:1564
       vfs_get_super fs/super.c:1327 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1346
       vfs_get_tree+0x92/0x2a0 fs/super.c:1754
       fc_mount fs/namespace.c:1193 [inline]
       do_new_mount_fc fs/namespace.c:3760 [inline]
       do_new_mount+0x341/0xd30 fs/namespace.c:3836
       do_mount fs/namespace.c:4159 [inline]
       __do_sys_mount fs/namespace.c:4348 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4325
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE] --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]);

 *** DEADLOCK ***

4 locks held by syz.4.2934/14463:
 #0: ffff88801cfd00d0 (&type->s_umount_key#90/1){+.+.}-{4:4}, at: alloc_super+0x28c/0xac0 fs/super.c:345
 #1: ffff88805ed5e480 (sb_writers#19){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:493
 #2: ffff888068f69c40 (&sb->s_type->i_mutex_key#32){++++}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
 #2: ffff888068f69c40 (&sb->s_type->i_mutex_key#32){++++}-{4:4}, at: vfs_setxattr+0x13e/0x370 fs/xattr.c:320
 #3: ffff888068f69918 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0 fs/ocfs2/xattr.c:3614

stack backtrace:
CPU: 0 UID: 0 PID: 14463 Comm: syz.4.2934 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
 inode_lock include/linux/fs.h:1028 [inline]
 ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3653
 __vfs_setxattr+0x43c/0x480 fs/xattr.c:200
 __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:234
 vfs_setxattr+0x163/0x370 fs/xattr.c:321
 ovl_do_setxattr fs/overlayfs/overlayfs.h:317 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:329 [inline]
 ovl_make_workdir fs/overlayfs/super.c:728 [inline]
 ovl_get_workdir fs/overlayfs/super.c:840 [inline]
 ovl_fill_super_creds fs/overlayfs/super.c:1453 [inline]
 ovl_fill_super+0x4b6b/0x5e50 fs/overlayfs/super.c:1564
 vfs_get_super fs/super.c:1327 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1346
 vfs_get_tree+0x92/0x2a0 fs/super.c:1754
 fc_mount fs/namespace.c:1193 [inline]
 do_new_mount_fc fs/namespace.c:3760 [inline]
 do_new_mount+0x341/0xd30 fs/namespace.c:3836
 do_mount fs/namespace.c:4159 [inline]
 __do_sys_mount fs/namespace.c:4348 [inline]
 __se_sys_mount+0x31d/0x420 fs/namespace.c:4325
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fad4493c629
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fad42b54028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fad44bb6180 RCX: 00007fad4493c629
RDX: 0000200000000000 RSI: 0000200000000100 RDI: 0000000000000000
RBP: 00007fad449d2b39 R08: 00002000000000c0 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fad44bb6218 R14: 00007fad44bb6180 R15: 00007ffdb3748648
 </TASK>
overlayfs: upper fs missing required features.