syzbot

overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.1136/15502 is trying to acquire lock:
ffff88805f1aad00 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1024 [inline]
ffff88805f1aad00 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_xattr_set+0xbeb/0x13a0 fs/ocfs2/xattr.c:3666

but task is already holding lock:
ffff8880693a0858 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x494/0x13a0 fs/ocfs2/xattr.c:3627

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1574
       ocfs2_xattr_get+0xf4/0x260 fs/ocfs2/xattr.c:1379
       __vfs_getxattr+0x412/0x440 fs/xattr.c:446
       smk_fetch+0xb4/0x140 security/smack/smack_lsm.c:289
       smack_d_instantiate+0x757/0x990 security/smack/smack_lsm.c:3648
       security_d_instantiate+0x106/0x1d0 security/security.c:3704
       d_instantiate+0x54/0xb0 fs/dcache.c:2171
       ocfs2_mknod+0x1c88/0x2240 fs/ocfs2/namei.c:454
       ocfs2_mkdir+0x181/0x460 fs/ocfs2/namei.c:660
       vfs_mkdir+0x402/0x620 fs/namei.c:5276
       filename_mkdirat+0x289/0x520 fs/namei.c:5309
       __do_sys_mkdirat fs/namei.c:5330 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5327
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1574
       ocfs2_start_trans+0x3ac/0x700 fs/ocfs2/journal.c:369
       ocfs2_shutdown_local_alloc+0x1ef/0xa50 fs/ocfs2/localalloc.c:417
       ocfs2_dismount_volume+0x1ec/0x8d0 fs/ocfs2/super.c:1824
       generic_shutdown_super+0x13d/0x2d0 fs/super.c:647
       kill_block_super+0x44/0x90 fs/super.c:1665
       deactivate_locked_super+0xbc/0x130 fs/super.c:477
       cleanup_mnt+0x3d3/0x460 fs/namespace.c:1317
       task_work_run+0x1d9/0x270 kernel/task_work.c:233
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       __exit_to_user_mode_loop kernel/entry/common.c:70 [inline]
       exit_to_user_mode_loop+0x1fa/0x730 kernel/entry/common.c:101
       __exit_to_user_mode_prepare include/linux/irq-entry-common.h:207 [inline]
       syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:230 [inline]
       syscall_exit_to_user_mode include/linux/entry-common.h:318 [inline]
       do_syscall_64+0x353/0x580 arch/x86/entry/syscall_64.c:100
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:367
       ocfs2_remove_btree_range+0x819/0x15f0 fs/ocfs2/alloc.c:5769
       ocfs2_commit_truncate+0xc60/0x2560 fs/ocfs2/alloc.c:7383
       ocfs2_truncate_for_delete fs/ocfs2/inode.c:735 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:902 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1191 [inline]
       ocfs2_evict_inode+0xf8f/0x4360 fs/ocfs2/inode.c:1333
       evict+0x624/0xb50 fs/inode.c:825
       d_delete_notify include/linux/fsnotify.h:381 [inline]
       vfs_rmdir+0x416/0x6b0 fs/namei.c:5394
       filename_rmdir+0x292/0x520 fs/namei.c:5438
       __do_sys_unlinkat fs/namei.c:5613 [inline]
       __se_sys_unlinkat+0x71/0x1a0 fs/namei.c:5606
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x1520/0x2ce0 kernel/locking/lockdep.c:5237
       lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1631
       inode_lock include/linux/fs.h:1024 [inline]
       ocfs2_xattr_set+0xbeb/0x13a0 fs/ocfs2/xattr.c:3666
       __vfs_setxattr+0x442/0x480 fs/xattr.c:223
       __vfs_setxattr_noperm+0x12a/0x660 fs/xattr.c:257
       vfs_setxattr+0x163/0x360 fs/xattr.c:344
       ovl_do_setxattr fs/overlayfs/overlayfs.h:323 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:335 [inline]
       ovl_make_workdir fs/overlayfs/super.c:724 [inline]
       ovl_get_workdir fs/overlayfs/super.c:836 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
       ovl_fill_super+0x3fa0/0x5d40 fs/overlayfs/super.c:1560
       vfs_get_super fs/super.c:1267 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1286
       vfs_get_tree+0x92/0x2a0 fs/super.c:1694
       fc_mount fs/namespace.c:1198 [inline]
       do_new_mount_fc fs/namespace.c:3765 [inline]
       do_new_mount+0x319/0xdc0 fs/namespace.c:3841
       do_mount fs/namespace.c:4174 [inline]
       __do_sys_mount fs/namespace.c:4390 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4367
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE] --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]);

 *** DEADLOCK ***

4 locks held by syz.6.1136/15502:
 #0: ffff8880644c20d0 (&type->s_umount_key#82/1){+.+.}-{4:4}, at: alloc_super fs/super.c:345 [inline]
 #0: ffff8880644c20d0 (&type->s_umount_key#82/1){+.+.}-{4:4}, at: sget_fc+0x938/0x1910 fs/super.c:766
 #1: ffff888061c9e500 (sb_writers#15){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:494
 #2: ffff8880693a0b80 (&sb->s_type->i_mutex_key#28){++++}-{4:4}, at: inode_lock include/linux/fs.h:1024 [inline]
 #2: ffff8880693a0b80 (&sb->s_type->i_mutex_key#28){++++}-{4:4}, at: vfs_setxattr+0x13e/0x360 fs/xattr.c:343
 #3: ffff8880693a0858 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x494/0x13a0 fs/ocfs2/xattr.c:3627

stack backtrace:
CPU: 1 UID: 0 PID: 15502 Comm: syz.6.1136 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/25/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x1520/0x2ce0 kernel/locking/lockdep.c:5237
 lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1631
 inode_lock include/linux/fs.h:1024 [inline]
 ocfs2_xattr_set+0xbeb/0x13a0 fs/ocfs2/xattr.c:3666
 __vfs_setxattr+0x442/0x480 fs/xattr.c:223
 __vfs_setxattr_noperm+0x12a/0x660 fs/xattr.c:257
 vfs_setxattr+0x163/0x360 fs/xattr.c:344
 ovl_do_setxattr fs/overlayfs/overlayfs.h:323 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:335 [inline]
 ovl_make_workdir fs/overlayfs/super.c:724 [inline]
 ovl_get_workdir fs/overlayfs/super.c:836 [inline]
 ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
 ovl_fill_super+0x3fa0/0x5d40 fs/overlayfs/super.c:1560
 vfs_get_super fs/super.c:1267 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1286
 vfs_get_tree+0x92/0x2a0 fs/super.c:1694
 fc_mount fs/namespace.c:1198 [inline]
 do_new_mount_fc fs/namespace.c:3765 [inline]
 do_new_mount+0x319/0xdc0 fs/namespace.c:3841
 do_mount fs/namespace.c:4174 [inline]
 __do_sys_mount fs/namespace.c:4390 [inline]
 __se_sys_mount+0x31d/0x420 fs/namespace.c:4367
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fb10d8fde99
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb10bb56028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fb10db85fa0 RCX: 00007fb10d8fde99
RDX: 0000200000000440 RSI: 0000200000000100 RDI: 0000000000000000
RBP: 00007fb10d993eaf R08: 0000200000000140 R09: 0000000000000000
R10: 0000000000000008 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fb10db86038 R14: 00007fb10db85fa0 R15: 00007ffecc5839b8
 </TASK>
overlayfs: upper fs missing required features.