syzbot

overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.667/10880 is trying to acquire lock:
ffff88805e1d8b80 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
ffff88805e1d8b80 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3652

but task is already holding lock:
ffff888060058858 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0 fs/ocfs2/xattr.c:3613

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1537
       ocfs2_xattr_get+0xfa/0x270 fs/ocfs2/xattr.c:1368
       __vfs_getxattr+0x3f4/0x430 fs/xattr.c:423
       smk_fetch+0xb4/0x140 security/smack/smack_lsm.c:289
       smack_d_instantiate+0x757/0x990 security/smack/smack_lsm.c:3653
       security_d_instantiate+0x106/0x1d0 security/security.c:3601
       d_instantiate+0x57/0xc0 fs/dcache.c:1999
       ocfs2_mknod+0x1a4a/0x2210 fs/ocfs2/namei.c:454
       ocfs2_mkdir+0x181/0x430 fs/ocfs2/namei.c:660
       vfs_mkdir+0x52c/0x5d0 fs/namei.c:5139
       do_mkdirat+0x281/0x4c0 fs/namei.c:5173
       __do_sys_mkdirat fs/namei.c:5195 [inline]
       __se_sys_mkdirat fs/namei.c:5193 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:5193
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1537
       ocfs2_start_trans+0x3ac/0x700 fs/ocfs2/journal.c:372
       ocfs2_shutdown_local_alloc+0x1fb/0xab0 fs/ocfs2/localalloc.c:417
       ocfs2_dismount_volume+0x1ec/0x8c0 fs/ocfs2/super.c:1825
       generic_shutdown_super+0x135/0x2c0 fs/super.c:643
       kill_block_super+0x44/0x90 fs/super.c:1722
       deactivate_locked_super+0xbc/0x130 fs/super.c:474
       cleanup_mnt+0x437/0x4d0 fs/namespace.c:1318
       task_work_run+0x1d9/0x270 kernel/task_work.c:233
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       __exit_to_user_mode_loop kernel/entry/common.c:44 [inline]
       exit_to_user_mode_loop+0xed/0x480 kernel/entry/common.c:75
       __exit_to_user_mode_prepare include/linux/irq-entry-common.h:226 [inline]
       syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:256 [inline]
       syscall_exit_to_user_mode_work include/linux/entry-common.h:159 [inline]
       syscall_exit_to_user_mode include/linux/entry-common.h:194 [inline]
       do_syscall_64+0x2b7/0xf80 arch/x86/entry/syscall_64.c:100
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:370
       ocfs2_remove_btree_range+0x84c/0x1610 fs/ocfs2/alloc.c:5760
       ocfs2_commit_truncate+0xbb8/0x22f0 fs/ocfs2/alloc.c:7374
       ocfs2_truncate_for_delete fs/ocfs2/inode.c:701 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:868 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x1023/0x42c0 fs/ocfs2/inode.c:1299
       evict+0x61e/0xb10 fs/inode.c:837
       do_unlinkat+0x354/0x590 fs/namei.c:5452
       __do_sys_unlink fs/namei.c:5483 [inline]
       __se_sys_unlink fs/namei.c:5481 [inline]
       __x64_sys_unlink+0x47/0x50 fs/namei.c:5481
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0x106/0x330 kernel/locking/lockdep.c:5868
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1027 [inline]
       ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3652
       __vfs_setxattr+0x43c/0x480 fs/xattr.c:200
       __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:234
       vfs_setxattr+0x16a/0x2f0 fs/xattr.c:321
       ovl_do_setxattr fs/overlayfs/overlayfs.h:317 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:329 [inline]
       ovl_make_workdir fs/overlayfs/super.c:728 [inline]
       ovl_get_workdir fs/overlayfs/super.c:840 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1453 [inline]
       ovl_fill_super+0x4b50/0x5e60 fs/overlayfs/super.c:1567
       vfs_get_super fs/super.c:1324 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1343
       vfs_get_tree+0x92/0x2a0 fs/super.c:1751
       fc_mount fs/namespace.c:1199 [inline]
       do_new_mount_fc fs/namespace.c:3636 [inline]
       do_new_mount+0x329/0xa50 fs/namespace.c:3712
       do_mount fs/namespace.c:4035 [inline]
       __do_sys_mount fs/namespace.c:4224 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4201
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE] --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]);

 *** DEADLOCK ***

4 locks held by syz.6.667/10880:
 #0: ffff88806c35a0d0 (&type->s_umount_key#66/1){+.+.}-{4:4}, at: alloc_super+0x28c/0xab0 fs/super.c:344
 #1: ffff888033dc0480 (sb_writers#26){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:499
 #2: ffff888060058b80 (&sb->s_type->i_mutex_key#42){++++}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #2: ffff888060058b80 (&sb->s_type->i_mutex_key#42){++++}-{4:4}, at: vfs_setxattr+0x143/0x2f0 fs/xattr.c:320
 #3: ffff888060058858 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0 fs/ocfs2/xattr.c:3613

stack backtrace:
CPU: 0 UID: 0 PID: 10880 Comm: syz.6.667 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/13/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0x106/0x330 kernel/locking/lockdep.c:5868
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
 inode_lock include/linux/fs.h:1027 [inline]
 ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3652
 __vfs_setxattr+0x43c/0x480 fs/xattr.c:200
 __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:234
 vfs_setxattr+0x16a/0x2f0 fs/xattr.c:321
 ovl_do_setxattr fs/overlayfs/overlayfs.h:317 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:329 [inline]
 ovl_make_workdir fs/overlayfs/super.c:728 [inline]
 ovl_get_workdir fs/overlayfs/super.c:840 [inline]
 ovl_fill_super_creds fs/overlayfs/super.c:1453 [inline]
 ovl_fill_super+0x4b50/0x5e60 fs/overlayfs/super.c:1567
 vfs_get_super fs/super.c:1324 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1343
 vfs_get_tree+0x92/0x2a0 fs/super.c:1751
 fc_mount fs/namespace.c:1199 [inline]
 do_new_mount_fc fs/namespace.c:3636 [inline]
 do_new_mount+0x329/0xa50 fs/namespace.c:3712
 do_mount fs/namespace.c:4035 [inline]
 __do_sys_mount fs/namespace.c:4224 [inline]
 __se_sys_mount+0x31d/0x420 fs/namespace.c:4201
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f055b43acb9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f0559696028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f055b6b5fa0 RCX: 00007f055b43acb9
RDX: 0000200000000b80 RSI: 0000200000000000 RDI: 0000000000000000
RBP: 00007f055b4a8bf7 R08: 0000200000000200 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f055b6b6038 R14: 00007f055b6b5fa0 R15: 00007ffd58d540d8
 </TASK>
------------[ cut here ]------------
UBSAN: array-index-out-of-bounds in fs/ocfs2/xattr.c:1985:3
index 2 is out of range for type 'struct ocfs2_xattr_entry[] __counted_by(xh_count)' (aka 'struct ocfs2_xattr_entry[]')
CPU: 0 UID: 0 PID: 10880 Comm: syz.6.667 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/13/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 ubsan_epilogue+0xa/0x30 lib/ubsan.c:233
 __ubsan_handle_out_of_bounds+0xe8/0xf0 lib/ubsan.c:455
 ocfs2_xa_remove_entry+0x49e/0x670 fs/ocfs2/xattr.c:1985
 ocfs2_xa_remove fs/ocfs2/xattr.c:2073 [inline]
 ocfs2_xa_set+0xb27/0x2b50 fs/ocfs2/xattr.c:2277
 ocfs2_xattr_block_set+0x3e0/0x3350 fs/ocfs2/xattr.c:3015
 __ocfs2_xattr_set_handle+0x262/0xf50 fs/ocfs2/xattr.c:-1
 ocfs2_xattr_set+0xf3f/0x13e0 fs/ocfs2/xattr.c:3680
 __vfs_removexattr+0x431/0x470 fs/xattr.c:518
 __vfs_removexattr_locked+0x1ee/0x230 fs/xattr.c:553
 vfs_removexattr+0x80/0x1b0 fs/xattr.c:575
 ovl_do_removexattr fs/overlayfs/overlayfs.h:335 [inline]
 ovl_removexattr fs/overlayfs/overlayfs.h:343 [inline]
 ovl_make_workdir fs/overlayfs/super.c:760 [inline]
 ovl_get_workdir fs/overlayfs/super.c:840 [inline]
 ovl_fill_super_creds fs/overlayfs/super.c:1453 [inline]
 ovl_fill_super+0x4c39/0x5e60 fs/overlayfs/super.c:1567
 vfs_get_super fs/super.c:1324 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1343
 vfs_get_tree+0x92/0x2a0 fs/super.c:1751
 fc_mount fs/namespace.c:1199 [inline]
 do_new_mount_fc fs/namespace.c:3636 [inline]
 do_new_mount+0x329/0xa50 fs/namespace.c:3712
 do_mount fs/namespace.c:4035 [inline]
 __do_sys_mount fs/namespace.c:4224 [inline]
 __se_sys_mount+0x31d/0x420 fs/namespace.c:4201
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f055b43acb9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f0559696028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f055b6b5fa0 RCX: 00007f055b43acb9
RDX: 0000200000000b80 RSI: 0000200000000000 RDI: 0000000000000000
RBP: 00007f055b4a8bf7 R08: 0000200000000200 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f055b6b6038 R14: 00007f055b6b5fa0 R15: 00007ffd58d540d8
 </TASK>
---[ end trace ]---