syzbot

overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.689/11621 is trying to acquire lock:
ffff888066e42d00 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
ffff888066e42d00 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3653

but task is already holding lock:
ffff888060266cd8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0 fs/ocfs2/xattr.c:3614

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1568
       ocfs2_xattr_get+0xfa/0x270 fs/ocfs2/xattr.c:1368
       __vfs_getxattr+0x3f4/0x430 fs/xattr.c:441
       smk_fetch+0xb4/0x140 security/smack/smack_lsm.c:289
       smack_d_instantiate+0x757/0x990 security/smack/smack_lsm.c:3653
       security_d_instantiate+0x106/0x1d0 security/security.c:3704
       d_instantiate+0x54/0xb0 fs/dcache.c:2076
       ocfs2_mknod+0x1c98/0x2260 fs/ocfs2/namei.c:454
       ocfs2_create+0x195/0x460 fs/ocfs2/namei.c:677
       lookup_open fs/namei.c:4511 [inline]
       open_last_lookups fs/namei.c:4611 [inline]
       path_openat+0x13b4/0x38a0 fs/namei.c:4855
       do_file_open+0x23e/0x4a0 fs/namei.c:4887
       do_sys_openat2+0x113/0x200 fs/open.c:1364
       do_sys_open fs/open.c:1370 [inline]
       __do_sys_openat fs/open.c:1386 [inline]
       __se_sys_openat fs/open.c:1381 [inline]
       __x64_sys_openat+0x138/0x170 fs/open.c:1381
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1568
       ocfs2_start_trans+0x3ac/0x700 fs/ocfs2/journal.c:369
       ocfs2_shutdown_local_alloc+0x1f5/0xa40 fs/ocfs2/localalloc.c:417
       ocfs2_dismount_volume+0x1ec/0x8d0 fs/ocfs2/super.c:1825
       generic_shutdown_super+0x13d/0x2d0 fs/super.c:646
       kill_block_super+0x44/0x90 fs/super.c:1725
       deactivate_locked_super+0xbc/0x130 fs/super.c:476
       cleanup_mnt+0x437/0x4d0 fs/namespace.c:1312
       task_work_run+0x1d9/0x270 kernel/task_work.c:233
       resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
       __exit_to_user_mode_loop kernel/entry/common.c:67 [inline]
       exit_to_user_mode_loop+0x193/0x680 kernel/entry/common.c:98
       __exit_to_user_mode_prepare include/linux/irq-entry-common.h:207 [inline]
       syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:230 [inline]
       syscall_exit_to_user_mode include/linux/entry-common.h:318 [inline]
       do_syscall_64+0x353/0x580 arch/x86/entry/syscall_64.c:100
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#4){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:367
       ocfs2_remove_btree_range+0x84c/0x1610 fs/ocfs2/alloc.c:5769
       ocfs2_commit_truncate+0xbb8/0x2310 fs/ocfs2/alloc.c:7383
       ocfs2_truncate_for_delete fs/ocfs2/inode.c:701 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:868 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x1023/0x4390 fs/ocfs2/inode.c:1299
       evict+0x61e/0xb10 fs/inode.c:841
       ocfs2_dentry_iput+0x24d/0x390 fs/ocfs2/dcache.c:407
       __dentry_kill+0x1a2/0x690 fs/dcache.c:718
       finish_dput+0xc9/0x480 fs/dcache.c:927
       path_put fs/namei.c:717 [inline]
       terminate_walk+0x189/0x510 fs/namei.c:846
       path_openat+0x308d/0x38a0 fs/namei.c:4859
       do_file_open+0x23e/0x4a0 fs/namei.c:4887
       do_sys_openat2+0x113/0x200 fs/open.c:1364
       do_sys_open fs/open.c:1370 [inline]
       __do_sys_openat fs/open.c:1386 [inline]
       __se_sys_openat fs/open.c:1381 [inline]
       __x64_sys_openat+0x138/0x170 fs/open.c:1381
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1625
       inode_lock include/linux/fs.h:1029 [inline]
       ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3653
       __vfs_setxattr+0x43c/0x480 fs/xattr.c:218
       __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:252
       vfs_setxattr+0x163/0x370 fs/xattr.c:339
       ovl_do_setxattr fs/overlayfs/overlayfs.h:323 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:335 [inline]
       ovl_make_workdir fs/overlayfs/super.c:724 [inline]
       ovl_get_workdir fs/overlayfs/super.c:836 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
       ovl_fill_super+0x4b5e/0x5e20 fs/overlayfs/super.c:1560
       vfs_get_super fs/super.c:1327 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1346
       vfs_get_tree+0x92/0x2a0 fs/super.c:1754
       fc_mount fs/namespace.c:1193 [inline]
       do_new_mount_fc fs/namespace.c:3758 [inline]
       do_new_mount+0x341/0xd30 fs/namespace.c:3834
       do_mount fs/namespace.c:4167 [inline]
       __do_sys_mount fs/namespace.c:4383 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4360
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE] --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]);

 *** DEADLOCK ***

4 locks held by syz.6.689/11621:
 #0: ffff888062fac0d0 (&type->s_umount_key#116/1){+.+.}-{4:4}, at: alloc_super+0x28c/0xac0 fs/super.c:345
 #1: ffff888080edc480 (sb_writers#26){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:493
 #2: ffff888060267000 (&sb->s_type->i_mutex_key#46){++++}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
 #2: ffff888060267000 (&sb->s_type->i_mutex_key#46){++++}-{4:4}, at: vfs_setxattr+0x13e/0x370 fs/xattr.c:338
 #3: ffff888060266cd8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0 fs/ocfs2/xattr.c:3614

stack backtrace:
CPU: 1 UID: 0 PID: 11621 Comm: syz.6.689 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/18/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1625
 inode_lock include/linux/fs.h:1029 [inline]
 ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3653
 __vfs_setxattr+0x43c/0x480 fs/xattr.c:218
 __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:252
 vfs_setxattr+0x163/0x370 fs/xattr.c:339
 ovl_do_setxattr fs/overlayfs/overlayfs.h:323 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:335 [inline]
 ovl_make_workdir fs/overlayfs/super.c:724 [inline]
 ovl_get_workdir fs/overlayfs/super.c:836 [inline]
 ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
 ovl_fill_super+0x4b5e/0x5e20 fs/overlayfs/super.c:1560
 vfs_get_super fs/super.c:1327 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1346
 vfs_get_tree+0x92/0x2a0 fs/super.c:1754
 fc_mount fs/namespace.c:1193 [inline]
 do_new_mount_fc fs/namespace.c:3758 [inline]
 do_new_mount+0x341/0xd30 fs/namespace.c:3834
 do_mount fs/namespace.c:4167 [inline]
 __do_sys_mount fs/namespace.c:4383 [inline]
 __se_sys_mount+0x31d/0x420 fs/namespace.c:4360
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x174/0x580 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f9bac34ce59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9baa141028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f9bac5c6270 RCX: 00007f9bac34ce59
RDX: 0000200000000b80 RSI: 0000200000000240 RDI: 0000000000000000
RBP: 00007f9bac3e2d6f R08: 0000200000000340 R09: 0000000000000000
R10: 0000000000000008 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f9bac5c6308 R14: 00007f9bac5c6270 R15: 00007ffc5d2d0d38
 </TASK>
overlayfs: upper fs missing required features.