overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.9.1048/19115 is trying to acquire lock:
ffff888061ad0b80 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1024 [inline]
ffff888061ad0b80 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_xattr_set+0xbeb/0x13a0 fs/ocfs2/xattr.c:3871

but task is already holding lock:
ffff888061a8ba98 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x494/0x13a0 fs/ocfs2/xattr.c:3832

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1574
       ocfs2_xattr_get+0xf4/0x260 fs/ocfs2/xattr.c:1578
       __vfs_getxattr+0x412/0x440 fs/xattr.c:446
       smk_fetch+0xb4/0x140 security/smack/smack_lsm.c:298
       smack_d_instantiate+0x757/0x990 security/smack/smack_lsm.c:3679
       security_d_instantiate+0x106/0x1d0 security/security.c:3703
       d_instantiate+0x54/0xb0 fs/dcache.c:2176
       ocfs2_mknod+0x1acb/0x22b0 fs/ocfs2/namei.c:459
       ocfs2_mkdir+0x180/0x430 fs/ocfs2/namei.c:667
       vfs_mkdir+0x408/0x620 fs/namei.c:5410
       filename_mkdirat+0x289/0x520 fs/namei.c:5443
       __do_sys_mkdirat fs/namei.c:5464 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5461
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1574
       ocfs2_start_trans+0x3af/0x700 fs/ocfs2/journal.c:369
       ocfs2_update_inode_atime+0xef/0x590 fs/ocfs2/file.c:262
       ocfs2_inode_lock_atime+0x33b/0x540 fs/ocfs2/dlmglue.c:2607
       ocfs2_readdir+0x1be/0x550 fs/ocfs2/dir.c:2041
       wrap_directory_iterator+0x99/0xe0 fs/readdir.c:67
       iterate_dir+0x2f1/0x4e0 fs/readdir.c:110
       __do_sys_getdents64 fs/readdir.c:399 [inline]
       __se_sys_getdents64+0xf1/0x280 fs/readdir.c:384
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:367
       ocfs2_remove_btree_range+0x819/0x15f0 fs/ocfs2/alloc.c:5769
       ocfs2_commit_truncate+0xc60/0x2560 fs/ocfs2/alloc.c:7383
       ocfs2_truncate_for_delete fs/ocfs2/inode.c:735 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:902 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1191 [inline]
       ocfs2_evict_inode+0xf8f/0x4360 fs/ocfs2/inode.c:1333
       evict+0x624/0xb50 fs/inode.c:822
       d_delete_notify include/linux/fsnotify.h:381 [inline]
       vfs_rmdir+0x416/0x6b0 fs/namei.c:5528
       filename_rmdir+0x292/0x520 fs/namei.c:5572
       __do_sys_unlinkat fs/namei.c:5747 [inline]
       __se_sys_unlinkat+0x71/0x1a0 fs/namei.c:5740
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3181 [inline]
       check_prevs_add kernel/locking/lockdep.c:3300 [inline]
       validate_chain kernel/locking/lockdep.c:3924 [inline]
       __lock_acquire+0x15ff/0x2e40 kernel/locking/lockdep.c:5254
       lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5908
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1631
       inode_lock include/linux/fs.h:1024 [inline]
       ocfs2_xattr_set+0xbeb/0x13a0 fs/ocfs2/xattr.c:3871
       __vfs_setxattr+0x442/0x480 fs/xattr.c:223
       __vfs_setxattr_noperm+0x12a/0x660 fs/xattr.c:257
       vfs_setxattr+0x163/0x360 fs/xattr.c:344
       ovl_do_setxattr fs/overlayfs/overlayfs.h:324 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:336 [inline]
       ovl_make_workdir fs/overlayfs/super.c:724 [inline]
       ovl_get_workdir+0xd18/0x1980 fs/overlayfs/super.c:836
       ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
       ovl_fill_super+0x1702/0x4360 fs/overlayfs/super.c:1561
       vfs_get_super fs/super.c:1405 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1424
       vfs_get_tree+0x92/0x2a0 fs/super.c:1947
       fc_mount fs/namespace.c:1198 [inline]
       do_new_mount_fc fs/namespace.c:3772 [inline]
       do_new_mount+0x319/0xdc0 fs/namespace.c:3848
       do_mount fs/namespace.c:4181 [inline]
       __do_sys_mount fs/namespace.c:4397 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4374
       do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
       do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE] --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]);

 *** DEADLOCK ***

locks held by syz.9.1048/19115: 4, last CPU#1:
 #0: ffff8880319e80e0 (&type->s_umount_key#54/1){+.+.}-{4:4}, at: alloc_super fs/super.c:365 [inline]
 #0: ffff8880319e80e0 (&type->s_umount_key#54/1){+.+.}-{4:4}, at: sget_fc+0x97c/0x1a60 fs/super.c:889
 #1: ffff88802a590510 (sb_writers#15){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:494
 #2: ffff888061a8bdc0 (&sb->s_type->i_mutex_key#36){++++}-{4:4}, at: inode_lock include/linux/fs.h:1024 [inline]
 #2: ffff888061a8bdc0 (&sb->s_type->i_mutex_key#36){++++}-{4:4}, at: vfs_setxattr+0x13e/0x360 fs/xattr.c:343
 #3: ffff888061a8ba98 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x494/0x13a0 fs/ocfs2/xattr.c:3832

stack backtrace:
CPU: 1 UID: 0 PID: 19115 Comm: syz.9.1048 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e2/0x300 kernel/locking/lockdep.c:2059
 check_noncircular+0x12f/0x150 kernel/locking/lockdep.c:2191
 check_prev_add kernel/locking/lockdep.c:3181 [inline]
 check_prevs_add kernel/locking/lockdep.c:3300 [inline]
 validate_chain kernel/locking/lockdep.c:3924 [inline]
 __lock_acquire+0x15ff/0x2e40 kernel/locking/lockdep.c:5254
 lock_acquire+0x115/0x350 kernel/locking/lockdep.c:5908
 down_write+0x3a/0x50 kernel/locking/rwsem.c:1631
 inode_lock include/linux/fs.h:1024 [inline]
 ocfs2_xattr_set+0xbeb/0x13a0 fs/ocfs2/xattr.c:3871
 __vfs_setxattr+0x442/0x480 fs/xattr.c:223
 __vfs_setxattr_noperm+0x12a/0x660 fs/xattr.c:257
 vfs_setxattr+0x163/0x360 fs/xattr.c:344
 ovl_do_setxattr fs/overlayfs/overlayfs.h:324 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:336 [inline]
 ovl_make_workdir fs/overlayfs/super.c:724 [inline]
 ovl_get_workdir+0xd18/0x1980 fs/overlayfs/super.c:836
 ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
 ovl_fill_super+0x1702/0x4360 fs/overlayfs/super.c:1561
 vfs_get_super fs/super.c:1405 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1424
 vfs_get_tree+0x92/0x2a0 fs/super.c:1947
 fc_mount fs/namespace.c:1198 [inline]
 do_new_mount_fc fs/namespace.c:3772 [inline]
 do_new_mount+0x319/0xdc0 fs/namespace.c:3848
 do_mount fs/namespace.c:4181 [inline]
 __do_sys_mount fs/namespace.c:4397 [inline]
 __se_sys_mount+0x31d/0x420 fs/namespace.c:4374
 do_syscall_x64 arch/x86/entry/syscall_64.c:61 [inline]
 do_syscall_64+0x166/0x520 arch/x86/entry/syscall_64.c:84
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f3f83d2e159
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f3f81f65028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f3f83fb6090 RCX: 00007f3f83d2e159
RDX: 0000200000000b80 RSI: 0000200000000000 RDI: 0000000000000000
RBP: 00007f3f83dc5024 R08: 0000200000000180 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f3f83fb6128 R14: 00007f3f83fb6090 R15: 00007ffec42298a8
 </TASK>
overlayfs: upper fs missing required features.