syzbot

ocfs2: Mounting device (7,9) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Tainted: G             L     
------------------------------------------------------
syz.9.2889/22080 is trying to acquire lock:
ffff88804779b480 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
ffff88804779b480 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3653

but task is already holding lock:
ffff888053ce5c78 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0 fs/ocfs2/xattr.c:3614

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x47/0x2e0 kernel/locking/rwsem.c:1537
       ocfs2_init_acl+0x2fd/0x7e0 fs/ocfs2/acl.c:367
       ocfs2_mknod+0x1679/0x2290 fs/ocfs2/namei.c:414
       ocfs2_create+0x195/0x490 fs/ocfs2/namei.c:677
       lookup_open fs/namei.c:4489 [inline]
       open_last_lookups fs/namei.c:4589 [inline]
       path_openat+0x1395/0x3860 fs/namei.c:4833
       do_file_open+0x23e/0x4a0 fs/namei.c:4865
       do_sys_openat2+0x113/0x200 fs/open.c:1366
       do_sys_open fs/open.c:1372 [inline]
       __do_sys_creat fs/open.c:1450 [inline]
       __se_sys_creat fs/open.c:1444 [inline]
       __x64_sys_creat+0x8f/0xc0 fs/open.c:1444
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x47/0x2e0 kernel/locking/rwsem.c:1537
       ocfs2_start_trans+0x3ab/0x700 fs/ocfs2/journal.c:369
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1252 [inline]
       ocfs2_reserve_local_alloc_bits+0xb43/0x26f0 fs/ocfs2/localalloc.c:669
       ocfs2_reserve_clusters_with_limit+0x1b9/0xc20 fs/ocfs2/suballoc.c:1237
       ocfs2_expand_inline_dir fs/ocfs2/dir.c:2882 [inline]
       ocfs2_extend_dir+0x754/0x4a60 fs/ocfs2/dir.c:3227
       ocfs2_prepare_dir_for_insert+0x34b0/0x5360 fs/ocfs2/dir.c:4345
       ocfs2_mknod+0xa1b/0x2290 fs/ocfs2/namei.c:298
       ocfs2_mkdir+0x181/0x490 fs/ocfs2/namei.c:660
       vfs_mkdir+0x413/0x630 fs/namei.c:5239
       filename_mkdirat+0x285/0x510 fs/namei.c:5272
       __do_sys_mkdirat fs/namei.c:5293 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5290
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#8){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:367
       ocfs2_remove_btree_range+0x84c/0x1610 fs/ocfs2/alloc.c:5760
       ocfs2_commit_truncate+0xbc9/0x2340 fs/ocfs2/alloc.c:7374
       ocfs2_truncate_for_delete fs/ocfs2/inode.c:701 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:868 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x1023/0x44e0 fs/ocfs2/inode.c:1299
       evict+0x61e/0xb10 fs/inode.c:846
       filename_unlinkat+0x43f/0x610 fs/namei.c:5550
       __do_sys_unlinkat fs/namei.c:5575 [inline]
       __se_sys_unlinkat+0x83/0x1a0 fs/namei.c:5567
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3653
       __vfs_setxattr+0x43c/0x480 fs/xattr.c:200
       __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:234
       vfs_setxattr+0x163/0x360 fs/xattr.c:321
       do_setxattr fs/xattr.c:636 [inline]
       filename_setxattr+0x296/0x630 fs/xattr.c:664
       path_setxattrat+0x3eb/0x440 fs/xattr.c:708
       __do_sys_setxattr fs/xattr.c:742 [inline]
       __se_sys_setxattr fs/xattr.c:738 [inline]
       __x64_sys_setxattr+0xbc/0xe0 fs/xattr.c:738
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE] --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]);

 *** DEADLOCK ***

3 locks held by syz.9.2889/22080:
 #0: ffff8880a47e6420 (sb_writers#43){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:493
 #1: ffff888053ce5f40 (&sb->s_type->i_mutex_key#64){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
 #1: ffff888053ce5f40 (&sb->s_type->i_mutex_key#64){+.+.}-{4:4}, at: vfs_setxattr+0x13e/0x360 fs/xattr.c:320
 #2: ffff888053ce5c78 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0 fs/ocfs2/xattr.c:3614

stack backtrace:
CPU: 0 UID: 0 PID: 22080 Comm: syz.9.2889 Tainted: G             L      syzkaller #0 PREEMPT(full) 
Tainted: [L]=SOFTLOCKUP
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/18/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
 down_write+0x96/0x200 kernel/locking/rwsem.c:1590
 inode_lock include/linux/fs.h:1028 [inline]
 ocfs2_xattr_set+0xba7/0x13e0 fs/ocfs2/xattr.c:3653
 __vfs_setxattr+0x43c/0x480 fs/xattr.c:200
 __vfs_setxattr_noperm+0x12d/0x660 fs/xattr.c:234
 vfs_setxattr+0x163/0x360 fs/xattr.c:321
 do_setxattr fs/xattr.c:636 [inline]
 filename_setxattr+0x296/0x630 fs/xattr.c:664
 path_setxattrat+0x3eb/0x440 fs/xattr.c:708
 __do_sys_setxattr fs/xattr.c:742 [inline]
 __se_sys_setxattr fs/xattr.c:738 [inline]
 __x64_sys_setxattr+0xbc/0xe0 fs/xattr.c:738
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fa73639c819
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa737263028 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc
RAX: ffffffffffffffda RBX: 00007fa736615fa0 RCX: 00007fa73639c819
RDX: 0000000000000000 RSI: 00002000000004c0 RDI: 0000200000000480
RBP: 00007fa736432c91 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fa736616038 R14: 00007fa736615fa0 R15: 00007ffc16df8248
 </TASK>