overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.1.1877/9494 is trying to acquire lock:
ffff8880747d42c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:793 [inline]
ffff8880747d42c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_xattr_set+0xbd0/0x1390 fs/ocfs2/xattr.c:3632

but task is already holding lock:
ffff8880747d86f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x47d/0x1390 fs/ocfs2/xattr.c:3593

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_init_acl+0x307/0x770 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x15de/0x2510 fs/ocfs2/namei.c:410
       ocfs2_mkdir+0x192/0x420 fs/ocfs2/namei.c:657
       vfs_mkdir+0x386/0x570 fs/namei.c:4116
       do_mkdirat+0x1dd/0x5c0 fs/namei.c:4141
       __do_sys_mkdirat fs/namei.c:4156 [inline]
       __se_sys_mkdirat fs/namei.c:4154 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4154
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (jbd2_handle){++++}-{0:0}:
       jbd2_journal_lock_updates+0xa4/0x390 fs/jbd2/transaction.c:881
       __ocfs2_flush_truncate_log+0x2b4/0x1110 fs/ocfs2/alloc.c:6027
       ocfs2_flush_truncate_log+0x4b/0x60 fs/ocfs2/alloc.c:6074
       ocfs2_sync_fs+0x119/0x330 fs/ocfs2/super.c:403
       sync_filesystem+0x1be/0x220 fs/sync.c:66
       generic_shutdown_super+0x6b/0x300 fs/super.c:448
       kill_block_super+0x7c/0xe0 fs/super.c:1438
       deactivate_locked_super+0x93/0xf0 fs/super.c:335
       cleanup_mnt+0x426/0x4d0 fs/namespace.c:1148
       task_work_run+0x125/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x10f/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xee/0x180 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:307
       do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:793 [inline]
       ocfs2_xattr_set+0xbd0/0x1390 fs/ocfs2/xattr.c:3632
       __vfs_setxattr+0x3d8/0x410 fs/xattr.c:182
       __vfs_setxattr_noperm+0x126/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x167/0x2e0 fs/xattr.c:303
       ovl_do_setxattr fs/overlayfs/overlayfs.h:214 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:225 [inline]
       ovl_make_workdir fs/overlayfs/super.c:1422 [inline]
       ovl_get_workdir+0x9e8/0x12a0 fs/overlayfs/super.c:1526
       ovl_fill_super+0x1cd4/0x42a0 fs/overlayfs/super.c:2082
       mount_nodev+0x52/0xe0 fs/super.c:1457
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1541
       do_new_mount+0x247/0xa40 fs/namespace.c:3034
       do_mount fs/namespace.c:3377 [inline]
       __do_sys_mount fs/namespace.c:3585 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3562
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);

 *** DEADLOCK ***

4 locks held by syz.1.1877/9494:
 #0: ffff8880535820e0 (&type->s_umount_key#82/1){+.+.}-{3:3}, at: alloc_super+0x200/0x970 fs/super.c:229
 #1: ffff88802123a460 (sb_writers#35){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:386
 #2: ffff8880747d89c8 (&sb->s_type->i_mutex_key#48){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:793 [inline]
 #2: ffff8880747d89c8 (&sb->s_type->i_mutex_key#48){+.+.}-{3:3}, at: vfs_setxattr+0x140/0x2e0 fs/xattr.c:302
 #3: ffff8880747d86f8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x47d/0x1390 fs/ocfs2/xattr.c:3593

stack backtrace:
CPU: 0 PID: 9494 Comm: syz.1.1877 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:793 [inline]
 ocfs2_xattr_set+0xbd0/0x1390 fs/ocfs2/xattr.c:3632
 __vfs_setxattr+0x3d8/0x410 fs/xattr.c:182
 __vfs_setxattr_noperm+0x126/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x167/0x2e0 fs/xattr.c:303
 ovl_do_setxattr fs/overlayfs/overlayfs.h:214 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:225 [inline]
 ovl_make_workdir fs/overlayfs/super.c:1422 [inline]
 ovl_get_workdir+0x9e8/0x12a0 fs/overlayfs/super.c:1526
 ovl_fill_super+0x1cd4/0x42a0 fs/overlayfs/super.c:2082
 mount_nodev+0x52/0xe0 fs/super.c:1457
 legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
 vfs_get_tree+0x88/0x270 fs/super.c:1541
 do_new_mount+0x247/0xa40 fs/namespace.c:3034
 do_mount fs/namespace.c:3377 [inline]
 __do_sys_mount fs/namespace.c:3585 [inline]
 __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3562
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f76e1f83159
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f76e01db028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f76e220afa0 RCX: 00007f76e1f83159
RDX: 0000200000000b80 RSI: 0000200000000200 RDI: 0000000000000000
RBP: 00007f76e201a03b R08: 0000200000000180 R09: 0000000000000000
R10: 0000000000000008 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f76e220b038 R14: 00007f76e220afa0 R15: 00007fff5b259d98
 </TASK>
overlayfs: failed to set xattr on upper
overlayfs: ...falling back to index=off,metacopy=off.
overlayfs: upper fs missing required features.