KASAN: use-after-free Read in l2tp_session_create

Status: upstream: reported syz repro on 2019/08/13 00:46
Reported-by: syzbot+4550480206ba5318178f@syzkaller.appspotmail.com
First crash: 2538d, last: 1356d
Fix bisection the fix commit could be any of (bisect log):
  e132c8d7b58d Linux 4.14.149
  56dfe6252c68 Linux 4.14.188
   
▶ ▼ Similar bugs (3)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream KASAN: use-after-free Read in l2tp_session_create net 19 119 3045d 3112d 8/29 fixed on 2018/07/20 18:40
android-44 KASAN: use-after-free Read in l2tp_session_create 19 C 10 2887d 3085d 0/2 closed as invalid on 2019/03/26 00:01
android-49 KASAN: use-after-free Read in l2tp_session_create 19 C 2 2887d 2659d 0/3 public: reported C repro on 2019/04/14 08:51
▶ ▼ Fix bisection attempts (8)
Created Duration User Patch Repo Result
2020/07/15 04:39 32m bisect fix linux-4.14.y OK (2) job log
2020/06/15 03:59 23m bisect fix linux-4.14.y OK (0) job log log
2020/05/16 03:33 25m bisect fix linux-4.14.y OK (0) job log log
2020/04/16 03:04 25m bisect fix linux-4.14.y OK (0) job log log
2020/03/17 02:39 24m bisect fix linux-4.14.y OK (0) job log log
2020/02/15 23:26 24m bisect fix linux-4.14.y OK (0) job log log
2020/01/16 23:02 24m bisect fix linux-4.14.y OK (0) job log log
2019/12/17 22:38 23m bisect fix linux-4.14.y OK (0) job log log

Sample crash report:
l2tp_core: tunl 4: sockfd_lookup(fd=4) returned -9
l2tp_core: tunl 4: sockfd_lookup(fd=4) returned -9
l2tp_core: tunl 4: sockfd_lookup(fd=4) returned -9
l2tp_core: tunl 4: sockfd_lookup(fd=4) returned -9
==================================================================
BUG: KASAN: use-after-free in l2tp_session_create+0x1439/0x1600 net/l2tp/l2tp_core.c:1854
Read of size 4 at addr ffff88808b23e018 by task syz-executor.0/14287

CPU: 1 PID: 14287 Comm: syz-executor.0 Not tainted 4.14.149 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x138/0x197 lib/dump_stack.c:53
 print_address_description.cold+0x7c/0x1dc mm/kasan/report.c:252
 kasan_report_error mm/kasan/report.c:351 [inline]
 kasan_report mm/kasan/report.c:409 [inline]
 kasan_report.cold+0xa9/0x2af mm/kasan/report.c:393
 __asan_report_load4_noabort+0x14/0x20 mm/kasan/report.c:429
 l2tp_session_create+0x1439/0x1600 net/l2tp/l2tp_core.c:1854
 pppol2tp_connect+0x11bf/0x18b0 net/l2tp/l2tp_ppp.c:721
 SYSC_connect+0x1f6/0x2d0 net/socket.c:1655
 SyS_connect+0x24/0x30 net/socket.c:1636
 do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x42/0xb7
RIP: 0033:0x459a59
RSP: 002b:00007f372b0ffc78 EFLAGS: 00000246 ORIG_RAX: 000000000000002a
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000459a59
RDX: 0000000000000026 RSI: 0000000020000180 RDI: 0000000000000005
RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f372b1006d4
R13: 00000000004c0006 R14: 00000000004d2298 R15: 00000000ffffffff

Allocated by task 14287:
 save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:59
 save_stack+0x45/0xd0 mm/kasan/kasan.c:447
 set_track mm/kasan/kasan.c:459 [inline]
 kasan_kmalloc mm/kasan/kasan.c:551 [inline]
 kasan_kmalloc+0xce/0xf0 mm/kasan/kasan.c:529
 __do_kmalloc mm/slab.c:3720 [inline]
 __kmalloc+0x15d/0x7a0 mm/slab.c:3729
 kmalloc include/linux/slab.h:493 [inline]
 kzalloc include/linux/slab.h:661 [inline]
 l2tp_session_create+0x38/0x1600 net/l2tp/l2tp_core.c:1791
 pppol2tp_connect+0x11bf/0x18b0 net/l2tp/l2tp_ppp.c:721
 SYSC_connect+0x1f6/0x2d0 net/socket.c:1655
 SyS_connect+0x24/0x30 net/socket.c:1636
 do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x42/0xb7

Freed by task 14289:
 save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:59
 save_stack+0x45/0xd0 mm/kasan/kasan.c:447
 set_track mm/kasan/kasan.c:459 [inline]
 kasan_slab_free+0x75/0xc0 mm/kasan/kasan.c:524
 __cache_free mm/slab.c:3496 [inline]
 kfree+0xcc/0x270 mm/slab.c:3815
 l2tp_session_free+0x176/0x210 net/l2tp/l2tp_core.c:1714
 l2tp_session_dec_refcount_1 net/l2tp/l2tp_core.h:300 [inline]
 l2tp_tunnel_closeall+0x2ca/0x380 net/l2tp/l2tp_core.c:1345
 l2tp_udp_encap_destroy+0x99/0x100 net/l2tp/l2tp_core.c:1366
 udpv6_destroy_sock+0xb3/0xd0 net/ipv6/udp.c:1444
 sk_common_release+0x6b/0x310 net/core/sock.c:2989
 udp_lib_close+0x16/0x20 include/net/udp.h:203
 inet_release+0xec/0x1c0 net/ipv4/af_inet.c:425
 inet6_release+0x53/0x80 net/ipv6/af_inet6.c:450
 __sock_release+0xce/0x2b0 net/socket.c:602
 sock_close+0x1b/0x30 net/socket.c:1139
 __fput+0x275/0x7a0 fs/file_table.c:210
 ____fput+0x16/0x20 fs/file_table.c:244
 task_work_run+0x114/0x190 kernel/task_work.c:113
 tracehook_notify_resume include/linux/tracehook.h:191 [inline]
 exit_to_usermode_loop+0x1da/0x220 arch/x86/entry/common.c:164
 prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
 do_syscall_64+0x4bc/0x640 arch/x86/entry/common.c:297
 entry_SYSCALL_64_after_hwframe+0x42/0xb7

The buggy address belongs to the object at ffff88808b23e000
 which belongs to the cache kmalloc-512 of size 512
The buggy address is located 24 bytes inside of
 512-byte region [ffff88808b23e000, ffff88808b23e200)
The buggy address belongs to the page:
page:ffffea00022c8f80 count:1 mapcount:0 mapping:ffff88808b23e000 index:0x0
flags: 0x1fffc0000000100(slab)
raw: 01fffc0000000100 ffff88808b23e000 0000000000000000 0000000100000006
raw: ffffea00026df7a0 ffffea000265a7a0 ffff8880aa800940 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88808b23df00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff88808b23df80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff88808b23e000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                            ^
 ffff88808b23e080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88808b23e100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (7):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/10/15 16:30 linux-4.14.y e132c8d7b58d b5268b89 .config console log report syz ci2-linux-4-14
2022/11/07 13:19 linux-4.14.y a901bb6c7db7 a779b11a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-4-14 KASAN: use-after-free Read in l2tp_session_create
2022/04/05 18:25 linux-4.14.y 74766a973637 0127c10f .config console log report info ci2-linux-4-14 KASAN: use-after-free Read in l2tp_session_create
2019/10/10 07:36 linux-4.14.y 42327896f194 c4b9981b .config console log report ci2-linux-4-14
2019/09/25 10:37 linux-4.14.y f6e27dbb1afa e38a6630 .config console log report ci2-linux-4-14
2019/09/04 20:02 linux-4.14.y 01fd1694b93c d994512d .config console log report ci2-linux-4-14
2019/08/12 23:45 linux-4.14.y 3ffe1e79c174 8620c2c2 .config console log report ci2-linux-4-14
* Struck through repros no longer work on HEAD.