syzbot


possible deadlock in hfsplus_get_block

Status: upstream: reported C repro on 2023/03/13 14:59
Bug presence: origin:lts-only
[Documentation on labels]
Reported-by: syzbot+4b92cf592cc55a929db6@syzkaller.appspotmail.com
First crash: 205d, last: 3h50m
Bug presence (2)
Date Name Commit Repro Result
2023/09/13 linux-6.1.y (ToT) 09045dae0d90 C [report] possible deadlock in hfsplus_get_block
2023/09/13 upstream (ToT) 3669558bdf35 C Didn't crash
Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in hfsplus_get_block origin:upstream C 278 4d10h 204d 0/3 upstream: reported C repro on 2023/03/14 12:03
linux-4.19 possible deadlock in hfsplus_get_block hfsplus C 248 211d 312d 0/1 upstream: reported C repro on 2022/11/26 01:19
linux-4.14 possible deadlock in hfsplus_get_block hfsplus C 131 217d 308d 0/1 upstream: reported C repro on 2022/11/30 01:33
upstream possible deadlock in hfsplus_get_block hfs C error 4161 5h06m 313d 0/25 upstream: reported C repro on 2022/11/25 09:45
Fix bisection attempts (1)
Created Duration User Patch Repo Result
2023/09/27 12:10 2h09m fix candidate upstream job log (0) log

Sample crash report:
loop0: detected capacity change from 0 to 1024
============================================
WARNING: possible recursive locking detected
6.1.53-syzkaller #0 Not tainted
--------------------------------------------
syz-executor130/3543 is trying to acquire lock:
ffff88807d4a07c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260

but task is already holding lock:
ffff88807c1187c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

5 locks held by syz-executor130/3543:
 #0: ffff88807bd040e0 (&type->s_umount_key#41/1){+.+.}-{3:3}, at: alloc_super+0x217/0x930 fs/super.c:228
 #1: ffff88807c3f1998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_fill_super+0x1378/0x1c90 fs/hfsplus/super.c:553
 #2: ffff88807c1b40b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0
 #3: ffff88807c1187c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457
 #4: ffff88807c3f18f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x9a/0x8b0 fs/hfsplus/bitmap.c:35

stack backtrace:
CPU: 1 PID: 3543 Comm: syz-executor130 Not tainted 6.1.53-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/04/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 print_deadlock_bug kernel/locking/lockdep.c:2983 [inline]
 check_deadlock kernel/locking/lockdep.c:3026 [inline]
 validate_chain+0x4726/0x58e0 kernel/locking/lockdep.c:3811
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5048
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5661
 __mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603
 __mutex_lock kernel/locking/mutex.c:747 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
 hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260
 block_read_full_folio+0x403/0xf60 fs/buffer.c:2271
 filemap_read_folio+0x199/0x780 mm/filemap.c:2407
 do_read_cache_folio+0x2ee/0x810 mm/filemap.c:3535
 do_read_cache_page+0x32/0x220 mm/filemap.c:3577
 read_mapping_page include/linux/pagemap.h:756 [inline]
 hfsplus_block_allocate+0xea/0x8b0 fs/hfsplus/bitmap.c:37
 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
 hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:358
 hfsplus_create_cat+0x1a9/0x1ba0 fs/hfsplus/catalog.c:272
 hfsplus_fill_super+0x13e6/0x1c90 fs/hfsplus/super.c:560
 mount_bdev+0x2c9/0x3f0 fs/super.c:1432
 legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
 vfs_get_tree+0x88/0x270 fs/super.c:1562
 do_new_mount+0x28b/0xae0 fs/namespace.c:3040
 do_mount fs/namespace.c:3383 [inline]
 __do_sys_mount fs/namespace.c:3591 [inline]
 __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3568
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f1a220e4c3a
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 5e 04 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffce08c3808 EFLAGS: 00000286 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffce08c3820 RCX: 00007f1a220e4c3a
RDX: 0000000020000000 RSI: 0000000020000080 RDI: 00007ffce08c3820
RBP: 0000000000000004 R08: 00007ffce08c3860 R09: 000000000000064e
R10: 0000000000208010 R11: 0000000000000286 R12: 0000000000208010
R13: 00007ffce08c3860 R14: 0000000000000003 R15: 0000000000080000

Crashes (256):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/09/15 12:31 linux-6.1.y 09045dae0d90 0b6a67ac .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/09/13 01:18 linux-6.1.y 59b13c2b647e 59da8366 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/05/13 03:06 linux-6.1.y bf4ad6fa4e53 ecca8a24 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/06/28 09:44 linux-6.1.y e84a4e368abe 4cd5bb25 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/06/11 21:46 linux-6.1.y 2f3918bc53fb 49519f06 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/06/04 15:07 linux-6.1.y d2869ace6eeb a4ae4f42 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/06/17 19:57 linux-6.1.y ca87e77a2ef8 f3921d4d .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/05/07 04:51 linux-6.1.y ca48fc16c493 90c93c40 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/10/03 06:47 linux-6.1.y d23900f974e0 65faba36 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/09/30 11:54 linux-6.1.y d23900f974e0 8e26a358 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/09/28 15:03 linux-6.1.y d23900f974e0 c2ab1e5d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/09/27 23:35 linux-6.1.y d23900f974e0 2895a507 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/09/24 21:22 linux-6.1.y d23900f974e0 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/09/23 19:24 linux-6.1.y d23900f974e0 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/09/19 23:33 linux-6.1.y a356197db198 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/09/12 19:07 linux-6.1.y 59b13c2b647e 59da8366 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/09/12 17:02 linux-6.1.y 59b13c2b647e 59da8366 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/09/10 09:15 linux-6.1.y 59b13c2b647e 6654cf89 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/09/07 11:36 linux-6.1.y 59b13c2b647e 72324844 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/31 16:31 linux-6.1.y a2943d2d9a00 84803932 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/30 23:07 linux-6.1.y a2943d2d9a00 84803932 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/30 21:34 linux-6.1.y a2943d2d9a00 84803932 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/10/04 15:26 linux-6.1.y d23900f974e0 b7d7ff54 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/10/03 05:37 linux-6.1.y d23900f974e0 65faba36 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/09/30 08:35 linux-6.1.y d23900f974e0 8e26a358 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/09/28 08:30 linux-6.1.y d23900f974e0 c2ab1e5d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/09/26 02:27 linux-6.1.y d23900f974e0 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/09/23 15:36 linux-6.1.y d23900f974e0 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/09/14 09:35 linux-6.1.y 09045dae0d90 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/09/07 01:08 linux-6.1.y 59b13c2b647e 72324844 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/09/04 14:56 linux-6.1.y c2cbfe5f5122 db3306a6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/09/02 13:28 linux-6.1.y c2cbfe5f5122 696ea0d2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/09/02 10:37 linux-6.1.y c2cbfe5f5122 696ea0d2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/31 01:54 linux-6.1.y a2943d2d9a00 84803932 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/30 18:38 linux-6.1.y a2943d2d9a00 84803932 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/30 03:50 linux-6.1.y 024f76bca9d0 ce731e62 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/30 01:19 linux-6.1.y 024f76bca9d0 ce731e62 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/28 21:04 linux-6.1.y 024f76bca9d0 7ba13a15 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/28 04:25 linux-6.1.y 024f76bca9d0 7ba13a15 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/18 13:46 linux-6.1.y 6c44e13dc284 acb1ba71 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/17 09:35 linux-6.1.y 6c44e13dc284 74b106b6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/17 03:41 linux-6.1.y 6c44e13dc284 74b106b6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/17 02:20 linux-6.1.y 6c44e13dc284 74b106b6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/13 16:36 linux-6.1.y 1321ab403b38 39990d51 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/13 07:44 linux-6.1.y 1321ab403b38 39990d51 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/06 15:51 linux-6.1.y 52a953d0934b 4ffcc9ef .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_get_block
2023/08/28 02:03 linux-6.1.y 024f76bca9d0 7ba13a15 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/25 11:38 linux-6.1.y 802aacbbffe2 03d9c195 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/25 09:31 linux-6.1.y 802aacbbffe2 03d9c195 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/24 08:36 linux-6.1.y 802aacbbffe2 4d7ae7ab .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/22 14:13 linux-6.1.y 6c44e13dc284 b81ca3f6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/15 17:46 linux-6.1.y 1321ab403b38 39990d51 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/09 20:05 linux-6.1.y 0a4a7855302d 13ca4cd6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/09 07:13 linux-6.1.y 0a4a7855302d 8ad1a287 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/08 16:15 linux-6.1.y 52a953d0934b 9552ae77 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/08/04 20:27 linux-6.1.y 52a953d0934b cdae481e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
2023/03/13 14:57 linux-6.1.y 6449a0ba6843 026e2200 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_get_block
* Struck through repros no longer work on HEAD.