syzbot


possible deadlock in ocfs2_truncate_file

Status: upstream: reported on 2024/10/02 11:36
Reported-by: syzbot+505e17155790d5758123@syzkaller.appspotmail.com
First crash: 20d, last: 20d
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in ocfs2_truncate_file ocfs2 15 2h53m 59d 0/28 upstream: reported on 2024/08/24 04:12

Sample crash report:
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.2043/9345 is trying to acquire lock:
ffff0000e4544650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_orphan_for_truncate fs/ocfs2/file.c:392 [inline]
ffff0000e4544650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_truncate_file+0x5f8/0x14dc fs/ocfs2/file.c:496

but task is already holding lock:
ffff0000eb48ea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_truncate_file+0x344/0x14dc fs/ocfs2/file.c:467

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
       ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811
       dqget+0x664/0xd0c fs/quota/dquot.c:986
       ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
       notify_change+0xa34/0xcf8 fs/attr.c:505
       chown_common+0x4ac/0x74c fs/open.c:680
       vfs_fchown fs/open.c:748 [inline]
       ksys_fchown+0xe0/0x158 fs/open.c:759
       __do_sys_fchown fs/open.c:767 [inline]
       __se_sys_fchown fs/open.c:765 [inline]
       __arm64_sys_fchown+0x7c/0x94 fs/open.c:765
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:789 [inline]
       ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811
       dqget+0x664/0xd0c fs/quota/dquot.c:986
       ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
       notify_change+0xa34/0xcf8 fs/attr.c:505
       chown_common+0x4ac/0x74c fs/open.c:680
       vfs_fchown fs/open.c:748 [inline]
       ksys_fchown+0xe0/0x158 fs/open.c:759
       __do_sys_fchown fs/open.c:767 [inline]
       __se_sys_fchown fs/open.c:765 [inline]
       __arm64_sys_fchown+0x7c/0x94 fs/open.c:765
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743
       dquot_commit+0x54/0x240 fs/quota/dquot.c:507
       ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6172
       ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6232
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
       __dquot_free_space+0x878/0xce8 fs/quota/dquot.c:1940
       dquot_free_space_nodirty include/linux/quotaops.h:376 [inline]
       dquot_free_space include/linux/quotaops.h:381 [inline]
       dquot_free_block include/linux/quotaops.h:392 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6158 [inline]
       ext4_free_blocks+0x1c0c/0x2bf0 fs/ext4/mballoc.c:6288
       ext4_remove_blocks fs/ext4/extents.c:2519 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2685 [inline]
       ext4_ext_remove_space+0x1c48/0x4254 fs/ext4/extents.c:2933
       ext4_ext_truncate+0x188/0x250 fs/ext4/extents.c:4450
       ext4_truncate+0x9c4/0x1058 fs/ext4/inode.c:4249
       ext4_evict_inode+0xc30/0x124c fs/ext4/inode.c:289
       evict+0x418/0x894 fs/inode.c:622
       iput_final fs/inode.c:1740 [inline]
       iput+0x744/0x824 fs/inode.c:1766
       ext4_process_orphan+0x244/0x2b8 fs/ext4/orphan.c:360
       ext4_orphan_cleanup+0x8bc/0x1048 fs/ext4/orphan.c:474
       ext4_fill_super+0x8044/0x8768 fs/ext4/super.c:4974
       mount_bdev+0x274/0x370 fs/super.c:1398
       ext4_mount+0x44/0x58 fs/ext4/super.c:6602
       legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
       vfs_get_tree+0x90/0x274 fs/super.c:1528
       do_new_mount+0x278/0x8fc fs/namespace.c:3005
       path_mount+0x594/0x101c fs/namespace.c:3335
       do_mount fs/namespace.c:3348 [inline]
       __do_sys_mount fs/namespace.c:3556 [inline]
       __se_sys_mount fs/namespace.c:3533 [inline]
       __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #3 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
       ext4_map_blocks+0x830/0x1a44 fs/ext4/inode.c:665
       mpage_map_one_extent fs/ext4/inode.c:2407 [inline]
       mpage_map_and_submit_extent fs/ext4/inode.c:2460 [inline]
       ext4_writepages+0x12c0/0x36fc fs/ext4/inode.c:2828
       do_writepages+0x39c/0x5ec mm/page-writeback.c:2386
       __writeback_single_inode+0x148/0x13a4 fs/fs-writeback.c:1647
       writeback_sb_inodes+0x94c/0x1654 fs/fs-writeback.c:1930
       __writeback_inodes_wb+0x110/0x39c fs/fs-writeback.c:2001
       wb_writeback+0x410/0xfc8 fs/fs-writeback.c:2106
       wb_check_background_flush fs/fs-writeback.c:2172 [inline]
       wb_do_writeback fs/fs-writeback.c:2260 [inline]
       wb_workfn+0xc44/0x1070 fs/fs-writeback.c:2288
       process_one_work+0x790/0x11b8 kernel/workqueue.c:2310
       worker_thread+0x910/0x1034 kernel/workqueue.c:2457
       kthread+0x37c/0x45c kernel/kthread.c:334
       ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:870

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0xfc0/0x12a4 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x29c/0x7b4 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x468/0x804 fs/ocfs2/journal.c:354
       ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1d8/0x904 fs/ocfs2/super.c:1882
       ocfs2_put_super+0xec/0x350 fs/ocfs2/super.c:1610
       generic_shutdown_super+0x130/0x29c fs/super.c:475
       kill_block_super+0x70/0xdc fs/super.c:1425
       deactivate_locked_super+0xb8/0x13c fs/super.c:335
       deactivate_super+0x108/0x128 fs/super.c:366
       cleanup_mnt+0x3c0/0x474 fs/namespace.c:1143
       __cleanup_mnt+0x20/0x30 fs/namespace.c:1150
       task_work_run+0x130/0x1e4 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946
       prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline]
       exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline]
       el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0xc0/0x398 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x45c/0x804 fs/ocfs2/journal.c:352
       ocfs2_shutdown_local_alloc+0x1d8/0x8d8 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1d8/0x904 fs/ocfs2/super.c:1882
       ocfs2_put_super+0xec/0x350 fs/ocfs2/super.c:1610
       generic_shutdown_super+0x130/0x29c fs/super.c:475
       kill_block_super+0x70/0xdc fs/super.c:1425
       deactivate_locked_super+0xb8/0x13c fs/super.c:335
       deactivate_super+0x108/0x128 fs/super.c:366
       cleanup_mnt+0x3c0/0x474 fs/namespace.c:1143
       __cleanup_mnt+0x20/0x30 fs/namespace.c:1150
       task_work_run+0x130/0x1e4 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946
       prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline]
       exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline]
       el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #0 (sb_internal#5){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
       lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350
       ocfs2_orphan_for_truncate fs/ocfs2/file.c:392 [inline]
       ocfs2_truncate_file+0x5f8/0x14dc fs/ocfs2/file.c:496
       ocfs2_setattr+0x1244/0x191c fs/ocfs2/file.c:1212
       notify_change+0xa34/0xcf8 fs/attr.c:505
       do_truncate+0x1c0/0x28c fs/open.c:65
       handle_truncate fs/namei.c:3265 [inline]
       do_open fs/namei.c:3612 [inline]
       path_openat+0x20c4/0x26cc fs/namei.c:3742
       do_filp_open+0x1a8/0x3b4 fs/namei.c:3769
       do_sys_openat2+0x128/0x3e0 fs/open.c:1253
       do_sys_open fs/open.c:1269 [inline]
       __do_sys_openat fs/open.c:1285 [inline]
       __se_sys_openat fs/open.c:1280 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1280
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

other info that might help us debug this:

Chain exists of:
  sb_internal#5 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(sb_internal#5);

 *** DEADLOCK ***

3 locks held by syz.0.2043/9345:
 #0: ffff0000e4544460 (sb_writers#28){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377
 #1: ffff0000eb48ed88 (&sb->s_type->i_mutex_key#38){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
 #1: ffff0000eb48ed88 (&sb->s_type->i_mutex_key#38){+.+.}-{3:3}, at: do_truncate+0x1ac/0x28c fs/open.c:63
 #2: ffff0000eb48ea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_truncate_file+0x344/0x14dc fs/ocfs2/file.c:467

stack backtrace:
CPU: 0 PID: 9345 Comm: syz.0.2043 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call trace:
 dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1811 [inline]
 sb_start_intwrite include/linux/fs.h:1928 [inline]
 ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350
 ocfs2_orphan_for_truncate fs/ocfs2/file.c:392 [inline]
 ocfs2_truncate_file+0x5f8/0x14dc fs/ocfs2/file.c:496
 ocfs2_setattr+0x1244/0x191c fs/ocfs2/file.c:1212
 notify_change+0xa34/0xcf8 fs/attr.c:505
 do_truncate+0x1c0/0x28c fs/open.c:65
 handle_truncate fs/namei.c:3265 [inline]
 do_open fs/namei.c:3612 [inline]
 path_openat+0x20c4/0x26cc fs/namei.c:3742
 do_filp_open+0x1a8/0x3b4 fs/namei.c:3769
 do_sys_openat2+0x128/0x3e0 fs/open.c:1253
 do_sys_open fs/open.c:1269 [inline]
 __do_sys_openat fs/open.c:1285 [inline]
 __se_sys_openat fs/open.c:1280 [inline]
 __arm64_sys_openat+0x1f0/0x240 fs/open.c:1280
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/10/02 11:35 linux-5.15.y 3a5928702e71 02f9582a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ocfs2_truncate_file
* Struck through repros no longer work on HEAD.