syzbot

(syz.2.18,4370,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,2) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.18/4370 is trying to acquire lock:
ffff88805ed09538 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_calc_xattr_init+0x204/0xd90 fs/ocfs2/xattr.c:631

but task is already holding lock:
ffff888060d62648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff888060d62648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16a/0x44d0 fs/ocfs2/suballoc.c:782

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x1d72/0x41d0 fs/ocfs2/inode.c:1216
       evict+0x4c9/0x8d0 fs/inode.c:647
       d_delete_notify include/linux/fsnotify.h:267 [inline]
       vfs_rmdir+0x3b4/0x430 fs/namei.c:4170
       do_rmdir+0x2a1/0x740 fs/namei.c:4218
       __do_sys_unlinkat fs/namei.c:4398 [inline]
       __se_sys_unlinkat fs/namei.c:4392 [inline]
       __x64_sys_unlinkat+0xc0/0xe0 fs/namei.c:4392
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_del_inode_from_orphan+0x12b/0x7a0 fs/ocfs2/namei.c:2713
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2333 [inline]
       ocfs2_dio_end_io+0x540/0x1200 fs/ocfs2/aops.c:2431
       dio_complete+0x249/0x720 fs/direct-io.c:272
       do_blockdev_direct_IO fs/direct-io.c:1336 [inline]
       __blockdev_direct_IO+0x2e31/0x3a70 fs/direct-io.c:1368
       ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2468
       generic_file_direct_write+0x22c/0x490 mm/filemap.c:3687
       __generic_file_write_iter+0x2b1/0x4e0 mm/filemap.c:3869
       ocfs2_file_write_iter+0x1670/0x1e70 fs/ocfs2/file.c:2472
       do_iter_readv_writev+0x47e/0x5f0 fs/read_write.c:-1
       do_iter_write+0x205/0x7b0 fs/read_write.c:855
       iter_file_splice_write+0x699/0xcc0 fs/splice.c:689
       do_splice_from fs/splice.c:767 [inline]
       direct_splice_actor+0xe1/0x130 fs/splice.c:956
       splice_direct_to_actor+0x4ea/0xc10 fs/splice.c:902
       do_splice_direct+0x1d4/0x2f0 fs/splice.c:1008
       do_sendfile+0x5fc/0xeb0 fs/read_write.c:1249
       __do_sys_sendfile64 fs/read_write.c:1317 [inline]
       __se_sys_sendfile64+0x141/0x1a0 fs/read_write.c:1303
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&oi->ip_alloc_sem){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ocfs2_try_remove_refcount_tree+0xb3/0x340 fs/ocfs2/refcounttree.c:932
       ocfs2_xattr_set+0x609/0x13e0 fs/ocfs2/xattr.c:3673
       __vfs_removexattr+0x3b7/0x3f0 fs/xattr.c:470
       cap_inode_killpriv+0x20/0x40 security/commoncap.c:325
       security_inode_killpriv+0x67/0x90 security/security.c:1429
       setattr_prepare+0x1f4/0xda0 fs/attr.c:224
       ocfs2_setattr+0x453/0x1ad0 fs/ocfs2/file.c:1151
       notify_change+0xbcd/0xee0 fs/attr.c:505
       do_truncate+0x1ac/0x240 fs/open.c:65
       handle_truncate fs/namei.c:3273 [inline]
       do_open fs/namei.c:3620 [inline]
       path_openat+0x2922/0x2fa0 fs/namei.c:3750
       do_filp_open+0x1e2/0x410 fs/namei.c:3777
       do_sys_openat2+0x150/0x4b0 fs/open.c:1255
       do_sys_open fs/open.c:1271 [inline]
       __do_sys_openat fs/open.c:1287 [inline]
       __se_sys_openat fs/open.c:1282 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1282
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&oi->ip_xattr_sem){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_calc_xattr_init+0x204/0xd90 fs/ocfs2/xattr.c:631
       ocfs2_mknod+0xd3c/0x2510 fs/ocfs2/namei.c:330
       ocfs2_mkdir+0x192/0x420 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4073
       do_mkdirat+0x1df/0x5b0 fs/namei.c:4098
       __do_sys_mkdirat fs/namei.c:4113 [inline]
       __se_sys_mkdirat fs/namei.c:4111 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
  lock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

3 locks held by syz.2.18/4370:
 #0: ffff8880781fa460 (sb_writers#14){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:386
 #1: ffff88805ed09808 (&type->i_mutex_dir_key#9/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline]
 #1: ffff88805ed09808 (&type->i_mutex_dir_key#9/1){+.+.}-{3:3}, at: filename_create+0x208/0x470 fs/namei.c:3843
 #2: ffff888060d62648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff888060d62648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16a/0x44d0 fs/ocfs2/suballoc.c:782

stack backtrace:
CPU: 1 PID: 4370 Comm: syz.2.18 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
 ocfs2_calc_xattr_init+0x204/0xd90 fs/ocfs2/xattr.c:631
 ocfs2_mknod+0xd3c/0x2510 fs/ocfs2/namei.c:330
 ocfs2_mkdir+0x192/0x420 fs/ocfs2/namei.c:657
 vfs_mkdir+0x387/0x570 fs/namei.c:4073
 do_mkdirat+0x1df/0x5b0 fs/namei.c:4098
 __do_sys_mkdirat fs/namei.c:4113 [inline]
 __se_sys_mkdirat fs/namei.c:4111 [inline]
 __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f91b3e5c607
Code: 00 66 90 48 89 f2 b9 00 01 00 00 48 89 fe bf 9c ff ff ff e9 db f7 ff ff 66 2e 0f 1f 84 00 00 00 00 00 90 b8 02 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f91b20b6e58 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 00007f91b20b6ee0 RCX: 00007f91b3e5c607
RDX: 00000000000001ff RSI: 0000200000000040 RDI: 00000000ffffff9c
RBP: 0000200000000000 R08: 0000200000000040 R09: 0000000000000000
R10: 0000200000000000 R11: 0000000000000246 R12: 0000200000000040
R13: 00007f91b20b6ea0 R14: 0000000000000000 R15: 0000000000000000
 </TASK>