syzbot

ocfs2: Mounting device (7,1) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc5-syzkaller-00193-g40f92e79b0aa #0 Not tainted
------------------------------------------------------
syz.1.112/6432 is trying to acquire lock:
ffff888053004e38 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_calc_xattr_init+0x5e5/0xc90 fs/ocfs2/xattr.c:627

but task is already holding lock:
ffff88805ab31800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
ffff88805ab31800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x4900 fs/ocfs2/suballoc.c:788

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:869 [inline]
       ocfs2_remove_inode+0x15b/0x8a0 fs/ocfs2/inode.c:669
       ocfs2_wipe_inode+0x446/0x1210 fs/ocfs2/inode.c:832
       ocfs2_delete_inode fs/ocfs2/inode.c:1093 [inline]
       ocfs2_evict_inode+0x6e0/0x1680 fs/ocfs2/inode.c:1230
       evict+0x3e6/0x920 fs/inode.c:810
       iput_final fs/inode.c:1898 [inline]
       iput fs/inode.c:1924 [inline]
       iput+0x521/0x880 fs/inode.c:1910
       do_unlinkat+0x518/0x6a0 fs/namei.c:4666
       __do_sys_unlinkat fs/namei.c:4700 [inline]
       __se_sys_unlinkat fs/namei.c:4693 [inline]
       __x64_sys_unlinkat+0xbf/0x130 fs/namei.c:4693
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:869 [inline]
       ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2727
       ocfs2_dio_end_io_write+0x2cb/0xf30 fs/ocfs2/aops.c:2303
       ocfs2_dio_end_io+0x136/0x2c0 fs/ocfs2/aops.c:2401
       dio_complete+0x224/0x970 fs/direct-io.c:281
       __blockdev_direct_IO+0x348f/0x4180 fs/direct-io.c:1303
       ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2438
       generic_file_direct_write+0x19a/0x410 mm/filemap.c:4046
       __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4215
       ocfs2_file_write_iter+0xbc4/0x21b0 fs/ocfs2/file.c:2469
       new_sync_write fs/read_write.c:593 [inline]
       vfs_write+0x6c7/0x1150 fs/read_write.c:686
       ksys_write+0x12a/0x250 fs/read_write.c:738
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&oi->ip_alloc_sem){++++}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1577
       ocfs2_try_remove_refcount_tree+0xa7/0x320 fs/ocfs2/refcounttree.c:932
       ocfs2_truncate_file+0xbba/0x17c0 fs/ocfs2/file.c:521
       ocfs2_setattr+0x1594/0x2560 fs/ocfs2/file.c:1212
       notify_change+0x6a9/0x1230 fs/attr.c:552
       do_truncate+0x1d7/0x230 fs/open.c:68
       handle_truncate fs/namei.c:3517 [inline]
       do_open fs/namei.c:3900 [inline]
       path_openat+0x2678/0x2cb0 fs/namei.c:4055
       do_filp_open+0x20b/0x470 fs/namei.c:4082
       do_sys_openat2+0x11b/0x1d0 fs/open.c:1437
       do_sys_open fs/open.c:1452 [inline]
       __do_sys_openat fs/open.c:1468 [inline]
       __se_sys_openat fs/open.c:1463 [inline]
       __x64_sys_openat+0x174/0x210 fs/open.c:1463
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_xattr_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3168 [inline]
       check_prevs_add kernel/locking/lockdep.c:3287 [inline]
       validate_chain kernel/locking/lockdep.c:3911 [inline]
       __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5240
       lock_acquire kernel/locking/lockdep.c:5871 [inline]
       lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5828
       down_read+0x9b/0x480 kernel/locking/rwsem.c:1524
       ocfs2_calc_xattr_init+0x5e5/0xc90 fs/ocfs2/xattr.c:627
       ocfs2_mknod+0xa2b/0x2540 fs/ocfs2/namei.c:330
       ocfs2_create+0x17c/0x460 fs/ocfs2/namei.c:673
       lookup_open.isra.0+0x11d3/0x1580 fs/namei.c:3717
       open_last_lookups fs/namei.c:3816 [inline]
       path_openat+0x893/0x2cb0 fs/namei.c:4052
       do_filp_open+0x20b/0x470 fs/namei.c:4082
       do_sys_openat2+0x11b/0x1d0 fs/open.c:1437
       do_sys_open fs/open.c:1452 [inline]
       __do_sys_openat fs/open.c:1468 [inline]
       __se_sys_openat fs/open.c:1463 [inline]
       __x64_sys_openat+0x174/0x210 fs/open.c:1463
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

3 locks held by syz.1.112/6432:
 #0: ffff888022308428 (sb_writers#13){.+.+}-{0:0}, at: open_last_lookups fs/namei.c:3805 [inline]
 #0: ffff888022308428 (sb_writers#13){.+.+}-{0:0}, at: path_openat+0x1f0f/0x2cb0 fs/namei.c:4052
 #1: ffff888053005100 (&type->i_mutex_dir_key#8){++++}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
 #1: ffff888053005100 (&type->i_mutex_dir_key#8){++++}-{4:4}, at: open_last_lookups fs/namei.c:3813 [inline]
 #1: ffff888053005100 (&type->i_mutex_dir_key#8){++++}-{4:4}, at: path_openat+0x1534/0x2cb0 fs/namei.c:4052
 #2: ffff88805ab31800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
 #2: ffff88805ab31800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x4900 fs/ocfs2/suballoc.c:788

stack backtrace:
CPU: 0 UID: 0 PID: 6432 Comm: syz.1.112 Not tainted 6.16.0-rc5-syzkaller-00193-g40f92e79b0aa #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2046
 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3168 [inline]
 check_prevs_add kernel/locking/lockdep.c:3287 [inline]
 validate_chain kernel/locking/lockdep.c:3911 [inline]
 __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5240
 lock_acquire kernel/locking/lockdep.c:5871 [inline]
 lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5828
 down_read+0x9b/0x480 kernel/locking/rwsem.c:1524
 ocfs2_calc_xattr_init+0x5e5/0xc90 fs/ocfs2/xattr.c:627
 ocfs2_mknod+0xa2b/0x2540 fs/ocfs2/namei.c:330
 ocfs2_create+0x17c/0x460 fs/ocfs2/namei.c:673
 lookup_open.isra.0+0x11d3/0x1580 fs/namei.c:3717
 open_last_lookups fs/namei.c:3816 [inline]
 path_openat+0x893/0x2cb0 fs/namei.c:4052
 do_filp_open+0x20b/0x470 fs/namei.c:4082
 do_sys_openat2+0x11b/0x1d0 fs/open.c:1437
 do_sys_open fs/open.c:1452 [inline]
 __do_sys_openat fs/open.c:1468 [inline]
 __se_sys_openat fs/open.c:1463 [inline]
 __x64_sys_openat+0x174/0x210 fs/open.c:1463
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fbec538e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fbec31f6038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007fbec55b5fa0 RCX: 00007fbec538e929
RDX: 000000000000275a RSI: 0000200000000040 RDI: ffffffffffffff9c
RBP: 00007fbec5410b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fbec55b5fa0 R15: 00007ffc63514ca8
 </TASK>