syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Tainted: G             L     
------------------------------------------------------
syz.8.8803/7826 is trying to acquire lock:
ffff888056b2bee8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_calc_xattr_init+0x20a/0xd90 fs/ocfs2/xattr.c:631

but task is already holding lock:
ffff888056bf79a0 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
ffff888056bf79a0 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x16d/0x4840 fs/ocfs2/suballoc.c:857

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1625
       inode_lock include/linux/fs.h:1029 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:733 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:896 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x1539/0x43b0 fs/ocfs2/inode.c:1299
       evict+0x61e/0xb10 fs/inode.c:841
       ocfs2_dentry_iput+0x24d/0x390 fs/ocfs2/dcache.c:407
       __dentry_kill+0x1a2/0x5e0 fs/dcache.c:670
       finish_dput+0xc9/0x480 fs/dcache.c:879
       ovl_check_rename_whiteout fs/overlayfs/super.c:617 [inline]
       ovl_make_workdir fs/overlayfs/super.c:713 [inline]
       ovl_get_workdir fs/overlayfs/super.c:836 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
       ovl_fill_super+0x49b2/0x5e20 fs/overlayfs/super.c:1560
       vfs_get_super fs/super.c:1327 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1346
       vfs_get_tree+0x92/0x2a0 fs/super.c:1754
       fc_mount fs/namespace.c:1193 [inline]
       do_new_mount_fc fs/namespace.c:3758 [inline]
       do_new_mount+0x341/0xd30 fs/namespace.c:3834
       do_mount fs/namespace.c:4167 [inline]
       __do_sys_mount fs/namespace.c:4383 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4360
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x15f/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1625
       inode_lock include/linux/fs.h:1029 [inline]
       ocfs2_del_inode_from_orphan+0x12e/0x7a0 fs/ocfs2/namei.c:2728
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2305 [inline]
       ocfs2_dio_end_io+0x543/0x1210 fs/ocfs2/aops.c:2403
       dio_complete+0x25b/0x790 fs/direct-io.c:281
       __blockdev_direct_IO+0x2e5d/0x34e0 fs/direct-io.c:1303
       ocfs2_direct_IO+0x251/0x2c0 fs/ocfs2/aops.c:2440
       generic_file_direct_write+0x1db/0x3e0 mm/filemap.c:4258
       __generic_file_write_iter+0x11d/0x230 mm/filemap.c:4427
       ocfs2_file_write_iter+0x1663/0x1e70 fs/ocfs2/file.c:2476
       aio_write+0x5cd/0x870 fs/aio.c:1687
       __io_submit_one fs/aio.c:-1 [inline]
       io_submit_one+0x7bb/0x14c0 fs/aio.c:2106
       __do_sys_io_submit fs/aio.c:2165 [inline]
       __se_sys_io_submit+0x195/0x340 fs/aio.c:2135
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x15f/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1625
       ocfs2_try_remove_refcount_tree+0xb6/0x340 fs/ocfs2/refcounttree.c:932
       ocfs2_xattr_set+0x61a/0x13e0 fs/ocfs2/xattr.c:3700
       __vfs_removexattr+0x431/0x470 fs/xattr.c:536
       __vfs_removexattr_locked+0xe2/0x280 fs/xattr.c:571
       vfs_removexattr+0x7f/0x230 fs/xattr.c:593
       ovl_do_removexattr fs/overlayfs/overlayfs.h:341 [inline]
       ovl_removexattr fs/overlayfs/overlayfs.h:349 [inline]
       ovl_make_workdir fs/overlayfs/super.c:756 [inline]
       ovl_get_workdir fs/overlayfs/super.c:836 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1449 [inline]
       ovl_fill_super+0x4c47/0x5e20 fs/overlayfs/super.c:1560
       vfs_get_super fs/super.c:1327 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1346
       vfs_get_tree+0x92/0x2a0 fs/super.c:1754
       fc_mount fs/namespace.c:1193 [inline]
       do_new_mount_fc fs/namespace.c:3758 [inline]
       do_new_mount+0x341/0xd30 fs/namespace.c:3834
       do_mount fs/namespace.c:4167 [inline]
       __do_sys_mount fs/namespace.c:4383 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4360
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x15f/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_xattr_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
       down_read+0x47/0x2e0 kernel/locking/rwsem.c:1568
       ocfs2_calc_xattr_init+0x20a/0xd90 fs/ocfs2/xattr.c:631
       ocfs2_mknod+0xf51/0x2260 fs/ocfs2/namei.c:334
       ocfs2_create+0x195/0x460 fs/ocfs2/namei.c:677
       lookup_open fs/namei.c:4511 [inline]
       open_last_lookups fs/namei.c:4611 [inline]
       path_openat+0x1395/0x3860 fs/namei.c:4855
       do_file_open+0x23e/0x4a0 fs/namei.c:4887
       do_sys_openat2+0x113/0x200 fs/open.c:1364
       do_sys_open fs/open.c:1370 [inline]
       __do_sys_open fs/open.c:1378 [inline]
       __se_sys_open fs/open.c:1374 [inline]
       __x64_sys_open+0x11e/0x150 fs/open.c:1374
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x15f/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE] --> &ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]);
                               lock(&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]);
                               lock(&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

3 locks held by syz.8.8803/7826:
 #0: ffff88807c234410 (sb_writers#18){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:493
 #1: ffff888056b2c1a0 (&type->i_mutex_dir_key#10){++++}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
 #1: ffff888056b2c1a0 (&type->i_mutex_dir_key#10){++++}-{4:4}, at: open_last_lookups fs/namei.c:4608 [inline]
 #1: ffff888056b2c1a0 (&type->i_mutex_dir_key#10){++++}-{4:4}, at: path_openat+0xb4c/0x3860 fs/namei.c:4855
 #2: ffff888056bf79a0 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1029 [inline]
 #2: ffff888056bf79a0 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x16d/0x4840 fs/ocfs2/suballoc.c:857

stack backtrace:
CPU: 1 UID: 0 PID: 7826 Comm: syz.8.8803 Tainted: G             L      syzkaller #0 PREEMPT(full) 
Tainted: [L]=SOFTLOCKUP
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/18/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0x106/0x350 kernel/locking/lockdep.c:5868
 down_read+0x47/0x2e0 kernel/locking/rwsem.c:1568
 ocfs2_calc_xattr_init+0x20a/0xd90 fs/ocfs2/xattr.c:631
 ocfs2_mknod+0xf51/0x2260 fs/ocfs2/namei.c:334
 ocfs2_create+0x195/0x460 fs/ocfs2/namei.c:677
 lookup_open fs/namei.c:4511 [inline]
 open_last_lookups fs/namei.c:4611 [inline]
 path_openat+0x1395/0x3860 fs/namei.c:4855
 do_file_open+0x23e/0x4a0 fs/namei.c:4887
 do_sys_openat2+0x113/0x200 fs/open.c:1364
 do_sys_open fs/open.c:1370 [inline]
 __do_sys_open fs/open.c:1378 [inline]
 __se_sys_open fs/open.c:1374 [inline]
 __x64_sys_open+0x11e/0x150 fs/open.c:1374
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x15f/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fabc999c819
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fabc7bf6028 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00007fabc9c15fa0 RCX: 00007fabc999c819
RDX: 000000000000002a RSI: 0000000400141042 RDI: 0000200000000040
RBP: 00007fabc9a32c91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fabc9c16038 R14: 00007fabc9c15fa0 R15: 00007ffdd2acbaa8
 </TASK>