syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Tainted: G             L     
------------------------------------------------------
syz.4.2502/16069 is trying to acquire lock:
ffff88805189ce38 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_calc_xattr_init+0x20a/0xd90 fs/ocfs2/xattr.c:631

but task is already holding lock:
ffff8880553bed80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
ffff8880553bed80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x16f/0x4790 fs/ocfs2/suballoc.c:789

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1027 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:733 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:896 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x1539/0x42e0 fs/ocfs2/inode.c:1299
       evict+0x61e/0xb10 fs/inode.c:837
       d_delete_notify include/linux/fsnotify.h:377 [inline]
       vfs_rmdir+0x3f1/0x660 fs/namei.c:5258
       do_rmdir+0x278/0x470 fs/namei.c:5300
       __do_sys_unlinkat fs/namei.c:5477 [inline]
       __se_sys_unlinkat fs/namei.c:5471 [inline]
       __x64_sys_unlinkat+0xc2/0xf0 fs/namei.c:5471
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1027 [inline]
       ocfs2_del_inode_from_orphan+0x12e/0x7a0 fs/ocfs2/namei.c:2731
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2306 [inline]
       ocfs2_dio_end_io+0x543/0x1210 fs/ocfs2/aops.c:2404
       dio_complete+0x25b/0x790 fs/direct-io.c:281
       __blockdev_direct_IO+0x2cb0/0x32f0 fs/direct-io.c:1303
       ocfs2_direct_IO+0x251/0x2c0 fs/ocfs2/aops.c:2441
       generic_file_direct_write+0x1db/0x3e0 mm/filemap.c:4248
       __generic_file_write_iter+0x11d/0x230 mm/filemap.c:4417
       ocfs2_file_write_iter+0x1663/0x1e20 fs/ocfs2/file.c:2475
       do_iter_readv_writev+0x619/0x8c0 fs/read_write.c:-1
       vfs_writev+0x33c/0x990 fs/read_write.c:1057
       do_writev+0x154/0x2e0 fs/read_write.c:1103
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       ocfs2_try_remove_refcount_tree+0xb6/0x340 fs/ocfs2/refcounttree.c:933
       ocfs2_truncate_file+0xdf3/0x1480 fs/ocfs2/file.c:521
       ocfs2_recover_orphans fs/ocfs2/journal.c:2335 [inline]
       ocfs2_complete_recovery+0x127d/0x2190 fs/ocfs2/journal.c:1366
       process_one_work kernel/workqueue.c:3257 [inline]
       process_scheduled_works+0xaec/0x17a0 kernel/workqueue.c:3340
       worker_thread+0xda6/0x1360 kernel/workqueue.c:3421
       kthread+0x726/0x8b0 kernel/kthread.c:463
       ret_from_fork+0x51b/0xa40 arch/x86/kernel/process.c:158
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:246

-> #0 (&oi->ip_xattr_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0x106/0x330 kernel/locking/lockdep.c:5868
       down_read+0x47/0x2e0 kernel/locking/rwsem.c:1537
       ocfs2_calc_xattr_init+0x20a/0xd90 fs/ocfs2/xattr.c:631
       ocfs2_mknod+0xd07/0x2210 fs/ocfs2/namei.c:334
       ocfs2_mkdir+0x181/0x430 fs/ocfs2/namei.c:660
       vfs_mkdir+0x753/0x870 fs/namei.c:5139
       do_mkdirat+0x27d/0x4b0 fs/namei.c:5173
       __do_sys_mkdirat fs/namei.c:5195 [inline]
       __se_sys_mkdirat fs/namei.c:5193 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:5193
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE] --> &ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]);
                               lock(&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]);
                               lock(&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

3 locks held by syz.4.2502/16069:
 #0: ffff88806199a420 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:499
 #1: ffff88805189d100 (&type->i_mutex_dir_key#10/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1072 [inline]
 #1: ffff88805189d100 (&type->i_mutex_dir_key#10/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2873 [inline]
 #1: ffff88805189d100 (&type->i_mutex_dir_key#10/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2884 [inline]
 #1: ffff88805189d100 (&type->i_mutex_dir_key#10/1){+.+.}-{4:4}, at: filename_create+0x200/0x370 fs/namei.c:4888
 #2: ffff8880553bed80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #2: ffff8880553bed80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x16f/0x4790 fs/ocfs2/suballoc.c:789

stack backtrace:
CPU: 0 UID: 0 PID: 16069 Comm: syz.4.2502 Tainted: G             L      syzkaller #0 PREEMPT(full) 
Tainted: [L]=SOFTLOCKUP
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/24/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0x106/0x330 kernel/locking/lockdep.c:5868
 down_read+0x47/0x2e0 kernel/locking/rwsem.c:1537
 ocfs2_calc_xattr_init+0x20a/0xd90 fs/ocfs2/xattr.c:631
 ocfs2_mknod+0xd07/0x2210 fs/ocfs2/namei.c:334
 ocfs2_mkdir+0x181/0x430 fs/ocfs2/namei.c:660
 vfs_mkdir+0x753/0x870 fs/namei.c:5139
 do_mkdirat+0x27d/0x4b0 fs/namei.c:5173
 __do_sys_mkdirat fs/namei.c:5195 [inline]
 __se_sys_mkdirat fs/namei.c:5193 [inline]
 __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:5193
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fe5fc199d97
Code: 00 66 90 48 89 f2 b9 00 01 00 00 48 89 fe bf 9c ff ff ff e9 db f7 ff ff 66 2e 0f 1f 84 00 00 00 00 00 90 b8 02 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe5fd084e58 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 00007fe5fd084ee0 RCX: 00007fe5fc199d97
RDX: 00000000000001ff RSI: 0000200000000280 RDI: 00000000ffffff9c
RBP: 0000200000000040 R08: 00002000000007c0 R09: 0000000000000000
R10: 0000200000000040 R11: 0000000000000246 R12: 0000200000000280
R13: 00007fe5fd084ea0 R14: 0000000000000000 R15: 0000000000000000
 </TASK>