syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Tainted: G             L     
------------------------------------------------------
syz.7.5989/26550 is trying to acquire lock:
ffff88807e2db1b8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_calc_xattr_init+0x174/0xca0 fs/ocfs2/xattr.c:631

but task is already holding lock:
ffff88807e2ded80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
ffff88807e2ded80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x4be0 fs/ocfs2/suballoc.c:857

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_remove_inode+0x15b/0x860 fs/ocfs2/inode.c:733
       ocfs2_wipe_inode+0x6dd/0x1270 fs/ocfs2/inode.c:896
       ocfs2_delete_inode fs/ocfs2/inode.c:1157 [inline]
       ocfs2_evict_inode+0x809/0x1550 fs/ocfs2/inode.c:1299
       evict+0x3c2/0xad0 fs/inode.c:846
       iput_final fs/inode.c:1966 [inline]
       iput.part.0+0x605/0xf50 fs/inode.c:2015
       iput+0x35/0x40 fs/inode.c:1981
       ocfs2_dentry_iput+0x139/0x330 fs/ocfs2/dcache.c:407
       dentry_unlink_inode+0x282/0x490 fs/dcache.c:465
       __dentry_kill+0x1d0/0x600 fs/dcache.c:670
       finish_dput+0x76/0x480 fs/dcache.c:879
       dput.part.0+0x456/0x570 fs/dcache.c:928
       dput+0x1f/0x30 fs/dcache.c:920
       ovl_check_rename_whiteout+0x40c/0x620 fs/overlayfs/super.c:622
       ovl_make_workdir fs/overlayfs/super.c:717 [inline]
       ovl_get_workdir fs/overlayfs/super.c:840 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1453 [inline]
       ovl_fill_super+0x11cf/0x5db0 fs/overlayfs/super.c:1564
       vfs_get_super fs/super.c:1327 [inline]
       get_tree_nodev+0xdd/0x190 fs/super.c:1346
       vfs_get_tree+0x92/0x320 fs/super.c:1754
       fc_mount fs/namespace.c:1193 [inline]
       do_new_mount_fc fs/namespace.c:3763 [inline]
       do_new_mount fs/namespace.c:3839 [inline]
       path_mount+0x7d0/0x23d0 fs/namespace.c:4159
       do_mount fs/namespace.c:4172 [inline]
       __do_sys_mount fs/namespace.c:4361 [inline]
       __se_sys_mount fs/namespace.c:4338 [inline]
       __x64_sys_mount+0x293/0x310 fs/namespace.c:4338
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x106/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:1028 [inline]
       ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2731
       ocfs2_dio_end_io_write+0x2cd/0xee0 fs/ocfs2/aops.c:2305
       ocfs2_dio_end_io+0x136/0x2c0 fs/ocfs2/aops.c:2403
       dio_complete+0x224/0x950 fs/direct-io.c:281
       __blockdev_direct_IO+0x309f/0x3ae0 fs/direct-io.c:1303
       ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2440
       generic_file_direct_write+0x198/0x410 mm/filemap.c:4253
       __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4422
       ocfs2_file_write_iter+0xdd9/0x2270 fs/ocfs2/file.c:2476
       do_iter_readv_writev+0x6ee/0x920 fs/read_write.c:829
       vfs_writev+0x360/0xe10 fs/read_write.c:1059
       do_pwritev+0x1ac/0x270 fs/read_write.c:1155
       __do_sys_pwritev2 fs/read_write.c:1213 [inline]
       __se_sys_pwritev2 fs/read_write.c:1204 [inline]
       __x64_sys_pwritev2+0xef/0x160 fs/read_write.c:1204
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x106/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       down_write+0x8b/0x1f0 kernel/locking/rwsem.c:1590
       ocfs2_try_remove_refcount_tree+0xa7/0x2f0 fs/ocfs2/refcounttree.c:933
       ocfs2_truncate_file+0xbab/0x1840 fs/ocfs2/file.c:522
       ocfs2_setattr+0x14cb/0x26a0 fs/ocfs2/file.c:1219
       notify_change+0xb25/0x1330 fs/attr.c:556
       do_truncate+0x1df/0x240 fs/open.c:68
       handle_truncate fs/namei.c:4279 [inline]
       do_open fs/namei.c:4675 [inline]
       path_openat+0x2a55/0x31a0 fs/namei.c:4830
       do_file_open+0x20e/0x430 fs/namei.c:4859
       do_sys_openat2+0x10d/0x1e0 fs/open.c:1366
       do_sys_open fs/open.c:1372 [inline]
       __do_sys_openat fs/open.c:1388 [inline]
       __se_sys_openat fs/open.c:1383 [inline]
       __x64_sys_openat+0x12d/0x210 fs/open.c:1383
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x106/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_xattr_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x14b8/0x2630 kernel/locking/lockdep.c:5237
       lock_acquire kernel/locking/lockdep.c:5868 [inline]
       lock_acquire+0x1cf/0x380 kernel/locking/lockdep.c:5825
       down_read+0x99/0x460 kernel/locking/rwsem.c:1537
       ocfs2_calc_xattr_init+0x174/0xca0 fs/ocfs2/xattr.c:631
       ocfs2_mknod+0xe73/0x27d0 fs/ocfs2/namei.c:334
       ocfs2_mkdir+0xf2/0x460 fs/ocfs2/namei.c:660
       vfs_mkdir+0x361/0x850 fs/namei.c:5233
       filename_mkdirat+0x48b/0x5e0 fs/namei.c:5266
       __do_sys_mkdirat fs/namei.c:5287 [inline]
       __se_sys_mkdirat fs/namei.c:5284 [inline]
       __x64_sys_mkdirat+0x89/0xc0 fs/namei.c:5284
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x106/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE] --> &ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]);
                               lock(&ocfs2_sysfile_lock_key[ORPHAN_DIR_SYSTEM_INODE]);
                               lock(&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

3 locks held by syz.7.5989/26550:
 #0: ffff88806a4f2420 (sb_writers#17){.+.+}-{0:0}, at: filename_create+0x10d/0x400 fs/namei.c:4915
 #1: ffff88807e2db480 (&type->i_mutex_dir_key#11/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:1073 [inline]
 #1: ffff88807e2db480 (&type->i_mutex_dir_key#11/1){+.+.}-{4:4}, at: __start_dirop fs/namei.c:2923 [inline]
 #1: ffff88807e2db480 (&type->i_mutex_dir_key#11/1){+.+.}-{4:4}, at: start_dirop fs/namei.c:2934 [inline]
 #1: ffff88807e2db480 (&type->i_mutex_dir_key#11/1){+.+.}-{4:4}, at: filename_create+0x1c0/0x400 fs/namei.c:4922
 #2: ffff88807e2ded80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
 #2: ffff88807e2ded80 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x4be0 fs/ocfs2/suballoc.c:857

stack backtrace:
CPU: 1 UID: 0 PID: 26550 Comm: syz.7.5989 Tainted: G             L      syzkaller #0 PREEMPT(full) 
Tainted: [L]=SOFTLOCKUP
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x100/0x190 lib/dump_stack.c:120
 print_circular_bug.cold+0x178/0x1c7 kernel/locking/lockdep.c:2043
 check_noncircular+0x146/0x160 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x14b8/0x2630 kernel/locking/lockdep.c:5237
 lock_acquire kernel/locking/lockdep.c:5868 [inline]
 lock_acquire+0x1cf/0x380 kernel/locking/lockdep.c:5825
 down_read+0x99/0x460 kernel/locking/rwsem.c:1537
 ocfs2_calc_xattr_init+0x174/0xca0 fs/ocfs2/xattr.c:631
 ocfs2_mknod+0xe73/0x27d0 fs/ocfs2/namei.c:334
 ocfs2_mkdir+0xf2/0x460 fs/ocfs2/namei.c:660
 vfs_mkdir+0x361/0x850 fs/namei.c:5233
 filename_mkdirat+0x48b/0x5e0 fs/namei.c:5266
 __do_sys_mkdirat fs/namei.c:5287 [inline]
 __se_sys_mkdirat fs/namei.c:5284 [inline]
 __x64_sys_mkdirat+0x89/0xc0 fs/namei.c:5284
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x106/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fb891b9b607
Code: 00 66 90 48 89 f2 b9 00 01 00 00 48 89 fe bf 9c ff ff ff e9 db f7 ff ff 66 2e 0f 1f 84 00 00 00 00 00 90 b8 02 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb892b33e58 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 00007fb892b33ee0 RCX: 00007fb891b9b607
RDX: 00000000000001ff RSI: 0000200000000040 RDI: 00000000ffffff9c
RBP: 0000200000000000 R08: 0000200000000040 R09: 0000000000000000
R10: 0000200000000000 R11: 0000000000000246 R12: 0000200000000040
R13: 00007fb892b33ea0 R14: 0000000000000000 R15: 0000000000000000
 </TASK>