syzbot


inconsistent lock state in sync_info_debugfs_show

Status: upstream: reported on 2024/03/09 05:08
Reported-by: syzbot+5ad9466d76abfe188fbc@syzkaller.appspotmail.com
First crash: 98d, last: 32d
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream inconsistent lock state in sync_info_debugfs_show dri media C done unreliable 277 12d 870d 0/27 upstream: reported C repro on 2022/01/27 16:33
linux-5.15 inconsistent lock state in sync_info_debugfs_show 13 1d13h 157d 0/3 upstream: reported on 2024/01/09 18:23

Sample crash report:
================================
WARNING: inconsistent lock state
6.1.90-syzkaller #0 Not tainted
--------------------------------
inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage.
syz-executor.1/6039 [HC0[0]:SC0[0]:HE0:SE1] takes:
ffff800016e9c9f8 (sync_timeline_list_lock){?...}-{2:2}, at: spin_lock_irq include/linux/spinlock.h:376 [inline]
ffff800016e9c9f8 (sync_timeline_list_lock){?...}-{2:2}, at: sync_info_debugfs_show+0x9c/0x464 drivers/dma-buf/sync_debug.c:147
{IN-HARDIRQ-W} state was registered at:
  lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
  __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
  _raw_spin_lock_irqsave+0x6c/0xb4 kernel/locking/spinlock.c:162
  sync_timeline_debug_remove+0x38/0x130 drivers/dma-buf/sync_debug.c:31
  sync_timeline_free drivers/dma-buf/sw_sync.c:104 [inline]
  kref_put include/linux/kref.h:65 [inline]
  sync_timeline_put drivers/dma-buf/sw_sync.c:116 [inline]
  timeline_fence_release+0x1e8/0x270 drivers/dma-buf/sw_sync.c:144
  dma_fence_release+0x1a4/0x5f8 drivers/dma-buf/dma-fence.c:560
  kref_put include/linux/kref.h:65 [inline]
  dma_fence_put include/linux/dma-fence.h:276 [inline]
  dma_fence_array_release+0x11c/0x24c drivers/dma-buf/dma-fence-array.c:120
  dma_fence_release+0x1a4/0x5f8 drivers/dma-buf/dma-fence.c:560
  kref_put include/linux/kref.h:65 [inline]
  dma_fence_put include/linux/dma-fence.h:276 [inline]
  irq_dma_fence_array_work+0xa0/0x13c drivers/dma-buf/dma-fence-array.c:52
  irq_work_single+0xbc/0x1d4 kernel/irq_work.c:211
  irq_work_run_list kernel/irq_work.c:242 [inline]
  irq_work_run+0x108/0x25c kernel/irq_work.c:251
  do_handle_IPI arch/arm64/kernel/smp.c:899 [inline]
  ipi_handler+0x108/0x86c arch/arm64/kernel/smp.c:922
  handle_percpu_devid_irq+0x174/0x354 kernel/irq/chip.c:930
  generic_handle_irq_desc include/linux/irqdesc.h:158 [inline]
  handle_irq_desc kernel/irq/irqdesc.c:651 [inline]
  generic_handle_domain_irq+0x7c/0xc4 kernel/irq/irqdesc.c:707
  __gic_handle_irq drivers/irqchip/irq-gic-v3.c:737 [inline]
  __gic_handle_irq_from_irqson drivers/irqchip/irq-gic-v3.c:788 [inline]
  gic_handle_irq+0x70/0x1e4 drivers/irqchip/irq-gic-v3.c:832
  call_on_irq_stack+0x24/0x4c arch/arm64/kernel/entry.S:893
  do_interrupt_handler+0xd4/0x138 arch/arm64/kernel/entry-common.c:274
  __el1_irq arch/arm64/kernel/entry-common.c:471 [inline]
  el1_interrupt+0x34/0x68 arch/arm64/kernel/entry-common.c:486
  el1h_64_irq_handler+0x18/0x24 arch/arm64/kernel/entry-common.c:491
  el1h_64_irq+0x64/0x68 arch/arm64/kernel/entry.S:581
  arch_local_irq_enable arch/arm64/include/asm/irqflags.h:35 [inline]
  __raw_spin_unlock_irq include/linux/spinlock_api_smp.h:159 [inline]
  _raw_spin_unlock_irq+0x44/0x90 kernel/locking/spinlock.c:202
  spin_unlock_irq include/linux/spinlock.h:401 [inline]
  sw_sync_debugfs_release+0x134/0x1f0 drivers/dma-buf/sw_sync.c:321
  __fput+0x30c/0x7bc fs/file_table.c:320
  ____fput+0x20/0x30 fs/file_table.c:348
  task_work_run+0x240/0x2f0 kernel/task_work.c:179
  resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
  do_notify_resume+0x2148/0x3474 arch/arm64/kernel/signal.c:1132
  prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline]
  exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline]
  el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638
  el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
  el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
irq event stamp: 2074
hardirqs last  enabled at (2073): [<ffff800012238ed4>] __raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:151 [inline]
hardirqs last  enabled at (2073): [<ffff800012238ed4>] _raw_spin_unlock_irqrestore+0x48/0xac kernel/locking/spinlock.c:194
hardirqs last disabled at (2074): [<ffff800012238d34>] __raw_spin_lock_irq include/linux/spinlock_api_smp.h:117 [inline]
hardirqs last disabled at (2074): [<ffff800012238d34>] _raw_spin_lock_irq+0x34/0x9c kernel/locking/spinlock.c:170
softirqs last  enabled at (2050): [<ffff800008033178>] local_bh_enable+0x10/0x34 include/linux/bottom_half.h:32
softirqs last disabled at (2048): [<ffff800008033144>] local_bh_disable+0x10/0x34 include/linux/bottom_half.h:19

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(sync_timeline_list_lock);
  <Interrupt>
    lock(sync_timeline_list_lock
);

 *** DEADLOCK ***

3 locks held by syz-executor.1/6039:
 #0: ffff0000d0082368 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x124/0x16c fs/file.c:1062
 #1: ffff0000ccf341c8 (&p->lock){+.+.}-{3:3}, at: seq_read_iter+0xac/0xc44 fs/seq_file.c:182
 #2: ffff800016e9c9f8 (sync_timeline_list_lock){?...}-{2:2}, at: spin_lock_irq include/linux/spinlock.h:376 [inline]
 #2: ffff800016e9c9f8 (sync_timeline_list_lock){?...}-{2:2}, at: sync_info_debugfs_show+0x9c/0x464 drivers/dma-buf/sync_debug.c:147

stack backtrace:
CPU: 1 PID: 6039 Comm: syz-executor.1 Not tainted 6.1.90-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_usage_bug+0x654/0x9b0 kernel/locking/lockdep.c:3957
 mark_lock_irq+0x980/0xd2c
 mark_lock+0x258/0x360 kernel/locking/lockdep.c:4628
 mark_held_locks kernel/locking/lockdep.c:4230 [inline]
 __trace_hardirqs_on_caller kernel/locking/lockdep.c:4248 [inline]
 lockdep_hardirqs_on_prepare+0x300/0x874 kernel/locking/lockdep.c:4315
 trace_hardirqs_on+0x184/0x2d4 kernel/trace/trace_preemptirq.c:49
 __raw_spin_unlock_irq include/linux/spinlock_api_smp.h:159 [inline]
 _raw_spin_unlock_irq+0x3c/0x90 kernel/locking/spinlock.c:202
 spin_unlock_irq include/linux/spinlock.h:401 [inline]
 sync_print_obj drivers/dma-buf/sync_debug.c:118 [inline]
 sync_info_debugfs_show+0x16c/0x464 drivers/dma-buf/sync_debug.c:153
 seq_read_iter+0x3e0/0xc44 fs/seq_file.c:230
 seq_read+0x1e8/0x2c0 fs/seq_file.c:162
 vfs_read+0x280/0x8ac fs/read_write.c:468
 ksys_read+0x15c/0x26c fs/read_write.c:613
 __do_sys_read fs/read_write.c:623 [inline]
 __se_sys_read fs/read_write.c:621 [inline]
 __arm64_sys_read+0x7c/0x90 fs/read_write.c:621
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

Crashes (6):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/05/14 16:28 linux-6.1.y 909ba1f1b414 fdb4c10c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/05/09 11:06 linux-6.1.y 909ba1f1b414 05079661 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/05/07 02:56 linux-6.1.y 909ba1f1b414 fa7a5cf0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/04/23 09:58 linux-6.1.y 6741e066ec76 21339d7b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/04/23 09:58 linux-6.1.y 6741e066ec76 21339d7b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/03/09 05:08 linux-6.1.y 61adba85cc40 6ee49f2e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
* Struck through repros no longer work on HEAD.