syzbot


possible deadlock in ocfs2_lock_refcount_tree

Status: upstream: reported on 2024/11/11 19:23
Reported-by: syzbot+640885a40c07e1675348@syzkaller.appspotmail.com
First crash: 209d, last: 7d15h
Similar bugs (3)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in ocfs2_lock_refcount_tree 48 21d 268d 0/3 upstream: reported on 2024/09/14 13:53
upstream possible deadlock in ocfs2_lock_refcount_tree ocfs2 5 259d 275d 0/28 auto-obsoleted due to no activity on 2025/01/01 02:27
upstream possible deadlock in ocfs2_lock_refcount_tree (2) ocfs2 5 103d 151d 0/28 auto-obsoleted due to no activity on 2025/06/06 14:54

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.1.138-syzkaller #0 Not tainted
------------------------------------------------------
syz.8.1177/9256 is trying to acquire lock:
ffff8881443ed898 (&new->rf_sem){+.+.}-{3:3}, at: __ocfs2_lock_refcount_tree fs/ocfs2/refcounttree.c:428 [inline]
ffff8881443ed898 (&new->rf_sem){+.+.}-{3:3}, at: ocfs2_lock_refcount_tree+0x1c0/0x980 fs/ocfs2/refcounttree.c:463

but task is already holding lock:
ffff888075d15be0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_truncate_file+0x36a/0x14d0 fs/ocfs2/file.c:467

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_read_virt_blocks+0x265/0x950 fs/ocfs2/extent_map.c:976
       ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
       ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
       ocfs2_find_entry+0x3d1/0x20c0 fs/ocfs2/dir.c:1091
       ocfs2_find_files_on_disk+0x102/0x390 fs/ocfs2/dir.c:1995
       ocfs2_lookup_ino_from_name+0x4f/0xf0 fs/ocfs2/dir.c:2017
       _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
       ocfs2_get_system_file_inode+0x332/0x7b0 fs/ocfs2/sysfile.c:112
       ocfs2_init_global_system_inodes+0x316/0x650 fs/ocfs2/super.c:457
       ocfs2_initialize_super fs/ocfs2/super.c:2250 [inline]
       ocfs2_fill_super+0x2a32/0x4d00 fs/ocfs2/super.c:994
       mount_bdev+0x287/0x3c0 fs/super.c:1443
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3057
       do_mount fs/namespace.c:3400 [inline]
       __do_sys_mount fs/namespace.c:3608 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3585
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&osb->system_file_mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       ocfs2_get_system_file_inode+0x1a2/0x7b0 fs/ocfs2/sysfile.c:101
       ocfs2_reserve_suballoc_bits+0x135/0x4630 fs/ocfs2/suballoc.c:776
       ocfs2_reserve_new_metadata_blocks+0x400/0x940 fs/ocfs2/suballoc.c:978
       ocfs2_add_refcount_flag+0x388/0xe90 fs/ocfs2/refcounttree.c:3683
       ocfs2_reflink_remap_extent fs/ocfs2/refcounttree.c:4563 [inline]
       ocfs2_reflink_remap_blocks+0xd2c/0x1930 fs/ocfs2/refcounttree.c:4690
       ocfs2_remap_file_range+0x4aa/0x720 fs/ocfs2/file.c:2703
       vfs_copy_file_range+0xd95/0x1560 fs/read_write.c:1518
       __do_sys_copy_file_range fs/read_write.c:1596 [inline]
       __se_sys_copy_file_range+0x31d/0x480 fs/read_write.c:1559
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&new->rf_sem){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       __ocfs2_lock_refcount_tree fs/ocfs2/refcounttree.c:428 [inline]
       ocfs2_lock_refcount_tree+0x1c0/0x980 fs/ocfs2/refcounttree.c:463
       ocfs2_refcount_cow_hunk fs/ocfs2/refcounttree.c:3415 [inline]
       ocfs2_refcount_cow+0x5ad/0xd30 fs/ocfs2/refcounttree.c:3476
       ocfs2_cow_file_pos+0x329/0x390 fs/ocfs2/file.c:362
       ocfs2_orphan_for_truncate fs/ocfs2/file.c:383 [inline]
       ocfs2_truncate_file+0x3ce/0x14d0 fs/ocfs2/file.c:496
       ocfs2_setattr+0x16a9/0x1cf0 fs/ocfs2/file.c:1212
       notify_change+0xc74/0xf40 fs/attr.c:499
       do_truncate+0x197/0x220 fs/open.c:65
       vfs_truncate+0x262/0x2f0 fs/open.c:111
       do_sys_truncate+0xdc/0x190 fs/open.c:134
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &new->rf_sem --> &osb->system_file_mutex --> &ocfs2_file_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_file_ip_alloc_sem_key);
                               lock(&osb->system_file_mutex);
                               lock(&ocfs2_file_ip_alloc_sem_key);
  lock(&new->rf_sem);

 *** DEADLOCK ***

3 locks held by syz.8.1177/9256:
 #0: ffff88807c824460 (sb_writers#28){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:393
 #1: ffff888075d15f48 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff888075d15f48 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: do_truncate+0x183/0x220 fs/open.c:63
 #2: ffff888075d15be0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_truncate_file+0x36a/0x14d0 fs/ocfs2/file.c:467

stack backtrace:
CPU: 0 PID: 9256 Comm: syz.8.1177 Not tainted 6.1.138-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/19/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 __ocfs2_lock_refcount_tree fs/ocfs2/refcounttree.c:428 [inline]
 ocfs2_lock_refcount_tree+0x1c0/0x980 fs/ocfs2/refcounttree.c:463
 ocfs2_refcount_cow_hunk fs/ocfs2/refcounttree.c:3415 [inline]
 ocfs2_refcount_cow+0x5ad/0xd30 fs/ocfs2/refcounttree.c:3476
 ocfs2_cow_file_pos+0x329/0x390 fs/ocfs2/file.c:362
 ocfs2_orphan_for_truncate fs/ocfs2/file.c:383 [inline]
 ocfs2_truncate_file+0x3ce/0x14d0 fs/ocfs2/file.c:496
 ocfs2_setattr+0x16a9/0x1cf0 fs/ocfs2/file.c:1212
 notify_change+0xc74/0xf40 fs/attr.c:499
 do_truncate+0x197/0x220 fs/open.c:65
 vfs_truncate+0x262/0x2f0 fs/open.c:111
 do_sys_truncate+0xdc/0x190 fs/open.c:134
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7feba4b8e969
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007feba5a8b038 EFLAGS: 00000246 ORIG_RAX: 000000000000004c
RAX: ffffffffffffffda RBX: 00007feba4db6160 RCX: 00007feba4b8e969
RDX: 0000000000000000 RSI: 000000000000000d RDI: 0000200000000080
RBP: 00007feba4c10ab1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000001 R14: 00007feba4db6160 R15: 00007fff13ef7108
 </TASK>

Crashes (49):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/05/13 19:09 linux-6.1.y 02b72ccb5f9d 7344edeb .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/05/09 05:03 linux-6.1.y ac7079a42ea5 bb813bcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/05/05 06:41 linux-6.1.y b6736e03756f b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/04/12 17:01 linux-6.1.y 420102835862 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/03/16 09:54 linux-6.1.y 344a09659766 e2826670 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/22 17:43 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/22 17:29 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/22 17:25 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/22 17:19 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/22 01:45 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/19 08:56 linux-6.1.y 0cbb5f65e52f 9a14138f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/14 00:19 linux-6.1.y 0cbb5f65e52f a98a8417 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/10 03:11 linux-6.1.y 0cbb5f65e52f ef44b750 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/10 00:33 linux-6.1.y 0cbb5f65e52f ef44b750 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/04 09:02 linux-6.1.y 0cbb5f65e52f 8f267cef .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/04 08:55 linux-6.1.y 0cbb5f65e52f 8f267cef .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/02/03 04:42 linux-6.1.y 0cbb5f65e52f 568559e4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/01/20 19:23 linux-6.1.y f4f677285b38 6e87cfa2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/01/11 04:25 linux-6.1.y c63962be84ef 6dbc6a9b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2024/12/30 06:01 linux-6.1.y 563edd786f0a d3ccff63 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2024/12/30 00:02 linux-6.1.y 563edd786f0a d3ccff63 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2024/12/26 18:10 linux-6.1.y 29f02ec58a94 d3ccff63 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2024/12/09 14:23 linux-6.1.y e4d90d63d385 9ac0fdc6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2024/12/09 13:28 linux-6.1.y e4d90d63d385 9ac0fdc6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2024/12/05 17:06 linux-6.1.y e4d90d63d385 29f61fce .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2024/12/04 15:56 linux-6.1.y e4d90d63d385 b50eb251 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2024/12/01 14:06 linux-6.1.y e4d90d63d385 68914665 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2024/11/30 20:02 linux-6.1.y e4d90d63d385 68914665 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2024/11/21 10:04 linux-6.1.y b67dc5c9ade9 4b25d554 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2024/11/19 06:18 linux-6.1.y b67dc5c9ade9 571351cb .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ocfs2_lock_refcount_tree
2025/06/02 00:43 linux-6.1.y da3c5173c55f 3d2f584d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/03/18 06:04 linux-6.1.y 344a09659766 ce3352cd .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/03/15 11:51 linux-6.1.y 344a09659766 e2826670 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/02/26 07:11 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/02/25 10:13 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/02/23 17:27 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/02/23 13:08 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/02/23 13:02 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/02/23 12:51 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/02/17 13:38 linux-6.1.y 0cbb5f65e52f 4121cf9d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/02/16 07:43 linux-6.1.y 0cbb5f65e52f 40a34ec9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/02/16 07:00 linux-6.1.y 0cbb5f65e52f 40a34ec9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2025/01/08 14:03 linux-6.1.y 7dc732d24ff7 f3558dbf .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2024/12/11 22:50 linux-6.1.y e4d90d63d385 ff949d25 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2024/11/29 21:17 linux-6.1.y e4d90d63d385 5df23865 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
2024/11/11 19:23 linux-6.1.y d7039b844a1c 0c4b1325 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_lock_refcount_tree
* Struck through repros no longer work on HEAD.