syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.28/4622 is trying to acquire lock:
ffff8880265fb898 (&new->rf_sem){+.+.}-{3:3}, at: __ocfs2_lock_refcount_tree fs/ocfs2/refcounttree.c:428 [inline]
ffff8880265fb898 (&new->rf_sem){+.+.}-{3:3}, at: ocfs2_lock_refcount_tree+0x1c0/0x980 fs/ocfs2/refcounttree.c:463

but task is already holding lock:
ffff8880566694a0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_inode_lock_for_extent_tree+0x72/0x190 fs/ocfs2/file.c:2208

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_read_virt_blocks+0x265/0x950 fs/ocfs2/extent_map.c:984
       ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
       ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
       ocfs2_find_entry+0x3d1/0x20c0 fs/ocfs2/dir.c:1091
       ocfs2_find_files_on_disk+0x102/0x390 fs/ocfs2/dir.c:1995
       ocfs2_lookup_ino_from_name+0x4f/0xf0 fs/ocfs2/dir.c:2017
       _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
       ocfs2_get_system_file_inode+0x332/0x7b0 fs/ocfs2/sysfile.c:112
       ocfs2_init_global_system_inodes+0x316/0x650 fs/ocfs2/super.c:457
       ocfs2_initialize_super fs/ocfs2/super.c:2253 [inline]
       ocfs2_fill_super+0x2a32/0x4d00 fs/ocfs2/super.c:994
       mount_bdev+0x287/0x3c0 fs/super.c:1443
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3069
       do_mount fs/namespace.c:3412 [inline]
       __do_sys_mount fs/namespace.c:3620 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3597
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&osb->system_file_mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       ocfs2_get_system_file_inode+0x1a2/0x7b0 fs/ocfs2/sysfile.c:101
       ocfs2_reserve_suballoc_bits+0x135/0x4630 fs/ocfs2/suballoc.c:776
       ocfs2_reserve_new_metadata_blocks+0x400/0x940 fs/ocfs2/suballoc.c:978
       ocfs2_add_refcount_flag+0x388/0xe90 fs/ocfs2/refcounttree.c:3683
       ocfs2_reflink_remap_extent fs/ocfs2/refcounttree.c:4563 [inline]
       ocfs2_reflink_remap_blocks+0xd2c/0x1930 fs/ocfs2/refcounttree.c:4690
       ocfs2_remap_file_range+0x4aa/0x720 fs/ocfs2/file.c:2703
       vfs_copy_file_range+0xd95/0x1560 fs/read_write.c:1518
       __do_sys_copy_file_range fs/read_write.c:1596 [inline]
       __se_sys_copy_file_range+0x31d/0x480 fs/read_write.c:1559
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&new->rf_sem){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       __ocfs2_lock_refcount_tree fs/ocfs2/refcounttree.c:428 [inline]
       ocfs2_lock_refcount_tree+0x1c0/0x980 fs/ocfs2/refcounttree.c:463
       ocfs2_refcount_cow_hunk fs/ocfs2/refcounttree.c:3415 [inline]
       ocfs2_refcount_cow+0x5ad/0xd30 fs/ocfs2/refcounttree.c:3476
       ocfs2_prepare_inode_for_write fs/ocfs2/file.c:2340 [inline]
       ocfs2_file_write_iter+0xe39/0x1df0 fs/ocfs2/file.c:2451
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x44c/0x960 fs/read_write.c:584
       ksys_write+0x143/0x240 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &new->rf_sem --> &osb->system_file_mutex --> &ocfs2_file_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_file_ip_alloc_sem_key);
                               lock(&osb->system_file_mutex);
                               lock(&ocfs2_file_ip_alloc_sem_key);
  lock(&new->rf_sem);

 *** DEADLOCK ***

4 locks held by syz.2.28/4622:
 #0: ffff8880295614e8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2ae/0x360 fs/file.c:1038
 #1: ffff8880295d0460 (sb_writers#14){.+.+}-{0:0}, at: vfs_write+0x256/0x960 fs/read_write.c:580
 #2: ffff888056669808 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff888056669808 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x438/0x1df0 fs/ocfs2/file.c:2399
 #3: ffff8880566694a0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_inode_lock_for_extent_tree+0x72/0x190 fs/ocfs2/file.c:2208

stack backtrace:
CPU: 0 PID: 4622 Comm: syz.2.28 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/18/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 __ocfs2_lock_refcount_tree fs/ocfs2/refcounttree.c:428 [inline]
 ocfs2_lock_refcount_tree+0x1c0/0x980 fs/ocfs2/refcounttree.c:463
 ocfs2_refcount_cow_hunk fs/ocfs2/refcounttree.c:3415 [inline]
 ocfs2_refcount_cow+0x5ad/0xd30 fs/ocfs2/refcounttree.c:3476
 ocfs2_prepare_inode_for_write fs/ocfs2/file.c:2340 [inline]
 ocfs2_file_write_iter+0xe39/0x1df0 fs/ocfs2/file.c:2451
 call_write_iter include/linux/fs.h:2265 [inline]
 new_sync_write fs/read_write.c:491 [inline]
 vfs_write+0x44c/0x960 fs/read_write.c:584
 ksys_write+0x143/0x240 fs/read_write.c:637
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7efd2e38eec9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007efd2f1c9038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007efd2e5e5fa0 RCX: 00007efd2e38eec9
RDX: 00000000fffffe13 RSI: 0000200000000040 RDI: 0000000000000007
RBP: 00007efd2e411f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007efd2e5e6038 R14: 00007efd2e5e5fa0 R15: 00007ffde46423f8
 </TASK>