syzbot

======================================================
WARNING: possible circular locking dependency detected
5.15.164-syzkaller #0 Not tainted
------------------------------------------------------
syz.1.3002/15111 is trying to acquire lock:
ffff88806210cbc0 (&type->i_mutex_dir_key#14){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff88806210cbc0 (&type->i_mutex_dir_key#14){+.+.}-{3:3}, at: vfs_rename+0x814/0x10f0 fs/namei.c:4797

but task is already holding lock:
ffff8880608b2aa0 (&type->i_mutex_dir_key#14/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
ffff8880608b2aa0 (&type->i_mutex_dir_key#14/2){+.+.}-{3:3}, at: vfs_rename+0x7a2/0x10f0 fs/namei.c:4795

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&type->i_mutex_dir_key#14/2){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667
       inode_lock_nested include/linux/fs.h:824 [inline]
       xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
       delete_one_xattr+0x102/0x2f0 fs/reiserfs/xattr.c:338
       reiserfs_for_each_xattr+0x9b2/0xb40 fs/reiserfs/xattr.c:311
       reiserfs_delete_xattrs+0x1b/0x80 fs/reiserfs/xattr.c:364
       reiserfs_evict_inode+0x20c/0x460 fs/reiserfs/inode.c:53
       evict+0x2a4/0x620 fs/inode.c:587
       __dentry_kill+0x436/0x650 fs/dcache.c:586
       dentry_kill+0xbb/0x290
       dput+0xd8/0x1a0 fs/dcache.c:893
       path_put+0x35/0x60 fs/namei.c:559
       path_setxattr+0x1ee/0x2a0 fs/xattr.c:634
       __do_sys_lsetxattr fs/xattr.c:653 [inline]
       __se_sys_lsetxattr fs/xattr.c:649 [inline]
       __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:649
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&type->i_mutex_dir_key#14/3){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667
       inode_lock_nested include/linux/fs.h:824 [inline]
       open_xa_root fs/reiserfs/xattr.c:127 [inline]
       open_xa_dir+0x132/0x610 fs/reiserfs/xattr.c:152
       xattr_lookup+0x24/0x280 fs/reiserfs/xattr.c:395
       reiserfs_xattr_set_handle+0x100/0x10b0 fs/reiserfs/xattr.c:540
       reiserfs_xattr_set+0x44e/0x570 fs/reiserfs/xattr.c:640
       __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x21d/0x420 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x27e/0x2e0 fs/xattr.c:611
       path_setxattr+0x1bc/0x2a0 fs/xattr.c:630
       __do_sys_lsetxattr fs/xattr.c:653 [inline]
       __se_sys_lsetxattr fs/xattr.c:649 [inline]
       __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:649
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&type->i_mutex_dir_key#14){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:789 [inline]
       vfs_rename+0x814/0x10f0 fs/namei.c:4797
       do_renameat2+0xe0f/0x1700 fs/namei.c:4985
       __do_sys_renameat2 fs/namei.c:5018 [inline]
       __se_sys_renameat2 fs/namei.c:5015 [inline]
       __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5015
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &type->i_mutex_dir_key#14 --> &type->i_mutex_dir_key#14/3 --> &type->i_mutex_dir_key#14/2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&type->i_mutex_dir_key#14/2);
                               lock(&type->i_mutex_dir_key#14/3);
                               lock(&type->i_mutex_dir_key#14/2);
  lock(&type->i_mutex_dir_key#14);

 *** DEADLOCK ***

5 locks held by syz.1.3002/15111:
 #0: ffff8880662ec460 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
 #1: ffff8880662ec748 (&type->s_vfs_rename_key#14){+.+.}-{3:3}, at: lock_rename fs/namei.c:3016 [inline]
 #1: ffff8880662ec748 (&type->s_vfs_rename_key#14){+.+.}-{3:3}, at: do_renameat2+0x5b7/0x1700 fs/namei.c:4924
 #2: ffff8880608b2400 (&type->i_mutex_dir_key#14/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3017 [inline]
 #2: ffff8880608b2400 (&type->i_mutex_dir_key#14/1){+.+.}-{3:3}, at: do_renameat2+0x644/0x1700 fs/namei.c:4924
 #3: ffff8880608b1020 (&type->i_mutex_dir_key#14/5){+.+.}-{3:3}, at: do_renameat2+0x67e/0x1700 fs/namei.c:4924
 #4: ffff8880608b2aa0 (&type->i_mutex_dir_key#14/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
 #4: ffff8880608b2aa0 (&type->i_mutex_dir_key#14/2){+.+.}-{3:3}, at: vfs_rename+0x7a2/0x10f0 fs/namei.c:4795

stack backtrace:
CPU: 0 PID: 15111 Comm: syz.1.3002 Not tainted 5.15.164-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:789 [inline]
 vfs_rename+0x814/0x10f0 fs/namei.c:4797
 do_renameat2+0xe0f/0x1700 fs/namei.c:4985
 __do_sys_renameat2 fs/namei.c:5018 [inline]
 __se_sys_renameat2 fs/namei.c:5015 [inline]
 __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5015
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f86136e79f9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8611b45038 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 00007f8613876058 RCX: 00007f86136e79f9
RDX: 0000000000000005 RSI: 00000000200001c0 RDI: 0000000000000005
RBP: 00007f86137558ee R08: 0000000000000000 R09: 0000000000000000
R10: 0000000020000140 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f8613876058 R15: 00007ffcdddc98b8
 </TASK>
REISERFS warning (device loop1): vs-13060 reiserfs_update_sd_size: stat data of object [1 2 0x0 SD] (nlink == 1) not found (pos 2)