syzbot


possible deadlock in chown_common (2)

Status: upstream: reported on 2024/04/02 11:14
Reported-by: syzbot+66bb777ebd9b0114629c@syzkaller.appspotmail.com
First crash: 77d, last: 77d
Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.14 possible deadlock in chown_common C 1 483d 622d 0/1 upstream: reported C repro on 2022/10/05 17:28
linux-5.15 possible deadlock in chown_common 6 49d 288d 0/3 upstream: reported on 2023/09/04 16:29
linux-6.1 possible deadlock in chown_common 1 334d 334d 0/3 auto-obsoleted due to no activity on 2023/10/28 14:17
upstream possible deadlock in chown_common reiserfs C error done 22 148d 618d 26/27 fixed on 2024/01/30 15:47

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.1.83-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/11571 is trying to acquire lock:
ffff0000fdbd82e0 (&type->i_mutex_dir_key#17){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff0000fdbd82e0 (&type->i_mutex_dir_key#17){+.+.}-{3:3}, at: chown_common+0x358/0x7d8 fs/open.c:726

but task is already holding lock:
ffff0000db10a460 (sb_writers#18){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:437

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (sb_writers#18){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_write+0x7c/0x308 include/linux/fs.h:1966
       mnt_want_write_file+0x64/0x1e8 fs/namespace.c:437
       reiserfs_ioctl+0x184/0x454 fs/reiserfs/ioctl.c:103
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl fs/ioctl.c:856 [inline]
       __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (&sbi->lock){+.+.}-{3:3}:
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       reiserfs_write_lock+0x7c/0xe8 fs/reiserfs/lock.c:27
       reiserfs_lookup+0x130/0x3c4 fs/reiserfs/namei.c:364
       __lookup_slow+0x250/0x374 fs/namei.c:1690
       lookup_one_len+0x178/0x28c fs/namei.c:2742
       reiserfs_lookup_privroot+0x8c/0x204 fs/reiserfs/xattr.c:973
       reiserfs_fill_super+0x15b4/0x2028 fs/reiserfs/super.c:2192
       mount_bdev+0x274/0x370 fs/super.c:1432
       get_super_block+0x44/0x58 fs/reiserfs/super.c:2601
       legacy_get_tree+0xd4/0x16c fs/fs_context.c:632
       vfs_get_tree+0x90/0x274 fs/super.c:1562
       do_new_mount+0x278/0x8fc fs/namespace.c:3051
       path_mount+0x590/0xe5c fs/namespace.c:3381
       do_mount fs/namespace.c:3394 [inline]
       __do_sys_mount fs/namespace.c:3602 [inline]
       __se_sys_mount fs/namespace.c:3579 [inline]
       __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3579
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (&type->i_mutex_dir_key#17){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       chown_common+0x358/0x7d8 fs/open.c:726
       vfs_fchown fs/open.c:804 [inline]
       ksys_fchown+0xe0/0x158 fs/open.c:815
       __do_sys_fchown fs/open.c:823 [inline]
       __se_sys_fchown fs/open.c:821 [inline]
       __arm64_sys_fchown+0x7c/0x94 fs/open.c:821
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
  &type->i_mutex_dir_key#17 --> &sbi->lock --> sb_writers#18

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(sb_writers#18);
                               lock(&sbi->lock);
                               lock(sb_writers#18);
  lock(&type->i_mutex_dir_key#17);

 *** DEADLOCK ***

1 lock held by syz-executor.1/11571:
 #0: ffff0000db10a460 (sb_writers#18){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:437

stack backtrace:
CPU: 1 PID: 11571 Comm: syz-executor.1 Not tainted 6.1.83-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x5c lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:758 [inline]
 chown_common+0x358/0x7d8 fs/open.c:726
 vfs_fchown fs/open.c:804 [inline]
 ksys_fchown+0xe0/0x158 fs/open.c:815
 __do_sys_fchown fs/open.c:823 [inline]
 __se_sys_fchown fs/open.c:821 [inline]
 __arm64_sys_fchown+0x7c/0x94 fs/open.c:821
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/04/02 11:14 linux-6.1.y e5cd595e23c1 6baf5069 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in chown_common
* Struck through repros no longer work on HEAD.