syzbot


possible deadlock in hsr_dev_xmit

Status: upstream: reported on 2024/05/15 14:40
Reported-by: syzbot+6866f758b12eff7002ef@syzkaller.appspotmail.com
First crash: 35d, last: 11d
Similar bugs (3)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in hsr_dev_xmit 1 11d 11d 0/3 upstream: reported on 2024/06/08 01:23
upstream possible deadlock in hsr_dev_xmit (2) net C done 148 5h22m 83d 0/27 upstream: reported C repro on 2024/03/28 14:20
upstream possible deadlock in hsr_dev_xmit net 1 448d 444d 0/27 auto-obsoleted due to no activity on 2023/07/27 11:35

Sample crash report:
============================================
WARNING: possible recursive locking detected
5.15.158-syzkaller #0 Not tainted
--------------------------------------------
swapper/0/0 is trying to acquire lock:
ffff88807873ed88 (&hsr->seqnr_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:368 [inline]
ffff88807873ed88 (&hsr->seqnr_lock){+.-.}-{2:2}, at: hsr_dev_xmit+0x13a/0x1e0 net/hsr/hsr_device.c:222

but task is already holding lock:
ffff88807e59ad88 (&hsr->seqnr_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:368 [inline]
ffff88807e59ad88 (&hsr->seqnr_lock){+.-.}-{2:2}, at: send_hsr_supervision_frame+0x272/0xad0 net/hsr/hsr_device.c:303

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&hsr->seqnr_lock);
  lock(&hsr->seqnr_lock);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

7 locks held by swapper/0/0:
 #0: ffffc90000007be0 ((&hsr->announce_timer)){+.-.}-{0:0}, at: lockdep_copy_map include/linux/lockdep.h:45 [inline]
 #0: ffffc90000007be0 ((&hsr->announce_timer)){+.-.}-{0:0}, at: call_timer_fn+0xbe/0x560 kernel/time/timer.c:1441
 #1: ffffffff8c91fae0 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:311
 #2: ffff88807e59ad88 (&hsr->seqnr_lock
){+.-.}-{2:2}
, at: spin_lock_bh include/linux/spinlock.h:368 [inline]
, at: send_hsr_supervision_frame+0x272/0xad0 net/hsr/hsr_device.c:303
 #3: ffffffff8c91fae0
 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:311
 #4: ffffffff8c91fb40 (rcu_read_lock_bh){....}-{1:2}, at: rcu_lock_acquire+0x9/0x30 include/linux/rcupdate.h:312
 #5: ffffffff8c91fae0 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:311
 #6: ffffffff8c91fb40 (rcu_read_lock_bh){....}-{1:2}, at: rcu_lock_acquire+0x9/0x30 include/linux/rcupdate.h:312

stack backtrace:
CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.15.158-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 print_deadlock_bug kernel/locking/lockdep.c:2946 [inline]
 check_deadlock kernel/locking/lockdep.c:2989 [inline]
 validate_chain+0x46d2/0x5930 kernel/locking/lockdep.c:3775
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
 _raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:178
 spin_lock_bh include/linux/spinlock.h:368 [inline]
 hsr_dev_xmit+0x13a/0x1e0 net/hsr/hsr_device.c:222
 __netdev_start_xmit include/linux/netdevice.h:5019 [inline]
 netdev_start_xmit include/linux/netdevice.h:5033 [inline]
 xmit_one net/core/dev.c:3617 [inline]
 dev_hard_start_xmit+0x298/0x7a0 net/core/dev.c:3633
 __dev_queue_xmit+0x1cee/0x3230 net/core/dev.c:4248
 br_dev_queue_push_xmit+0x6e1/0x8a0 net/bridge/br_forward.c:53
 NF_HOOK+0x36c/0x420 include/linux/netfilter.h:302
 br_forward_finish+0x74/0x80 net/bridge/br_forward.c:66
 NF_HOOK+0x36c/0x420 include/linux/netfilter.h:302
 __br_forward+0x430/0x5f0 net/bridge/br_forward.c:115
 deliver_clone net/bridge/br_forward.c:131 [inline]
 maybe_deliver+0xb3/0x150 net/bridge/br_forward.c:189
 br_flood+0x2e7/0x440 net/bridge/br_forward.c:231
 br_dev_xmit+0xfb3/0x1520
 __netdev_start_xmit include/linux/netdevice.h:5019 [inline]
 netdev_start_xmit include/linux/netdevice.h:5033 [inline]
 xmit_one net/core/dev.c:3617 [inline]
 dev_hard_start_xmit+0x298/0x7a0 net/core/dev.c:3633
 __dev_queue_xmit+0x1cee/0x3230 net/core/dev.c:4248
 hsr_xmit net/hsr/hsr_forward.c:338 [inline]
 hsr_forward_do net/hsr/hsr_forward.c:429 [inline]
 hsr_forward_skb+0x133c/0x1b50 net/hsr/hsr_forward.c:577
 send_hsr_supervision_frame+0x540/0xad0 net/hsr/hsr_device.c:326
 hsr_announce+0x176/0x300 net/hsr/hsr_device.c:382
 call_timer_fn+0x16d/0x560 kernel/time/timer.c:1451
 expire_timers kernel/time/timer.c:1496 [inline]
 __run_timers+0x67c/0x890 kernel/time/timer.c:1767
 run_timer_softirq+0x63/0xf0 kernel/time/timer.c:1780
 __do_softirq+0x3b3/0x93a kernel/softirq.c:558
 invoke_softirq kernel/softirq.c:432 [inline]
 __irq_exit_rcu+0x155/0x240 kernel/softirq.c:637
 irq_exit_rcu+0x5/0x20 kernel/softirq.c:649
 sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1096
 </IRQ>
 <TASK>
 asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:638
RIP: 0010:native_save_fl arch/x86/include/asm/irqflags.h:22 [inline]
RIP: 0010:arch_local_save_flags arch/x86/include/asm/irqflags.h:70 [inline]
RIP: 0010:arch_irqs_disabled arch/x86/include/asm/irqflags.h:132 [inline]
RIP: 0010:acpi_safe_halt drivers/acpi/processor_idle.c:110 [inline]
RIP: 0010:acpi_idle_do_entry+0x10f/0x340 drivers/acpi/processor_idle.c:570
Code: 1d 59 f7 48 83 e3 08 0f 85 0a 01 00 00 4c 8d 74 24 20 e8 24 99 5f f7 0f 1f 44 00 00 e8 1a 19 59 f7 0f 00 2d b3 d9 bb 00 fb f4 <4c> 89 f3 48 c1 eb 03 42 80 3c 3b 00 74 08 4c 89 f7 e8 9b f1 a2 f7
RSP: 0018:ffffffff8c607b80 EFLAGS: 000002d3
RAX: ffffffff8a2743a6 RBX: 0000000000000000 RCX: ffffffff8c6bd5c0
RDX: 0000000000000000 RSI: ffffffff8a8b2980 RDI: ffffffff8ad8f600
RBP: ffffffff8c607c10 R08: ffffffff8186dcf0 R09: fffffbfff18d7ab9
R10: 0000000000000000 R11: dffffc0000000001 R12: 1ffffffff18c0f70
R13: ffff888146aa4004 R14: ffffffff8c607ba0 R15: dffffc0000000000
 acpi_idle_enter+0x352/0x4f0 drivers/acpi/processor_idle.c:705
 cpuidle_enter_state+0x521/0xef0 drivers/cpuidle/cpuidle.c:237
 cpuidle_enter+0x59/0x90 drivers/cpuidle/cpuidle.c:351
 call_cpuidle kernel/sched/idle.c:158 [inline]
 cpuidle_idle_call kernel/sched/idle.c:239 [inline]
 do_idle+0x3e4/0x670 kernel/sched/idle.c:306
 cpu_startup_entry+0x14/0x20 kernel/sched/idle.c:403
 start_kernel+0x48c/0x540 init/main.c:1140
 secondary_startup_64_no_verify+0xb1/0xbb
 </TASK>
----------------
Code disassembly (best guess):
   0:	1d 59 f7 48 83       	sbb    $0x8348f759,%eax
   5:	e3 08                	jrcxz  0xf
   7:	0f 85 0a 01 00 00    	jne    0x117
   d:	4c 8d 74 24 20       	lea    0x20(%rsp),%r14
  12:	e8 24 99 5f f7       	call   0xf75f993b
  17:	0f 1f 44 00 00       	nopl   0x0(%rax,%rax,1)
  1c:	e8 1a 19 59 f7       	call   0xf759193b
  21:	0f 00 2d b3 d9 bb 00 	verw   0xbbd9b3(%rip)        # 0xbbd9db
  28:	fb                   	sti
  29:	f4                   	hlt
* 2a:	4c 89 f3             	mov    %r14,%rbx <-- trapping instruction
  2d:	48 c1 eb 03          	shr    $0x3,%rbx
  31:	42 80 3c 3b 00       	cmpb   $0x0,(%rbx,%r15,1)
  36:	74 08                	je     0x40
  38:	4c 89 f7             	mov    %r14,%rdi
  3b:	e8 9b f1 a2 f7       	call   0xf7a2f1db

Crashes (4):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/05/15 14:39 linux-5.15.y 284087d4f7d5 94b087b1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hsr_dev_xmit
2024/06/08 01:02 linux-5.15.y c61bd26ae81a 82c05ab8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hsr_dev_xmit
2024/06/08 01:02 linux-5.15.y c61bd26ae81a 82c05ab8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hsr_dev_xmit
2024/05/15 15:27 linux-5.15.y 284087d4f7d5 94b087b1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hsr_dev_xmit
* Struck through repros no longer work on HEAD.