syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.136/4900 is trying to acquire lock:
ffff88801fd0e990 (jbd2_handle){++++}-{0:0}, at: wait_transaction_locked+0x19f/0x270 fs/jbd2/transaction.c:178

but task is already holding lock:
ffff88805fe29ce8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe0/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13c8/0x1750 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x756/0xac0 fs/quota/dquot.c:2463
       dquot_load_quota_inode+0x2d8/0x5d0 fs/quota/dquot.c:2500
       ocfs2_enable_quotas+0x1c5/0x490 fs/ocfs2/super.c:927
       ocfs2_fill_super+0x3cd2/0x50f0 fs/ocfs2/super.c:1140
       mount_bdev+0x287/0x3c0 fs/super.c:1400
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x24a/0xa40 fs/namespace.c:3034
       do_mount fs/namespace.c:3377 [inline]
       __do_sys_mount fs/namespace.c:3585 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3562
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #4 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x2a7/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_acquire_dquot+0x688/0xb10 fs/ocfs2/quota_global.c:848
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3c3/0xcd0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x144/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8ab/0x2510 fs/ocfs2/namei.c:310
       ocfs2_mkdir+0x192/0x420 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4073
       do_mkdirat+0x1df/0x5b0 fs/namei.c:4098
       __do_sys_mkdirat fs/namei.c:4113 [inline]
       __se_sys_mkdirat fs/namei.c:4111 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ocfs2_create_local_dquot+0x199/0x1850 fs/ocfs2/quota_local.c:1224
       ocfs2_acquire_dquot+0x7ed/0xb10 fs/ocfs2/quota_global.c:871
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3c3/0xcd0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x144/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8ab/0x2510 fs/ocfs2/namei.c:310
       ocfs2_mkdir+0x192/0x420 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4073
       do_mkdirat+0x1df/0x5b0 fs/namei.c:4098
       __do_sys_mkdirat fs/namei.c:4113 [inline]
       __se_sys_mkdirat fs/namei.c:4111 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x1e3/0x2400 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:507
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6212
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412
       __dquot_alloc_space+0x5d0/0xe20 fs/quota/dquot.c:1752
       dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline]
       dquot_alloc_space include/linux/quotaops.h:310 [inline]
       dquot_alloc_block include/linux/quotaops.h:334 [inline]
       ext4_mb_new_blocks+0xfb1/0x4820 fs/ext4/mballoc.c:5750
       ext4_ext_map_blocks+0x18ab/0x65e0 fs/ext4/extents.c:4357
       ext4_map_blocks+0x98e/0x1b30 fs/ext4/inode.c:675
       _ext4_get_block+0x1e7/0x540 fs/ext4/inode.c:818
       ext4_block_write_begin+0x61b/0x1220 fs/ext4/inode.c:1103
       ext4_write_begin+0x6c8/0x15d0 fs/ext4/ext4_jbd2.h:-1
       ext4_da_write_begin+0x43b/0xb40 fs/ext4/inode.c:2977
       generic_perform_write+0x2b6/0x550 mm/filemap.c:3785
       ext4_buffered_write_iter+0x25f/0x3b0 fs/ext4/file.c:268
       ext4_file_write_iter+0x74d/0x1700 fs/ext4/file.c:-1
       call_write_iter include/linux/fs.h:2173 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0x745/0xd60 fs/read_write.c:594
       ksys_write+0x152/0x260 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ext4_truncate+0x97f/0x10f0 fs/ext4/inode.c:4258
       ext4_setattr+0x1147/0x1b60 fs/ext4/inode.c:5620
       notify_change+0xbcd/0xee0 fs/attr.c:505
       do_truncate+0x1ac/0x240 fs/open.c:65
       do_sys_ftruncate+0x31b/0x3d0 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (jbd2_handle){++++}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       wait_transaction_locked+0x1bb/0x270 fs/jbd2/transaction.c:178
       add_transaction_credits+0x103/0xc80 fs/jbd2/transaction.c:242
       start_this_handle+0x74d/0x15c0 fs/jbd2/transaction.c:423
       jbd2__journal_restart+0x233/0x630 fs/jbd2/transaction.c:816
       ocfs2_extend_trans+0x2bb/0x6f0 fs/ocfs2/journal.c:459
       ocfs2_extend_rotate_transaction fs/ocfs2/alloc.c:2297 [inline]
       ocfs2_try_to_merge_extent+0xdb9/0x1cd0 fs/ocfs2/alloc.c:3805
       ocfs2_split_extent+0x1a82/0x21f0 fs/ocfs2/alloc.c:5131
       ocfs2_change_extent_flag+0xafb/0xe10 fs/ocfs2/alloc.c:5222
       ocfs2_mark_extent_written+0x2f3/0x570 fs/ocfs2/alloc.c:5268
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2377 [inline]
       ocfs2_dio_end_io+0xc34/0x1200 fs/ocfs2/aops.c:2431
       dio_complete+0x249/0x720 fs/direct-io.c:272
       do_blockdev_direct_IO fs/direct-io.c:1336 [inline]
       __blockdev_direct_IO+0x2e31/0x3a70 fs/direct-io.c:1368
       ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2468
       generic_file_direct_write+0x22c/0x490 mm/filemap.c:3687
       __generic_file_write_iter+0x2b1/0x4e0 mm/filemap.c:3869
       ocfs2_file_write_iter+0x1670/0x1e70 fs/ocfs2/file.c:2472
       do_iter_readv_writev+0x47e/0x5f0 fs/read_write.c:-1
       do_iter_write+0x205/0x7b0 fs/read_write.c:855
       vfs_writev fs/read_write.c:928 [inline]
       do_pwritev+0x240/0x3a0 fs/read_write.c:1025
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  jbd2_handle --> sb_internal#2 --> &journal->j_trans_barrier

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&journal->j_trans_barrier);
                               lock(sb_internal#2);
                               lock(&journal->j_trans_barrier);
  lock(jbd2_handle);

 *** DEADLOCK ***

6 locks held by syz.0.136/4900:
 #0: ffff88807871a460 (sb_writers#23){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:927 [inline]
 #0: ffff88807871a460 (sb_writers#23){.+.+}-{0:0}, at: do_pwritev+0x229/0x3a0 fs/read_write.c:1025
 #1: ffff88805ea9df48 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff88805ea9df48 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x436/0x1e70 fs/ocfs2/file.c:2402
 #2: ffff88805ea9dbe0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2325 [inline]
 #2: ffff88805ea9dbe0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_dio_end_io+0x434/0x1200 fs/ocfs2/aops.c:2431
 #3: ffff8880611b1808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #3: ffff8880611b1808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16a/0x44d0 fs/ocfs2/suballoc.c:782
 #4: ffff88807871a650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2358 [inline]
 #4: ffff88807871a650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_dio_end_io+0x8b0/0x1200 fs/ocfs2/aops.c:2431
 #5: ffff88805fe29ce8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374

stack backtrace:
CPU: 1 PID: 4900 Comm: syz.0.136 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/18/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 wait_transaction_locked+0x1bb/0x270 fs/jbd2/transaction.c:178
 add_transaction_credits+0x103/0xc80 fs/jbd2/transaction.c:242
 start_this_handle+0x74d/0x15c0 fs/jbd2/transaction.c:423
 jbd2__journal_restart+0x233/0x630 fs/jbd2/transaction.c:816
 ocfs2_extend_trans+0x2bb/0x6f0 fs/ocfs2/journal.c:459
 ocfs2_extend_rotate_transaction fs/ocfs2/alloc.c:2297 [inline]
 ocfs2_try_to_merge_extent+0xdb9/0x1cd0 fs/ocfs2/alloc.c:3805
 ocfs2_split_extent+0x1a82/0x21f0 fs/ocfs2/alloc.c:5131
 ocfs2_change_extent_flag+0xafb/0xe10 fs/ocfs2/alloc.c:5222
 ocfs2_mark_extent_written+0x2f3/0x570 fs/ocfs2/alloc.c:5268
 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2377 [inline]
 ocfs2_dio_end_io+0xc34/0x1200 fs/ocfs2/aops.c:2431
 dio_complete+0x249/0x720 fs/direct-io.c:272
 do_blockdev_direct_IO fs/direct-io.c:1336 [inline]
 __blockdev_direct_IO+0x2e31/0x3a70 fs/direct-io.c:1368
 ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2468
 generic_file_direct_write+0x22c/0x490 mm/filemap.c:3687
 __generic_file_write_iter+0x2b1/0x4e0 mm/filemap.c:3869
 ocfs2_file_write_iter+0x1670/0x1e70 fs/ocfs2/file.c:2472
 do_iter_readv_writev+0x47e/0x5f0 fs/read_write.c:-1
 do_iter_write+0x205/0x7b0 fs/read_write.c:855
 vfs_writev fs/read_write.c:928 [inline]
 do_pwritev+0x240/0x3a0 fs/read_write.c:1025
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f7d9c3e9dd9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f7d9a622028 EFLAGS: 00000246 ORIG_RAX: 0000000000000148
RAX: ffffffffffffffda RBX: 00007f7d9c663090 RCX: 00007f7d9c3e9dd9
RDX: 0000000000000001 RSI: 0000200000000240 RDI: 0000000000000007
RBP: 00007f7d9c47fd69 R08: 0000000000029000 R09: 0000000000000003
R10: 0000000000007000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f7d9c663128 R14: 00007f7d9c663090 R15: 00007ffd11210198
 </TASK>
syz.0.136 (4900) used greatest stack depth: 19576 bytes left