syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
kworker/u4:7/4493 is trying to acquire lock:
ffff0000f36d0990 (jbd2_handle){++++}-{0:0}, at: wait_transaction_locked+0x158/0x234 fs/jbd2/transaction.c:176

but task is already holding lock:
ffff0000ca8e80e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x374/0x6cc fs/ocfs2/journal.c:374

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x64/0x300 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x374/0x6cc fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xd8/0x44c fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x107c/0x1378 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x6c4/0xa24 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x274/0x4e4 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x17c/0x3c0 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x34ec/0x436c fs/ocfs2/super.c:1139
       mount_bdev+0x264/0x358 fs/super.c:1443
       ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1186
       legacy_get_tree+0xd4/0x16c fs/fs_context.c:632
       vfs_get_tree+0x90/0x274 fs/super.c:1573
       do_new_mount+0x228/0x810 fs/namespace.c:3078
       path_mount+0x5bc/0xe80 fs/namespace.c:3408
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount fs/namespace.c:3606 [inline]
       __arm64_sys_mount+0x49c/0x59c fs/namespace.c:3606
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b4 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x130 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x128 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #4 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x20c/0x6cc fs/ocfs2/journal.c:372
       ocfs2_acquire_dquot+0x5c8/0xac8 fs/ocfs2/quota_global.c:848
       dqget+0x654/0xcc4 fs/quota/dquot.c:988
       __dquot_initialize+0x2fc/0xacc fs/quota/dquot.c:1517
       dquot_initialize+0x24/0x34 fs/quota/dquot.c:1579
       ocfs2_get_init_inode+0x140/0x1b4 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x7bc/0x2110 fs/ocfs2/namei.c:310
       ocfs2_create+0x19c/0x4f8 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0xe18/0x26bc fs/namei.c:3788
       do_filp_open+0x194/0x384 fs/namei.c:3818
       do_sys_openat2+0x134/0x3f4 fs/open.c:1320
       do_sys_open fs/open.c:1336 [inline]
       __do_sys_openat fs/open.c:1352 [inline]
       __se_sys_openat fs/open.c:1347 [inline]
       __arm64_sys_openat+0x118/0x14c fs/open.c:1347
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b4 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x130 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x128 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       ocfs2_create_local_dquot+0x144/0x13d4 fs/ocfs2/quota_local.c:1224
       ocfs2_acquire_dquot+0x6f4/0xac8 fs/ocfs2/quota_global.c:871
       dqget+0x654/0xcc4 fs/quota/dquot.c:988
       __dquot_initialize+0x2fc/0xacc fs/quota/dquot.c:1517
       dquot_initialize+0x24/0x34 fs/quota/dquot.c:1579
       ocfs2_get_init_inode+0x140/0x1b4 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x7bc/0x2110 fs/ocfs2/namei.c:310
       ocfs2_create+0x19c/0x4f8 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3490 [inline]
       open_last_lookups fs/namei.c:3558 [inline]
       path_openat+0xe18/0x26bc fs/namei.c:3788
       do_filp_open+0x194/0x384 fs/namei.c:3818
       do_sys_openat2+0x134/0x3f4 fs/open.c:1320
       do_sys_open fs/open.c:1336 [inline]
       __do_sys_openat fs/open.c:1352 [inline]
       __se_sys_openat fs/open.c:1347 [inline]
       __arm64_sys_openat+0x118/0x14c fs/open.c:1347
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b4 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x130 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x128 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x190/0x1f60 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       dquot_commit+0x50/0x1c4 fs/quota/dquot.c:507
       ext4_write_dquot+0x1b4/0x31c fs/ext4/super.c:6817
       ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6894
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
       __dquot_alloc_space+0x560/0xce0 fs/quota/dquot.c:1752
       dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
       dquot_alloc_space include/linux/quotaops.h:313 [inline]
       dquot_alloc_block include/linux/quotaops.h:337 [inline]
       ext4_mb_new_blocks+0xd38/0x4254 fs/ext4/mballoc.c:5740
       ext4_ext_map_blocks+0x1394/0x56f4 fs/ext4/extents.c:4346
       ext4_map_blocks+0x860/0x1778 fs/ext4/inode.c:681
       _ext4_get_block+0x19c/0x4d8 fs/ext4/inode.c:824
       ext4_get_block+0x4c/0x60 fs/ext4/inode.c:841
       ext4_block_write_begin+0x50c/0x10e4 fs/ext4/inode.c:1126
       ext4_write_begin+0x5f4/0x131c fs/ext4/ext4_jbd2.h:-1
       generic_perform_write+0x234/0x4f4 mm/filemap.c:3862
       ext4_buffered_write_iter+0x2c4/0x528 fs/ext4/file.c:285
       ext4_file_write_iter+0x18c/0x1574 fs/ext4/file.c:-1
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x53c/0x940 fs/read_write.c:861
       vfs_writev fs/read_write.c:934 [inline]
       do_writev+0x210/0x3ec fs/read_write.c:977
       __do_sys_writev fs/read_write.c:1050 [inline]
       __se_sys_writev fs/read_write.c:1047 [inline]
       __arm64_sys_writev+0x80/0x94 fs/read_write.c:1047
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b4 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x130 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x128 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       ext4_map_blocks+0x7c4/0x1778 fs/ext4/inode.c:674
       mpage_map_one_extent fs/ext4/inode.c:2436 [inline]
       mpage_map_and_submit_extent fs/ext4/inode.c:2489 [inline]
       ext4_writepages+0xdbc/0x28b4 fs/ext4/inode.c:2857
       do_writepages+0x2b0/0x504 mm/page-writeback.c:2491
       __writeback_single_inode+0x164/0x1554 fs/fs-writeback.c:1622
       writeback_sb_inodes+0x858/0x143c fs/fs-writeback.c:1913
       __writeback_inodes_wb+0x110/0x394 fs/fs-writeback.c:1984
       wb_writeback+0x428/0xfcc fs/fs-writeback.c:2089
       wb_check_background_flush fs/fs-writeback.c:2155 [inline]
       wb_do_writeback fs/fs-writeback.c:2243 [inline]
       wb_workfn+0xb38/0xe18 fs/fs-writeback.c:2270
       process_one_work+0x7f8/0x13a4 kernel/workqueue.c:2292
       worker_thread+0x8c4/0xfec kernel/workqueue.c:2439
       kthread+0x250/0x2d8 kernel/kthread.c:376
       ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:850

-> #0 (jbd2_handle){++++}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2880/0x6800 kernel/locking/lockdep.c:5049
       lock_acquire+0x20c/0x63c kernel/locking/lockdep.c:5662
       wait_transaction_locked+0x180/0x234 fs/jbd2/transaction.c:177
       add_transaction_credits+0x104/0xaf0 fs/jbd2/transaction.c:-1
       start_this_handle+0x520/0x1280 fs/jbd2/transaction.c:422
       jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:520
       jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x380/0x6cc fs/ocfs2/journal.c:376
       ocfs2_release_dquot+0x3f4/0xba8 fs/ocfs2/quota_global.c:749
       quota_release_workfn+0x374/0x61c fs/quota/dquot.c:848
       process_one_work+0x7f8/0x13a4 kernel/workqueue.c:2292
       process_scheduled_works kernel/workqueue.c:2355 [inline]
       worker_thread+0xb64/0xfec kernel/workqueue.c:2444
       kthread+0x250/0x2d8 kernel/kthread.c:376
       ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:850

other info that might help us debug this:

Chain exists of:
  jbd2_handle --> sb_internal#2 --> &journal->j_trans_barrier

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&journal->j_trans_barrier);
                               lock(sb_internal#2);
                               lock(&journal->j_trans_barrier);
  lock(jbd2_handle);

 *** DEADLOCK ***

7 locks held by kworker/u4:7/4493:
 #0: ffff0000c0029138 ((wq_completion)events_unbound){+.+.}-{0:0}, at: process_one_work+0x6b8/0x13a4 kernel/workqueue.c:2265
 #1: ffff800021027c20 ((quota_release_work).work){+.+.}-{0:0}, at: process_one_work+0x6fc/0x13a4 kernel/workqueue.c:2267
 #2: ffff0000f00d52a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_release_dquot+0x23c/0xba8 fs/ocfs2/quota_global.c:729
 #3: ffff0000f0219808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #3: ffff0000f0219808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x190/0x238 fs/ocfs2/quota_global.c:313
 #4: ffff0000f02194a0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1ac/0x238 fs/ocfs2/quota_global.c:314
 #5: ffff0000da96c650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_release_dquot+0x3f4/0xba8 fs/ocfs2/quota_global.c:749
 #6: ffff0000ca8e80e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x374/0x6cc fs/ocfs2/journal.c:374

stack backtrace:
CPU: 1 PID: 4493 Comm: kworker/u4:7 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/18/2026
Workqueue: events_unbound quota_release_workfn
Call trace:
 dump_backtrace+0x1c0/0x1ec arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack+0x30/0x40 lib/dump_stack.c:88
 dump_stack_lvl+0xf4/0x15c lib/dump_stack.c:106
 dump_stack+0x1c/0x5c lib/dump_stack.c:113
 print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2048
 check_noncircular+0x264/0x2f8 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2880/0x6800 kernel/locking/lockdep.c:5049
 lock_acquire+0x20c/0x63c kernel/locking/lockdep.c:5662
 wait_transaction_locked+0x180/0x234 fs/jbd2/transaction.c:177
 add_transaction_credits+0x104/0xaf0 fs/jbd2/transaction.c:-1
 start_this_handle+0x520/0x1280 fs/jbd2/transaction.c:422
 jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:520
 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
 ocfs2_start_trans+0x380/0x6cc fs/ocfs2/journal.c:376
 ocfs2_release_dquot+0x3f4/0xba8 fs/ocfs2/quota_global.c:749
 quota_release_workfn+0x374/0x61c fs/quota/dquot.c:848
 process_one_work+0x7f8/0x13a4 kernel/workqueue.c:2292
 process_scheduled_works kernel/workqueue.c:2355 [inline]
 worker_thread+0xb64/0xfec kernel/workqueue.c:2444
 kthread+0x250/0x2d8 kernel/kthread.c:376
 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:850