syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
kworker/u4:6/4320 is trying to acquire lock:
ffff888065f4e990 (jbd2_handle){++++}-{0:0}, at: wait_transaction_locked+0x1a6/0x270 fs/jbd2/transaction.c:177

but task is already holding lock:
ffff888028ad90e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a4/0x6f0 fs/ocfs2/journal.c:374

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3a4/0x6f0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe0/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13c8/0x1750 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x756/0xac0 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x2d8/0x5d0 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x1c5/0x490 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x43b5/0x5090 fs/ocfs2/super.c:1139
       mount_bdev+0x287/0x3c0 fs/super.c:1443
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2e3/0x3d0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #4 (sb_internal#5){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x2a5/0x6f0 fs/ocfs2/journal.c:372
       ocfs2_acquire_dquot+0x681/0xb20 fs/ocfs2/quota_global.c:848
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3c3/0xcd0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x144/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8c8/0x25b0 fs/ocfs2/namei.c:310
       ocfs2_mkdir+0x1b6/0x4b0 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4114
       do_mkdirat+0x1d8/0x440 fs/namei.c:4139
       __do_sys_mkdirat fs/namei.c:4154 [inline]
       __se_sys_mkdirat fs/namei.c:4152 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4152
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_create_local_dquot+0x1a5/0x18e0 fs/ocfs2/quota_local.c:1224
       ocfs2_acquire_dquot+0x7c6/0xb20 fs/ocfs2/quota_global.c:871
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3c3/0xcd0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x144/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8c8/0x25b0 fs/ocfs2/namei.c:310
       ocfs2_mkdir+0x1b6/0x4b0 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4114
       do_mkdirat+0x1d8/0x440 fs/namei.c:4139
       __do_sys_mkdirat fs/namei.c:4154 [inline]
       __se_sys_mkdirat fs/namei.c:4152 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4152
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12d/0xaf0 kernel/locking/mutex.c:747
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:507
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6817
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412
       __dquot_alloc_space+0x5fc/0xe60 fs/quota/dquot.c:1752
       dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
       dquot_alloc_space include/linux/quotaops.h:313 [inline]
       dquot_alloc_block include/linux/quotaops.h:337 [inline]
       ext4_mb_new_blocks+0xfc4/0x4610 fs/ext4/mballoc.c:5740
       ext4_ext_map_blocks+0x195b/0x6810 fs/ext4/extents.c:4346
       ext4_map_blocks+0x9de/0x1b70 fs/ext4/inode.c:681
       _ext4_get_block+0x1e7/0x540 fs/ext4/inode.c:824
       ext4_block_write_begin+0x644/0x1300 fs/ext4/inode.c:1126
       ext4_write_begin+0x629/0xf80 fs/ext4/ext4_jbd2.h:-1
       pagecache_write+0x20a/0x380 fs/ext4/verity.c:85
       ext4_write_verity_descriptor fs/ext4/verity.c:185 [inline]
       ext4_end_enable_verity+0x1cb/0x570 fs/ext4/verity.c:210
       enable_verity+0x1a30/0x2040 fs/verity/enable.c:298
       fsverity_ioctl_enable+0x40c/0x4b0 fs/verity/enable.c:392
       __ext4_ioctl fs/ext4/ioctl.c:1583 [inline]
       ext4_ioctl+0x1aab/0x4160 fs/ext4/ioctl.c:1617
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl+0xfa/0x170 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ext4_truncate+0x999/0x1240 fs/ext4/inode.c:4297
       ext4_setattr+0x11f8/0x1b50 fs/ext4/inode.c:5668
       notify_change+0xc74/0xf40 fs/attr.c:499
       do_truncate+0x1ac/0x240 fs/open.c:65
       do_sys_ftruncate+0x312/0x3c0 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (jbd2_handle){++++}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2d07/0x7d10 kernel/locking/lockdep.c:5049
       lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
       wait_transaction_locked+0x1bf/0x270 fs/jbd2/transaction.c:177
       add_transaction_credits fs/jbd2/transaction.c:241 [inline]
       start_this_handle+0x7ec/0x2230 fs/jbd2/transaction.c:422
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3b0/0x6f0 fs/ocfs2/journal.c:376
       ocfs2_release_dquot+0x47c/0xc70 fs/ocfs2/quota_global.c:749
       quota_release_workfn+0x35e/0x610 fs/quota/dquot.c:848
       process_one_work+0x8a2/0x1160 kernel/workqueue.c:2292
       worker_thread+0xaa2/0x1270 kernel/workqueue.c:2439
       kthread+0x29d/0x330 kernel/kthread.c:376
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295

other info that might help us debug this:

Chain exists of:
  jbd2_handle --> sb_internal#5 --> &journal->j_trans_barrier

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&journal->j_trans_barrier);
                               lock(sb_internal#5);
                               lock(&journal->j_trans_barrier);
  lock(jbd2_handle);

 *** DEADLOCK ***

7 locks held by kworker/u4:6/4320:
 #0: ffff888017479138 ((wq_completion)events_unbound){+.+.}-{0:0}, at: process_one_work+0x7b0/0x1160 kernel/workqueue.c:2267
 #1: ffffc90004087d00 ((quota_release_work).work){+.+.}-{0:0}, at: process_one_work+0x7b0/0x1160 kernel/workqueue.c:2267
 #2: ffff888055e0c2a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_release_dquot+0x260/0xc70 fs/ocfs2/quota_global.c:729
 #3: ffff888055d4ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #3: ffff888055d4ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1d7/0x290 fs/ocfs2/quota_global.c:313
 #4: ffff888055d4ea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1fe/0x290 fs/ocfs2/quota_global.c:314
 #5: ffff88807ac70650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_release_dquot+0x47c/0xc70 fs/ocfs2/quota_global.c:749
 #6: ffff888028ad90e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3a4/0x6f0 fs/ocfs2/journal.c:374

stack backtrace:
CPU: 0 PID: 4320 Comm: kworker/u4:6 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/18/2026
Workqueue: events_unbound quota_release_workfn
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x24e lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2d07/0x7d10 kernel/locking/lockdep.c:5049
 lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5662
 wait_transaction_locked+0x1bf/0x270 fs/jbd2/transaction.c:177
 add_transaction_credits fs/jbd2/transaction.c:241 [inline]
 start_this_handle+0x7ec/0x2230 fs/jbd2/transaction.c:422
 jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520
 jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559
 ocfs2_start_trans+0x3b0/0x6f0 fs/ocfs2/journal.c:376
 ocfs2_release_dquot+0x47c/0xc70 fs/ocfs2/quota_global.c:749
 quota_release_workfn+0x35e/0x610 fs/quota/dquot.c:848
 process_one_work+0x8a2/0x1160 kernel/workqueue.c:2292
 worker_thread+0xaa2/0x1270 kernel/workqueue.c:2439
 kthread+0x29d/0x330 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
 </TASK>