syzbot


possible deadlock in hfsplus_block_free

Status: upstream: reported on 2022/12/04 19:32
Subsystems: hfsplus
[Documentation on labels]
Reported-by: syzbot+9a3af69699b90503a205@syzkaller.appspotmail.com
First crash: 564d, last: 473d
Similar bugs (6)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in hfsplus_block_free (2) 4 13d 13d 0/3 upstream: reported on 2024/06/07 11:36
linux-4.14 possible deadlock in hfsplus_block_free hfsplus 10 482d 567d 0/1 upstream: reported on 2022/12/01 19:36
upstream possible deadlock in hfsplus_block_free hfs C inconclusive 239 6d07h 570d 0/27 upstream: reported C repro on 2022/11/29 08:32
linux-5.15 possible deadlock in hfsplus_block_free 20 241d 445d 0/3 auto-obsoleted due to no activity on 2024/01/31 18:41
linux-5.15 possible deadlock in hfsplus_block_free (2) 1 13d 13d 0/3 upstream: reported on 2024/06/07 11:28
linux-6.1 possible deadlock in hfsplus_block_free 27 167d 431d 0/3 auto-obsoleted due to no activity on 2024/04/14 19:02

Sample crash report:
syz-executor.4 (22976) used greatest stack depth: 22128 bytes left
8021q: adding VLAN 0 to HW filter on device batadv1
======================================================
WARNING: possible circular locking dependency detected
4.19.211-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/23087 is trying to acquire lock:
000000002802d5db (&sbi->alloc_mutex){+.+.}, at: hfsplus_block_free+0xdb/0x5d0 fs/hfsplus/bitmap.c:182

but task is already holding lock:
0000000015d1248a (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}:
       hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260
       block_read_full_page+0x288/0xd10 fs/buffer.c:2259
       do_read_cache_page+0x533/0x1170 mm/filemap.c:2828
       read_mapping_page include/linux/pagemap.h:402 [inline]
       hfsplus_block_allocate+0x197/0xa60 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0x436/0xf40 fs/hfsplus/extents.c:468
       hfsplus_get_block+0x196/0x960 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x46c/0x17b0 fs/buffer.c:1978
       __block_write_begin fs/buffer.c:2028 [inline]
       block_write_begin+0x58/0x2e0 fs/buffer.c:2087
       cont_write_begin+0x55a/0x820 fs/buffer.c:2440
       hfsplus_write_begin+0x87/0x150 fs/hfsplus/inode.c:52
       generic_perform_write+0x1f8/0x4d0 mm/filemap.c:3170
       __generic_file_write_iter+0x24b/0x610 mm/filemap.c:3295
       generic_file_write_iter+0x3f8/0x730 mm/filemap.c:3323
       call_write_iter include/linux/fs.h:1821 [inline]
       do_iter_readv_writev+0x668/0x790 fs/read_write.c:681
       do_iter_write+0x182/0x5d0 fs/read_write.c:960
       vfs_writev+0x153/0x2e0 fs/read_write.c:1005
       do_writev+0x136/0x330 fs/read_write.c:1040
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (&sbi->alloc_mutex){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:937 [inline]
       __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
       hfsplus_block_free+0xdb/0x5d0 fs/hfsplus/bitmap.c:182
       hfsplus_free_extents+0x228/0x520 fs/hfsplus/extents.c:363
       hfsplus_file_truncate+0xd96/0x1040 fs/hfsplus/extents.c:591
       hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263
       notify_change+0x70b/0xfc0 fs/attr.c:334
       do_truncate+0x134/0x1f0 fs/open.c:63
       handle_truncate fs/namei.c:3009 [inline]
       do_last fs/namei.c:3427 [inline]
       path_openat+0x2308/0x2df0 fs/namei.c:3537
       do_filp_open+0x18c/0x3f0 fs/namei.c:3567
       do_sys_open+0x3b3/0x520 fs/open.c:1085
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&sbi->alloc_mutex);

 *** DEADLOCK ***

3 locks held by syz-executor.1/23087:
 #0: 00000000baf59b2e (sb_writers#18){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline]
 #0: 00000000baf59b2e (sb_writers#18){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360
 #1: 00000000b7d5846a (&sb->s_type->i_mutex_key#24){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
 #1: 00000000b7d5846a (&sb->s_type->i_mutex_key#24){+.+.}, at: do_truncate+0x125/0x1f0 fs/open.c:61
 #2: 0000000015d1248a (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576

stack backtrace:
CPU: 0 PID: 23087 Comm: syz-executor.1 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
 check_prev_add kernel/locking/lockdep.c:1866 [inline]
 check_prevs_add kernel/locking/lockdep.c:1979 [inline]
 validate_chain kernel/locking/lockdep.c:2420 [inline]
 __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
 __mutex_lock_common kernel/locking/mutex.c:937 [inline]
 __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
 hfsplus_block_free+0xdb/0x5d0 fs/hfsplus/bitmap.c:182
 hfsplus_free_extents+0x228/0x520 fs/hfsplus/extents.c:363
 hfsplus_file_truncate+0xd96/0x1040 fs/hfsplus/extents.c:591
 hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263
 notify_change+0x70b/0xfc0 fs/attr.c:334
 do_truncate+0x134/0x1f0 fs/open.c:63
 handle_truncate fs/namei.c:3009 [inline]
 do_last fs/namei.c:3427 [inline]
 path_openat+0x2308/0x2df0 fs/namei.c:3537
 do_filp_open+0x18c/0x3f0 fs/namei.c:3567
 do_sys_open+0x3b3/0x520 fs/open.c:1085
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f158cbbf0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f158b131168 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00007f158ccdef80 RCX: 00007f158cbbf0f9
RDX: 0000000000000000 RSI: 0000000000143242 RDI: 0000000020000000
RBP: 00007f158cc1aae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd1ab98d5f R14: 00007f158b131300 R15: 0000000000022000
BTRFS info (device loop2): enabling inode map caching
BTRFS warning (device loop2): excessive commit interval 622039222
BTRFS info (device loop2): force zlib compression, level 3
BTRFS info (device loop2): using free space tree
BTRFS info (device loop2): has skinny extents
EXT4-fs (loop4): mounted filesystem without journal. Opts: ,errors=continue
IPVS: ftp: loaded support on port[0] = 21
8021q: adding VLAN 0 to HW filter on device batadv2
EXT4-fs (loop4): Unrecognized mount option "cgroup.controllers" or missing value
BTRFS info (device loop2): enabling inode map caching
BTRFS warning (device loop2): excessive commit interval 622039222
BTRFS info (device loop2): force zlib compression, level 3
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
BTRFS info (device loop2): using free space tree
BTRFS info (device loop2): has skinny extents
BTRFS info (device loop4): enabling inode map caching
BTRFS warning (device loop4): excessive commit interval 622039222
BTRFS info (device loop4): force zlib compression, level 3
BTRFS info (device loop4): using free space tree
BTRFS info (device loop4): has skinny extents
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
BTRFS info (device loop2): enabling inode map caching
BTRFS warning (device loop2): excessive commit interval 622039222
BTRFS info (device loop2): force zlib compression, level 3
BTRFS info (device loop2): using free space tree
BTRFS info (device loop2): has skinny extents
BTRFS warning (device <unknown>): duplicate device /dev/loop4 devid 1 generation 8 scanned by syz-executor.4 (23398)
BTRFS warning (device <unknown>): duplicate device /dev/loop4 devid 1 generation 8 scanned by systemd-udevd (23430)
netlink: 20 bytes leftover after parsing attributes in process `syz-executor.2'.
BTRFS info (device loop4): enabling inode map caching
BTRFS warning (device loop4): excessive commit interval 622039222
netlink: 20 bytes leftover after parsing attributes in process `syz-executor.2'.
BTRFS info (device loop4): force zlib compression, level 3
BTRFS info (device loop4): using free space tree
BTRFS info (device loop4): has skinny extents
netlink: 20 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
netlink: 8 bytes leftover after parsing attributes in process `syz-executor.5'.
kauditd_printk_skb: 6 callbacks suppressed
audit: type=1800 audit(1678059458.492:108): pid=23607 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.1" name="file0" dev="sda1" ino=13886 res=0
audit: type=1804 audit(1678059458.492:109): pid=23607 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.1" name="/root/syzkaller-testdir723381665/syzkaller.T6kj12/618/file0" dev="sda1" ino=13886 res=1
BTRFS info (device loop4): enabling inode map caching
BTRFS warning (device loop4): excessive commit interval 622039222
BTRFS info (device loop4): force zlib compression, level 3
BTRFS info (device loop4): using free space tree
BTRFS info (device loop4): has skinny extents
hub 9-0:1.0: USB hub found
hub 9-0:1.0: 8 ports detected
audit: type=1800 audit(1678059458.742:110): pid=23662 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.1" name="file0" dev="sda1" ino=13898 res=0
audit: type=1804 audit(1678059458.802:111): pid=23662 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.1" name="/root/syzkaller-testdir723381665/syzkaller.T6kj12/619/file0" dev="sda1" ino=13898 res=1
BTRFS info (device loop4): enabling inode map caching
BTRFS warning (device loop4): excessive commit interval 622039222
BTRFS warning (device <unknown>): duplicate device /dev/loop2 devid 1 generation 8 scanned by syz-executor.2 (23685)
hub 9-0:1.0: USB hub found
hub 9-0:1.0: 8 ports detected
BTRFS info (device loop4): force zlib compression, level 3
BTRFS warning (device <unknown>): duplicate device /dev/loop2 devid 1 generation 8 scanned by systemd-udevd (23708)
BTRFS info (device loop4): using free space tree
BTRFS info (device loop4): has skinny extents
audit: type=1800 audit(1678059459.442:112): pid=23748 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.2" name="file0" dev="sda1" ino=13911 res=0
audit: type=1804 audit(1678059459.442:113): pid=23748 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.2" name="/root/syzkaller-testdir1437965687/syzkaller.R4uuHo/663/file0" dev="sda1" ino=13911 res=1
BTRFS info (device loop4): enabling inode map caching
BTRFS warning (device loop4): excessive commit interval 622039222
BTRFS info (device loop4): force zlib compression, level 3
BTRFS info (device loop4): using free space tree
BTRFS info (device loop4): has skinny extents
BTRFS warning (device <unknown>): duplicate device /dev/loop1 devid 1 generation 8 scanned by syz-executor.1 (23779)
BTRFS warning (device <unknown>): duplicate device /dev/loop1 devid 1 generation 8 scanned by systemd-udevd (23804)
hub 9-0:1.0: USB hub found
hub 9-0:1.0: 8 ports detected
dccp_close: ABORT with 103 bytes unread
BTRFS info (device loop4): enabling inode map caching
BTRFS warning (device loop4): excessive commit interval 622039222
BTRFS info (device loop4): force zlib compression, level 3
audit: type=1800 audit(1678059460.762:114): pid=23876 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.2" name="file0" dev="sda1" ino=13889 res=0
BTRFS info (device loop4): using free space tree
BTRFS info (device loop4): has skinny extents
hub 9-0:1.0: USB hub found
hub 9-0:1.0: 8 ports detected
dccp_close: ABORT with 103 bytes unread
audit: type=1804 audit(1678059460.762:115): pid=23876 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.2" name="/root/syzkaller-testdir1437965687/syzkaller.R4uuHo/664/file0" dev="sda1" ino=13889 res=1
audit: type=1800 audit(1678059460.932:116): pid=23959 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.2" name="file0" dev="sda1" ino=13902 res=0
audit: type=1804 audit(1678059460.962:117): pid=23959 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.2" name="/root/syzkaller-testdir1437965687/syzkaller.R4uuHo/665/file0" dev="sda1" ino=13902 res=1
hub 9-0:1.0: USB hub found
hub 9-0:1.0: 8 ports detected
BTRFS info (device loop4): enabling inode map caching
BTRFS warning (device loop4): excessive commit interval 622039222
BTRFS info (device loop4): force zlib compression, level 3
BTRFS info (device loop4): using free space tree
BTRFS info (device loop4): has skinny extents
BTRFS info (device loop4): enabling inode map caching
BTRFS warning (device loop4): excessive commit interval 622039222
BTRFS warning (device <unknown>): duplicate device /dev/loop1 devid 1 generation 8 scanned by syz-executor.1 (24039)
BTRFS info (device loop4): force zlib compression, level 3
BTRFS info (device loop4): using free space tree
BTRFS info (device loop4): has skinny extents
BTRFS warning (device <unknown>): duplicate device /dev/loop1 devid 1 generation 8 scanned by systemd-udevd (24059)
hub 9-0:1.0: USB hub found
hub 9-0:1.0: 8 ports detected
hub 9-0:1.0: USB hub found
hub 9-0:1.0: 8 ports detected
hub 9-0:1.0: USB hub found
hub 9-0:1.0: 8 ports detected
BTRFS info (device loop4): enabling inode map caching
BTRFS warning (device loop4): excessive commit interval 622039222
BTRFS info (device loop4): force zlib compression, level 3
BTRFS info (device loop4): using free space tree
BTRFS info (device loop4): has skinny extents
BTRFS info (device loop1): enabling inode map caching
BTRFS warning (device loop1): excessive commit interval 622039222
BTRFS info (device loop1): force zlib compression, level 3
BTRFS info (device loop1): using free space tree
BTRFS info (device loop1): has skinny extents
BTRFS warning (device <unknown>): duplicate device /dev/loop4 devid 1 generation 8 scanned by syz-executor.4 (24193)
hub 9-0:1.0: USB hub found
BTRFS warning (device <unknown>): duplicate device /dev/loop4 devid 1 generation 8 scanned by systemd-udevd (24247)
hub 9-0:1.0: 8 ports detected
kauditd_printk_skb: 8 callbacks suppressed
audit: type=1800 audit(1678059463.732:126): pid=24279 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.2" name="file0" dev="sda1" ino=13887 res=0
audit: type=1804 audit(1678059463.772:127): pid=24279 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.2" name="/root/syzkaller-testdir1437965687/syzkaller.R4uuHo/669/file0" dev="sda1" ino=13887 res=1

Crashes (20):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/03/05 23:37 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2023/03/04 04:30 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2023/02/25 19:45 linux-4.19.y 3f8a27f9e27b ee50e71c .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/30 03:15 linux-4.19.y 3f8a27f9e27b 44712fbc .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/27 04:06 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/26 23:34 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/26 13:16 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/26 12:44 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/26 10:18 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/26 02:33 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/24 23:15 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/24 21:42 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/24 08:01 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/23 13:21 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/21 23:33 linux-4.19.y 3f8a27f9e27b 4067838e .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/21 20:22 linux-4.19.y 3f8a27f9e27b 4067838e .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/20 19:07 linux-4.19.y 3f8a27f9e27b d3e76707 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/17 19:51 linux-4.19.y 3f8a27f9e27b 05494336 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/17 02:47 linux-4.19.y 3f8a27f9e27b 05494336 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
2022/12/04 19:31 linux-4.19.y 3f8a27f9e27b e080de16 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_block_free
* Struck through repros no longer work on HEAD.