syzbot


possible deadlock in hfsplus_block_free

Status: auto-obsoleted due to no activity on 2024/01/31 18:41
Reported-by: syzbot+cfb543f3d81645f4cf9c@syzkaller.appspotmail.com
First crash: 479d, last: 275d
Similar bugs (6)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in hfsplus_block_free (2) 4 47d 48d 0/3 upstream: reported on 2024/06/07 11:36
linux-4.14 possible deadlock in hfsplus_block_free hfsplus 10 516d 601d 0/1 upstream: reported on 2022/12/01 19:36
linux-4.19 possible deadlock in hfsplus_block_free hfsplus 20 507d 598d 0/1 upstream: reported on 2022/12/04 19:32
upstream possible deadlock in hfsplus_block_free hfs C inconclusive 241 8d02h 604d 0/27 upstream: reported C repro on 2022/11/29 08:32
linux-5.15 possible deadlock in hfsplus_block_free (2) 1 48d 48d 0/3 upstream: reported on 2024/06/07 11:28
linux-6.1 possible deadlock in hfsplus_block_free 27 201d 465d 0/3 auto-obsoleted due to no activity on 2024/04/14 19:02

Sample crash report:
loop4: detected capacity change from 0 to 1024
hfsplus: xattr search failed
======================================================
WARNING: possible circular locking dependency detected
5.15.136-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.4/15473 is trying to acquire lock:
ffff88807b6120f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_free+0xb7/0x4f0 fs/hfsplus/bitmap.c:182

but task is already holding lock:
ffff88801ea9df88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2e1/0xb80 fs/hfsplus/extents.c:576

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260
       block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290
       do_read_cache_page+0x752/0x1040
       read_mapping_page include/linux/pagemap.h:515 [inline]
       hfsplus_block_allocate+0xfa/0x8d0 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
       hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012
       __block_write_begin fs/buffer.c:2062 [inline]
       block_write_begin fs/buffer.c:2122 [inline]
       cont_write_begin+0x5d6/0x840 fs/buffer.c:2471
       hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
       cont_expand_zero fs/buffer.c:2431 [inline]
       cont_write_begin+0x654/0x840 fs/buffer.c:2461
       hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
       generic_cont_expand_simple+0x144/0x230 fs/buffer.c:2362
       hfsplus_setattr+0x169/0x280 fs/hfsplus/inode.c:261
       notify_change+0xc6d/0xf50 fs/attr.c:505
       do_truncate+0x21c/0x300 fs/open.c:65
       do_sys_ftruncate+0x2eb/0x390 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (&sbi->alloc_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfsplus_block_free+0xb7/0x4f0 fs/hfsplus/bitmap.c:182
       hfsplus_free_extents+0x17a/0xae0 fs/hfsplus/extents.c:363
       hfsplus_file_truncate+0x822/0xb80 fs/hfsplus/extents.c:591
       hfsplus_delete_inode+0x170/0x220
       hfsplus_unlink+0x50d/0x7f0 fs/hfsplus/dir.c:405
       vfs_unlink+0x359/0x5f0 fs/namei.c:4209
       do_unlinkat+0x49d/0x940 fs/namei.c:4277
       __do_sys_unlink fs/namei.c:4325 [inline]
       __se_sys_unlink fs/namei.c:4323 [inline]
       __x64_sys_unlink+0x45/0x50 fs/namei.c:4323
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&sbi->alloc_mutex);

 *** DEADLOCK ***

5 locks held by syz-executor.4/15473:
 #0: ffff888078186460 (sb_writers#24){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
 #1: ffff88801ea9dac0 (&type->i_mutex_dir_key#18/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline]
 #1: ffff88801ea9dac0 (&type->i_mutex_dir_key#18/1){+.+.}-{3:3}, at: do_unlinkat+0x260/0x940 fs/namei.c:4260
 #2: ffff88801ea9e180 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff88801ea9e180 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: vfs_unlink+0xe0/0x5f0 fs/namei.c:4198
 #3: ffff88807b612198 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x15d/0x7f0 fs/hfsplus/dir.c:370
 #4: ffff88801ea9df88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2e1/0xb80 fs/hfsplus/extents.c:576

stack backtrace:
CPU: 1 PID: 15473 Comm: syz-executor.4 Not tainted 5.15.136-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 hfsplus_block_free+0xb7/0x4f0 fs/hfsplus/bitmap.c:182
 hfsplus_free_extents+0x17a/0xae0 fs/hfsplus/extents.c:363
 hfsplus_file_truncate+0x822/0xb80 fs/hfsplus/extents.c:591
 hfsplus_delete_inode+0x170/0x220
 hfsplus_unlink+0x50d/0x7f0 fs/hfsplus/dir.c:405
 vfs_unlink+0x359/0x5f0 fs/namei.c:4209
 do_unlinkat+0x49d/0x940 fs/namei.c:4277
 __do_sys_unlink fs/namei.c:4325 [inline]
 __se_sys_unlink fs/namei.c:4323 [inline]
 __x64_sys_unlink+0x45/0x50 fs/namei.c:4323
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7febc9719ae9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007febc7c9b0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000057
RAX: ffffffffffffffda RBX: 00007febc9838f80 RCX: 00007febc9719ae9
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020001280
RBP: 00007febc976547a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007febc9838f80 R15: 00007ffda1b54288
 </TASK>

Crashes (20):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/10/23 14:33 linux-5.15.y 00c03985402e 989a3687 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/09/29 18:23 linux-5.15.y b911329317b4 8e26a358 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/09/27 19:43 linux-5.15.y b911329317b4 2895a507 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/09/12 17:11 linux-5.15.y aff03380bda4 59da8366 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/10/23 18:40 linux-5.15.y 00c03985402e 989a3687 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_free
2023/08/28 10:56 linux-5.15.y 5ddfe5cc8716 7ba13a15 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/08/25 14:47 linux-5.15.y f6f7927ac664 03d9c195 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/07/17 16:19 linux-5.15.y d54cfc420586 20f8b3c2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/07/04 20:12 linux-5.15.y 4af60700a60c f99c2404 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/06/17 10:54 linux-5.15.y 471e639e59d1 f3921d4d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/04/24 21:21 linux-5.15.y 3299fb36854f fdc18293 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/04/21 06:37 linux-5.15.y 3299fb36854f 2b32bd34 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/04/04 17:19 linux-5.15.y c957cbb87315 928dd177 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_free
2023/07/04 20:15 linux-5.15.y 4af60700a60c f99c2404 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_free
2023/07/04 14:28 linux-5.15.y 4af60700a60c f99c2404 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_free
2023/07/03 18:48 linux-5.15.y 4af60700a60c 6e553898 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_free
2023/06/10 11:26 linux-5.15.y 7349e40704a0 49519f06 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_free
2023/04/07 05:52 linux-5.15.y d86dfc4d95cd 00ce4c67 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_free
2023/04/05 20:56 linux-5.15.y d86dfc4d95cd 8b834965 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_free
2023/04/03 09:27 linux-5.15.y c957cbb87315 41147e3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_free
* Struck through repros no longer work on HEAD.