syzbot

 sign-in | mailing list | source | docs
🐞 Open [547] 🐞 Fixed [32] 🐞 Invalid [296] ⬇ Missing Backports [45] 📈 Kernel Health 📈 Bug Lifetimes 📈 Fuzzing 📈 Crashes 💬 Send us feedback

possible deadlock in hfsplus_block_allocate

Status: upstream: reported on 2023/03/24 22:08
Reported-by: syzbot+a8745a7f69ed81d2446b@syzkaller.appspotmail.com
First crash: 398d, last: 38d
▶ ▼ Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in hfsplus_block_allocate 25 22d 392d 0/3 upstream: reported on 2023/03/30 21:16
linux-4.14 possible deadlock in hfsplus_block_allocate hfsplus 2 463d 480d 0/1 upstream: reported on 2023/01/02 02:59
upstream possible deadlock in hfsplus_block_allocate hfs C done 194 2d03h 514d 0/26 upstream: reported C repro on 2022/11/29 13:38
linux-4.19 possible deadlock in hfsplus_block_allocate hfsplus 2 483d 491d 0/1 upstream: reported on 2022/12/22 13:15

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
5.15.148-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/5803 is trying to acquire lock:
ffff888073bb40f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35

but task is already holding lock:
ffff888020e68e88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260
       block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290
       do_read_cache_page+0x752/0x1040
       read_mapping_page include/linux/pagemap.h:515 [inline]
       hfsplus_block_allocate+0xfa/0x8d0 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
       hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012
       __block_write_begin fs/buffer.c:2062 [inline]
       block_write_begin fs/buffer.c:2122 [inline]
       cont_write_begin+0x5d6/0x840 fs/buffer.c:2471
       hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
       __page_symlink+0x15b/0x2a0 fs/namei.c:5163
       hfsplus_symlink+0xc6/0x260 fs/hfsplus/dir.c:449
       vfs_symlink+0x2ad/0x490 fs/namei.c:4435
       do_symlinkat+0x1fd/0x600 fs/namei.c:4464
       __do_sys_symlink fs/namei.c:4486 [inline]
       __se_sys_symlink fs/namei.c:4484 [inline]
       __x64_sys_symlink+0x7a/0x90 fs/namei.c:4484
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (&sbi->alloc_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35
       hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
       hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245
       get_more_blocks fs/direct-io.c:673 [inline]
       do_direct_IO fs/direct-io.c:959 [inline]
       do_blockdev_direct_IO fs/direct-io.c:1276 [inline]
       __blockdev_direct_IO+0x1b13/0x4f40 fs/direct-io.c:1368
       blockdev_direct_IO include/linux/fs.h:3275 [inline]
       hfsplus_direct_IO+0xf6/0x1e0 fs/hfsplus/inode.c:135
       generic_file_direct_write+0x204/0x460 mm/filemap.c:3687
       __generic_file_write_iter+0x2a2/0x4f0 mm/filemap.c:3869
       generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944
       call_write_iter include/linux/fs.h:2146 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0xacf/0xe50 fs/read_write.c:594
       ksys_write+0x1a2/0x2c0 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&sbi->alloc_mutex);

 *** DEADLOCK ***

4 locks held by syz-executor.0/5803:
 #0: ffff888018fff9f0 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2cb/0x380 fs/file.c:1088
 #1: ffff88807ed8a460 (sb_writers#21){.+.+}-{0:0}, at: vfs_write+0x29a/0xe50 fs/read_write.c:590
 #2: ffff888020e69080 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff888020e69080 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: generic_file_write_iter+0x7c/0x1b0 mm/filemap.c:3941
 #3: ffff888020e68e88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457

stack backtrace:
CPU: 0 PID: 5803 Comm: syz-executor.0 Not tainted 5.15.148-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35
 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
 hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245
 get_more_blocks fs/direct-io.c:673 [inline]
 do_direct_IO fs/direct-io.c:959 [inline]
 do_blockdev_direct_IO fs/direct-io.c:1276 [inline]
 __blockdev_direct_IO+0x1b13/0x4f40 fs/direct-io.c:1368
 blockdev_direct_IO include/linux/fs.h:3275 [inline]
 hfsplus_direct_IO+0xf6/0x1e0 fs/hfsplus/inode.c:135
 generic_file_direct_write+0x204/0x460 mm/filemap.c:3687
 __generic_file_write_iter+0x2a2/0x4f0 mm/filemap.c:3869
 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944
 call_write_iter include/linux/fs.h:2146 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0xacf/0xe50 fs/read_write.c:594
 ksys_write+0x1a2/0x2c0 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f6b8a36cda9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f6b888ed0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f6b8a49af80 RCX: 00007f6b8a36cda9
RDX: 000000000003fe00 RSI: 0000000020004200 RDI: 0000000000000004
RBP: 00007f6b8a3b947a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007f6b8a49af80 R15: 00007fff73694a18
 </TASK>

Crashes (18):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/02/22 22:12 linux-5.15.y 6139f2a02fe0 8d446f15 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_allocate
2024/01/23 11:01 linux-5.15.y ddcaf4999061 1c0ecc51 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_allocate
2024/01/14 05:24 linux-5.15.y 26c690eff0a5 551587c1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_allocate
2023/12/31 20:13 linux-5.15.y d93fa2c78854 fb427a07 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_allocate
2023/12/12 15:00 linux-5.15.y 8a1d809b0545 ebcad15c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_allocate
2023/11/23 12:23 linux-5.15.y 2a910f4af54d fc59b78e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_allocate
2023/11/20 23:08 linux-5.15.y 2a910f4af54d cb976f63 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_allocate
2023/09/16 12:15 linux-5.15.y aff03380bda4 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_allocate
2024/03/19 07:35 linux-5.15.y b95c01af2113 baa80228 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_allocate
2023/10/23 14:42 linux-5.15.y 00c03985402e 989a3687 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_allocate
2023/04/24 14:12 linux-5.15.y 3299fb36854f fdc18293 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_allocate
2023/04/04 12:22 linux-5.15.y c957cbb87315 928dd177 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_allocate
2023/03/24 22:07 linux-5.15.y 115472395b0a 9700afae .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hfsplus_block_allocate
2023/08/03 06:56 linux-5.15.y 09996673e313 39a91c18 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_allocate
2023/06/29 16:30 linux-5.15.y 4af60700a60c 134ddc02 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_allocate
2023/06/20 08:16 linux-5.15.y 471e639e59d1 09ffe269 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_allocate
2023/06/14 14:30 linux-5.15.y 471e639e59d1 d2ee9228 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_allocate
2023/04/05 16:59 linux-5.15.y d86dfc4d95cd 8b834965 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in hfsplus_block_allocate
* Struck through repros no longer work on HEAD.