syzbot

WARNING: The mand mount option has been deprecated and
         and is ignored by this kernel. Remove the mand
         option from the mount to silence this warning.
=======================================================
ocfs2: Mounting device (7,0) on (node local, slot 0) with writeback data mode.
======================================================
WARNING: possible circular locking dependency detected
6.1.114-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor142/4240 is trying to acquire lock:
ffff88802fca6650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_setattr+0xd99/0x1f80 fs/ocfs2/file.c:1260

but task is already holding lock:
ffff88806f8acda0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xd87/0x1f80 fs/ocfs2/file.c:1259

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_alloc_sem){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_try_remove_refcount_tree+0xb2/0x330 fs/ocfs2/refcounttree.c:932
       ocfs2_xattr_set+0xa4b/0x1930 fs/ocfs2/xattr.c:3674
       ocfs2_set_acl+0x4cb/0x570 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x252/0x3c0 fs/ocfs2/acl.c:285
       set_posix_acl fs/posix_acl.c:1160 [inline]
       posix_acl_xattr_set+0x37b/0x3e0 fs/posix_acl.c:1189
       __vfs_removexattr+0x3ce/0x410 fs/xattr.c:479
       __vfs_removexattr_locked+0x1fe/0x410 fs/xattr.c:514
       vfs_removexattr+0xff/0x2a0 fs/xattr.c:536
       ovl_do_removexattr fs/overlayfs/overlayfs.h:270 [inline]
       ovl_workdir_create+0x52c/0x9d0 fs/overlayfs/super.c:821
       ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
       ovl_get_workdir+0x3b7/0x17b0 fs/overlayfs/super.c:1539
       ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2095
       mount_nodev+0x52/0xe0 fs/super.c:1489
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3056
       do_mount fs/namespace.c:3399 [inline]
       __do_sys_mount fs/namespace.c:3607 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&oi->ip_xattr_sem){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x398/0x930 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x1f75/0x2e20 fs/ocfs2/namei.c:408
       ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:655
       vfs_mkdir+0x3b6/0x590 fs/namei.c:4106
       do_mkdirat+0x225/0x360 fs/namei.c:4131
       __do_sys_mkdirat fs/namei.c:4146 [inline]
       __se_sys_mkdirat fs/namei.c:4144 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:359
       ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:655
       vfs_mkdir+0x3b6/0x590 fs/namei.c:4106
       do_mkdirat+0x225/0x360 fs/namei.c:4131
       __do_sys_mkdirat fs/namei.c:4146 [inline]
       __se_sys_mkdirat fs/namei.c:4144 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:359
       ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:655
       vfs_mkdir+0x3b6/0x590 fs/namei.c:4106
       do_mkdirat+0x225/0x360 fs/namei.c:4131
       __do_sys_mkdirat fs/namei.c:4146 [inline]
       __se_sys_mkdirat fs/namei.c:4144 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_setattr+0xd99/0x1f80 fs/ocfs2/file.c:1260
       notify_change+0xce3/0xfc0 fs/attr.c:499
       ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline]
       ovl_workdir_create+0x78b/0x9d0 fs/overlayfs/super.c:833
       ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
       ovl_get_workdir+0x3b7/0x17b0 fs/overlayfs/super.c:1539
       ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2095
       mount_nodev+0x52/0xe0 fs/super.c:1489
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3056
       do_mount fs/namespace.c:3399 [inline]
       __do_sys_mount fs/namespace.c:3607 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(&oi->ip_xattr_sem);
                               lock(&oi->ip_alloc_sem);
  lock(sb_internal#2);

 *** DEADLOCK ***

5 locks held by syz-executor142/4240:
 #0: ffff888078eec0e0 (&type->s_umount_key#42/1){+.+.}-{3:3}, at: alloc_super+0x217/0x930 fs/super.c:228
 #1: ffff88802fca6460 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393
 #2: ffff88806f8ac2c8 (&sb->s_type->i_mutex_key#15/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
 #2: ffff88806f8ac2c8 (&sb->s_type->i_mutex_key#15/1){+.+.}-{3:3}, at: ovl_workdir_create+0x159/0x9d0 fs/overlayfs/super.c:771
 #3: ffff88806f8ad108 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #3: ffff88806f8ad108 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: ovl_workdir_create+0x6ec/0x9d0 fs/overlayfs/super.c:832
 #4: ffff88806f8acda0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xd87/0x1f80 fs/ocfs2/file.c:1259

stack backtrace:
CPU: 1 PID: 4240 Comm: syz-executor142 Not tainted 6.1.114-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1891 [inline]
 sb_start_intwrite include/linux/fs.h:2013 [inline]
 ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
 ocfs2_setattr+0xd99/0x1f80 fs/ocfs2/file.c:1260
 notify_change+0xce3/0xfc0 fs/attr.c:499
 ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline]
 ovl_workdir_create+0x78b/0x9d0 fs/overlayfs/super.c:833
 ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
 ovl_get_workdir+0x3b7/0x17b0 fs/overlayfs/super.c:1539
 ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2095
 mount_nodev+0x52/0xe0 fs/super.c:1489
 legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
 vfs_get_tree+0x88/0x270 fs/super.c:1573
 do_new_mount+0x2ba/0xb40 fs/namespace.c:3056
 do_mount fs/namespace.c:3399 [inline]
 __do_sys_mount fs/namespace.c:3607 [inline]
 __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f5a425ecab9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffe5913c68 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0031656c69662f2e RCX: 00007f5a425ecab9
RDX: 0000000020000080 RSI: 00000000200000c0 RDI: 0000000000000000
RBP: 00007f5a42663610 R08: 0000000020000040 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007fffe5913e38 R14: 00000000000000