syzbot

ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc4-syzkaller-00319-g05df91921da6 #0 Not tainted
------------------------------------------------------
syz-executor153/5841 is trying to acquire lock:
ffff888030be0618 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_setattr+0x969/0x1b40 fs/ocfs2/file.c:1263

but task is already holding lock:
ffff8880608d6a20 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x95a/0x1b40 fs/ocfs2/file.c:1262

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_alloc_sem){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       ocfs2_try_remove_refcount_tree+0xb6/0x320 fs/ocfs2/refcounttree.c:932
       ocfs2_xattr_set+0x595/0x11f0 fs/ocfs2/xattr.c:3669
       ocfs2_set_acl+0x701/0x7b0 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x1aa/0x2a0 fs/ocfs2/acl.c:286
       set_posix_acl fs/posix_acl.c:954 [inline]
       vfs_remove_acl+0x48c/0x700 fs/posix_acl.c:1241
       ovl_do_remove_acl fs/overlayfs/overlayfs.h:355 [inline]
       ovl_workdir_create+0x4f3/0x7f0 fs/overlayfs/super.c:353
       ovl_make_workdir fs/overlayfs/super.c:669 [inline]
       ovl_get_workdir+0x32c/0x1730 fs/overlayfs/super.c:827
       ovl_fill_super+0x1386/0x35d0 fs/overlayfs/super.c:1406
       vfs_get_super fs/super.c:1325 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1344
       vfs_get_tree+0x8f/0x2b0 fs/super.c:1804
       do_new_mount+0x24a/0xa40 fs/namespace.c:3902
       do_mount fs/namespace.c:4239 [inline]
       __do_sys_mount fs/namespace.c:4450 [inline]
       __se_sys_mount+0x317/0x410 fs/namespace.c:4427
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1524
       ocfs2_init_acl+0x2f9/0x720 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x1321/0x2050 fs/ocfs2/namei.c:410
       ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:656
       vfs_mkdir+0x303/0x510 fs/namei.c:4375
       do_mkdirat+0x247/0x590 fs/namei.c:4408
       __do_sys_mkdirat fs/namei.c:4425 [inline]
       __se_sys_mkdirat fs/namei.c:4423 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4423
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (jbd2_handle){.+.+}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       start_this_handle+0x1fa7/0x21c0 fs/jbd2/transaction.c:444
       jbd2__journal_start+0x2c1/0x5b0 fs/jbd2/transaction.c:501
       jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:540
       ocfs2_start_trans+0x376/0x6d0 fs/ocfs2/journal.c:374
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0x711/0x4640 fs/ocfs2/suballoc.c:834
       ocfs2_reserve_new_metadata_blocks+0x403/0x940 fs/ocfs2/suballoc.c:984
       ocfs2_mknod+0xe08/0x2050 fs/ocfs2/namei.c:347
       ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:656
       vfs_mkdir+0x303/0x510 fs/namei.c:4375
       do_mkdirat+0x247/0x590 fs/namei.c:4408
       __do_sys_mkdirat fs/namei.c:4425 [inline]
       __se_sys_mkdirat fs/namei.c:4423 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4423
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1524
       ocfs2_start_trans+0x36a/0x6d0 fs/ocfs2/journal.c:372
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0x711/0x4640 fs/ocfs2/suballoc.c:834
       ocfs2_reserve_new_metadata_blocks+0x403/0x940 fs/ocfs2/suballoc.c:984
       ocfs2_mknod+0xe08/0x2050 fs/ocfs2/namei.c:347
       ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:656
       vfs_mkdir+0x303/0x510 fs/namei.c:4375
       do_mkdirat+0x247/0x590 fs/namei.c:4408
       __do_sys_mkdirat fs/namei.c:4425 [inline]
       __se_sys_mkdirat fs/namei.c:4423 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4423
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3168 [inline]
       check_prevs_add kernel/locking/lockdep.c:3287 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911
       __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs.h:1795 [inline]
       sb_start_intwrite include/linux/fs.h:1978 [inline]
       ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:370
       ocfs2_setattr+0x969/0x1b40 fs/ocfs2/file.c:1263
       notify_change+0xb33/0xe40 fs/attr.c:552
       ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline]
       ovl_workdir_create+0x658/0x7f0 fs/overlayfs/super.c:363
       ovl_make_workdir fs/overlayfs/super.c:669 [inline]
       ovl_get_workdir+0x32c/0x1730 fs/overlayfs/super.c:827
       ovl_fill_super+0x1386/0x35d0 fs/overlayfs/super.c:1406
       vfs_get_super fs/super.c:1325 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1344
       vfs_get_tree+0x8f/0x2b0 fs/super.c:1804
       do_new_mount+0x24a/0xa40 fs/namespace.c:3902
       do_mount fs/namespace.c:4239 [inline]
       __do_sys_mount fs/namespace.c:4450 [inline]
       __se_sys_mount+0x317/0x410 fs/namespace.c:4427
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(&oi->ip_xattr_sem);
                               lock(&oi->ip_alloc_sem);
  rlock(sb_internal#2);

 *** DEADLOCK ***

5 locks held by syz-executor153/5841:
 #0: ffff88807bdfc0e0 (&type->s_umount_key#43/1){+.+.}-{4:4}, at: alloc_super+0x204/0x970 fs/super.c:345
 #1: ffff888030be0428 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:557
 #2: ffff8880608d5f40 (&sb->s_type->i_mutex_key#14/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:914 [inline]
 #2: ffff8880608d5f40 (&sb->s_type->i_mutex_key#14/1){+.+.}-{4:4}, at: ovl_workdir_create+0x133/0x7f0 fs/overlayfs/super.c:302
 #3: ffff8880608d6d80 (&sb->s_type->i_mutex_key#16){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
 #3: ffff8880608d6d80 (&sb->s_type->i_mutex_key#16){+.+.}-{4:4}, at: ovl_workdir_create+0x5f7/0x7f0 fs/overlayfs/super.c:362
 #4: ffff8880608d6a20 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x95a/0x1b40 fs/ocfs2/file.c:1262

stack backtrace:
CPU: 0 UID: 0 PID: 5841 Comm: syz-executor153 Not tainted 6.16.0-rc4-syzkaller-00319-g05df91921da6 #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2046
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3168 [inline]
 check_prevs_add kernel/locking/lockdep.c:3287 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911
 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
 percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
 __sb_start_write include/linux/fs.h:1795 [inline]
 sb_start_intwrite include/linux/fs.h:1978 [inline]
 ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:370
 ocfs2_setattr+0x969/0x1b40 fs/ocfs2/file.c:1263
 notify_change+0xb33/0xe40 fs/attr.c:552
 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline]
 ovl_workdir_create+0x658/0x7f0 fs/overlayfs/super.c:363
 ovl_make_workdir fs/overlayfs/super.c:669 [inline]
 ovl_get_workdir+0x32c/0x1730 fs/overlayfs/super.c:827
 ovl_fill_super+0x1386/0x35d0 fs/overlayfs/super.c:1406
 vfs_get_super fs/super.c:1325 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1344
 vfs_get_tree+0x8f/0x2b0 fs/super.c:1804
 do_new_mount+0x24a/0xa40 fs/namespace.c:3902
 do_mount fs/namespace.c:4239 [inline]
 __do_sys_mount fs/namespace.c:4450 [inline]
 __se_sys_mount+0x317/0x410 fs/namespace.c:4427
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fdbe50f9bd9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff5f1e73d8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0031656c69662f2e RCX: 00007fdbe50f9bd9
RDX: 0000200000000080 RSI: 00002000000000c0 RDI: 0000000000000000
RBP: 00007fdbe51715f0 R08: 00002000000002c0 R09: 000055557fb8d4c0
R10: 0000000001000000 R11: 0000000000000246 R12: 00007fff5f1e7400
R13: 00007fff5f1e7628 R14: 431bde82d7b634db R15: 00007fdbe514203b
 </TASK>
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
overlayfs: upper fs missing required features.