syzbot

         option from the mount to silence this warning.
=======================================================
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.12.0-rc7-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor290/5829 is trying to acquire lock:
ffff88807e306610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_setattr+0x9dd/0x1f00 fs/ocfs2/file.c:1263

but task is already holding lock:
ffff8880752c0660 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0x9d0/0x1f00 fs/ocfs2/file.c:1262

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_alloc_sem){+.+.}-{3:3}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
       down_write+0x99/0x220 kernel/locking/rwsem.c:1577
       ocfs2_try_remove_refcount_tree+0xb6/0x330 fs/ocfs2/refcounttree.c:932
       ocfs2_xattr_set+0xa4f/0x1930 fs/ocfs2/xattr.c:3669
       ocfs2_set_acl+0x4cb/0x580 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x24a/0x3c0 fs/ocfs2/acl.c:286
       set_posix_acl fs/posix_acl.c:955 [inline]
       vfs_remove_acl+0x4cb/0x770 fs/posix_acl.c:1242
       ovl_do_remove_acl fs/overlayfs/overlayfs.h:352 [inline]
       ovl_workdir_create+0x52f/0x980 fs/overlayfs/super.c:334
       ovl_make_workdir fs/overlayfs/super.c:650 [inline]
       ovl_get_workdir+0x311/0x1920 fs/overlayfs/super.c:808
       ovl_fill_super+0x12a8/0x3560 fs/overlayfs/super.c:1376
       vfs_get_super fs/super.c:1280 [inline]
       get_tree_nodev+0xb7/0x140 fs/super.c:1299
       vfs_get_tree+0x90/0x2b0 fs/super.c:1814
       do_new_mount+0x2be/0xb40 fs/namespace.c:3507
       do_mount fs/namespace.c:3847 [inline]
       __do_sys_mount fs/namespace.c:4057 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4034
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&oi->ip_xattr_sem){++++}-{3:3}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
       down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524
       ocfs2_init_acl+0x397/0x930 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x1c05/0x2b40 fs/ocfs2/namei.c:408
       ocfs2_mkdir+0x1ab/0x480 fs/ocfs2/namei.c:655
       vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4257
       do_mkdirat+0x264/0x3a0 fs/namei.c:4280
       __do_sys_mkdirat fs/namei.c:4295 [inline]
       __se_sys_mkdirat fs/namei.c:4293 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4293
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (jbd2_handle){.+.+}-{0:0}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
       start_this_handle+0x1eb4/0x2110 fs/jbd2/transaction.c:448
       jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:505
       jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:544
       ocfs2_start_trans+0x3c9/0x700 fs/ocfs2/journal.c:352
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0x9f6/0x4eb0 fs/ocfs2/suballoc.c:832
       ocfs2_reserve_new_metadata_blocks+0x41c/0x9c0 fs/ocfs2/suballoc.c:982
       ocfs2_mknod+0x143a/0x2b40 fs/ocfs2/namei.c:345
       ocfs2_mkdir+0x1ab/0x480 fs/ocfs2/namei.c:655
       vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4257
       do_mkdirat+0x264/0x3a0 fs/namei.c:4280
       __do_sys_mkdirat fs/namei.c:4295 [inline]
       __se_sys_mkdirat fs/namei.c:4293 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4293
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
       down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524
       ocfs2_start_trans+0x3be/0x700 fs/ocfs2/journal.c:350
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0x9f6/0x4eb0 fs/ocfs2/suballoc.c:832
       ocfs2_reserve_new_metadata_blocks+0x41c/0x9c0 fs/ocfs2/suballoc.c:982
       ocfs2_mknod+0x143a/0x2b40 fs/ocfs2/namei.c:345
       ocfs2_mkdir+0x1ab/0x480 fs/ocfs2/namei.c:655
       vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4257
       do_mkdirat+0x264/0x3a0 fs/namei.c:4280
       __do_sys_mkdirat fs/namei.c:4295 [inline]
       __se_sys_mkdirat fs/namei.c:4293 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4293
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
       __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1716 [inline]
       sb_start_intwrite include/linux/fs.h:1899 [inline]
       ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348
       ocfs2_setattr+0x9dd/0x1f00 fs/ocfs2/file.c:1263
       notify_change+0xbca/0xe90 fs/attr.c:503
       ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline]
       ovl_workdir_create+0x782/0x980 fs/overlayfs/super.c:344
       ovl_make_workdir fs/overlayfs/super.c:650 [inline]
       ovl_get_workdir+0x311/0x1920 fs/overlayfs/super.c:808
       ovl_fill_super+0x12a8/0x3560 fs/overlayfs/super.c:1376
       vfs_get_super fs/super.c:1280 [inline]
       get_tree_nodev+0xb7/0x140 fs/super.c:1299
       vfs_get_tree+0x90/0x2b0 fs/super.c:1814
       do_new_mount+0x2be/0xb40 fs/namespace.c:3507
       do_mount fs/namespace.c:3847 [inline]
       __do_sys_mount fs/namespace.c:4057 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4034
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(&oi->ip_xattr_sem);
                               lock(&oi->ip_alloc_sem);
  rlock(sb_internal#2);

 *** DEADLOCK ***

5 locks held by syz-executor290/5829:
 #0: ffff88807804c0e0 (&type->s_umount_key#44/1){+.+.}-{3:3}, at: alloc_super+0x221/0x9d0 fs/super.c:344
 #1: ffff88807e306420 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:515
 #2: ffff8880752b5f40 (&sb->s_type->i_mutex_key#14/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:850 [inline]
 #2: ffff8880752b5f40 (&sb->s_type->i_mutex_key#14/1){+.+.}-{3:3}, at: ovl_workdir_create+0x160/0x980 fs/overlayfs/super.c:284
 #3: ffff8880752c09c0 (&sb->s_type->i_mutex_key#16){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:815 [inline]
 #3: ffff8880752c09c0 (&sb->s_type->i_mutex_key#16){+.+.}-{3:3}, at: ovl_workdir_create+0x6e3/0x980 fs/overlayfs/super.c:343
 #4: ffff8880752c0660 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0x9d0/0x1f00 fs/ocfs2/file.c:1262

stack backtrace:
CPU: 0 UID: 0 PID: 5829 Comm: syz-executor290 Not tainted 6.12.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074
 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1716 [inline]
 sb_start_intwrite include/linux/fs.h:1899 [inline]
 ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348
 ocfs2_setattr+0x9dd/0x1f00 fs/ocfs2/file.c:1263
 notify_change+0xbca/0xe90 fs/attr.c:503
 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline]
 ovl_workdir_create+0x782/0x980 fs/overlayfs/super.c:344
 ovl_make_workdir fs/overlayfs/super.c:650 [inline]
 ovl_get_workdir+0x311/0x1920 fs/overlayfs/super.c:808
 ovl_fill_super+0x12a8/0x3560 fs/overlayfs/super.c:1376
 vfs_get_super fs/super.c:1280 [inline]
 get_tree_nodev+0xb7/0x140 fs/super.c:1299
 vfs_get_tree+0x90/0x2b0 fs/super.c:1814
 do_new_mount+0x2be/0xb40 fs/namespace.c:3507
 do_mount fs/namespace.c:3847 [inline]
 __do_sys_mount fs/namespace.c:4057 [inline]
 __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4034
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f9565fc47f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd24d2eef8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffd24d2ef00 RCX: 00007f9565fc47f9
RDX: 0000000020000000 RSI: 0000000020000040 RDI: 0000000000000000
RBP: 00007ffd24d2ef08 R08: 0000000020000140 R09: 00007f9565f90520
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd24d2f168 R14: 0000000000000001 R15: 0000000000000001
 </TASK>
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WH