syzbot

ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc5-syzkaller-00204-g0e1329d4045c #0 Not tainted
------------------------------------------------------
syz-executor370/5822 is trying to acquire lock:
ffff8880119ae610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_setattr+0x969/0x1b40 fs/ocfs2/file.c:1263

but task is already holding lock:
ffff888074063120 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x95a/0x1b40 fs/ocfs2/file.c:1262

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_alloc_sem){+.+.}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       ocfs2_try_remove_refcount_tree+0xb6/0x320 fs/ocfs2/refcounttree.c:932
       ocfs2_xattr_set+0x595/0x11f0 fs/ocfs2/xattr.c:3669
       ocfs2_set_acl+0x701/0x7b0 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x1aa/0x2a0 fs/ocfs2/acl.c:286
       set_posix_acl fs/posix_acl.c:954 [inline]
       vfs_remove_acl+0x489/0x700 fs/posix_acl.c:1241
       ovl_do_remove_acl fs/overlayfs/overlayfs.h:353 [inline]
       ovl_workdir_create+0x508/0x810 fs/overlayfs/super.c:353
       ovl_make_workdir fs/overlayfs/super.c:669 [inline]
       ovl_get_workdir+0x324/0x1700 fs/overlayfs/super.c:827
       ovl_fill_super+0x1386/0x35d0 fs/overlayfs/super.c:1406
       vfs_get_super fs/super.c:1280 [inline]
       get_tree_nodev+0xb8/0x150 fs/super.c:1299
       vfs_get_tree+0x8f/0x2b0 fs/super.c:1759
       do_new_mount+0x24a/0xa40 fs/namespace.c:3884
       do_mount fs/namespace.c:4224 [inline]
       __do_sys_mount fs/namespace.c:4435 [inline]
       __se_sys_mount+0x317/0x410 fs/namespace.c:4412
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1524
       ocfs2_init_acl+0x2f9/0x720 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x1321/0x2050 fs/ocfs2/namei.c:410
       ocfs2_mkdir+0x191/0x440 fs/ocfs2/namei.c:656
       vfs_mkdir+0x303/0x510 fs/namei.c:4359
       do_mkdirat+0x247/0x590 fs/namei.c:4392
       __do_sys_mkdirat fs/namei.c:4409 [inline]
       __se_sys_mkdirat fs/namei.c:4407 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4407
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (jbd2_handle){.+.+}-{0:0}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       start_this_handle+0x1fa7/0x21c0 fs/jbd2/transaction.c:444
       jbd2__journal_start+0x2c1/0x5b0 fs/jbd2/transaction.c:501
       jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:540
       ocfs2_start_trans+0x376/0x6d0 fs/ocfs2/journal.c:352
       ocfs2_modify_bh+0xe8/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1465/0x17e0 fs/ocfs2/quota_local.c:771
       dquot_load_quota_sb+0x78e/0xbd0 fs/quota/dquot.c:2459
       dquot_load_quota_inode+0x2e1/0x5d0 fs/quota/dquot.c:2496
       ocfs2_enable_quotas+0x1c6/0x450 fs/ocfs2/super.c:930
       ocfs2_fill_super+0x5115/0x63d0 fs/ocfs2/super.c:1140
       get_tree_bdev_flags+0x40b/0x4d0 fs/super.c:1636
       vfs_get_tree+0x8f/0x2b0 fs/super.c:1759
       do_new_mount+0x24a/0xa40 fs/namespace.c:3884
       do_mount fs/namespace.c:4224 [inline]
       __do_sys_mount fs/namespace.c:4435 [inline]
       __se_sys_mount+0x317/0x410 fs/namespace.c:4412
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1524
       ocfs2_start_trans+0x36a/0x6d0 fs/ocfs2/journal.c:350
       ocfs2_modify_bh+0xe8/0x470 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1465/0x17e0 fs/ocfs2/quota_local.c:771
       dquot_load_quota_sb+0x78e/0xbd0 fs/quota/dquot.c:2459
       dquot_load_quota_inode+0x2e1/0x5d0 fs/quota/dquot.c:2496
       ocfs2_enable_quotas+0x1c6/0x450 fs/ocfs2/super.c:930
       ocfs2_fill_super+0x5115/0x63d0 fs/ocfs2/super.c:1140
       get_tree_bdev_flags+0x40b/0x4d0 fs/super.c:1636
       vfs_get_tree+0x8f/0x2b0 fs/super.c:1759
       do_new_mount+0x24a/0xa40 fs/namespace.c:3884
       do_mount fs/namespace.c:4224 [inline]
       __do_sys_mount fs/namespace.c:4435 [inline]
       __se_sys_mount+0x317/0x410 fs/namespace.c:4412
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
       __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
       percpu_down_read include/linux/percpu-rwsem.h:52 [inline]
       __sb_start_write include/linux/fs.h:1783 [inline]
       sb_start_intwrite include/linux/fs.h:1966 [inline]
       ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:348
       ocfs2_setattr+0x969/0x1b40 fs/ocfs2/file.c:1263
       notify_change+0xb33/0xe40 fs/attr.c:552
       ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline]
       ovl_workdir_create+0x68b/0x810 fs/overlayfs/super.c:363
       ovl_make_workdir fs/overlayfs/super.c:669 [inline]
       ovl_get_workdir+0x324/0x1700 fs/overlayfs/super.c:827
       ovl_fill_super+0x1386/0x35d0 fs/overlayfs/super.c:1406
       vfs_get_super fs/super.c:1280 [inline]
       get_tree_nodev+0xb8/0x150 fs/super.c:1299
       vfs_get_tree+0x8f/0x2b0 fs/super.c:1759
       do_new_mount+0x24a/0xa40 fs/namespace.c:3884
       do_mount fs/namespace.c:4224 [inline]
       __do_sys_mount fs/namespace.c:4435 [inline]
       __se_sys_mount+0x317/0x410 fs/namespace.c:4412
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(&oi->ip_xattr_sem);
                               lock(&oi->ip_alloc_sem);
  rlock(sb_internal#2);

 *** DEADLOCK ***

5 locks held by syz-executor370/5822:
 #0: ffff8880330f00e0 (&type->s_umount_key#43/1){+.+.}-{4:4}, at: alloc_super+0x204/0x970 fs/super.c:344
 #1: ffff8880119ae420 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:556
 #2: ffff888074062640 (&sb->s_type->i_mutex_key#14/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:902 [inline]
 #2: ffff888074062640 (&sb->s_type->i_mutex_key#14/1){+.+.}-{4:4}, at: ovl_workdir_create+0x143/0x810 fs/overlayfs/super.c:302
 #3: ffff888074063480 (&sb->s_type->i_mutex_key#16){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #3: ffff888074063480 (&sb->s_type->i_mutex_key#16){+.+.}-{4:4}, at: ovl_workdir_create+0x610/0x810 fs/overlayfs/super.c:362
 #4: ffff888074063120 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x95a/0x1b40 fs/ocfs2/file.c:1262

stack backtrace:
CPU: 0 UID: 0 PID: 5822 Comm: syz-executor370 Not tainted 6.15.0-rc5-syzkaller-00204-g0e1329d4045c #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2079
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3909
 __lock_acquire+0xaac/0xd20 kernel/locking/lockdep.c:5235
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5866
 percpu_down_read include/linux/percpu-rwsem.h:52 [inline]
 __sb_start_write include/linux/fs.h:1783 [inline]
 sb_start_intwrite include/linux/fs.h:1966 [inline]
 ocfs2_start_trans+0x26b/0x6d0 fs/ocfs2/journal.c:348
 ocfs2_setattr+0x969/0x1b40 fs/ocfs2/file.c:1263
 notify_change+0xb33/0xe40 fs/attr.c:552
 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline]
 ovl_workdir_create+0x68b/0x810 fs/overlayfs/super.c:363
 ovl_make_workdir fs/overlayfs/super.c:669 [inline]
 ovl_get_workdir+0x324/0x1700 fs/overlayfs/super.c:827
 ovl_fill_super+0x1386/0x35d0 fs/overlayfs/super.c:1406
 vfs_get_super fs/super.c:1280 [inline]
 get_tree_nodev+0xb8/0x150 fs/super.c:1299
 vfs_get_tree+0x8f/0x2b0 fs/super.c:1759
 do_new_mount+0x24a/0xa40 fs/namespace.c:3884
 do_mount fs/namespace.c:4224 [inline]
 __do_sys_mount fs/namespace.c:4435 [inline]
 __se_sys_mount+0x317/0x410 fs/namespace.c:4412
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xf6/0x210 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f317c1f57b9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd8b910a28 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0000200000000340 RCX: 00007f317c1f57b9
RDX: 0000200000000080 RSI: 00002000000000c0 RDI: 0000000000000000
RBP: 0030656c69662f2e R08: 0000200000000340 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffd8b910c08 R14: 0000000000000001 R15: 0000000000000001
 </TASK>
overlayfs: upper fs does not support tmpfile.
overlay