syzbot

(syz.0.17,6018,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/6018 is trying to acquire lock:
ffff888038c48770 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_setattr+0xcc6/0x1cc0 fs/ocfs2/file.c:1270

but task is already holding lock:
ffff88805ce41890 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0xcb7/0x1cc0 fs/ocfs2/file.c:1269

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_alloc_sem){+.+.}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       ocfs2_try_remove_refcount_tree+0xb6/0x340 fs/ocfs2/refcounttree.c:933
       ocfs2_xattr_set+0x61a/0x13e0 fs/ocfs2/xattr.c:3700
       ocfs2_set_acl+0x701/0x7b0 fs/ocfs2/acl.c:255
       ocfs2_iop_set_acl+0x1b1/0x2b0 fs/ocfs2/acl.c:287
       set_posix_acl fs/posix_acl.c:955 [inline]
       vfs_remove_acl+0x54e/0x840 fs/posix_acl.c:1242
       ovl_do_remove_acl fs/overlayfs/overlayfs.h:355 [inline]
       ovl_workdir_create+0x5b3/0x940 fs/overlayfs/super.c:369
       ovl_make_workdir fs/overlayfs/super.c:682 [inline]
       ovl_get_workdir fs/overlayfs/super.c:840 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1453 [inline]
       ovl_fill_super+0x1a3f/0x5e00 fs/overlayfs/super.c:1564
       vfs_get_super fs/super.c:1327 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1346
       vfs_get_tree+0x92/0x2a0 fs/super.c:1754
       fc_mount fs/namespace.c:1193 [inline]
       do_new_mount_fc fs/namespace.c:3763 [inline]
       do_new_mount+0x341/0xd30 fs/namespace.c:3839
       do_mount fs/namespace.c:4172 [inline]
       __do_sys_mount fs/namespace.c:4361 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4338
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1537
       ocfs2_init_acl+0x1c3/0x800 fs/ocfs2/acl.c:367
       ocfs2_mknod+0x1679/0x2290 fs/ocfs2/namei.c:414
       ocfs2_mkdir+0x181/0x490 fs/ocfs2/namei.c:660
       vfs_mkdir+0x40b/0x630 fs/namei.c:5233
       filename_mkdirat+0x289/0x520 fs/namei.c:5266
       __do_sys_mkdirat fs/namei.c:5287 [inline]
       __se_sys_mkdirat+0x35/0x150 fs/namei.c:5284
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x97/0x200 kernel/locking/rwsem.c:1537
       ocfs2_start_trans+0x3ac/0x700 fs/ocfs2/journal.c:369
       ocfs2_modify_bh+0xe3/0x4d0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1454/0x1810 fs/ocfs2/quota_local.c:767
       dquot_load_quota_sb+0x791/0xbd0 fs/quota/dquot.c:2462
       dquot_load_quota_inode+0x2e1/0x5d0 fs/quota/dquot.c:2499
       ocfs2_enable_quotas+0x1c8/0x4a0 fs/ocfs2/super.c:930
       ocfs2_fill_super+0x53b7/0x69a0 fs/ocfs2/super.c:1140
       get_tree_bdev_flags+0x431/0x4f0 fs/super.c:1694
       vfs_get_tree+0x92/0x2a0 fs/super.c:1754
       fc_mount fs/namespace.c:1193 [inline]
       do_new_mount_fc fs/namespace.c:3763 [inline]
       do_new_mount+0x341/0xd30 fs/namespace.c:3839
       do_mount fs/namespace.c:4172 [inline]
       __do_sys_mount fs/namespace.c:4361 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4338
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:367
       ocfs2_setattr+0xcc6/0x1cc0 fs/ocfs2/file.c:1270
       notify_change+0xc18/0xf60 fs/attr.c:556
       ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline]
       ovl_workdir_create+0x716/0x940 fs/overlayfs/super.c:379
       ovl_make_workdir fs/overlayfs/super.c:682 [inline]
       ovl_get_workdir fs/overlayfs/super.c:840 [inline]
       ovl_fill_super_creds fs/overlayfs/super.c:1453 [inline]
       ovl_fill_super+0x1a3f/0x5e00 fs/overlayfs/super.c:1564
       vfs_get_super fs/super.c:1327 [inline]
       get_tree_nodev+0xbb/0x150 fs/super.c:1346
       vfs_get_tree+0x92/0x2a0 fs/super.c:1754
       fc_mount fs/namespace.c:1193 [inline]
       do_new_mount_fc fs/namespace.c:3763 [inline]
       do_new_mount+0x341/0xd30 fs/namespace.c:3839
       do_mount fs/namespace.c:4172 [inline]
       __do_sys_mount fs/namespace.c:4361 [inline]
       __se_sys_mount+0x31d/0x420 fs/namespace.c:4338
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(&oi->ip_xattr_sem);
                               lock(&oi->ip_alloc_sem);
  rlock(sb_internal#2);

 *** DEADLOCK ***

4 locks held by syz.0.17/6018:
 #0: ffff888038b6c0d0 (&type->s_umount_key#56/1){+.+.}-{4:4}, at: alloc_super+0x28c/0xac0 fs/super.c:345
 #1: ffff888038c48480 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:493
 #2: ffff88805ce41c40 (&sb->s_type->i_mutex_key#26){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1028 [inline]
 #2: ffff88805ce41c40 (&sb->s_type->i_mutex_key#26){+.+.}-{4:4}, at: ovl_workdir_create+0x6b7/0x940 fs/overlayfs/super.c:378
 #3: ffff88805ce41890 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0xcb7/0x1cc0 fs/ocfs2/file.c:1269

stack backtrace:
CPU: 0 UID: 0 PID: 6018 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
 percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
 __sb_start_write include/linux/fs/super.h:19 [inline]
 sb_start_intwrite include/linux/fs/super.h:177 [inline]
 ocfs2_start_trans+0x2ac/0x700 fs/ocfs2/journal.c:367
 ocfs2_setattr+0xcc6/0x1cc0 fs/ocfs2/file.c:1270
 notify_change+0xc18/0xf60 fs/attr.c:556
 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline]
 ovl_workdir_create+0x716/0x940 fs/overlayfs/super.c:379
 ovl_make_workdir fs/overlayfs/super.c:682 [inline]
 ovl_get_workdir fs/overlayfs/super.c:840 [inline]
 ovl_fill_super_creds fs/overlayfs/super.c:1453 [inline]
 ovl_fill_super+0x1a3f/0x5e00 fs/overlayfs/super.c:1564
 vfs_get_super fs/super.c:1327 [inline]
 get_tree_nodev+0xbb/0x150 fs/super.c:1346
 vfs_get_tree+0x92/0x2a0 fs/super.c:1754
 fc_mount fs/namespace.c:1193 [inline]
 do_new_mount_fc fs/namespace.c:3763 [inline]
 do_new_mount+0x341/0xd30 fs/namespace.c:3839
 do_mount fs/namespace.c:4172 [inline]
 __do_sys_mount fs/namespace.c:4361 [inline]
 __se_sys_mount+0x31d/0x420 fs/namespace.c:4338
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f66d192c799
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffcd0a4ed38 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f66d1ba5fa0 RCX: 00007f66d192c799
RDX: 0000200000000440 RSI: 0000200000000100 RDI: 0000000000000000
RBP: 00007f66d19c2bd9 R08: 0000200000000300 R09: 0000000000000000
R10: 0000000000000008 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f66d1ba5fac R14: 00007f66d1ba5fa0 R15: 00007f66d1ba5fa0
 </TASK>
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
overlayfs: upper fs missing required features.