syzbot


possible deadlock in trie_delete_elem

Status: upstream: reported C repro on 2024/03/19 12:09
Bug presence: origin:upstream
[Documentation on labels]
Reported-by: syzbot+c361763297bd80b2cc11@syzkaller.appspotmail.com
First crash: 49d, last: 33m
Bug presence (1)
Date Name Commit Repro Result
2024/05/03 upstream (ToT) 3d25a941ea50 C [report] possible deadlock in trie_delete_elem
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in trie_delete_elem bpf C done 15115 now 48d 0/26 upstream: reported C repro on 2024/03/20 08:42
linux-6.1 possible deadlock in trie_delete_elem origin:upstream C 1653 3h13m 48d 0/3 upstream: reported C repro on 2024/03/20 00:33

Sample crash report:
============================================
WARNING: possible recursive locking detected
5.15.156-syzkaller #0 Not tainted
--------------------------------------------
syz-executor238/3507 is trying to acquire lock:
ffff888019f50db8 (&trie->lock){....}-{2:2}, at: trie_delete_elem+0x90/0x690 kernel/bpf/lpm_trie.c:450

but task is already holding lock:
ffff8880770829b8 (&trie->lock){....}-{2:2}, at: trie_update_elem+0xc5/0xc00 kernel/bpf/lpm_trie.c:323

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&trie->lock);
  lock(&trie->lock);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

3 locks held by syz-executor238/3507:
 #0: ffffffff8c91fb20 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:311
 #1: ffff8880770829b8 (&trie->lock){....}-{2:2}, at: trie_update_elem+0xc5/0xc00 kernel/bpf/lpm_trie.c:323
 #2: ffffffff8c91fb20 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:311

stack backtrace:
CPU: 1 PID: 3507 Comm: syz-executor238 Not tainted 5.15.156-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 print_deadlock_bug kernel/locking/lockdep.c:2946 [inline]
 check_deadlock kernel/locking/lockdep.c:2989 [inline]
 validate_chain+0x46d2/0x5930 kernel/locking/lockdep.c:3775
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
 _raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
 trie_delete_elem+0x90/0x690 kernel/bpf/lpm_trie.c:450
 bpf_prog_1db1603a7cfa36fb+0x3d/0x358
 bpf_dispatcher_nop_func include/linux/bpf.h:785 [inline]
 __bpf_prog_run include/linux/filter.h:628 [inline]
 bpf_prog_run include/linux/filter.h:635 [inline]
 __bpf_trace_run kernel/trace/bpf_trace.c:1880 [inline]
 bpf_trace_run4+0x1ea/0x390 kernel/trace/bpf_trace.c:1919
 __bpf_trace_mm_page_alloc+0xba/0xe0 include/trace/events/kmem.h:201
 trace_mm_page_alloc include/trace/events/kmem.h:201 [inline]
 __alloc_pages+0x6e0/0x700 mm/page_alloc.c:5445
 __alloc_pages_node include/linux/gfp.h:570 [inline]
 alloc_pages_node include/linux/gfp.h:584 [inline]
 kmalloc_large_node+0x7c/0x180 mm/slub.c:4421
 __kmalloc_node+0x22d/0x390 mm/slub.c:4437
 kmalloc_node include/linux/slab.h:614 [inline]
 bpf_map_kmalloc_node+0xdb/0x160 kernel/bpf/syscall.c:430
 lpm_trie_node_alloc kernel/bpf/lpm_trie.c:290 [inline]
 trie_update_elem+0x1cb/0xc00 kernel/bpf/lpm_trie.c:332
 bpf_map_update_value+0x5d7/0x6c0 kernel/bpf/syscall.c:221
 map_update_elem+0x6a0/0x7c0 kernel/bpf/syscall.c:1185
 __sys_bpf+0x2fd/0x670 kernel/bpf/syscall.c:4639
 __do_sys_bpf kernel/bpf/syscall.c:4755 [inline]
 __se_sys_bpf kernel/bpf/syscall.c:4753 [inline]
 __x64_sys_bpf+0x78/0x90 kernel/bpf/syscall.c:4753
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fa1b590afa9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 c1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe0c8bcee8 EFLAGS: 00000246 ORIG_RAX: 0000000000000141
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fa1b590afa9
RDX: 0000000000000020 RSI: 0000000020000080 RDI: 0000000000000002
RBP: 0000000000000000 R08: 00000000000000a0 R09: 00000000000000a0
R10: 00000000000000a0 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
 </TASK>

Crashes (1426):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/04/26 08:21 linux-5.15.y c52b9710c83d 8bdc0f22 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/04/26 04:09 linux-5.15.y c52b9710c83d 8bdc0f22 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/04/24 10:55 linux-5.15.y c52b9710c83d 21339d7b .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/04/18 16:16 linux-5.15.y c52b9710c83d af24b050 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/04/06 06:50 linux-5.15.y 9465fef4ae35 ca620dd8 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/04/05 16:14 linux-5.15.y 9465fef4ae35 77230c29 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/04/05 11:36 linux-5.15.y 9465fef4ae35 0ee3535e .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/04/01 16:34 linux-5.15.y 9465fef4ae35 6baf5069 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/04/01 14:38 linux-5.15.y 9465fef4ae35 6baf5069 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/03/30 04:20 linux-5.15.y 9465fef4ae35 6baf5069 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/03/28 20:14 linux-5.15.y 9465fef4ae35 e91187ee .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/03/25 22:24 linux-5.15.y b95c01af2113 0ea90952 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/03/23 23:24 linux-5.15.y b95c01af2113 0ea90952 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/03/20 04:58 linux-5.15.y b95c01af2113 a485f239 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/03/20 04:22 linux-5.15.y b95c01af2113 a485f239 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/03/20 03:52 linux-5.15.y b95c01af2113 a485f239 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/03/20 02:06 linux-5.15.y b95c01af2113 e104824c .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/03/20 01:35 linux-5.15.y b95c01af2113 e104824c .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/03/20 01:06 linux-5.15.y b95c01af2113 e104824c .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/07 11:19 linux-5.15.y 284087d4f7d5 fa7a5cf0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/07 04:08 linux-5.15.y 284087d4f7d5 fa7a5cf0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/07 04:05 linux-5.15.y 284087d4f7d5 fa7a5cf0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/07 02:50 linux-5.15.y 284087d4f7d5 fa7a5cf0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/06 23:52 linux-5.15.y 284087d4f7d5 fa7a5cf0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/06 22:26 linux-5.15.y 284087d4f7d5 fa7a5cf0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/06 19:40 linux-5.15.y 284087d4f7d5 d884b519 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/06 18:07 linux-5.15.y 284087d4f7d5 d884b519 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/06 16:08 linux-5.15.y 284087d4f7d5 d884b519 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/06 09:44 linux-5.15.y 284087d4f7d5 d884b519 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/05 20:46 linux-5.15.y 284087d4f7d5 610f2a54 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/05 12:59 linux-5.15.y 284087d4f7d5 610f2a54 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/05 02:43 linux-5.15.y 284087d4f7d5 610f2a54 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/05 00:58 linux-5.15.y 284087d4f7d5 610f2a54 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/04 16:13 linux-5.15.y 284087d4f7d5 610f2a54 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/04 11:47 linux-5.15.y 284087d4f7d5 610f2a54 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/04 10:07 linux-5.15.y 284087d4f7d5 610f2a54 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/04 05:46 linux-5.15.y 284087d4f7d5 610f2a54 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/04 02:19 linux-5.15.y 284087d4f7d5 610f2a54 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/04 01:00 linux-5.15.y 284087d4f7d5 610f2a54 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/03 23:58 linux-5.15.y 284087d4f7d5 dd26401e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/03 23:54 linux-5.15.y 284087d4f7d5 dd26401e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/03 22:53 linux-5.15.y 284087d4f7d5 dd26401e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/03 21:07 linux-5.15.y 284087d4f7d5 dd26401e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/03 17:43 linux-5.15.y 284087d4f7d5 dd26401e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/03 16:37 linux-5.15.y 284087d4f7d5 dd26401e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/03 13:44 linux-5.15.y 284087d4f7d5 dd26401e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/03 12:09 linux-5.15.y 284087d4f7d5 dd26401e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/03 10:57 linux-5.15.y 284087d4f7d5 dd26401e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/03 09:20 linux-5.15.y 284087d4f7d5 dd26401e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/03 07:39 linux-5.15.y 284087d4f7d5 ddfc15a1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/03 05:01 linux-5.15.y 284087d4f7d5 ddfc15a1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/03 00:41 linux-5.15.y 284087d4f7d5 ddfc15a1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/02 22:35 linux-5.15.y 284087d4f7d5 ddfc15a1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/02 21:32 linux-5.15.y 284087d4f7d5 ddfc15a1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/02 19:19 linux-5.15.y 284087d4f7d5 3ba885bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/02 18:13 linux-5.15.y 284087d4f7d5 3ba885bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/02 16:50 linux-5.15.y 284087d4f7d5 3ba885bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/02 16:20 linux-5.15.y 284087d4f7d5 3ba885bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/02 15:18 linux-5.15.y b925f60c6ee7 3ba885bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/02 14:06 linux-5.15.y b925f60c6ee7 3ba885bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/02 03:00 linux-5.15.y b925f60c6ee7 3ba885bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
2024/05/01 23:20 linux-5.15.y b925f60c6ee7 3ba885bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/05/01 18:34 linux-5.15.y b925f60c6ee7 3ba885bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in trie_delete_elem
2024/03/19 12:09 linux-5.15.y b95c01af2113 e104824c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in trie_delete_elem
* Struck through repros no longer work on HEAD.