syzbot


possible deadlock in ntfs_file_mmap

Status: upstream: reported on 2024/08/03 10:10
Reported-by: syzbot+cc755c7ab634df04bf66@syzkaller.appspotmail.com
First crash: 56d, last: 16h24m
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in ntfs_file_mmap origin:lts-only C 60 3h20m 40d 0/3 upstream: reported C repro on 2024/08/19 06:49
upstream possible deadlock in ntfs_file_mmap ntfs3 C done 1046 2h54m 105d 0/28 upstream: reported C repro on 2024/06/15 07:17

Sample crash report:
loop1: detected capacity change from 0 to 4096
ntfs3: loop1: Different NTFS' sector size (4096) and media sector size (512)
======================================================
WARNING: possible circular locking dependency detected
6.1.111-syzkaller #0 Not tainted
------------------------------------------------------
syz.1.328/6123 is trying to acquire lock:
ffff888071a683a0 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff888071a683a0 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: ntfs_file_mmap+0x583/0x7d0 fs/ntfs3/file.c:399

but task is already holding lock:
ffff8880278453d8 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:87 [inline]
ffff8880278453d8 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x175/0x2d0 mm/util.c:518

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&mm->mmap_lock){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       internal_get_user_pages_fast+0x224/0x2cf0 mm/gup.c:3031
       __iov_iter_get_pages_alloc+0x3b1/0xa70 lib/iov_iter.c:1460
       iov_iter_get_pages2+0xcb/0x120 lib/iov_iter.c:1503
       dio_refill_pages fs/direct-io.c:172 [inline]
       dio_get_page fs/direct-io.c:215 [inline]
       do_direct_IO fs/direct-io.c:932 [inline]
       __blockdev_direct_IO+0x13d6/0x4810 fs/direct-io.c:1266
       blockdev_direct_IO include/linux/fs.h:3295 [inline]
       ntfs_direct_IO+0x193/0x360 fs/ntfs3/inode.c:796
       generic_file_direct_write+0x204/0x460 mm/filemap.c:3741
       __generic_file_write_iter+0x1c4/0x400 mm/filemap.c:3901
       ntfs_file_write_iter+0x5fa/0x6d0 fs/ntfs3/file.c:1163
       do_iter_write+0x6e6/0xc40 fs/read_write.c:861
       vfs_writev fs/read_write.c:934 [inline]
       do_pwritev+0x216/0x360 fs/read_write.c:1031
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ntfs_file_mmap+0x583/0x7d0 fs/ntfs3/file.c:399
       call_mmap include/linux/fs.h:2270 [inline]
       mmap_region+0xf96/0x1fa0 mm/mmap.c:2763
       do_mmap+0x8c5/0xf60 mm/mmap.c:1425
       vm_mmap_pgoff+0x1ca/0x2d0 mm/util.c:520
       ksys_mmap_pgoff+0x4f5/0x6d0 mm/mmap.c:1471
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&sb->s_type->i_mutex_key#28);
                               lock(&mm->mmap_lock);
  lock(&sb->s_type->i_mutex_key#28);

 *** DEADLOCK ***

1 lock held by syz.1.328/6123:
 #0: ffff8880278453d8 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:87 [inline]
 #0: ffff8880278453d8 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x175/0x2d0 mm/util.c:518

stack backtrace:
CPU: 1 PID: 6123 Comm: syz.1.328 Not tainted 6.1.111-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:758 [inline]
 ntfs_file_mmap+0x583/0x7d0 fs/ntfs3/file.c:399
 call_mmap include/linux/fs.h:2270 [inline]
 mmap_region+0xf96/0x1fa0 mm/mmap.c:2763
 do_mmap+0x8c5/0xf60 mm/mmap.c:1425
 vm_mmap_pgoff+0x1ca/0x2d0 mm/util.c:520
 ksys_mmap_pgoff+0x4f5/0x6d0 mm/mmap.c:1471
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f7cfef7df39
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f7cffdcc038 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: ffffffffffffffda RBX: 00007f7cff135f80 RCX: 00007f7cfef7df39
RDX: 000000000000000b RSI: 0000000000b36000 RDI: 0000000020000000
RBP: 00007f7cfeff0216 R08: 0000000000000004 R09: 0000000000000000
R10: 0000000000028011 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f7cff135f80 R15: 00007ffd3752c7c8
 </TASK>

Crashes (64):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/09/27 04:58 linux-6.1.y e526b12bf916 9314348a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/09/27 04:58 linux-6.1.y e526b12bf916 9314348a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/09/13 07:44 linux-6.1.y 5f55cad62cc9 73e8a465 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/23 12:51 linux-6.1.y ee5e09825b81 d7d32352 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/19 06:22 linux-6.1.y ee5e09825b81 dbc93b08 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/19 06:22 linux-6.1.y ee5e09825b81 dbc93b08 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/17 01:25 linux-6.1.y 117ac406ba90 dbc93b08 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/17 01:25 linux-6.1.y 117ac406ba90 dbc93b08 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/12 14:00 linux-6.1.y 36790ef5e00b 842184b3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/08 09:24 linux-6.1.y 48d525b0e463 de12cf65 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/08 09:12 linux-6.1.y 48d525b0e463 de12cf65 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/07 00:52 linux-6.1.y 48d525b0e463 1ef9fe42 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/07 00:52 linux-6.1.y 48d525b0e463 1ef9fe42 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/06 08:53 linux-6.1.y 48d525b0e463 e1bdb00a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/06 02:46 linux-6.1.y 48d525b0e463 e1bdb00a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/06 02:38 linux-6.1.y 48d525b0e463 e1bdb00a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/05 14:57 linux-6.1.y 48d525b0e463 e35c337f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/03 16:15 linux-6.1.y 48d525b0e463 1786a2a8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/03 16:14 linux-6.1.y 48d525b0e463 1786a2a8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/03 15:37 linux-6.1.y 48d525b0e463 1786a2a8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/03 15:37 linux-6.1.y 48d525b0e463 1786a2a8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/03 13:09 linux-6.1.y 48d525b0e463 1786a2a8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/03 13:09 linux-6.1.y 48d525b0e463 1786a2a8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/03 10:10 linux-6.1.y 48d525b0e463 1786a2a8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/08/03 10:10 linux-6.1.y 48d525b0e463 1786a2a8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_mmap
2024/09/27 19:46 linux-6.1.y e526b12bf916 440b26ec .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/09/26 18:00 linux-6.1.y e526b12bf916 9314348a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/09/25 19:51 linux-6.1.y e526b12bf916 349a68c4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/09/25 18:49 linux-6.1.y e526b12bf916 349a68c4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/09/25 09:22 linux-6.1.y e526b12bf916 349a68c4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/09/23 08:27 linux-6.1.y e526b12bf916 6f888b75 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/09/22 23:44 linux-6.1.y e526b12bf916 6f888b75 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/09/22 11:34 linux-6.1.y e526b12bf916 6f888b75 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/09/12 13:01 linux-6.1.y 5f55cad62cc9 60e1a995 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/09/11 20:48 linux-6.1.y 5ca5b389fddf d94c83d8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/09/10 17:25 linux-6.1.y 5ca5b389fddf 86aa7bd7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/09/09 13:56 linux-6.1.y 5ca5b389fddf 073f8be2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/25 08:31 linux-6.1.y ee5e09825b81 d7d32352 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/23 01:35 linux-6.1.y ee5e09825b81 ce8a9099 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/23 01:32 linux-6.1.y ee5e09825b81 ce8a9099 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/19 11:40 linux-6.1.y ee5e09825b81 9f0ab3fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/19 11:39 linux-6.1.y ee5e09825b81 9f0ab3fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/19 07:09 linux-6.1.y ee5e09825b81 dbc93b08 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/19 07:07 linux-6.1.y ee5e09825b81 dbc93b08 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/18 18:53 linux-6.1.y 117ac406ba90 dbc93b08 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/17 16:15 linux-6.1.y 117ac406ba90 dbc93b08 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/16 21:01 linux-6.1.y 117ac406ba90 e1c76ab2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/16 21:00 linux-6.1.y 117ac406ba90 e1c76ab2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/15 05:15 linux-6.1.y 117ac406ba90 e4bacdaf .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/15 05:15 linux-6.1.y 117ac406ba90 e4bacdaf .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/14 05:41 linux-6.1.y 36790ef5e00b bde81f6f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/14 05:41 linux-6.1.y 36790ef5e00b bde81f6f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/05 18:16 linux-6.1.y 48d525b0e463 e35c337f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/05 18:16 linux-6.1.y 48d525b0e463 e35c337f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/03 15:52 linux-6.1.y 48d525b0e463 1786a2a8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
2024/08/03 15:52 linux-6.1.y 48d525b0e463 1786a2a8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_mmap
* Struck through repros no longer work on HEAD.