syzbot


possible deadlock in ntfs_file_mmap

Status: upstream: reported C repro on 2024/06/15 07:17
Subsystems: ntfs3
[Documentation on labels]
Reported-by: syzbot+c1751b6739d83d70bb75@syzkaller.appspotmail.com
First crash: 380d, last: 1h50m
Cause bisection: introduced by (bisect log) :
commit 69505fe98f198ee813898cbcaf6770949636430b
Author: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Date: Thu May 30 07:54:07 2024 +0000

  fs/ntfs3: Replace inode_trylock with inode_lock

Crash: possible deadlock in ntfs_file_mmap (log)
Repro: C syz .config
  
Discussions (11)
Title Replies (including bot) Last reply
[syzbot] Monthly ntfs3 report (Jun 2025) 0 (1) 2025/06/24 07:38
[syzbot] Monthly ntfs3 report (May 2025) 0 (1) 2025/05/24 10:04
[syzbot] Monthly ntfs3 report (Apr 2025) 0 (1) 2025/04/22 12:41
[syzbot] Monthly ntfs3 report (Mar 2025) 0 (1) 2025/03/18 14:49
[syzbot] Monthly ntfs3 report (Feb 2025) 0 (1) 2025/02/16 21:53
[syzbot] Monthly ntfs3 report (Jan 2025) 0 (1) 2025/01/15 08:54
[syzbot] Monthly ntfs3 report (Dec 2024) 0 (1) 2024/12/16 09:44
[syzbot] Monthly ntfs3 report (Nov 2024) 0 (1) 2024/11/13 11:07
[syzbot] Monthly ntfs3 report (Sep 2024) 0 (1) 2024/09/12 08:11
[syzbot] Monthly ntfs3 report (Aug 2024) 0 (1) 2024/08/13 08:54
[syzbot] [ntfs3?] possible deadlock in ntfs_file_mmap 1 (5) 2024/07/27 23:03
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in ntfs_file_mmap origin:lts-only C error 351 18h34m 326d 0/3 upstream: reported C repro on 2024/08/03 10:10
linux-5.15 possible deadlock in ntfs_file_mmap origin:lts-only C error 441 1d09h 311d 0/3 upstream: reported C repro on 2024/08/19 06:49
Last patch testing requests (1)
Created Duration User Patch Repo Result
2024/07/27 22:40 20m hdanton@sina.com patch git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2f8c4f506285 OK log

Sample crash report:
loop0: detected capacity change from 0 to 4096
======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc2-syzkaller-00318-g739a6c93cc75 #0 Not tainted
------------------------------------------------------
syz-executor305/5820 is trying to acquire lock:
ffff88807696ea68 (&sb->s_type->i_mutex_key#14){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
ffff88807696ea68 (&sb->s_type->i_mutex_key#14){+.+.}-{4:4}, at: ntfs_file_mmap+0x525/0x730 fs/ntfs3/file.c:313

but task is already holding lock:
ffff88807772f560 (&mm->mmap_lock){++++}-{4:4}, at: mmap_write_lock_killable include/linux/mmap_lock.h:374 [inline]
ffff88807772f560 (&mm->mmap_lock){++++}-{4:4}, at: vm_mmap_pgoff+0x1bd/0x4c0 mm/util.c:577

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&mm->mmap_lock){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       gup_fast_fallback+0x22e/0x2260 mm/gup.c:3341
       iov_iter_extract_user_pages lib/iov_iter.c:1846 [inline]
       iov_iter_extract_pages+0x35a/0x5e0 lib/iov_iter.c:1909
       dio_refill_pages fs/direct-io.c:172 [inline]
       dio_get_page fs/direct-io.c:213 [inline]
       do_direct_IO fs/direct-io.c:915 [inline]
       __blockdev_direct_IO+0x114f/0x33d0 fs/direct-io.c:1243
       blockdev_direct_IO include/linux/fs.h:3477 [inline]
       ntfs_direct_IO+0x20b/0x410 fs/ntfs3/inode.c:813
       generic_file_read_iter+0x319/0x510 mm/filemap.c:2880
       do_iter_readv_writev+0x56b/0x7f0 fs/read_write.c:-1
       vfs_readv+0x253/0x850 fs/read_write.c:1018
       do_preadv fs/read_write.c:1132 [inline]
       __do_sys_preadv2 fs/read_write.c:1191 [inline]
       __se_sys_preadv2+0x179/0x290 fs/read_write.c:1182
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&sb->s_type->i_mutex_key#14){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3168 [inline]
       check_prevs_add kernel/locking/lockdep.c:3287 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911
       __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
       down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:869 [inline]
       ntfs_file_mmap+0x525/0x730 fs/ntfs3/file.c:313
       call_mmap include/linux/fs.h:2286 [inline]
       mmap_file mm/internal.h:167 [inline]
       __mmap_new_file_vma mm/vma.c:2405 [inline]
       __mmap_new_vma mm/vma.c:2467 [inline]
       __mmap_region mm/vma.c:2622 [inline]
       mmap_region+0x127a/0x1f30 mm/vma.c:2692
       do_mmap+0xc45/0x10d0 mm/mmap.c:561
       vm_mmap_pgoff+0x31b/0x4c0 mm/util.c:579
       ksys_mmap_pgoff+0x51f/0x760 mm/mmap.c:607
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&sb->s_type->i_mutex_key#14);
                               lock(&mm->mmap_lock);
  lock(&sb->s_type->i_mutex_key#14);

 *** DEADLOCK ***

1 lock held by syz-executor305/5820:
 #0: ffff88807772f560 (&mm->mmap_lock){++++}-{4:4}, at: mmap_write_lock_killable include/linux/mmap_lock.h:374 [inline]
 #0: ffff88807772f560 (&mm->mmap_lock){++++}-{4:4}, at: vm_mmap_pgoff+0x1bd/0x4c0 mm/util.c:577

stack backtrace:
CPU: 1 UID: 0 PID: 5820 Comm: syz-executor305 Not tainted 6.16.0-rc2-syzkaller-00318-g739a6c93cc75 #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2046
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3168 [inline]
 check_prevs_add kernel/locking/lockdep.c:3287 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911
 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
 down_write+0x96/0x1f0 kernel/locking/rwsem.c:1577
 inode_lock include/linux/fs.h:869 [inline]
 ntfs_file_mmap+0x525/0x730 fs/ntfs3/file.c:313
 call_mmap include/linux/fs.h:2286 [inline]
 mmap_file mm/internal.h:167 [inline]
 __mmap_new_file_vma mm/vma.c:2405 [inline]
 __mmap_new_vma mm/vma.c:2467 [inline]
 __mmap_region mm/vma.c:2622 [inline]
 mmap_region+0x127a/0x1f30 mm/vma.c:2692
 do_mmap+0xc45/0x10d0 mm/mmap.c:561
 vm_mmap_pgoff+0x31b/0x4c0 mm/util.c:579
 ksys_mmap_pgoff+0x51f/0x760 mm/mmap.c:607
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f7bf83a1469
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 21 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff71dc6198 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: ffffffffffffffda RBX: 0000200000000080 RCX: 00007f7bf83a1469
RDX: 000000000000000e RSI: 0000000000001000 RDI: 0000200000001000
RBP: 00002000000000c0 R08: 0000000000000005 R09: 0000000000000000
R10: 0000000000000011 R11: 0000000000000246 R12: 0031656c69662f2e
R13: 0000200000000040 R14: 431bde82d7b634db R15: 00007fff71dc6200
 </TASK>

Crashes (3278):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/06/22 17:07 upstream 739a6c93cc75 d6cdfb8a .config console log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro #1] [mounted in repro #2] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/22 12:43 upstream 739a6c93cc75 d6cdfb8a .config console log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro #1] [mounted in repro #2] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2024/10/05 13:51 upstream 27cc6fdf7201 d7906eff .config console log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro #1] [mounted in repro #2] [mounted in repro #3] [mounted in repro #4] [mounted in repro #5] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2024/07/27 15:16 upstream 3a7e02c040b1 46eb10b7 .config strace log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2024/07/27 13:44 upstream 2f8c4f506285 46eb10b7 .config strace log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/04/24 05:52 upstream a79be02bba5c 9882047a .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in ntfs_file_mmap
2025/06/26 07:19 upstream 92ca6c498a5e 26d77996 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/26 00:48 upstream 92ca6c498a5e 26d77996 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/25 21:51 upstream 92ca6c498a5e 26d77996 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/25 10:15 upstream 7595b66ae9de 26d77996 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/25 06:33 upstream 7595b66ae9de 26d77996 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/24 14:46 upstream 78f4e737a53e e2f27c35 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/24 00:58 upstream 78f4e737a53e e2f27c35 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/23 19:42 upstream 86731a2a651e 1a7fb460 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root possible deadlock in ntfs_file_mmap
2025/06/23 17:12 upstream 86731a2a651e d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/23 13:24 upstream 86731a2a651e d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/23 12:15 upstream 86731a2a651e d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/23 11:57 upstream 86731a2a651e d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/23 07:25 upstream b67ec639010f d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/23 02:26 upstream b67ec639010f d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/22 23:44 upstream b67ec639010f d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/22 21:36 upstream b67ec639010f d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/22 10:16 upstream 739a6c93cc75 d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/22 05:57 upstream 739a6c93cc75 d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/22 05:56 upstream 739a6c93cc75 d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/21 23:29 upstream 3f75bfff44be d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/21 05:08 upstream 11313e2f7812 d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/20 21:05 upstream 41687a5c6f8b 804b3919 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/20 07:55 upstream 41687a5c6f8b ed3e87f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/19 20:52 upstream 24770983ccfe ed3e87f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/19 18:33 upstream 24770983ccfe ed3e87f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/19 17:06 upstream fb4d33ab452e ed3e87f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/19 15:46 upstream fb4d33ab452e ed3e87f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/19 06:40 upstream fb4d33ab452e ed3e87f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/19 01:34 upstream 52da431bf03b ed3e87f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/18 13:55 upstream 52da431bf03b ca631f70 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root possible deadlock in ntfs_file_mmap
2025/06/18 13:19 upstream 52da431bf03b ca631f70 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/18 09:56 upstream 52da431bf03b e77fae15 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/17 20:11 upstream 4663747812d1 e77fae15 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/17 10:26 upstream 9afe652958c3 417d98fa .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root possible deadlock in ntfs_file_mmap
2025/06/17 07:08 upstream 9afe652958c3 cfebc887 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/17 05:24 upstream 9afe652958c3 d1716036 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root possible deadlock in ntfs_file_mmap
2025/06/17 01:12 upstream e04c78d86a96 d1716036 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/16 23:50 upstream e04c78d86a96 d1716036 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/16 21:08 upstream e04c78d86a96 d1716036 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/16 17:42 upstream e04c78d86a96 d1716036 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/16 13:27 upstream e04c78d86a96 d1716036 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/16 09:54 upstream e04c78d86a96 5f4b362d .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in ntfs_file_mmap
2025/06/25 04:05 upstream 7595b66ae9de 26d77996 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in ntfs_file_mmap
2025/06/07 08:54 upstream c0c9379f235d 4826c28e .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in ntfs_file_mmap
2025/06/18 11:41 linux-next 6e5ab6fee68d ca631f70 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/18 07:38 linux-next 6e5ab6fee68d e77fae15 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/18 06:11 linux-next 4325743c7e20 e77fae15 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/17 12:41 linux-next 4325743c7e20 417d98fa .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/17 08:14 linux-next 4325743c7e20 cfebc887 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/17 08:13 linux-next 4325743c7e20 cfebc887 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in ntfs_file_mmap
2024/06/15 00:04 linux-next a957267fa7e9 8d849073 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in ntfs_file_mmap
2024/06/11 07:14 linux-next a957267fa7e9 048c640a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in ntfs_file_mmap
2025/06/24 16:48 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 9aa9b43d689e 26d77996 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in ntfs_file_mmap
2025/06/24 07:43 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 9aa9b43d689e 1a7fb460 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in ntfs_file_mmap
2025/06/23 10:05 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 9aa9b43d689e d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in ntfs_file_mmap
* Struck through repros no longer work on HEAD.