syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.3.53/6106 is trying to acquire lock:
ffff88805b469818 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff88805b469818 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_del_inode_from_orphan+0x12f/0x7a0 fs/ocfs2/namei.c:2716

but task is already holding lock:
ffff88805b4689d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff88805b4689d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16e/0x44c0 fs/ocfs2/suballoc.c:782

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
       __lock_release kernel/locking/lockdep.c:5468 [inline]
       lock_release+0x332/0x8c0 kernel/locking/lockdep.c:5774
       up_write+0x2d/0x410 kernel/locking/rwsem.c:1625
       ocfs2_expand_inline_dir fs/ocfs2/dir.c:3089 [inline]
       ocfs2_extend_dir+0x28da/0x48b0 fs/ocfs2/dir.c:3201
       ocfs2_prepare_dir_for_insert+0x315b/0x56b0 fs/ocfs2/dir.c:4322
       __ocfs2_prepare_orphan_dir+0x145/0x310 fs/ocfs2/namei.c:2167
       ocfs2_prepare_orphan_dir+0xf1/0x420 fs/ocfs2/namei.c:2210
       ocfs2_unlink+0xb8f/0x1b50 fs/ocfs2/namei.c:960
       vfs_unlink+0x389/0x600 fs/namei.c:4333
       do_unlinkat+0x339/0x590 fs/namei.c:4399
       __do_sys_unlink fs/namei.c:4447 [inline]
       __se_sys_unlink fs/namei.c:4445 [inline]
       __x64_sys_unlink+0x49/0x50 fs/namei.c:4445
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2df1/0x7d40 kernel/locking/lockdep.c:5137
       lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
       down_write+0x97/0x200 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_del_inode_from_orphan+0x12f/0x7a0 fs/ocfs2/namei.c:2716
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
       ocfs2_dio_end_io+0x1040/0x13c0 fs/ocfs2/aops.c:2446
       dio_complete+0x254/0x710 fs/direct-io.c:282
       __blockdev_direct_IO+0x2ea8/0x3500 fs/direct-io.c:1308
       ocfs2_direct_IO+0x235/0x2a0 fs/ocfs2/aops.c:2483
       generic_file_direct_write+0x1d4/0x3e0 mm/filemap.c:3961
       __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4117
       ocfs2_file_write_iter+0x167a/0x1e80 fs/ocfs2/file.c:2468
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x738/0xc30 fs/read_write.c:860
       iter_file_splice_write+0x6a3/0xcb0 fs/splice.c:736
       do_splice_from fs/splice.c:933 [inline]
       direct_splice_actor+0xe8/0x130 fs/splice.c:1142
       splice_direct_to_actor+0x304/0x8c0 fs/splice.c:1088
       do_splice_direct+0x1d5/0x2f0 fs/splice.c:1194
       do_sendfile+0x5f2/0xef0 fs/read_write.c:1254
       __do_sys_sendfile64 fs/read_write.c:1322 [inline]
       __se_sys_sendfile64+0x145/0x1a0 fs/read_write.c:1308
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);

 *** DEADLOCK ***

3 locks held by syz.3.53/6106:
 #0: ffff88807af18418 (sb_writers#14){.+.+}-{0:0}, at: do_sendfile+0x5cf/0xef0 fs/read_write.c:1253
 #1: ffff88805f251818 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff88805f251818 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x440/0x1e80 fs/ocfs2/file.c:2398
 #2: ffff88805b4689d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #2: ffff88805b4689d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16e/0x44c0 fs/ocfs2/suballoc.c:782

stack backtrace:
CPU: 0 PID: 6106 Comm: syz.3.53 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x18c/0x250 lib/dump_stack.c:106
 check_noncircular+0x2fc/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2df1/0x7d40 kernel/locking/lockdep.c:5137
 lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
 down_write+0x97/0x200 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:804 [inline]
 ocfs2_del_inode_from_orphan+0x12f/0x7a0 fs/ocfs2/namei.c:2716
 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
 ocfs2_dio_end_io+0x1040/0x13c0 fs/ocfs2/aops.c:2446
 dio_complete+0x254/0x710 fs/direct-io.c:282
 __blockdev_direct_IO+0x2ea8/0x3500 fs/direct-io.c:1308
 ocfs2_direct_IO+0x235/0x2a0 fs/ocfs2/aops.c:2483
 generic_file_direct_write+0x1d4/0x3e0 mm/filemap.c:3961
 __generic_file_write_iter+0x11b/0x230 mm/filemap.c:4117
 ocfs2_file_write_iter+0x167a/0x1e80 fs/ocfs2/file.c:2468
 do_iter_readv_writev fs/read_write.c:-1 [inline]
 do_iter_write+0x738/0xc30 fs/read_write.c:860
 iter_file_splice_write+0x6a3/0xcb0 fs/splice.c:736
 do_splice_from fs/splice.c:933 [inline]
 direct_splice_actor+0xe8/0x130 fs/splice.c:1142
 splice_direct_to_actor+0x304/0x8c0 fs/splice.c:1088
 do_splice_direct+0x1d5/0x2f0 fs/splice.c:1194
 do_sendfile+0x5f2/0xef0 fs/read_write.c:1254
 __do_sys_sendfile64 fs/read_write.c:1322 [inline]
 __se_sys_sendfile64+0x145/0x1a0 fs/read_write.c:1308
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f9b1439ce59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9b125f6028 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f9b14616090 RCX: 00007f9b1439ce59
RDX: 0000000000000000 RSI: 000000000000000c RDI: 000000000000000b
RBP: 00007f9b14432d6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000fffe82 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f9b14616128 R14: 00007f9b14616090 R15: 00007fffb97a59c8
 </TASK>