syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.1475/10026 is trying to acquire lock:
ffff888072776d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff888072776d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_del_inode_from_orphan+0x12b/0x7b0 fs/ocfs2/namei.c:2713

but task is already holding lock:
ffff888072775f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff888072775f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16a/0x4810 fs/ocfs2/suballoc.c:804

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_reserve_suballoc_bits+0x16a/0x4810 fs/ocfs2/suballoc.c:804
       ocfs2_reserve_new_metadata_blocks+0x412/0x9a0 fs/ocfs2/suballoc.c:1000
       ocfs2_mknod+0x11e5/0x2580 fs/ocfs2/namei.c:347
       ocfs2_mkdir+0x1b6/0x4b0 fs/ocfs2/namei.c:657
       vfs_mkdir+0x386/0x570 fs/namei.c:4114
       do_mkdirat+0x1d8/0x440 fs/namei.c:4139
       __do_sys_mkdirat fs/namei.c:4154 [inline]
       __se_sys_mkdirat fs/namei.c:4152 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4152
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x1e90/0x45e0 fs/ocfs2/inode.c:1219
       evict+0x4b6/0x8b0 fs/inode.c:705
       d_delete_notify include/linux/fsnotify.h:267 [inline]
       vfs_rmdir+0x374/0x4a0 fs/namei.c:4212
       do_rmdir+0x29a/0x5c0 fs/namei.c:4260
       __do_sys_rmdir fs/namei.c:4279 [inline]
       __se_sys_rmdir fs/namei.c:4277 [inline]
       __x64_sys_rmdir+0x45/0x50 fs/namei.c:4277
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3095 [inline]
       check_prevs_add kernel/locking/lockdep.c:3214 [inline]
       validate_chain kernel/locking/lockdep.c:3830 [inline]
       __lock_acquire+0x2d18/0x7c40 kernel/locking/lockdep.c:5063
       lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5676
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_del_inode_from_orphan+0x12b/0x7b0 fs/ocfs2/namei.c:2713
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
       ocfs2_dio_end_io+0x1074/0x13f0 fs/ocfs2/aops.c:2446
       dio_complete+0x249/0x710 fs/direct-io.c:271
       __blockdev_direct_IO+0x2e15/0x34c0 fs/direct-io.c:1320
       ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2483
       generic_file_direct_write+0x112/0x330 mm/filemap.c:3787
       __generic_file_write_iter+0x15f/0x2a0 mm/filemap.c:3945
       ocfs2_file_write_iter+0x1731/0x1fc0 fs/ocfs2/file.c:2469
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x638/0xb10 fs/read_write.c:861
       vfs_writev fs/read_write.c:934 [inline]
       do_pwritev+0x23e/0x3a0 fs/read_write.c:1031
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);

 *** DEADLOCK ***

3 locks held by syz.4.1475/10026:
 #0: ffff888026af4460 (sb_writers#18){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:933 [inline]
 #0: ffff888026af4460 (sb_writers#18){.+.+}-{0:0}, at: do_pwritev+0x227/0x3a0 fs/read_write.c:1031
 #1: ffff888050a209c8 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff888050a209c8 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x45a/0x1fc0 fs/ocfs2/file.c:2399
 #2: ffff888072775f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff888072775f48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16a/0x4810 fs/ocfs2/suballoc.c:804

stack backtrace:
CPU: 1 PID: 10026 Comm: syz.4.1475 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x24e lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3095 [inline]
 check_prevs_add kernel/locking/lockdep.c:3214 [inline]
 validate_chain kernel/locking/lockdep.c:3830 [inline]
 __lock_acquire+0x2d18/0x7c40 kernel/locking/lockdep.c:5063
 lock_acquire+0x1bb/0x4a0 kernel/locking/lockdep.c:5676
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:758 [inline]
 ocfs2_del_inode_from_orphan+0x12b/0x7b0 fs/ocfs2/namei.c:2713
 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
 ocfs2_dio_end_io+0x1074/0x13f0 fs/ocfs2/aops.c:2446
 dio_complete+0x249/0x710 fs/direct-io.c:271
 __blockdev_direct_IO+0x2e15/0x34c0 fs/direct-io.c:1320
 ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2483
 generic_file_direct_write+0x112/0x330 mm/filemap.c:3787
 __generic_file_write_iter+0x15f/0x2a0 mm/filemap.c:3945
 ocfs2_file_write_iter+0x1731/0x1fc0 fs/ocfs2/file.c:2469
 do_iter_readv_writev fs/read_write.c:-1 [inline]
 do_iter_write+0x638/0xb10 fs/read_write.c:861
 vfs_writev fs/read_write.c:934 [inline]
 do_pwritev+0x23e/0x3a0 fs/read_write.c:1031
 do_syscall_x64 arch/x86/entry/common.c:46 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:76
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f3aebf9de59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f3aecf54028 EFLAGS: 00000246 ORIG_RAX: 0000000000000148
RAX: ffffffffffffffda RBX: 00007f3aec225fa0 RCX: 00007f3aebf9de59
RDX: 0000000000000001 RSI: 0000200000000240 RDI: 0000000000000005
RBP: 00007f3aec033e6f R08: 0000000000000000 R09: 0000000000000003
R10: 0000000000002000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f3aec226038 R14: 00007f3aec225fa0 R15: 00007fffb9829df8
 </TASK>