syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.57/4577 is trying to acquire lock:
ffff8880746c6d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff8880746c6d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_del_inode_from_orphan+0x12b/0x7b0 fs/ocfs2/namei.c:2713

but task is already holding lock:
ffff88805d4289c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff88805d4289c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16d/0x44b0 fs/ocfs2/suballoc.c:804

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_reserve_suballoc_bits+0x16d/0x44b0 fs/ocfs2/suballoc.c:804
       ocfs2_reserve_new_metadata_blocks+0x412/0x9a0 fs/ocfs2/suballoc.c:1000
       ocfs2_mknod+0xee2/0x2510 fs/ocfs2/namei.c:347
       ocfs2_create+0x192/0x420 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3470 [inline]
       open_last_lookups fs/namei.c:3540 [inline]
       path_openat+0x120a/0x2fb0 fs/namei.c:3747
       do_filp_open+0x1df/0x400 fs/namei.c:3777
       do_sys_openat2+0x14b/0x500 fs/open.c:1255
       do_sys_open fs/open.c:1271 [inline]
       __do_sys_openat fs/open.c:1287 [inline]
       __se_sys_openat fs/open.c:1282 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1282
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
       ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
       ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
       ocfs2_evict_inode+0x1453/0x4190 fs/ocfs2/inode.c:1216
       evict+0x4b6/0x8b0 fs/inode.c:647
       d_delete_notify include/linux/fsnotify.h:267 [inline]
       vfs_rmdir+0x392/0x410 fs/namei.c:4170
       do_rmdir+0x27f/0x710 fs/namei.c:4218
       __do_sys_unlinkat fs/namei.c:4398 [inline]
       __se_sys_unlinkat fs/namei.c:4392 [inline]
       __x64_sys_unlinkat+0xc0/0xe0 fs/namei.c:4392
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_del_inode_from_orphan+0x12b/0x7b0 fs/ocfs2/namei.c:2713
       ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
       ocfs2_dio_end_io+0x1074/0x13f0 fs/ocfs2/aops.c:2446
       dio_complete+0x255/0x700 fs/direct-io.c:272
       do_blockdev_direct_IO fs/direct-io.c:1336 [inline]
       __blockdev_direct_IO+0x2eb0/0x3b20 fs/direct-io.c:1368
       ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2483
       generic_file_direct_write+0x222/0x470 mm/filemap.c:3687
       __generic_file_write_iter+0x2b2/0x4e0 mm/filemap.c:3869
       ocfs2_file_write_iter+0x171a/0x1ee0 fs/ocfs2/file.c:2472
       do_iter_readv_writev+0x47d/0x5f0 fs/read_write.c:-1
       do_iter_write+0x1f8/0x7a0 fs/read_write.c:855
       iter_file_splice_write+0x6be/0xcf0 fs/splice.c:689
       do_splice_from fs/splice.c:767 [inline]
       direct_splice_actor+0xe1/0x130 fs/splice.c:956
       splice_direct_to_actor+0x4e8/0xc00 fs/splice.c:902
       do_splice_direct+0x1d4/0x2f0 fs/splice.c:1008
       do_sendfile+0x524/0xe30 fs/read_write.c:1249
       __do_sys_sendfile64 fs/read_write.c:1317 [inline]
       __se_sys_sendfile64+0x141/0x1a0 fs/read_write.c:1303
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);

 *** DEADLOCK ***

3 locks held by syz.0.57/4577:
 #0: ffff88805a528460 (sb_writers#14){.+.+}-{0:0}, at: do_sendfile+0x4ff/0xe30 fs/read_write.c:1248
 #1: ffff88805d42ed88 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff88805d42ed88 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x437/0x1ee0 fs/ocfs2/file.c:2402
 #2: ffff88805d4289c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff88805d4289c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16d/0x44b0 fs/ocfs2/suballoc.c:804

stack backtrace:
CPU: 0 PID: 4577 Comm: syz.0.57 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:787 [inline]
 ocfs2_del_inode_from_orphan+0x12b/0x7b0 fs/ocfs2/namei.c:2713
 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2407 [inline]
 ocfs2_dio_end_io+0x1074/0x13f0 fs/ocfs2/aops.c:2446
 dio_complete+0x255/0x700 fs/direct-io.c:272
 do_blockdev_direct_IO fs/direct-io.c:1336 [inline]
 __blockdev_direct_IO+0x2eb0/0x3b20 fs/direct-io.c:1368
 ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2483
 generic_file_direct_write+0x222/0x470 mm/filemap.c:3687
 __generic_file_write_iter+0x2b2/0x4e0 mm/filemap.c:3869
 ocfs2_file_write_iter+0x171a/0x1ee0 fs/ocfs2/file.c:2472
 do_iter_readv_writev+0x47d/0x5f0 fs/read_write.c:-1
 do_iter_write+0x1f8/0x7a0 fs/read_write.c:855
 iter_file_splice_write+0x6be/0xcf0 fs/splice.c:689
 do_splice_from fs/splice.c:767 [inline]
 direct_splice_actor+0xe1/0x130 fs/splice.c:956
 splice_direct_to_actor+0x4e8/0xc00 fs/splice.c:902
 do_splice_direct+0x1d4/0x2f0 fs/splice.c:1008
 do_sendfile+0x524/0xe30 fs/read_write.c:1249
 __do_sys_sendfile64 fs/read_write.c:1317 [inline]
 __se_sys_sendfile64+0x141/0x1a0 fs/read_write.c:1303
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f57dd36fe59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f57db5c8028 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f57dd5f7fa0 RCX: 00007f57dd36fe59
RDX: 0000000000000000 RSI: 0000000000000008 RDI: 0000000000000007
RBP: 00007f57dd405e6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000fffe82 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f57dd5f8038 R14: 00007f57dd5f7fa0 R15: 00007fff2941ee98
 </TASK>
syz.0.57 (4577) used greatest stack depth: 20384 bytes left