syzbot

 sign-in | mailing list | source | docs
🐞 Open [712] 🐞 Fixed [297] 🐞 Invalid [838] 📈 Kernel Health 📈 Bug Lifetimes 📈 Fuzzing 📈 Crashes 💬 Send us feedback

KASAN: use-after-free Read in slip_open

Status: fixed on 2020/01/03 09:37
Reported-by: syzbot+e95c821c30501cc1f5d1@syzkaller.appspotmail.com
Fix commit: 0c6e6ceae72c slip: Fix use-after-free Read in slip_open
First crash: 1616d, last: 1604d
Cause bisection: introduced by (bisect log) :
commit edc471038b4846b119d0b025f0336bf4b3e1ce23
Author: Jouni Hogander <jouni.hogander@unikie.com>
Date: Wed Nov 13 11:45:02 2019 +0000

  slip: Fix memory leak in slip_open error path

Crash: KASAN: use-after-free Read in slip_open (log)
Repro: C syz .config
  
Fix bisection: fixed by (bisect log) :
commit 0c6e6ceae72c9bdb8834352190c6cafcd0b3c21d
Author: Jouni Hogander <jouni.hogander@unikie.com>
Date: Mon Nov 25 12:23:43 2019 +0000

  slip: Fix use-after-free Read in slip_open

  
▶ ▼ Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream KASAN: use-after-free Read in slip_open net C done 3 1613d 1615d 15/26 fixed on 2019/12/13 00:31
linux-6.1 KASAN: use-after-free Read in slip_open 1 317d 317d 0/3 auto-obsoleted due to no activity on 2023/09/20 09:40
upstream KASAN: use-after-free Read in slip_open (2) net 4 558d 712d 0/26 auto-obsoleted due to no activity on 2023/02/11 15:10
linux-4.14 KASAN: use-after-free Read in slip_open C done done 2 1612d 1612d 1/1 fixed on 2019/12/28 10:32

Sample crash report:
RDX: 00000000200003c0 RSI: 0000000000005423 RDI: 0000000000000003
RBP: 00007fffb6f4fed0 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: ffffffffffffffff
R13: 0000000000000004 R14: 0000000000000000 R15: 0000000000000000
==================================================================
BUG: KASAN: use-after-free in sl_sync drivers/net/slip/slip.c:725 [inline]
BUG: KASAN: use-after-free in slip_open+0xe92/0x1175 drivers/net/slip/slip.c:801
Read of size 8 at addr ffff88809dab5388 by task syz-executor205/7589

CPU: 1 PID: 7589 Comm: syz-executor205 Not tainted 4.19.85-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x197/0x210 lib/dump_stack.c:118
 print_address_description.cold+0x7c/0x20d mm/kasan/report.c:256
 kasan_report_error mm/kasan/report.c:354 [inline]
 kasan_report mm/kasan/report.c:412 [inline]
 kasan_report.cold+0x8c/0x2ba mm/kasan/report.c:396
 __asan_report_load8_noabort+0x14/0x20 mm/kasan/report.c:433
 sl_sync drivers/net/slip/slip.c:725 [inline]
 slip_open+0xe92/0x1175 drivers/net/slip/slip.c:801
 tty_ldisc_open.isra.0+0x89/0xd0 drivers/tty/tty_ldisc.c:462
 tty_set_ldisc+0x2e3/0x690 drivers/tty/tty_ldisc.c:587
 tiocsetd drivers/tty/tty_io.c:2359 [inline]
 tty_ioctl+0x65e/0x1510 drivers/tty/tty_io.c:2603
 vfs_ioctl fs/ioctl.c:46 [inline]
 file_ioctl fs/ioctl.c:501 [inline]
 do_vfs_ioctl+0xd5f/0x1380 fs/ioctl.c:688
 ksys_ioctl+0xab/0xd0 fs/ioctl.c:705
 __do_sys_ioctl fs/ioctl.c:712 [inline]
 __se_sys_ioctl fs/ioctl.c:710 [inline]
 __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:710
 do_syscall_64+0xfd/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x441199
Code: e8 5c ae 02 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 bb 0a fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fffb6f4feb8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000441199
RDX: 00000000200003c0 RSI: 0000000000005423 RDI: 0000000000000003
RBP: 00007fffb6f4fed0 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: ffffffffffffffff
R13: 0000000000000004 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 7588:
 save_stack+0x45/0xd0 mm/kasan/kasan.c:448
 set_track mm/kasan/kasan.c:460 [inline]
 kasan_kmalloc mm/kasan/kasan.c:553 [inline]
 kasan_kmalloc+0xce/0xf0 mm/kasan/kasan.c:531
 __do_kmalloc_node mm/slab.c:3689 [inline]
 __kmalloc_node+0x51/0x80 mm/slab.c:3696
 kmalloc_node include/linux/slab.h:557 [inline]
 kvmalloc_node+0x68/0x100 mm/util.c:423
 kvmalloc include/linux/mm.h:577 [inline]
 kvzalloc include/linux/mm.h:585 [inline]
 alloc_netdev_mqs+0x98/0xd40 net/core/dev.c:8945
 sl_alloc drivers/net/slip/slip.c:751 [inline]
 slip_open+0x38e/0x1175 drivers/net/slip/slip.c:812
 tty_ldisc_open.isra.0+0x89/0xd0 drivers/tty/tty_ldisc.c:462
 tty_set_ldisc+0x2e3/0x690 drivers/tty/tty_ldisc.c:587
 tiocsetd drivers/tty/tty_io.c:2359 [inline]
 tty_ioctl+0x65e/0x1510 drivers/tty/tty_io.c:2603
 vfs_ioctl fs/ioctl.c:46 [inline]
 file_ioctl fs/ioctl.c:501 [inline]
 do_vfs_ioctl+0xd5f/0x1380 fs/ioctl.c:688
 ksys_ioctl+0xab/0xd0 fs/ioctl.c:705
 __do_sys_ioctl fs/ioctl.c:712 [inline]
 __se_sys_ioctl fs/ioctl.c:710 [inline]
 __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:710
 do_syscall_64+0xfd/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 7588:
 save_stack+0x45/0xd0 mm/kasan/kasan.c:448
 set_track mm/kasan/kasan.c:460 [inline]
 __kasan_slab_free+0x102/0x150 mm/kasan/kasan.c:521
 kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
 __cache_free mm/slab.c:3503 [inline]
 kfree+0xcf/0x220 mm/slab.c:3822
 kvfree+0x61/0x70 mm/util.c:452
 netdev_freemem net/core/dev.c:8899 [inline]
 free_netdev+0x384/0x430 net/core/dev.c:9048
 slip_open+0xd2a/0x1175 drivers/net/slip/slip.c:858
 tty_ldisc_open.isra.0+0x89/0xd0 drivers/tty/tty_ldisc.c:462
 tty_set_ldisc+0x2e3/0x690 drivers/tty/tty_ldisc.c:587
 tiocsetd drivers/tty/tty_io.c:2359 [inline]
 tty_ioctl+0x65e/0x1510 drivers/tty/tty_io.c:2603
 vfs_ioctl fs/ioctl.c:46 [inline]
 file_ioctl fs/ioctl.c:501 [inline]
 do_vfs_ioctl+0xd5f/0x1380 fs/ioctl.c:688
 ksys_ioctl+0xab/0xd0 fs/ioctl.c:705
 __do_sys_ioctl fs/ioctl.c:712 [inline]
 __se_sys_ioctl fs/ioctl.c:710 [inline]
 __x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:710
 do_syscall_64+0xfd/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff88809dab48c0
 which belongs to the cache kmalloc-4096 of size 4096
The buggy address is located 2760 bytes inside of
 4096-byte region [ffff88809dab48c0, ffff88809dab58c0)
The buggy address belongs to the page:
page:ffffea000276ad00 count:1 mapcount:0 mapping:ffff88812c3f0dc0 index:0x0 compound_mapcount: 0
flags: 0x1fffc0000008100(slab|head)
raw: 01fffc0000008100 ffffea0002657b08 ffffea00027c8e08 ffff88812c3f0dc0
raw: 0000000000000000 ffff88809dab48c0 0000000100000001 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88809dab5280: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88809dab5300: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88809dab5380: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                      ^
 ffff88809dab5400: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88809dab5480: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (7):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/11/21 20:46 linux-4.19.y c63ee2939dc1 8098ea0f .config console log report syz C ci2-linux-4-19
2019/12/03 13:25 linux-4.19.y 174651bdf802 ab342da3 .config console log report ci2-linux-4-19
2019/11/24 15:26 linux-4.19.y 14260788bbb9 598ca6c8 .config console log report ci2-linux-4-19
2019/11/23 13:38 linux-4.19.y c63ee2939dc1 598ca6c8 .config console log report ci2-linux-4-19
2019/11/23 11:27 linux-4.19.y c63ee2939dc1 598ca6c8 .config console log report ci2-linux-4-19
2019/11/23 07:28 linux-4.19.y c63ee2939dc1 598ca6c8 .config console log report ci2-linux-4-19
2019/11/21 20:19 linux-4.19.y c63ee2939dc1 8098ea0f .config console log report ci2-linux-4-19
* Struck through repros no longer work on HEAD.