syzbot


possible deadlock in do_journal_begin_r

Status: upstream: reported C repro on 2023/06/19 07:49
Bug presence: origin:upstream
[Documentation on labels]
Reported-by: syzbot+f6ec13710cba2de48467@syzkaller.appspotmail.com
First crash: 402d, last: 49d
Fix bisection: failed (error log, bisect log)
  
Bug presence (1)
Date Name Commit Repro Result
2023/06/19 upstream (ToT) 45a3e24f65e9 C [report] possible deadlock in page_cache_ra_unbounded
Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 possible deadlock in do_journal_begin_r reiserfs C error 45 581d 666d 0/1 upstream: reported C repro on 2022/09/27 10:45
linux-4.14 possible deadlock in do_journal_begin_r reiserfs C 55 509d 658d 0/1 upstream: reported C repro on 2022/10/05 14:07
upstream possible deadlock in do_journal_begin_r reiserfs C error error 227 186d 662d 0/27 auto-obsoleted due to no activity on 2024/05/26 14:27
linux-6.1 possible deadlock in do_journal_begin_r origin:upstream C 25 16d 395d 0/3 upstream: reported C repro on 2023/06/25 10:36
Fix bisection attempts (7)
Created Duration User Patch Repo Result
2024/07/07 07:06 0m bisect fix linux-5.15.y error job log
2024/06/06 01:25 2h23m bisect fix linux-5.15.y OK (0) job log log
2024/03/01 19:20 1h05m bisect fix linux-5.15.y OK (0) job log log
2024/01/22 10:49 1h10m bisect fix linux-5.15.y OK (0) job log log
2023/12/23 07:54 57m bisect fix linux-5.15.y OK (0) job log log
2023/10/05 19:41 58m bisect fix linux-5.15.y OK (0) job log log
2023/08/08 07:23 2h41m bisect fix linux-5.15.y OK (0) job log log

Sample crash report:
REISERFS (device loop0): journal params: device loop0, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop0): checking transaction log (loop0)
REISERFS (device loop0): Using tea hash to sort names
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
======================================================
WARNING: possible circular locking dependency detected
5.15.151-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor337/3498 is trying to acquire lock:
ffffc90002c190f0 (&journal->j_mutex){+.+.}-{3:3}, at: reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:814 [inline]
ffffc90002c190f0 (&journal->j_mutex){+.+.}-{3:3}, at: lock_journal fs/reiserfs/journal.c:534 [inline]
ffffc90002c190f0 (&journal->j_mutex){+.+.}-{3:3}, at: do_journal_begin_r+0x34e/0x1000 fs/reiserfs/journal.c:3045

but task is already holding lock:
ffff888074242460 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (sb_writers#9){.+.+}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1787 [inline]
       sb_start_write+0x4f/0x1c0 include/linux/fs.h:1857
       mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421
       reiserfs_ioctl+0x170/0x340 fs/reiserfs/ioctl.c:103
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:874 [inline]
       __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #1 (&sbi->lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       reiserfs_write_lock_nested+0x5b/0xd0 fs/reiserfs/lock.c:78
       reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:815 [inline]
       lock_journal fs/reiserfs/journal.c:534 [inline]
       do_journal_begin_r+0x359/0x1000 fs/reiserfs/journal.c:3045
       journal_begin+0x148/0x350 fs/reiserfs/journal.c:3253
       reiserfs_fill_super+0x1812/0x2690 fs/reiserfs/super.c:2108
       mount_bdev+0x2c9/0x3f0 fs/super.c:1387
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1517
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3005
       do_mount fs/namespace.c:3348 [inline]
       __do_sys_mount fs/namespace.c:3556 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3533
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (&journal->j_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:814 [inline]
       lock_journal fs/reiserfs/journal.c:534 [inline]
       do_journal_begin_r+0x34e/0x1000 fs/reiserfs/journal.c:3045
       journal_begin+0x148/0x350 fs/reiserfs/journal.c:3253
       reiserfs_dirty_inode+0x11c/0x240 fs/reiserfs/super.c:710
       __mark_inode_dirty+0x2fd/0xd60 fs/fs-writeback.c:2464
       mark_inode_dirty include/linux/fs.h:2438 [inline]
       reiserfs_ioctl+0x29e/0x340 fs/reiserfs/ioctl.c:111
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:874 [inline]
       __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

Chain exists of:
  &journal->j_mutex --> &sbi->lock --> sb_writers#9

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(sb_writers#9);
                               lock(&sbi->lock);
                               lock(sb_writers#9);
  lock(&journal->j_mutex);

 *** DEADLOCK ***

1 lock held by syz-executor337/3498:
 #0: ffff888074242460 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421

stack backtrace:
CPU: 1 PID: 3498 Comm: syz-executor337 Not tainted 5.15.151-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:814 [inline]
 lock_journal fs/reiserfs/journal.c:534 [inline]
 do_journal_begin_r+0x34e/0x1000 fs/reiserfs/journal.c:3045
 journal_begin+0x148/0x350 fs/reiserfs/journal.c:3253
 reiserfs_dirty_inode+0x11c/0x240 fs/reiserfs/super.c:710
 __mark_inode_dirty+0x2fd/0xd60 fs/fs-writeback.c:2464
 mark_inode_dirty include/linux/fs.h:2438 [inline]
 reiserfs_ioctl+0x29e/0x340 fs/reiserfs/ioctl.c:111
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:874 [inline]
 __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f947d131609
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffea4a68038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007ffea4a68208 RCX: 00007f947d131609
RDX: 0000000020000140 RSI: 0000000040087602 RDI: 00000000000

Crashes (45):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/03/15 02:19 linux-5.15.y 574362648507 d615901c .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan possible deadlock in do_journal_begin_r
2023/10/15 08:28 linux-5.15.y 02e21884dcf2 f757a323 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan possible deadlock in do_journal_begin_r
2023/06/19 07:49 linux-5.15.y 471e639e59d1 f3921d4d .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan possible deadlock in do_journal_begin_r
2024/05/05 19:42 linux-5.15.y 284087d4f7d5 610f2a54 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2024/04/24 09:07 linux-5.15.y c52b9710c83d 21339d7b .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2024/04/24 00:44 linux-5.15.y c52b9710c83d 21339d7b .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2024/04/23 07:04 linux-5.15.y c52b9710c83d 36c961ad .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2024/03/15 02:44 linux-5.15.y 574362648507 d615901c .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/15 22:35 linux-5.15.y 02e21884dcf2 f757a323 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2024/03/26 20:23 linux-5.15.y b95c01af2113 454571b6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in do_journal_begin_r
2024/03/26 14:15 linux-5.15.y b95c01af2113 bcd9b39f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in do_journal_begin_r
2024/03/26 01:16 linux-5.15.y b95c01af2113 bcd9b39f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in do_journal_begin_r
2024/03/25 12:00 linux-5.15.y b95c01af2113 0ea90952 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in do_journal_begin_r
2024/03/24 23:08 linux-5.15.y b95c01af2113 0ea90952 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in do_journal_begin_r
2024/03/23 08:51 linux-5.15.y b95c01af2113 0ea90952 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in do_journal_begin_r
2024/03/15 00:10 linux-5.15.y 574362648507 d615901c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in do_journal_begin_r
2023/10/15 02:11 linux-5.15.y 02e21884dcf2 f757a323 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in do_journal_begin_r
2024/03/25 12:11 linux-5.15.y b95c01af2113 0ea90952 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2024/03/23 09:05 linux-5.15.y b95c01af2113 0ea90952 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2024/03/15 22:27 linux-5.15.y b95c01af2113 d615901c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2024/03/15 20:34 linux-5.15.y b95c01af2113 d615901c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2024/03/15 18:02 linux-5.15.y 574362648507 d615901c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2024/03/15 00:52 linux-5.15.y 574362648507 d615901c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2024/03/14 22:44 linux-5.15.y 574362648507 d615901c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/11/23 04:23 linux-5.15.y 2a910f4af54d fc59b78e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/11/22 16:46 linux-5.15.y 2a910f4af54d 03e12510 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/11/11 01:20 linux-5.15.y 80529b4968a8 d80eec66 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/11/09 02:02 linux-5.15.y 80529b4968a8 4862372a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/11/08 20:13 linux-5.15.y 80529b4968a8 b93f63e8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/11/08 15:05 linux-5.15.y 12952a23a5da b93f63e8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/11/03 02:25 linux-5.15.y 12952a23a5da c4ac074c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/11/02 21:33 linux-5.15.y 12952a23a5da c4ac074c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/11/02 09:08 linux-5.15.y 12952a23a5da 69904c9f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/11/02 06:54 linux-5.15.y 12952a23a5da 69904c9f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/31 11:41 linux-5.15.y 12952a23a5da 58499c95 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/30 17:17 linux-5.15.y 12952a23a5da b5729d82 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/27 03:46 linux-5.15.y 12952a23a5da bf285f0c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/26 16:37 linux-5.15.y 12952a23a5da 23afc60f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/25 15:52 linux-5.15.y 12952a23a5da 17e6d526 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/25 13:09 linux-5.15.y 12952a23a5da 17e6d526 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/23 17:27 linux-5.15.y 00c03985402e 989a3687 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/23 14:34 linux-5.15.y 00c03985402e 989a3687 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/20 22:12 linux-5.15.y 00c03985402e 361b23dc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/20 03:53 linux-5.15.y 00c03985402e a42250d2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
2023/10/15 02:19 linux-5.15.y 02e21884dcf2 f757a323 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in do_journal_begin_r
* Struck through repros no longer work on HEAD.