syzbot

REISERFS (device loop0): checking transaction log (loop0)
REISERFS (device loop0): Using tea hash to sort names
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
======================================================
WARNING: possible circular locking dependency detected
6.6.0-rc7-syzkaller-00151-g56567a20b22b #0 Not tainted
------------------------------------------------------
syz-executor363/5030 is trying to acquire lock:
ffffc900043210f0 (&journal->j_mutex){+.+.}-{3:3}, at: reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:813 [inline]
ffffc900043210f0 (&journal->j_mutex){+.+.}-{3:3}, at: lock_journal fs/reiserfs/journal.c:534 [inline]
ffffc900043210f0 (&journal->j_mutex){+.+.}-{3:3}, at: do_journal_begin_r+0x352/0x1020 fs/reiserfs/journal.c:3053

but task is already holding lock:
ffff888028262410 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write_file+0x61/0x200 fs/namespace.c:447

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (sb_writers#9){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1571 [inline]
       sb_start_write+0x4d/0x1c0 include/linux/fs.h:1646
       mnt_want_write_file+0x61/0x200 fs/namespace.c:447
       reiserfs_ioctl+0x178/0x2f0 fs/reiserfs/ioctl.c:103
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:871 [inline]
       __se_sys_ioctl+0xf8/0x170 fs/ioctl.c:857
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&sbi->lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747
       reiserfs_write_lock_nested+0x5f/0xd0 fs/reiserfs/lock.c:78
       reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:814 [inline]
       lock_journal fs/reiserfs/journal.c:534 [inline]
       do_journal_begin_r+0x35d/0x1020 fs/reiserfs/journal.c:3053
       journal_begin+0x14c/0x360 fs/reiserfs/journal.c:3260
       reiserfs_fill_super+0x1853/0x2620 fs/reiserfs/super.c:2104
       mount_bdev+0x237/0x300 fs/super.c:1629
       legacy_get_tree+0xef/0x190 fs/fs_context.c:662
       vfs_get_tree+0x8c/0x280 fs/super.c:1750
       do_new_mount+0x28f/0xae0 fs/namespace.c:3335
       do_mount fs/namespace.c:3675 [inline]
       __do_sys_mount fs/namespace.c:3884 [inline]
       __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3861
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&journal->j_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3868 [inline]
       __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747
       reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:813 [inline]
       lock_journal fs/reiserfs/journal.c:534 [inline]
       do_journal_begin_r+0x352/0x1020 fs/reiserfs/journal.c:3053
       journal_begin+0x14c/0x360 fs/reiserfs/journal.c:3260
       reiserfs_dirty_inode+0x120/0x240 fs/reiserfs/super.c:710
       __mark_inode_dirty+0x305/0xd90 fs/fs-writeback.c:2435
       mark_inode_dirty include/linux/fs.h:2237 [inline]
       reiserfs_ioctl+0x24e/0x2f0 fs/reiserfs/ioctl.c:111
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:871 [inline]
       __se_sys_ioctl+0xf8/0x170 fs/ioctl.c:857
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  &journal->j_mutex --> &sbi->lock --> sb_writers#9

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(sb_writers#9);
                               lock(&sbi->lock);
                               lock(sb_writers#9);
  lock(&journal->j_mutex);

 *** DEADLOCK ***

1 lock held by syz-executor363/5030:
 #0: ffff888028262410 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write_file+0x61/0x200 fs/namespace.c:447

stack backtrace:
CPU: 1 PID: 5030 Comm: syz-executor363 Not tainted 6.6.0-rc7-syzkaller-00151-g56567a20b22b #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3868 [inline]
 __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136
 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747
 reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:813 [inline]
 lock_journal fs/reiserfs/journal.c:534 [inline]
 do_journal_begin_r+0x352/0x1020 fs/reiserfs/journal.c:3053
 journal_begin+0x14c/0x360 fs/reiserfs/journal.c:3260
 reiserfs_dirty_inode+0x120/0x240 fs/reiserfs/super.c:710
 __mark_inode_dirty+0x305/0xd90 fs/fs-writeback.c:2435
 mark_inode_dirty include/linux/fs.h:2237 [inline]
 reiserfs_ioctl+0x24e/0x2f0 fs/reiserfs/ioctl.c:111
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:871 [inline]
 __se_sys_ioctl+0xf8/0x170 fs/ioctl.c:857
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fc69a37d5c9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff7102e1f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fff7102e3c8 RCX: 00007fc69a37d5c9
RDX: 0000000020000000 RSI: 0000000040087602 RDI: 0000000000000003