syzbot

loop0: detected capacity change from 0 to 32768
ocfs2: Mounting device (7,0) on (node local, slot 0) with writeback data mode.
======================================================
WARNING: possible circular locking dependency detected
6.1.118-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor113/4359 is trying to acquire lock:
ffff888020345488 (&osb->system_file_mutex){+.+.}-{3:3}, at: ocfs2_get_system_file_inode+0x1a1/0x7b0 fs/ocfs2/sysfile.c:101

but task is already holding lock:
ffff88806e8f6a20 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_wr_get_block+0x942/0x1920 fs/ocfs2/aops.c:2225

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_read_virt_blocks+0x2dc/0xab0 fs/ocfs2/extent_map.c:976
       ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
       ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
       ocfs2_find_entry+0x436/0x28c0 fs/ocfs2/dir.c:1080
       ocfs2_find_files_on_disk+0x10d/0x3a0 fs/ocfs2/dir.c:1982
       ocfs2_lookup_ino_from_name+0xad/0x1e0 fs/ocfs2/dir.c:2004
       _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
       ocfs2_get_system_file_inode+0x314/0x7b0 fs/ocfs2/sysfile.c:112
       ocfs2_init_global_system_inodes+0x328/0x720 fs/ocfs2/super.c:457
       ocfs2_initialize_super fs/ocfs2/super.c:2250 [inline]
       ocfs2_fill_super+0x2f82/0x5730 fs/ocfs2/super.c:994
       mount_bdev+0x2c9/0x3f0 fs/super.c:1443
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3056
       do_mount fs/namespace.c:3399 [inline]
       __do_sys_mount fs/namespace.c:3607 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&osb->system_file_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       ocfs2_get_system_file_inode+0x1a1/0x7b0 fs/ocfs2/sysfile.c:101
       ocfs2_reserve_suballoc_bits+0x167/0x5190 fs/ocfs2/suballoc.c:776
       ocfs2_reserve_cluster_bitmap_bits fs/ocfs2/suballoc.c:1128 [inline]
       ocfs2_reserve_clusters_with_limit+0x3d9/0xb50 fs/ocfs2/suballoc.c:1173
       ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
       ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669
       ocfs2_write_begin_nolock+0x271a/0x4e40 fs/ocfs2/aops.c:1740
       ocfs2_dio_wr_get_block+0xc29/0x1920 fs/ocfs2/aops.c:2239
       get_more_blocks fs/direct-io.c:665 [inline]
       do_direct_IO fs/direct-io.c:953 [inline]
       __blockdev_direct_IO+0x1d00/0x4810 fs/direct-io.c:1266
       ocfs2_direct_IO+0x250/0x2c0 fs/ocfs2/aops.c:2468
       generic_file_direct_write+0x204/0x460 mm/filemap.c:3769
       __generic_file_write_iter+0x1c4/0x400 mm/filemap.c:3929
       ocfs2_file_write_iter+0x17c6/0x2020 fs/ocfs2/file.c:2467
       do_iter_write+0x6e6/0xc40 fs/read_write.c:861
       iter_file_splice_write+0x830/0xfc0 fs/splice.c:685
       do_splice_from fs/splice.c:763 [inline]
       direct_splice_actor+0xe3/0x1c0 fs/splice.c:950
       splice_direct_to_actor+0x4c7/0xc30 fs/splice.c:896
       do_splice_direct+0x2a5/0x3e0 fs/splice.c:1002
       do_sendfile+0x619/0xff0 fs/read_write.c:1255
       __do_sys_sendfile64 fs/read_write.c:1323 [inline]
       __se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1309
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_file_ip_alloc_sem_key);
                               lock(&osb->system_file_mutex);
                               lock(&ocfs2_file_ip_alloc_sem_key);
  lock(&osb->system_file_mutex);

 *** DEADLOCK ***

3 locks held by syz-executor113/4359:
 #0: ffff88803087e460 (sb_writers#9){.+.+}-{0:0}, at: do_sendfile+0x5f4/0xff0 fs/read_write.c:1254
 #1: ffff88806e8f6d88 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff88806e8f6d88 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x476/0x2020 fs/ocfs2/file.c:2399
 #2: ffff88806e8f6a20 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_wr_get_block+0x942/0x1920 fs/ocfs2/aops.c:2225

stack backtrace:
CPU: 0 PID: 4359 Comm: syz-executor113 Not tainted 6.1.118-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
 ocfs2_get_system_file_inode+0x1a1/0x7b0 fs/ocfs2/sysfile.c:101
 ocfs2_reserve_suballoc_bits+0x167/0x5190 fs/ocfs2/suballoc.c:776
 ocfs2_reserve_cluster_bitmap_bits fs/ocfs2/suballoc.c:1128 [inline]
 ocfs2_reserve_clusters_with_limit+0x3d9/0xb50 fs/ocfs2/suballoc.c:1173
 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
 ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669
 ocfs2_write_begin_nolock+0x271a/0x4e40 fs/ocfs2/aops.c:1740
 ocfs2_dio_wr_get_block+0xc29/0x1920 fs/ocfs2/aops.c:2239
 get_more_blocks fs/direct-io.c:665 [inline]
 do_direct_IO fs/direct-io.c:953 [inline]
 __blockdev_direct_IO+0x1d00/0x4810 fs/direct-io.c:1266
 ocfs2_direct_IO+0x250/0x2c0 fs/ocfs2/aops.c:2468
 generic_file_direct_write+0x204/0x460 mm/filemap.c:3769
 __generic_file_write_iter+0x1c4/0x400 mm/filemap.c:3929
 ocfs2_file_write_iter+0x17c6/0x2020 fs/ocfs2/file.c:2467
 do_iter_write+0x6e6/0xc40 fs/read_write.c:861
 iter_file_splice_write+0x830/0xfc0 fs/splice.c:685
 do_splice_from fs/splice.c:763 [inline]
 direct_splice_actor+0xe3/0x1c0 fs/splice.c:950
 splice_direct_to_actor+0x4c7/0xc30 fs/splice.c:896
 do_splice_direct+0x2a5/0x3e0 fs/splice.c:1002
 do_sendfile+0x619/0xff0 fs/read_write.c:1255
 __do_sys_sendfile64 fs/read_write.c:1323 [inline]
 __se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1309
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7feb3c6802e9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 21 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff8f243678 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 0031656c69662f2e RCX: 00007feb3c6802e9
RDX: 0000000000000000 RSI: 0000000000000004 RDI: 0000000000000004
RBP: 00007feb3c6c90a0 R08: 00007fff8f2436b0 R09: 00007fff8f2436b0
R10: 0000000800000009 R11: 0000000000000246 R12: 6c6c616c61636f6c
R13: 000000000000001c R14: 431bde82d7b634db R15: 00007fff8f2436d0
 </TASK>
ocfs2_dio_end_io: 4 callbacks suppressed
(syz-executor113,4359,0):ocfs2_dio_end_io:2428 ERROR: Direct IO failed, bytes = -5