syzbot


possible deadlock in ntfs_fallocate

Status: upstream: reported on 2023/11/22 18:34
Reported-by: syzbot+e5a561d1c6c138fdb32a@syzkaller.appspotmail.com
First crash: 399d, last: 5d20h
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in ntfs_fallocate ntfs3 C error 374 8h40m 748d 0/28 upstream: reported C repro on 2022/12/09 08:57

Sample crash report:
loop1: detected capacity change from 0 to 4096
ntfs3: loop1: Different NTFS' sector size (1024) and media sector size (512)
======================================================
WARNING: possible circular locking dependency detected
6.1.121-syzkaller #0 Tainted: G        W         
------------------------------------------------------
syz.1.2106/14352 is trying to acquire lock:
ffff888076b65980 (&ni->ni_lock/5){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline]
ffff888076b65980 (&ni->ni_lock/5){+.+.}-{3:3}, at: ntfs_fallocate+0x7e9/0x1020 fs/ntfs3/file.c:665

but task is already holding lock:
ffff888076b65dc0 (mapping.invalidate_lock#6){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:803 [inline]
ffff888076b65dc0 (mapping.invalidate_lock#6){++++}-{3:3}, at: ntfs_fallocate+0x33e/0x1020 fs/ntfs3/file.c:580

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (mapping.invalidate_lock#6){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       filemap_invalidate_lock_shared include/linux/fs.h:813 [inline]
       filemap_fault+0x640/0x17e0 mm/filemap.c:3219
       __do_fault+0x136/0x4f0 mm/memory.c:4278
       do_read_fault mm/memory.c:4629 [inline]
       do_fault mm/memory.c:4758 [inline]
       handle_pte_fault mm/memory.c:5029 [inline]
       __handle_mm_fault mm/memory.c:5171 [inline]
       handle_mm_fault+0x3410/0x5340 mm/memory.c:5292
       do_user_addr_fault arch/x86/mm/fault.c:1340 [inline]
       handle_page_fault arch/x86/mm/fault.c:1431 [inline]
       exc_page_fault+0x26f/0x620 arch/x86/mm/fault.c:1487
       asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:608
       copy_user_short_string+0xa/0x40 arch/x86/lib/copy_user_64.S:231
       copy_user_generic arch/x86/include/asm/uaccess_64.h:37 [inline]
       raw_copy_from_user arch/x86/include/asm/uaccess_64.h:52 [inline]
       _copy_from_user+0xf3/0x170 lib/usercopy.c:23
       copy_from_user include/linux/uaccess.h:161 [inline]
       copy_msghdr_from_user+0xaa/0x670 net/socket.c:2449
       recvmsg_copy_msghdr net/socket.c:2704 [inline]
       ___sys_recvmsg net/socket.c:2776 [inline]
       do_recvmmsg+0x408/0xad0 net/socket.c:2874
       __sys_recvmmsg net/socket.c:2953 [inline]
       __do_sys_recvmmsg net/socket.c:2976 [inline]
       __se_sys_recvmmsg net/socket.c:2969 [inline]
       __x64_sys_recvmmsg+0x195/0x240 net/socket.c:2969
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&mm->mmap_lock){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __might_fault+0xbd/0x110 mm/memory.c:5851
       _copy_to_user+0x26/0x130 lib/usercopy.c:36
       copy_to_user include/linux/uaccess.h:169 [inline]
       ni_fiemap+0x1672/0x18a0 fs/ntfs3/frecord.c:2140
       ntfs_fiemap+0x12e/0x170 fs/ntfs3/file.c:1254
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x18e9/0x2a90 fs/ioctl.c:810
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ni->ni_lock/5){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline]
       ntfs_fallocate+0x7e9/0x1020 fs/ntfs3/file.c:665
       vfs_fallocate+0x547/0x6b0 fs/open.c:323
       ksys_fallocate fs/open.c:346 [inline]
       __do_sys_fallocate fs/open.c:354 [inline]
       __se_sys_fallocate fs/open.c:352 [inline]
       __x64_sys_fallocate+0xb9/0x100 fs/open.c:352
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ni->ni_lock/5 --> &mm->mmap_lock --> mapping.invalidate_lock#6

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(mapping.invalidate_lock#6);
                               lock(&mm->mmap_lock);
                               lock(mapping.invalidate_lock#6);
  lock(&ni->ni_lock/5);

 *** DEADLOCK ***

3 locks held by syz.1.2106/14352:
 #0: ffff88805dd0a460 (sb_writers#21){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:3015 [inline]
 #0: ffff88805dd0a460 (sb_writers#21){.+.+}-{0:0}, at: vfs_fallocate+0x4ba/0x6b0 fs/open.c:322
 #1: ffff888076b65c20 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff888076b65c20 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: ntfs_fallocate+0x2a0/0x1020 fs/ntfs3/file.c:566
 #2: ffff888076b65dc0 (mapping.invalidate_lock#6){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:803 [inline]
 #2: ffff888076b65dc0 (mapping.invalidate_lock#6){++++}-{3:3}, at: ntfs_fallocate+0x33e/0x1020 fs/ntfs3/file.c:580

stack backtrace:
CPU: 0 PID: 14352 Comm: syz.1.2106 Tainted: G        W          6.1.121-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/25/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
 ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline]
 ntfs_fallocate+0x7e9/0x1020 fs/ntfs3/file.c:665
 vfs_fallocate+0x547/0x6b0 fs/open.c:323
 ksys_fallocate fs/open.c:346 [inline]
 __do_sys_fallocate fs/open.c:354 [inline]
 __se_sys_fallocate fs/open.c:352 [inline]
 __x64_sys_fallocate+0xb9/0x100 fs/open.c:352
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f62ddd85d29
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f62deca6038 EFLAGS: 00000246 ORIG_RAX: 000000000000011d
RAX: ffffffffffffffda RBX: 00007f62ddf75fa0 RCX: 00007f62ddd85d29
RDX: 0000000000000000 RSI: 0000000000000020 RDI: 0000000000000005
RBP: 00007f62dde01aa8 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000007000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f62ddf75fa0 R15: 00007fff9e0bb328
 </TASK>

Crashes (20):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/12/20 14:08 linux-6.1.y 29f02ec58a94 0f61b415 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_fallocate
2024/10/03 12:31 linux-6.1.y aa4cd140bba5 a4c7fd36 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_fallocate
2024/08/12 18:14 linux-6.1.y 36790ef5e00b 842184b3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_fallocate
2024/06/10 20:53 linux-6.1.y 88690811da69 048c640a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_fallocate
2024/05/16 21:06 linux-6.1.y 909ba1f1b414 c2e07261 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_fallocate
2024/02/01 17:38 linux-6.1.y e5c3b988b827 81024119 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_fallocate
2024/12/07 22:36 linux-6.1.y e4d90d63d385 9ac0fdc6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/12/07 00:12 linux-6.1.y e4d90d63d385 9ac0fdc6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/12/05 03:21 linux-6.1.y e4d90d63d385 b50eb251 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/11/06 04:49 linux-6.1.y 7c15117f9468 3a465482 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/10/11 11:19 linux-6.1.y aa4cd140bba5 cd942402 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/10/08 09:54 linux-6.1.y aa4cd140bba5 402f1df0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/08/19 20:02 linux-6.1.y ee5e09825b81 9f0ab3fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/08/19 20:01 linux-6.1.y ee5e09825b81 9f0ab3fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/08/19 20:00 linux-6.1.y ee5e09825b81 9f0ab3fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/05/15 12:11 linux-6.1.y 909ba1f1b414 94b087b1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/04/08 14:15 linux-6.1.y 347385861c50 53df08b6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/04/08 04:08 linux-6.1.y 347385861c50 ca620dd8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/03/10 13:00 linux-6.1.y 61adba85cc40 6ee49f2e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2023/11/22 18:33 linux-6.1.y 69e434a1cb21 03e12510 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
* Struck through repros no longer work on HEAD.