syzbot

======================================================
WARNING: possible circular locking dependency detected
6.9.0-rc5-syzkaller-00042-ge88c4cfcb7b8 #0 Not tainted
------------------------------------------------------
syz-executor.5/10927 is trying to acquire lock:
ffff88804f4ff700 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline]
ffff88804f4ff700 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fallocate+0x965/0x1240 fs/ntfs3/file.c:556

but task is already holding lock:
ffff88804f4ffb40 (mapping.invalidate_lock#8){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:840 [inline]
ffff88804f4ffb40 (mapping.invalidate_lock#8){++++}-{3:3}, at: ntfs_fallocate+0x400/0x1240 fs/ntfs3/file.c:486

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (mapping.invalidate_lock#8){++++}-{3:3}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
       down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526
       filemap_invalidate_lock_shared include/linux/fs.h:850 [inline]
       filemap_fault+0x646/0x16a0 mm/filemap.c:3277
       __do_fault+0x137/0x460 mm/memory.c:4531
       do_read_fault mm/memory.c:4894 [inline]
       do_fault mm/memory.c:5024 [inline]
       do_pte_missing mm/memory.c:3880 [inline]
       handle_pte_fault mm/memory.c:5300 [inline]
       __handle_mm_fault+0x45f7/0x7240 mm/memory.c:5441
       handle_mm_fault+0x3c2/0x8a0 mm/memory.c:5606
       do_user_addr_fault arch/x86/mm/fault.c:1413 [inline]
       handle_page_fault arch/x86/mm/fault.c:1505 [inline]
       exc_page_fault+0x2a8/0x8e0 arch/x86/mm/fault.c:1563
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623
       copy_user_generic arch/x86/include/asm/uaccess_64.h:110 [inline]
       raw_copy_from_user arch/x86/include/asm/uaccess_64.h:125 [inline]
       _copy_from_user+0x87/0xe0 lib/usercopy.c:23
       copy_from_user include/linux/uaccess.h:183 [inline]
       copy_from_bpfptr_offset include/linux/bpfptr.h:53 [inline]
       copy_from_bpfptr include/linux/bpfptr.h:59 [inline]
       __sys_bpf+0x1a4/0x810 kernel/bpf/syscall.c:5633
       __do_sys_bpf kernel/bpf/syscall.c:5767 [inline]
       __se_sys_bpf kernel/bpf/syscall.c:5765 [inline]
       __x64_sys_bpf+0x7c/0x90 kernel/bpf/syscall.c:5765
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&mm->mmap_lock){++++}-{3:3}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
       __might_fault+0xc6/0x120 mm/memory.c:6220
       _copy_to_user+0x2a/0xb0 lib/usercopy.c:36
       copy_to_user include/linux/uaccess.h:191 [inline]
       fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:145
       ni_fiemap+0x9b2/0x1230 fs/ntfs3/frecord.c:2044
       ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1206
       ioctl_fiemap fs/ioctl.c:220 [inline]
       do_vfs_ioctl+0x1c09/0x2e50 fs/ioctl.c:838
       __do_sys_ioctl fs/ioctl.c:902 [inline]
       __se_sys_ioctl+0x81/0x170 fs/ioctl.c:890
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ni->file.run_lock#3){++++}-{3:3}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1579
       ntfs_truncate fs/ntfs3/file.c:395 [inline]
       ntfs3_setattr+0x6c3/0xb40 fs/ntfs3/file.c:703
       notify_change+0xb9f/0xe70 fs/attr.c:497
       do_truncate+0x220/0x310 fs/open.c:65
       handle_truncate fs/namei.c:3300 [inline]
       do_open fs/namei.c:3646 [inline]
       path_openat+0x29fe/0x3240 fs/namei.c:3799
       do_filp_open+0x235/0x490 fs/namei.c:3826
       do_sys_openat2+0x13e/0x1d0 fs/open.c:1406
       do_sys_open fs/open.c:1421 [inline]
       __do_sys_openat fs/open.c:1437 [inline]
       __se_sys_openat fs/open.c:1432 [inline]
       __x64_sys_openat+0x247/0x2a0 fs/open.c:1432
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ni->ni_lock/4){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869
       __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
       ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline]
       ntfs_fallocate+0x965/0x1240 fs/ntfs3/file.c:556
       vfs_fallocate+0x566/0x6c0 fs/open.c:330
       ksys_fallocate fs/open.c:353 [inline]
       __do_sys_fallocate fs/open.c:361 [inline]
       __se_sys_fallocate fs/open.c:359 [inline]
       __x64_sys_fallocate+0xbd/0x110 fs/open.c:359
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ni->ni_lock/4 --> &mm->mmap_lock --> mapping.invalidate_lock#8

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(mapping.invalidate_lock#8);
                               lock(&mm->mmap_lock);
                               lock(mapping.invalidate_lock#8);
  lock(&ni->ni_lock/4);

 *** DEADLOCK ***

3 locks held by syz-executor.5/10927:
 #0: ffff88806b3dc420 (sb_writers#13){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2855 [inline]
 #0: ffff88806b3dc420 (sb_writers#13){.+.+}-{0:0}, at: vfs_fallocate+0x4d3/0x6c0 fs/open.c:329
 #1: ffff88804f4ff9a0 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:795 [inline]
 #1: ffff88804f4ff9a0 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: ntfs_fallocate+0x32f/0x1240 fs/ntfs3/file.c:472
 #2: ffff88804f4ffb40 (mapping.invalidate_lock#8){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:840 [inline]
 #2: ffff88804f4ffb40 (mapping.invalidate_lock#8){++++}-{3:3}, at: ntfs_fallocate+0x400/0x1240 fs/ntfs3/file.c:486

stack backtrace:
CPU: 0 PID: 10927 Comm: syz-executor.5 Not tainted 6.9.0-rc5-syzkaller-00042-ge88c4cfcb7b8 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869
 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
 __mutex_lock_common kernel/locking/mutex.c:608 [inline]
 __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
 ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline]
 ntfs_fallocate+0x965/0x1240 fs/ntfs3/file.c:556
 vfs_fallocate+0x566/0x6c0 fs/open.c:330
 ksys_fallocate fs/open.c:353 [inline]
 __do_sys_fallocate fs/open.c:361 [inline]
 __se_sys_fallocate fs/open.c:359 [inline]
 __x64_sys_fallocate+0xbd/0x110 fs/open.c:359
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fb76427dea9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb76509f0c8 EFLAGS: 00000246 ORIG_RAX: 000000000000011d
RAX: ffffffffffffffda RBX: 00007fb7643abf80 RCX: 00007fb76427dea9
RDX: 0000000000000000 RSI: 0000000000000008 RDI: 000000000000000c
RBP: 00007fb7642ca4a4 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000007000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007fb7643abf80 R15: 00007ffec79c5bd8
 </TASK>
netlink: 4 bytes leftover after parsing attributes in process `syz-executor.5'.