syzbot

======================================================
WARNING: possible circular locking dependency detected
6.16.0-syzkaller-10910-g0905809b38bd #0 Tainted: G        W          
------------------------------------------------------
syz.5.19/7261 is trying to acquire lock:
ffff88805c32e5b0 (&ni->ni_lock#3/5){+.+.}-{4:4}, at: ni_lock fs/ntfs3/ntfs_fs.h:1113 [inline]
ffff88805c32e5b0 (&ni->ni_lock#3/5){+.+.}-{4:4}, at: ntfs_fallocate+0x580/0x10b0 fs/ntfs3/file.c:561

but task is already holding lock:
ffff88805c32ea38 (mapping.invalidate_lock#10){++++}-{4:4}, at: filemap_invalidate_lock include/linux/fs.h:924 [inline]
ffff88805c32ea38 (mapping.invalidate_lock#10){++++}-{4:4}, at: ntfs_fallocate+0x3be/0x10b0 fs/ntfs3/file.c:546

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (mapping.invalidate_lock#10){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       down_read+0x97/0x1f0 kernel/locking/rwsem.c:1522
       filemap_invalidate_lock_shared include/linux/fs.h:934 [inline]
       filemap_fault+0x551/0x1210 mm/filemap.c:3433
       __do_fault+0x135/0x390 mm/memory.c:5152
       do_read_fault mm/memory.c:5573 [inline]
       do_fault mm/memory.c:5707 [inline]
       do_pte_missing mm/memory.c:4234 [inline]
       handle_pte_fault mm/memory.c:6052 [inline]
       __handle_mm_fault mm/memory.c:6195 [inline]
       handle_mm_fault+0x23c6/0x3400 mm/memory.c:6364
       do_user_addr_fault+0x764/0x1390 arch/x86/mm/fault.c:1387
       handle_page_fault arch/x86/mm/fault.c:1476 [inline]
       exc_page_fault+0x76/0xf0 arch/x86/mm/fault.c:1532
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623
       rep_movs_alternative+0x30/0x90 arch/x86/lib/copy_user_64.S:53
       copy_user_generic arch/x86/include/asm/uaccess_64.h:126 [inline]
       raw_copy_from_user arch/x86/include/asm/uaccess_64.h:141 [inline]
       _inline_copy_from_user include/linux/uaccess.h:178 [inline]
       _copy_from_user+0x7a/0xb0 lib/usercopy.c:18
       copy_from_user include/linux/uaccess.h:212 [inline]
       ioctl_fiemap fs/ioctl.c:210 [inline]
       do_vfs_ioctl+0x77d/0x1440 fs/ioctl.c:532
       __do_sys_ioctl fs/ioctl.c:596 [inline]
       __se_sys_ioctl+0x82/0x170 fs/ioctl.c:584
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&mm->mmap_lock){++++}-{4:4}:
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       __might_fault+0xcc/0x130 mm/memory.c:6958
       _inline_copy_to_user include/linux/uaccess.h:192 [inline]
       _copy_to_user+0x2c/0xb0 lib/usercopy.c:26
       copy_to_user include/linux/uaccess.h:225 [inline]
       fiemap_fill_next_extent+0x1c0/0x390 fs/ioctl.c:145
       ni_fiemap+0x391/0xbf0 fs/ntfs3/frecord.c:1896
       ntfs_fiemap+0x11d/0x1a0 fs/ntfs3/file.c:1326
       ioctl_fiemap fs/ioctl.c:220 [inline]
       do_vfs_ioctl+0x1185/0x1440 fs/ioctl.c:532
       __do_sys_ioctl fs/ioctl.c:596 [inline]
       __se_sys_ioctl+0x82/0x170 fs/ioctl.c:584
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ni->ni_lock#3/5){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908
       __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237
       lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
       __mutex_lock_common kernel/locking/rtmutex_api.c:535 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:547
       ni_lock fs/ntfs3/ntfs_fs.h:1113 [inline]
       ntfs_fallocate+0x580/0x10b0 fs/ntfs3/file.c:561
       vfs_fallocate+0x66f/0x7f0 fs/open.c:342
       ksys_fallocate fs/open.c:366 [inline]
       __do_sys_fallocate fs/open.c:371 [inline]
       __se_sys_fallocate fs/open.c:369 [inline]
       __x64_sys_fallocate+0xc0/0x110 fs/open.c:369
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ni->ni_lock#3/5 --> &mm->mmap_lock --> mapping.invalidate_lock#10

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(mapping.invalidate_lock#10);
                               lock(&mm->mmap_lock);
                               lock(mapping.invalidate_lock#10);
  lock(&ni->ni_lock#3/5);

 *** DEADLOCK ***

3 locks held by syz.5.19/7261:
 #0: ffff888034934488 (sb_writers#12){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:3107 [inline]
 #0: ffff888034934488 (sb_writers#12){.+.+}-{0:0}, at: vfs_fallocate+0x5f9/0x7f0 fs/open.c:341
 #1: ffff88805c32e868 (&sb->s_type->i_mutex_key#31){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline]
 #1: ffff88805c32e868 (&sb->s_type->i_mutex_key#31){+.+.}-{4:4}, at: ntfs_fallocate+0x2f1/0x10b0 fs/ntfs3/file.c:532
 #2: ffff88805c32ea38 (mapping.invalidate_lock#10){++++}-{4:4}, at: filemap_invalidate_lock include/linux/fs.h:924 [inline]
 #2: ffff88805c32ea38 (mapping.invalidate_lock#10){++++}-{4:4}, at: ntfs_fallocate+0x3be/0x10b0 fs/ntfs3/file.c:546

stack backtrace:
CPU: 1 UID: 0 PID: 7261 Comm: syz.5.19 Tainted: G        W           6.16.0-syzkaller-10910-g0905809b38bd #0 PREEMPT_{RT,(full)} 
Tainted: [W]=WARN
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2043
 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908
 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868
 __mutex_lock_common kernel/locking/rtmutex_api.c:535 [inline]
 mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:547
 ni_lock fs/ntfs3/ntfs_fs.h:1113 [inline]
 ntfs_fallocate+0x580/0x10b0 fs/ntfs3/file.c:561
 vfs_fallocate+0x66f/0x7f0 fs/open.c:342
 ksys_fallocate fs/open.c:366 [inline]
 __do_sys_fallocate fs/open.c:371 [inline]
 __se_sys_fallocate fs/open.c:369 [inline]
 __x64_sys_fallocate+0xc0/0x110 fs/open.c:369
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fa2b407eb69
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa2b1ebd038 EFLAGS: 00000246 ORIG_RAX: 000000000000011d
RAX: ffffffffffffffda RBX: 00007fa2b42a6080 RCX: 00007fa2b407eb69
RDX: 0000000000000009 RSI: 0000000000000003 RDI: 0000000000000004
RBP: 00007fa2b4101df1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000010000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fa2b42a6080 R15: 00007ffcb30031d8
 </TASK>