syzbot


possible deadlock in ntfs_fallocate

Status: upstream: reported on 2023/11/22 18:34
Reported-by: syzbot+e5a561d1c6c138fdb32a@syzkaller.appspotmail.com
First crash: 215d, last: 14d
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in ntfs_fallocate ntfs3 93 16d 563d 0/27 upstream: reported on 2022/12/09 08:57

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.1.92-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.2/4313 is trying to acquire lock:
ffff88806f7c7700 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline]
ffff88806f7c7700 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fallocate+0x731/0x1020 fs/ntfs3/file.c:650

but task is already holding lock:
ffff88806f7c7b40 (mapping.invalidate_lock#3){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:803 [inline]
ffff88806f7c7b40 (mapping.invalidate_lock#3){++++}-{3:3}, at: ntfs_fallocate+0x33e/0x1020 fs/ntfs3/file.c:583

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (mapping.invalidate_lock#3){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       filemap_invalidate_lock_shared include/linux/fs.h:813 [inline]
       filemap_fault+0x640/0x17e0 mm/filemap.c:3191
       __do_fault+0x136/0x4f0 mm/memory.c:4261
       do_read_fault mm/memory.c:4612 [inline]
       do_fault mm/memory.c:4741 [inline]
       handle_pte_fault mm/memory.c:5013 [inline]
       __handle_mm_fault mm/memory.c:5155 [inline]
       handle_mm_fault+0x3412/0x5340 mm/memory.c:5276
       do_user_addr_fault arch/x86/mm/fault.c:1371 [inline]
       handle_page_fault arch/x86/mm/fault.c:1462 [inline]
       exc_page_fault+0x26f/0x660 arch/x86/mm/fault.c:1518
       asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
       copy_user_short_string+0xa/0x40 arch/x86/lib/copy_user_64.S:231
       copy_user_generic arch/x86/include/asm/uaccess_64.h:37 [inline]
       raw_copy_from_user arch/x86/include/asm/uaccess_64.h:52 [inline]
       _copy_from_user+0xf3/0x170 lib/usercopy.c:23
       copy_from_user include/linux/uaccess.h:161 [inline]
       ioctl_fiemap fs/ioctl.c:209 [inline]
       do_vfs_ioctl+0x5af/0x2a90 fs/ioctl.c:810
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&mm->mmap_lock){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __might_fault+0xbd/0x110 mm/memory.c:5835
       _copy_to_user+0x26/0x130 lib/usercopy.c:36
       copy_to_user include/linux/uaccess.h:169 [inline]
       fiemap_fill_next_extent+0x231/0x410 fs/ioctl.c:144
       ni_fiemap+0x9ae/0x1230 fs/ntfs3/frecord.c:2045
       ntfs_fiemap+0x12e/0x170 fs/ntfs3/file.c:1247
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x18e9/0x2a90 fs/ioctl.c:810
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ni->file.run_lock#3){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ntfs_set_size+0x139/0x1f0 fs/ntfs3/inode.c:841
       ntfs_extend+0x15a/0x4c0 fs/ntfs3/file.c:432
       ntfs_file_write_iter+0x304/0x6d0 fs/ntfs3/file.c:1161
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x7ae/0xba0 fs/read_write.c:584
       ksys_write+0x19c/0x2c0 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ni->ni_lock/4){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline]
       ntfs_fallocate+0x731/0x1020 fs/ntfs3/file.c:650
       vfs_fallocate+0x547/0x6b0 fs/open.c:323
       ksys_fallocate fs/open.c:346 [inline]
       __do_sys_fallocate fs/open.c:354 [inline]
       __se_sys_fallocate fs/open.c:352 [inline]
       __x64_sys_fallocate+0xb9/0x100 fs/open.c:352
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ni->ni_lock/4 --> &mm->mmap_lock --> mapping.invalidate_lock#3

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(mapping.invalidate_lock#3);
                               lock(&mm->mmap_lock);
                               lock(mapping.invalidate_lock#3);
  lock(&ni->ni_lock/4);

 *** DEADLOCK ***

3 locks held by syz-executor.2/4313:
 #0: ffff888023700460 (sb_writers#15){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:3010 [inline]
 #0: ffff888023700460 (sb_writers#15){.+.+}-{0:0}, at: vfs_fallocate+0x4ba/0x6b0 fs/open.c:322
 #1: ffff88806f7c79a0 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff88806f7c79a0 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: ntfs_fallocate+0x2a0/0x1020 fs/ntfs3/file.c:569
 #2: ffff88806f7c7b40 (mapping.invalidate_lock#3){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:803 [inline]
 #2: ffff88806f7c7b40 (mapping.invalidate_lock#3){++++}-{3:3}, at: ntfs_fallocate+0x33e/0x1020 fs/ntfs3/file.c:583

stack backtrace:
CPU: 1 PID: 4313 Comm: syz-executor.2 Not tainted 6.1.92-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
 ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline]
 ntfs_fallocate+0x731/0x1020 fs/ntfs3/file.c:650
 vfs_fallocate+0x547/0x6b0 fs/open.c:323
 ksys_fallocate fs/open.c:346 [inline]
 __do_sys_fallocate fs/open.c:354 [inline]
 __se_sys_fallocate fs/open.c:352 [inline]
 __x64_sys_fallocate+0xb9/0x100 fs/open.c:352
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f463007cf69
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f4630dbb0c8 EFLAGS: 00000246 ORIG_RAX: 000000000000011d
RAX: ffffffffffffffda RBX: 00007f46301b3f80 RCX: 00007f463007cf69
RDX: 0000000000007000 RSI: 0000000000000008 RDI: 0000000000000004
RBP: 00007f46300da6fe R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000007000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007f46301b3f80 R15: 00007ffeaf488078
 </TASK>

Crashes (8):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/06/10 20:53 linux-6.1.y 88690811da69 048c640a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_fallocate
2024/05/16 21:06 linux-6.1.y 909ba1f1b414 c2e07261 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_fallocate
2024/02/01 17:38 linux-6.1.y e5c3b988b827 81024119 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_fallocate
2024/05/15 12:11 linux-6.1.y 909ba1f1b414 94b087b1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/04/08 14:15 linux-6.1.y 347385861c50 53df08b6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/04/08 04:08 linux-6.1.y 347385861c50 ca620dd8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2024/03/10 13:00 linux-6.1.y 61adba85cc40 6ee49f2e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
2023/11/22 18:33 linux-6.1.y 69e434a1cb21 03e12510 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_fallocate
* Struck through repros no longer work on HEAD.