syzbot

loop2: detected capacity change from 0 to 32768
ocfs2: Mounting device (7,2) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
5.15.178-syzkaller #0 Not tainted
------------------------------------------------------
syz.2.134/5253 is trying to acquire lock:
ffff888078b56650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
ffff888078b56650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
ffff888078b56650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x2242/0x4d20 fs/ocfs2/aops.c:1671

but task is already holding lock:
ffff88805a15bf60 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x1cb/0x390 fs/ocfs2/aops.c:1903

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_alloc_sem){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_read_virt_blocks+0x2b3/0xa10 fs/ocfs2/extent_map.c:976
       ocfs2_read_dir_block+0x102/0x5b0 fs/ocfs2/dir.c:508
       ocfs2_dir_foreach_blk_el fs/ocfs2/dir.c:1829 [inline]
       ocfs2_dir_foreach_blk+0x2a8/0x1ba0 fs/ocfs2/dir.c:1915
       ocfs2_dir_foreach fs/ocfs2/dir.c:1925 [inline]
       ocfs2_empty_dir+0x1d1/0x8c0 fs/ocfs2/dir.c:2139
       ocfs2_rename+0x25d5/0x3ea0 fs/ocfs2/namei.c:1499
       vfs_rename+0xd32/0x10f0 fs/namei.c:4832
       do_renameat2+0xe0f/0x1700 fs/namei.c:4985
       __do_sys_renameat2 fs/namei.c:5018 [inline]
       __se_sys_renameat2 fs/namei.c:5015 [inline]
       __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5015
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
       ocfs2_reserve_local_alloc_bits+0xbf9/0x27a0 fs/ocfs2/localalloc.c:668
       ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
       ocfs2_mknod+0x1535/0x2cd0 fs/ocfs2/namei.c:354
       ocfs2_mkdir+0x194/0x430 fs/ocfs2/namei.c:657
       vfs_mkdir+0x3b6/0x590 fs/namei.c:4065
       do_mkdirat+0x260/0x520 fs/namei.c:4090
       __do_sys_mkdirat fs/namei.c:4105 [inline]
       __se_sys_mkdirat fs/namei.c:4103 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
       ocfs2_reserve_local_alloc_bits+0xbf9/0x27a0 fs/ocfs2/localalloc.c:668
       ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
       ocfs2_mknod+0x1535/0x2cd0 fs/ocfs2/namei.c:354
       ocfs2_mkdir+0x194/0x430 fs/ocfs2/namei.c:657
       vfs_mkdir+0x3b6/0x590 fs/namei.c:4065
       do_mkdirat+0x260/0x520 fs/namei.c:4090
       __do_sys_mkdirat fs/namei.c:4105 [inline]
       __se_sys_mkdirat fs/namei.c:4103 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (sb_internal#3){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1813 [inline]
       sb_start_intwrite include/linux/fs.h:1930 [inline]
       ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
       ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
       ocfs2_write_begin_nolock+0x2242/0x4d20 fs/ocfs2/aops.c:1671
       ocfs2_write_begin+0x1fd/0x390 fs/ocfs2/aops.c:1905
       generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785
       __generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3912
       ocfs2_file_write_iter+0x1980/0x2120 fs/ocfs2/file.c:2472
       call_write_iter include/linux/fs.h:2174 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0xacd/0xe50 fs/read_write.c:594
       ksys_write+0x1a2/0x2c0 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  sb_internal#3 --> jbd2_handle --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_alloc_sem);
  lock(sb_internal#3);

 *** DEADLOCK ***

4 locks held by syz.2.134/5253:
 #0: ffff888078e9dc70 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2cb/0x380 fs/file.c:1058
 #1: ffff888078b56460 (sb_writers#15){.+.+}-{0:0}, at: vfs_write+0x29a/0xe50 fs/read_write.c:590
 #2: ffff88805a15c2c8 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
 #2: ffff88805a15c2c8 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x41c/0x2120 fs/ocfs2/file.c:2402
 #3: ffff88805a15bf60 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x1cb/0x390 fs/ocfs2/aops.c:1903

stack backtrace:
CPU: 1 PID: 5253 Comm: syz.2.134 Not tainted 5.15.178-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1813 [inline]
 sb_start_intwrite include/linux/fs.h:1930 [inline]
 ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350
 ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
 ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
 ocfs2_write_begin_nolock+0x2242/0x4d20 fs/ocfs2/aops.c:1671
 ocfs2_write_begin+0x1fd/0x390 fs/ocfs2/aops.c:1905
 generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785
 __generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3912
 ocfs2_file_write_iter+0x1980/0x2120 fs/ocfs2/file.c:2472
 call_write_iter include/linux/fs.h:2174 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0xacd/0xe50 fs/read_write.c:594
 ksys_write+0x1a2/0x2c0 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fbaaf01d169
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fbaace86038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007fbaaf235fa0 RCX: 00007fbaaf01d169
RDX: 0000000000000020 RSI: 0000400000002280 RDI: 0000000000000004
RBP: 00007fbaaf09e2a0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fbaaf235fa0 R15: 00007ffdebf21fd8
 </TASK>