KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker

Status: upstream: reported on 2026/11/21 14:48
Subsystems: wireguard
Labels: prio:high race:harmful
[Documentation on labels]
Reported-by: syzbot+434045ea68296f3f0219@syzkaller.appspotmail.com
First crash: 4d13h, last: 2h18m
✨ AI cause bisection: introduced by (AI job) :
commit e7096c131e5161fa3b8e52a650d7719d2857adfd
Author: Jason A. Donenfeld <Jason@zx2c4.com>
Date: Sun Dec 8 23:27:34 2019 +0000

  net: WireGuard secure network tunnel

✨ AI-generated root cause summary:

In wg_index_hashtable_lookup() (drivers/net/wireguard/peerlookup.c:218), the function mistakenly assigns the return value of wg_peer_get_maybe_zero(entry->peer) to entry->peer instead of setting the caller's output parameter *peer. The entry->peer pointer is intended to remain immutable after keypair/handshake creation. This unintended write causes a data race against concurrent readers (such as PACKET_PEER(skb) in wg_queue_enqueue_per_peer_rx()) and concurrent lookups. If the peer's refcount has dropped to zero, it overwrites entry->peer with NULL, leading to potential NULL-pointer dereference crashes in subsequent teardown code.

▶ ▼ ✨ Full AI root cause analysis
Based on kernel commit 666539eecdf4:

Root Cause Analysis

Involved Functions, Structs, and Files


Bug Mechanism

When initializing a new handshake or keypair in WireGuard (via wg_noise_handshake_init() or keypair_create()), the entry.peer field of struct index_hashtable_entry is set to point to the owning struct wg_peer:

keypair->entry.type = INDEX_HASHTABLE_KEYPAIR;
keypair->entry.peer = peer;

This pointer is intended to be invariant and immutable throughout the lifetime of the index_hashtable_entry.

wg_index_hashtable_lookup() is declared as:

struct index_hashtable_entry *
wg_index_hashtable_lookup(struct index_hashtable *table,
			  const enum index_hashtable_type type_mask,
			  const __le32 index, struct wg_peer **peer);

Its intended purpose is to locate the entry matching the given index, take a reference to entry->peer if its refcount is non-zero, and return that reference to the caller via the output parameter *peer.

However, in drivers/net/wireguard/peerlookup.c:217-223:

	if (likely(entry)) {
		entry->peer = wg_peer_get_maybe_zero(entry->peer);
		if (likely(entry->peer))
			*peer = entry->peer;
		else
			entry = NULL;
	}

Instead of assigning the result of wg_peer_get_maybe_zero(entry->peer) to *peer (or a local variable), the code mistakenly writes it directly back into entry->peer.


How the Data Race is Triggered

  1. CPU 0 (Packet receive path): Incoming ciphertext packets are processed by wg_packet_consume_data(), which calls wg_index_hashtable_lookup(). This executes line 218:
    entry->peer = wg_peer_get_maybe_zero(entry->peer);
    
    This performs an unsynchronized 8-byte write to the shared entry->peer in the hashtable.
  2. CPU 1 (Decryption worker path): Concurrently, a worker thread running wg_packet_decrypt_worker() decrypts a previously received packet belonging to the same keypair and calls wg_queue_enqueue_per_peer_rx():
    struct wg_peer *peer = wg_peer_get(PACKET_PEER(skb));
    
    PACKET_PEER(skb) expands to PACKET_CB(skb)->keypair->entry.peer, performing an unsynchronized 8-byte read of entry->peer.
  3. KCSAN detects this concurrent unsynchronized read and write on entry->peer.

Invariant Violation and Consequences

  1. Unsynchronized Mutation of Immutable Field: entry->peer is shared across cores and is assumed to be read-only after creation. Every invocation of wg_index_hashtable_lookup() writes to it.
  2. Permanent NULL Overwrite on Teardown: If wg_index_hashtable_lookup() is called when peer->refcount has already dropped to 0 (for example, looking up peer->handshake.entry, which remains in the index hashtable until kref_release()), wg_peer_get_maybe_zero(entry->peer) returns NULL. Because of entry->peer = wg_peer_get_maybe_zero(entry->peer);, entry->peer is permanently overwritten with NULL. Subsequent code paths that rely on entry->peer being valid (such as wg_noise_handshake_clear() dereferencing handshake->entry.peer->device) will dereference NULL, triggering a kernel crash (denial of service).
▶ ▼ ✨ AI Jobs (4)
ID Workflow Result Correct Bug Created Started Finished Revision
a165a27a repro-c 💥 KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker 2026/11/20 02:30 2026/11/20 02:30 2026/11/20 03:38 229865fb
65fbc2aa assessment-security DenialOfService: ✅ Exploitable: ❌ FilesystemTrigger: ❌ FuzzingArtifact: ❌ MemoryCorruption: ❌ NetworkNeedsSetup: ✅ NetworkTrigger: ✅ PeripheralTrigger: ❌ RemoteTrigger: ❌ Unprivileged: ❌ UserNamespace: ✅ VMGuestTrigger: ❌ VMHostTrigger: ❌ ❓ KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker 2026/11/17 14:26 2026/11/17 14:26 2026/11/17 14:41 a3e64cfc
3b0df671 bisect-cause ❓ KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker 2026/11/17 14:19 2026/11/17 14:19 2026/11/17 14:55 a3e64cfc
dd1fed4e assessment-kcsan Benign: ❌ ❓ KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker 2026/11/17 14:02 2026/11/17 14:02 2026/11/17 14:55 a3e64cfc
▶ ▼ Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [wireguard?] KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker 0 (1) 2026/11/21 14:48

Sample crash report:
==================================================================
BUG: KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker

read to 0xffff88811b843800 of 8 bytes by task 3420 on cpu 1:
 wg_queue_enqueue_per_peer_rx drivers/net/wireguard/queueing.h:195 [inline]
 wg_packet_decrypt_worker+0x45c/0x670 drivers/net/wireguard/receive.c:503
 process_one_work kernel/workqueue.c:3495 [inline]
 process_scheduled_works+0x582/0xab0 kernel/workqueue.c:3578
 worker_thread+0x56c/0x770 kernel/workqueue.c:3659
 kthread+0x248/0x2a0 kernel/kthread.c:436
 ret_from_fork+0x146/0x330 arch/x86/kernel/process.c:158
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

write to 0xffff88811b843800 of 8 bytes by interrupt on cpu 0:
 wg_index_hashtable_lookup+0xcf/0x120 drivers/net/wireguard/peerlookup.c:218
 wg_packet_consume_data drivers/net/wireguard/receive.c:517 [inline]
 wg_packet_receive+0xa90/0x1260 drivers/net/wireguard/receive.c:576
 wg_receive+0x4e/0x80 drivers/net/wireguard/socket.c:325
 udp_queue_rcv_one_skb+0x85f/0x8b0 net/ipv4/udp.c:2433
 udp_queue_rcv_skb+0x355/0x430 net/ipv4/udp.c:2473
 udp_unicast_rcv_skb+0x196/0x1c0 net/ipv4/udp.c:2621
 udp_rcv+0xa3c/0xf20 net/ipv4/udp.c:2698
 ip_protocol_deliver_rcu+0x43d/0x810 net/ipv4/ip_input.c:207
 ip_local_deliver_finish+0x1f0/0x2e0 net/ipv4/ip_input.c:247
 NF_HOOK include/linux/netfilter.h:325 [inline]
 ip_local_deliver+0xe8/0x1e0 net/ipv4/ip_input.c:268
 dst_input include/net/dst.h:482 [inline]
 ip_rcv_finish+0x188/0x1a0 net/ipv4/ip_input.c:498
 NF_HOOK include/linux/netfilter.h:325 [inline]
 ip_rcv+0x62/0x160 net/ipv4/ip_input.c:618
 __netif_receive_skb_one_core net/core/dev.c:6451 [inline]
 __netif_receive_skb net/core/dev.c:6564 [inline]
 process_backlog+0x349/0x690 net/core/dev.c:6915
 __napi_poll+0x73/0x350 net/core/dev.c:8001
 napi_poll net/core/dev.c:8064 [inline]
 net_rx_action+0x33f/0x850 net/core/dev.c:8221
 handle_softirqs+0x109/0x310 kernel/softirq.c:669
 do_softirq+0x46/0x60 kernel/softirq.c:569
 __local_bh_enable_ip+0x79/0x80 kernel/softirq.c:473
 __raw_read_unlock_bh include/linux/rwlock_api_smp.h:283 [inline]
 _raw_read_unlock_bh+0x2f/0x40 kernel/locking/spinlock.c:319
 wg_socket_send_skb_to_peer+0x10c/0x130 drivers/net/wireguard/socket.c:183
 wg_packet_create_data_done drivers/net/wireguard/send.c:251 [inline]
 wg_packet_tx_worker+0x173/0x340 drivers/net/wireguard/send.c:276
 process_one_work kernel/workqueue.c:3495 [inline]
 process_scheduled_works+0x582/0xab0 kernel/workqueue.c:3578
 worker_thread+0x56c/0x770 kernel/workqueue.c:3659
 kthread+0x248/0x2a0 kernel/kthread.c:436
 ret_from_fork+0x146/0x330 arch/x86/kernel/process.c:158
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

Reported by Kernel Concurrency Sanitizer on:
CPU: 0 UID: 0 PID: 12 Comm: kworker/0:1 Not tainted syzkaller #0 PREEMPT(lazy) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/06/2026
Workqueue: wg-crypt-wg2 wg_packet_tx_worker
==================================================================

Crashes (17):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2026/11/21 13:01 upstream c44104f3642d b2c69459 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/21 13:00 upstream c44104f3642d b2c69459 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/20 22:40 upstream d0f871bfb831 b2c69459 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/20 11:12 upstream 65e4fd942f72 625aa117 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/19 21:07 upstream 8dac6df92a2e 229865fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/19 21:07 upstream 8dac6df92a2e 229865fb .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/19 07:30 upstream 4405c18c95d2 f138241c .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/19 07:29 upstream 4405c18c95d2 f138241c .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/18 20:52 upstream 4405c18c95d2 2006bdcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/18 19:33 upstream 20eef29b7c84 2006bdcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/18 19:33 upstream 20eef29b7c84 2006bdcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/18 07:15 upstream 20eef29b7c84 eb4895d7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/17 22:27 upstream 63fdb511c27a 122f94d5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/17 17:52 upstream 666539eecdf4 122f94d5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/17 17:52 upstream 666539eecdf4 122f94d5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/17 10:44 upstream 666539eecdf4 43af6cac .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
2026/11/17 02:18 upstream 666539eecdf4 a3e64cfc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-kcsan-gce KCSAN: data-race in wg_index_hashtable_lookup / wg_packet_decrypt_worker
* Struck through repros no longer work on HEAD.