syzbot

bond0: (slave syz_tun): Releasing backup interface
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.385/7283 is trying to acquire lock:
ffff888056614ae8 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xaf/0x670 fs/gfs2/quota.c:689

but task is already holding lock:
ffff888054b3cfd0 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1543 [inline]
ffff888054b3cfd0 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1d80/0x2ec0 fs/gfs2/bmap.c:1867

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ip->i_rw_mutex){++++}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       __gfs2_iomap_get+0x15f/0x1400 fs/gfs2/bmap.c:862
       gfs2_iomap_get+0xef/0x170 fs/gfs2/bmap.c:1427
       bh_get+0x251/0x760 fs/gfs2/quota.c:401
       qdsb_get+0x210/0x330 fs/gfs2/quota.c:535
       gfs2_quota_hold+0x198/0x5e0 fs/gfs2/quota.c:615
       gfs2_dinode_dealloc fs/gfs2/super.c:1226 [inline]
       evict_unlinked_inode fs/gfs2/super.c:1437 [inline]
       gfs2_evict_inode+0xeb0/0x1350 fs/gfs2/super.c:1523
       evict+0x4ca/0x8d0 fs/inode.c:705
       do_unlinkat+0x38c/0x590 fs/namei.c:4406
       __do_sys_unlink fs/namei.c:4447 [inline]
       __se_sys_unlink fs/namei.c:4445 [inline]
       __x64_sys_unlink+0x49/0x50 fs/namei.c:4445
       do_syscall_x64 arch/x86/entry/common.c:46 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:76
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2df1/0x7d40 kernel/locking/lockdep.c:5137
       lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x136/0xcc0 kernel/locking/mutex.c:747
       do_qc+0xaf/0x670 fs/gfs2/quota.c:689
       gfs2_quota_change+0x2b9/0x800 fs/gfs2/quota.c:1289
       punch_hole+0x2902/0x2ec0 fs/gfs2/bmap.c:1968
       evict_unlinked_inode fs/gfs2/super.c:1420 [inline]
       gfs2_evict_inode+0xd6a/0x1350 fs/gfs2/super.c:1523
       evict+0x4ca/0x8d0 fs/inode.c:705
       __dentry_kill+0x431/0x650 fs/dcache.c:611
       dentry_kill+0xb8/0x290 fs/dcache.c:-1
       dput+0xfe/0x1e0 fs/dcache.c:918
       __fput+0x5e5/0x970 fs/file_table.c:392
       task_work_run+0x1d4/0x260 kernel/task_work.c:245
       exit_task_work include/linux/task_work.h:43 [inline]
       do_exit+0x95a/0x2460 kernel/exit.c:884
       do_group_exit+0x21b/0x2d0 kernel/exit.c:1026
       get_signal+0x12fc/0x13f0 kernel/signal.c:2902
       arch_do_signal_or_restart+0xc2/0x800 arch/x86/kernel/signal.c:310
       exit_to_user_mode_loop+0x70/0x110 kernel/entry/common.c:174
       exit_to_user_mode_prepare+0xee/0x180 kernel/entry/common.c:210
       irqentry_exit_to_user_mode+0x9/0x30 kernel/entry/common.c:315
       exc_page_fault+0x8c/0x100 arch/x86/mm/fault.c:1519
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:608

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ip->i_rw_mutex);
                               lock(&sdp->sd_quota_mutex);
                               lock(&ip->i_rw_mutex);
  lock(&sdp->sd_quota_mutex);

 *** DEADLOCK ***

3 locks held by syz.0.385/7283:
 #0: ffff888028f6e608 (sb_internal#5){.+.+}-{0:0}, at: gfs2_trans_begin+0x6f/0xe0 fs/gfs2/trans.c:118
 #1: ffff888056615060 (&sdp->sd_log_flush_lock){.+.+}-{3:3}, at: __gfs2_trans_begin+0x517/0x890 fs/gfs2/trans.c:87
 #2: ffff888054b3cfd0 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1543 [inline]
 #2: ffff888054b3cfd0 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1d80/0x2ec0 fs/gfs2/bmap.c:1867

stack backtrace:
CPU: 0 PID: 7283 Comm: syz.0.385 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x18c/0x250 lib/dump_stack.c:106
 check_noncircular+0x2fc/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2df1/0x7d40 kernel/locking/lockdep.c:5137
 lock_acquire+0x19e/0x420 kernel/locking/lockdep.c:5754
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x136/0xcc0 kernel/locking/mutex.c:747
 do_qc+0xaf/0x670 fs/gfs2/quota.c:689
 gfs2_quota_change+0x2b9/0x800 fs/gfs2/quota.c:1289
 punch_hole+0x2902/0x2ec0 fs/gfs2/bmap.c:1968
 evict_unlinked_inode fs/gfs2/super.c:1420 [inline]
 gfs2_evict_inode+0xd6a/0x1350 fs/gfs2/super.c:1523
 evict+0x4ca/0x8d0 fs/inode.c:705
 __dentry_kill+0x431/0x650 fs/dcache.c:611
 dentry_kill+0xb8/0x290 fs/dcache.c:-1
 dput+0xfe/0x1e0 fs/dcache.c:918
 __fput+0x5e5/0x970 fs/file_table.c:392
 task_work_run+0x1d4/0x260 kernel/task_work.c:245
 exit_task_work include/linux/task_work.h:43 [inline]
 do_exit+0x95a/0x2460 kernel/exit.c:884
 do_group_exit+0x21b/0x2d0 kernel/exit.c:1026
 get_signal+0x12fc/0x13f0 kernel/signal.c:2902
 arch_do_signal_or_restart+0xc2/0x800 arch/x86/kernel/signal.c:310
 exit_to_user_mode_loop+0x70/0x110 kernel/entry/common.c:174
 exit_to_user_mode_prepare+0xee/0x180 kernel/entry/common.c:210
 irqentry_exit_to_user_mode+0x9/0x30 kernel/entry/common.c:315
 exc_page_fault+0x8c/0x100 arch/x86/mm/fault.c:1519
 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:608
RIP: 0033:0x7f9f5619ce61
Code: Unable to access opcode bytes at 0x7f9f5619ce37.
RSP: 002b:fffffffffffffea0 EFLAGS: 00010217
RAX: 0000000000000000 RBX: 00007f9f56415fa0 RCX: 00007f9f5619ce59
RDX: 0000000000000000 RSI: fffffffffffffea0 RDI: 0000000000000000
RBP: 00007f9f56232d6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f9f56416038 R14: 00007f9f56415fa0 R15: 00007ffe3a2cb0d8
 </TASK>