syzbot

======================================================
WARNING: possible circular locking dependency detected
5.15.179-syzkaller #0 Not tainted
------------------------------------------------------
syz.4.1385/9310 is trying to acquire lock:
ffff888076fecae0 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xc8/0x720 fs/gfs2/quota.c:678

but task is already holding lock:
ffff88804c4185e8 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1514 [inline]
ffff88804c4185e8 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x27e5/0x3ab0 fs/gfs2/bmap.c:1839

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ip->i_rw_mutex){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       __gfs2_iomap_get+0x178/0x1480 fs/gfs2/bmap.c:858
       gfs2_iomap_get fs/gfs2/bmap.c:1398 [inline]
       gfs2_block_map+0x292/0x830 fs/gfs2/bmap.c:1213
       bh_get+0x26d/0x6a0 fs/gfs2/quota.c:385
       qdsb_get+0x209/0x3b0 fs/gfs2/quota.c:518
       gfs2_quota_hold+0x19d/0x5c0 fs/gfs2/quota.c:604
       punch_hole+0xebd/0x3ab0 fs/gfs2/bmap.c:1800
       gfs2_iomap_end+0x511/0x6d0 fs/gfs2/bmap.c:1159
       iomap_iter+0x222/0xe30 fs/iomap/iter.c:62
       iomap_file_buffered_write+0x748/0x8a0 fs/iomap/buffered-io.c:814
       gfs2_file_buffered_write+0x3e3/0x850 fs/gfs2/file.c:1058
       gfs2_file_write_iter+0x4a2/0xf10 fs/gfs2/file.c:1166
       call_write_iter include/linux/fs.h:2172 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0xacd/0xe50 fs/read_write.c:594
       ksys_write+0x1a2/0x2c0 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       do_qc+0xc8/0x720 fs/gfs2/quota.c:678
       gfs2_quota_change+0x2db/0x8c0 fs/gfs2/quota.c:1295
       punch_hole+0x3446/0x3ab0 fs/gfs2/bmap.c:1940
       gfs2_iomap_end+0x511/0x6d0 fs/gfs2/bmap.c:1159
       iomap_iter+0x222/0xe30 fs/iomap/iter.c:62
       iomap_file_buffered_write+0x748/0x8a0 fs/iomap/buffered-io.c:814
       gfs2_file_buffered_write+0x3e3/0x850 fs/gfs2/file.c:1058
       gfs2_file_write_iter+0x4a2/0xf10 fs/gfs2/file.c:1166
       call_write_iter include/linux/fs.h:2172 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0xacd/0xe50 fs/read_write.c:594
       ksys_write+0x1a2/0x2c0 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ip->i_rw_mutex);
                               lock(&sdp->sd_quota_mutex);
                               lock(&ip->i_rw_mutex);
  lock(&sdp->sd_quota_mutex);

 *** DEADLOCK ***

6 locks held by syz.4.1385/9310:
 #0: ffff888076bbc870 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2cb/0x380 fs/file.c:1058
 #1: ffff88805775c460 (sb_writers#30){.+.+}-{0:0}, at: vfs_write+0x29a/0xe50 fs/read_write.c:590
 #2: ffff88804c418150 (&sb->s_type->i_mutex_key#40){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff88804c418150 (&sb->s_type->i_mutex_key#40){+.+.}-{3:3}, at: gfs2_file_write_iter+0x373/0xf10 fs/gfs2/file.c:1123
 #3: ffff88805775c650 (sb_internal#7){.+.+}-{0:0}, at: gfs2_trans_begin+0x6d/0xe0 fs/gfs2/trans.c:118
 #4: ffff888076fed0a8 (&sdp->sd_log_flush_lock){.+.+}-{3:3}, at: __gfs2_trans_begin+0x55a/0x940 fs/gfs2/trans.c:87
 #5: ffff88804c4185e8 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1514 [inline]
 #5: ffff88804c4185e8 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x27e5/0x3ab0 fs/gfs2/bmap.c:1839

stack backtrace:
CPU: 1 PID: 9310 Comm: syz.4.1385 Not tainted 5.15.179-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 do_qc+0xc8/0x720 fs/gfs2/quota.c:678
 gfs2_quota_change+0x2db/0x8c0 fs/gfs2/quota.c:1295
 punch_hole+0x3446/0x3ab0 fs/gfs2/bmap.c:1940
 gfs2_iomap_end+0x511/0x6d0 fs/gfs2/bmap.c:1159
 iomap_iter+0x222/0xe30 fs/iomap/iter.c:62
 iomap_file_buffered_write+0x748/0x8a0 fs/iomap/buffered-io.c:814
 gfs2_file_buffered_write+0x3e3/0x850 fs/gfs2/file.c:1058
 gfs2_file_write_iter+0x4a2/0xf10 fs/gfs2/file.c:1166
 call_write_iter include/linux/fs.h:2172 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0xacd/0xe50 fs/read_write.c:594
 ksys_write+0x1a2/0x2c0 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f5b41297169
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f5b3f0be038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f5b414b0160 RCX: 00007f5b41297169
RDX: 000000000208e24b RSI: 00002000000004c0 RDI: 000000000000000b
RBP: 00007f5b413182a0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f5b414b0160 R15: 00007ffdd7a09848
 </TASK>