syzbot

======================================================
WARNING: possible circular locking dependency detected
6.1.91-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.3/4733 is trying to acquire lock:
ffff88805685cae0 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xc8/0x720 fs/gfs2/quota.c:682

but task is already holding lock:
ffff888070b74fd0 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x2b7/0x2090 fs/gfs2/bmap.c:679

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ip->i_rw_mutex){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       __gfs2_iomap_get+0x178/0x1480 fs/gfs2/bmap.c:856
       gfs2_iomap_get+0xdb/0x150 fs/gfs2/bmap.c:1396
       bh_get+0x28c/0x810 fs/gfs2/quota.c:385
       qdsb_get+0x209/0x3b0 fs/gfs2/quota.c:522
       gfs2_quota_hold+0x19d/0x5c0 fs/gfs2/quota.c:608
       gfs2_quota_lock+0x9f/0x450 fs/gfs2/quota.c:1076
       gfs2_quota_lock_check fs/gfs2/quota.h:50 [inline]
       __gfs2_fallocate+0xa7d/0x1e00 fs/gfs2/file.c:1297
       gfs2_fallocate+0x358/0x490 fs/gfs2/file.c:1394
       vfs_fallocate+0x547/0x6b0 fs/open.c:323
       ksys_fallocate fs/open.c:346 [inline]
       __do_sys_fallocate fs/open.c:354 [inline]
       __se_sys_fallocate fs/open.c:352 [inline]
       __x64_sys_fallocate+0xb9/0x100 fs/open.c:352
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       do_qc+0xc8/0x720 fs/gfs2/quota.c:682
       gfs2_quota_change+0x2db/0x8c0 fs/gfs2/quota.c:1295
       gfs2_alloc_blocks+0x1e50/0x28c0 fs/gfs2/rgrp.c:2494
       __gfs2_iomap_alloc+0x4f0/0x2090 fs/gfs2/bmap.c:705
       gfs2_iomap_alloc+0x155/0x1f0 fs/gfs2/bmap.c:1409
       fallocate_chunk fs/gfs2/file.c:1191 [inline]
       __gfs2_fallocate+0x1032/0x1e00 fs/gfs2/file.c:1330
       gfs2_fallocate+0x358/0x490 fs/gfs2/file.c:1394
       vfs_fallocate+0x547/0x6b0 fs/open.c:323
       ksys_fallocate fs/open.c:346 [inline]
       __do_sys_fallocate fs/open.c:354 [inline]
       __se_sys_fallocate fs/open.c:352 [inline]
       __x64_sys_fallocate+0xb9/0x100 fs/open.c:352
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ip->i_rw_mutex);
                               lock(&sdp->sd_quota_mutex);
                               lock(&ip->i_rw_mutex);
  lock(&sdp->sd_quota_mutex);

 *** DEADLOCK ***

5 locks held by syz-executor.3/4733:
 #0: ffff888077104460 (sb_writers#25){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:3010 [inline]
 #0: ffff888077104460 (sb_writers#25){.+.+}-{0:0}, at: vfs_fallocate+0x4ba/0x6b0 fs/open.c:322
 #1: ffff888070b74b38 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff888070b74b38 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: gfs2_fallocate+0x198/0x490 fs/gfs2/file.c:1373
 #2: ffff888077104650 (sb_internal#5){.+.+}-{0:0}, at: gfs2_trans_begin+0x6d/0xe0 fs/gfs2/trans.c:118
 #3: ffff88805685d058 (&sdp->sd_log_flush_lock){.+.+}-{3:3}, at: __gfs2_trans_begin+0x558/0x940 fs/gfs2/trans.c:87
 #4: ffff888070b74fd0 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x2b7/0x2090 fs/gfs2/bmap.c:679

stack backtrace:
CPU: 1 PID: 4733 Comm: syz-executor.3 Not tainted 6.1.91-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
 do_qc+0xc8/0x720 fs/gfs2/quota.c:682
 gfs2_quota_change+0x2db/0x8c0 fs/gfs2/quota.c:1295
 gfs2_alloc_blocks+0x1e50/0x28c0 fs/gfs2/rgrp.c:2494
 __gfs2_iomap_alloc+0x4f0/0x2090 fs/gfs2/bmap.c:705
 gfs2_iomap_alloc+0x155/0x1f0 fs/gfs2/bmap.c:1409
 fallocate_chunk fs/gfs2/file.c:1191 [inline]
 __gfs2_fallocate+0x1032/0x1e00 fs/gfs2/file.c:1330
 gfs2_fallocate+0x358/0x490 fs/gfs2/file.c:1394
 vfs_fallocate+0x547/0x6b0 fs/open.c:323
 ksys_fallocate fs/open.c:346 [inline]
 __do_sys_fallocate fs/open.c:354 [inline]
 __se_sys_fallocate fs/open.c:352 [inline]
 __x64_sys_fallocate+0xb9/0x100 fs/open.c:352
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fe3adc7cee9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe3aeadb0c8 EFLAGS: 00000246 ORIG_RAX: 000000000000011d
RAX: ffffffffffffffda RBX: 00007fe3addabf80 RCX: 00007fe3adc7cee9
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000004
RBP: 00007fe3adcc949e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000040000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007fe3addabf80 R15: 00007fff60c29a28
 </TASK>