syzbot


KMSAN: uninit-value in cdc_ncm_set_dgram_size

Status: fixed on 2019/11/29 15:48
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+0631d878823ce2411636@syzkaller.appspotmail.com
Fix commit: 332f989a3b00 CDC-NCM: handle incomplete transfer of MTU
First crash: 1637d, last: 1630d
Discussions (7)
Title Replies (including bot) Last reply
[PATCH 4.19 000/125] 4.19.84-stable review 144 (144) 2019/11/18 14:33
[PATCH 4.14 000/105] 4.14.154-stable review 115 (115) 2019/11/13 09:55
[PATCH 5.3 000/193] 5.3.11-stable review 200 (200) 2019/11/12 18:26
[PATCH 4.9 00/65] 4.9.201-stable review 71 (71) 2019/11/12 18:19
[PATCH 4.4 00/43] 4.4.201-stable review 51 (51) 2019/11/12 18:18
[PATCHv2] CDC-NCM: handle incomplete transfer of MTU 3 (3) 2019/11/07 23:28
KMSAN: uninit-value in cdc_ncm_set_dgram_size 8 (11) 2019/11/06 16:31
Last patch testing requests (2)
Created Duration User Patch Repo Result
2019/11/06 12:39 22m oneukum@suse.com patch https://github.com/google/kmsan.git 96c6c319 OK
2019/11/05 11:27 21m oneukum@suse.com patch https://github.com/google/kmsan.git 96c6c319 OK

Sample crash report:
=====================================================
BUG: KMSAN: uninit-value in cdc_ncm_set_dgram_size+0x6ba/0xbc0 drivers/net/usb/cdc_ncm.c:587
CPU: 0 PID: 11865 Comm: kworker/0:3 Not tainted 5.4.0-rc5+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x191/0x1f0 lib/dump_stack.c:113
 kmsan_report+0x128/0x220 mm/kmsan/kmsan_report.c:108
 __msan_warning+0x73/0xe0 mm/kmsan/kmsan_instr.c:245
 cdc_ncm_set_dgram_size+0x6ba/0xbc0 drivers/net/usb/cdc_ncm.c:587
 cdc_ncm_setup drivers/net/usb/cdc_ncm.c:673 [inline]
 cdc_ncm_bind_common+0x2b54/0x3c50 drivers/net/usb/cdc_ncm.c:928
 cdc_ncm_bind+0x2de/0x330 drivers/net/usb/cdc_ncm.c:1042
 usbnet_probe+0x10d3/0x39d0 drivers/net/usb/usbnet.c:1730
 usb_probe_interface+0xd19/0x1310 drivers/usb/core/driver.c:361
 really_probe+0xd91/0x1f90 drivers/base/dd.c:552
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:721
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:828
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:430
 __device_attach+0x489/0x750 drivers/base/dd.c:894
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:941
 bus_probe_device+0x131/0x390 drivers/base/bus.c:490
 device_add+0x25b5/0x2df0 drivers/base/core.c:2202
 usb_set_configuration+0x309f/0x3710 drivers/usb/core/message.c:2027
 generic_probe+0xe7/0x280 drivers/usb/core/generic.c:210
 usb_probe_device+0x146/0x200 drivers/usb/core/driver.c:266
 really_probe+0xd91/0x1f90 drivers/base/dd.c:552
 driver_probe_device+0x1ba/0x510 drivers/base/dd.c:721
 __device_attach_driver+0x5b8/0x790 drivers/base/dd.c:828
 bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:430
 __device_attach+0x489/0x750 drivers/base/dd.c:894
 device_initial_probe+0x4a/0x60 drivers/base/dd.c:941
 bus_probe_device+0x131/0x390 drivers/base/bus.c:490
 device_add+0x25b5/0x2df0 drivers/base/core.c:2202
 usb_new_device+0x23e5/0x2fb0 drivers/usb/core/hub.c:2536
 hub_port_connect drivers/usb/core/hub.c:5098 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
 port_event drivers/usb/core/hub.c:5359 [inline]
 hub_event+0x581d/0x72f0 drivers/usb/core/hub.c:5441
 process_one_work+0x1572/0x1ef0 kernel/workqueue.c:2269
 process_scheduled_works kernel/workqueue.c:2331 [inline]
 worker_thread+0x189c/0x2460 kernel/workqueue.c:2417
 kthread+0x4b5/0x4f0 kernel/kthread.c:256
 ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:355

Local variable description: ----max_datagram_size@cdc_ncm_set_dgram_size
Variable was created at:
 cdc_ncm_set_dgram_size+0xf5/0xbc0 drivers/net/usb/cdc_ncm.c:564
 cdc_ncm_set_dgram_size+0xf5/0xbc0 drivers/net/usb/cdc_ncm.c:564
=====================================================

Crashes (4):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/10/29 22:31 https://github.com/google/kmsan.git master 96c6c3194b1b 5ea87a66 .config console log report syz C ci-upstream-kmsan-gce
2019/10/29 19:54 https://github.com/google/kmsan.git master 96c6c3194b1b 5ea87a66 .config console log report ci-upstream-kmsan-gce
2019/10/23 18:13 https://github.com/google/kmsan.git master 3c8ca70889aa b602d64b .config console log report ci-upstream-kmsan-gce
2019/10/22 18:44 https://github.com/google/kmsan.git master 3c8ca70889aa 5681358a .config console log report ci-upstream-kmsan-gce
* Struck through repros no longer work on HEAD.