WARNING in uvc_scan_chain

WARNING in uvc_scan_chain_forward
Status: fixed on 2020/02/18 14:31
Reported-by: syzbot+0a5c96772a9b26f2a876@syzkaller.appspotmail.com
Fix commit: 68035c80e129 media: uvcvideo: Avoid cyclic entity chains due to malformed USB descriptors
First crash: 714d, last: 689d

duplicates (1):
Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported	Patched	Status
BUG: corrupted list in uvc_scan_chain_forward	C			2	676d	688d	0/22	closed as dup on 2020/01/10 15:50

Sample crash report:

usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 1-1: Product: syz
usb 1-1: Manufacturer: syz
usb 1-1: SerialNumber: syz
usb 1-1: config 0 descriptor??
uvcvideo: Found UVC 0.00 device syz (18cd:cafe)
------------[ cut here ]------------
list_add double add: new=ffff8881cfef1010, prev=ffff8881cfef1010, next=ffff8881d4fd5c18.
WARNING: CPU: 0 PID: 95 at lib/list_debug.c:29 __list_add_valid+0xb4/0xf0 lib/list_debug.c:29
Kernel panic - not syncing: panic_on_warn set ...
CPU: 0 PID: 95 Comm: kworker/0:2 Not tainted 5.5.0-rc3-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xef/0x16e lib/dump_stack.c:118
 panic+0x2aa/0x6e1 kernel/panic.c:221
 __warn.cold+0x2f/0x30 kernel/panic.c:582
 report_bug+0x27b/0x2f0 lib/bug.c:195
 fixup_bug arch/x86/kernel/traps.c:174 [inline]
 fixup_bug arch/x86/kernel/traps.c:169 [inline]
 do_error_trap+0x12b/0x1e0 arch/x86/kernel/traps.c:267
 do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:286
 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1027
RIP: 0010:__list_add_valid+0xb4/0xf0 lib/list_debug.c:29
Code: 48 c7 c7 20 ef da 85 4c 89 e6 e8 2f b5 2b ff 0f 0b 31 c0 eb c5 48 89 f2 4c 89 e1 48 89 ee 48 c7 c7 a0 ef da 85 e8 14 b5 2b ff <0f> 0b 31 c0 eb aa 48 89 34 24 e8 ed 1f 7f ff 48 8b 34 24 e9 60 ff
RSP: 0018:ffff8881d6177080 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff8881cfef1010 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff812956dd RDI: ffffed103ac2ee02
RBP: ffff8881cfef1010 R08: ffff8881d755c980 R09: ffffed103b686210
R10: ffffed103b68620f R11: ffff8881db43107f R12: ffff8881d4fd5c18
R13: ffff8881cfef1000 R14: dffffc0000000000 R15: ffff8881d4fd5c18
 __list_add include/linux/list.h:60 [inline]
 list_add_tail include/linux/list.h:93 [inline]
 uvc_scan_chain_forward.isra.0+0x4df/0x637 drivers/media/usb/uvc/uvc_driver.c:1526
 uvc_scan_chain drivers/media/usb/uvc/uvc_driver.c:1640 [inline]
 uvc_scan_device drivers/media/usb/uvc/uvc_driver.c:1824 [inline]
 uvc_probe.cold+0x1aee/0x29de drivers/media/usb/uvc/uvc_driver.c:2197
 usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x141f/0x1bc0 drivers/base/core.c:2487
 usb_set_configuration+0xe38/0x16c0 drivers/usb/core/message.c:2023
 generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
 usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
 really_probe+0x281/0x6d0 drivers/base/dd.c:548
 driver_probe_device+0x104/0x210 drivers/base/dd.c:721
 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:828
 bus_for_each_drv+0x162/0x1e0 drivers/base/bus.c:430
 __device_attach+0x217/0x360 drivers/base/dd.c:894
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:490
 device_add+0x141f/0x1bc0 drivers/base/core.c:2487
 usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2537
 hub_port_connect drivers/usb/core/hub.c:5184 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5324 [inline]
 port_event drivers/usb/core/hub.c:5470 [inline]
 hub_event+0x1e59/0x3860 drivers/usb/core/hub.c:5552
 process_one_work+0x92b/0x1530 kernel/workqueue.c:2264
 worker_thread+0x96/0xe20 kernel/workqueue.c:2410
 kthread+0x318/0x420 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (6):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro
ci2-upstream-usb	2020/01/10 01:17	https://github.com/google/kasan.git usb-fuzzer	ae1794106b94	4de4e9f0	.config	log	report	syz	C
ci2-upstream-usb	2019/12/20 19:44	https://github.com/google/kasan.git usb-fuzzer	ecdf2214f472	34011c05	.config	log	report	syz	C
ci2-upstream-usb	2019/12/18 01:19	https://github.com/google/kasan.git usb-fuzzer	d533c9925862	1af3875f	.config	log	report	syz	C
ci2-upstream-usb	2019/12/15 22:23	https://github.com/google/kasan.git usb-fuzzer	4cc037ecf2cb	eef6e580	.config	log	report	syz	C
ci2-upstream-usb	2019/12/27 18:37	https://github.com/google/kasan.git usb-fuzzer	ecdf2214f472	be5c2c81	.config	log	report
ci2-upstream-usb	2019/12/15 22:08	https://github.com/google/kasan.git usb-fuzzer	4cc037ecf2cb	eef6e580	.config	log	report