syzbot


KASAN: slab-out-of-bounds Read in prism2sta_probe_usb

Status: fixed on 2020/10/10 01:52
Subsystems: staging usb
[Documentation on labels]
Reported-by: syzbot+22794221ab96b0bab53a@syzkaller.appspotmail.com
Fix commit: fea22e159d51 staging: wlan-ng: fix out of bounds read in prism2sta_probe_usb()
First crash: 1390d, last: 1359d
Discussions (9)
Title Replies (including bot) Last reply
[PATCH v2 00/63] Introduce strict memcpy() bounds checking 118 (118) 2021/11/24 13:33
[PATCH 4.4 00/46] 4.4.237-rc1 review 53 (53) 2020/09/28 12:17
[PATCH 4.19 00/78] 4.19.146-rc1 review 95 (95) 2020/09/23 18:57
[PATCH 4.14 00/94] 4.14.199-rc1 review 97 (97) 2020/09/22 20:18
[PATCH 4.9 00/70] 4.9.237-rc1 review 73 (73) 2020/09/22 20:17
[PATCH 5.8 000/177] 5.8.10-rc1 review 196 (196) 2020/09/17 17:40
[PATCH 5.4 000/132] 5.4.66-rc1 review 139 (139) 2020/09/15 16:41
[PATCH] staging: wlan-ng: fix out of bounds read in prism2sta_probe_usb() 1 (1) 2020/08/04 14:56
KASAN: slab-out-of-bounds Read in prism2sta_probe_usb 0 (1) 2020/07/30 12:04
Last patch testing requests (2)
Created Duration User Patch Repo Result
2020/08/04 01:27 16m rkovhaev@gmail.com patch https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing OK
2020/08/04 00:25 16m rkovhaev@gmail.com patch https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing OK

Sample crash report:
usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
usb 1-1: config 0 descriptor??
==================================================================
BUG: KASAN: slab-out-of-bounds in usb_endpoint_xfer_bulk include/uapi/linux/usb/ch9.h:518 [inline]
BUG: KASAN: slab-out-of-bounds in usb_endpoint_is_bulk_out include/uapi/linux/usb/ch9.h:586 [inline]
BUG: KASAN: slab-out-of-bounds in prism2sta_probe_usb+0x26c/0x810 drivers/staging/wlan-ng/prism2usb.c:80
Read of size 1 at addr ffff8881cc0c85a3 by task kworker/0:3/138

CPU: 0 PID: 138 Comm: kworker/0:3 Not tainted 5.8.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0xf6/0x16e lib/dump_stack.c:118
 print_address_description.constprop.0+0x1a/0x210 mm/kasan/report.c:383
 __kasan_report mm/kasan/report.c:513 [inline]
 kasan_report.cold+0x37/0x7c mm/kasan/report.c:530
 usb_endpoint_xfer_bulk include/uapi/linux/usb/ch9.h:518 [inline]
 usb_endpoint_is_bulk_out include/uapi/linux/usb/ch9.h:586 [inline]
 prism2sta_probe_usb+0x26c/0x810 drivers/staging/wlan-ng/prism2usb.c:80
 usb_probe_interface+0x315/0x7f0 drivers/usb/core/driver.c:374
 really_probe+0x291/0xc90 drivers/base/dd.c:520
 driver_probe_device+0x26b/0x3d0 drivers/base/dd.c:696
 __device_attach_driver+0x1d1/0x290 drivers/base/dd.c:802
 bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:431
 __device_attach+0x28d/0x430 drivers/base/dd.c:868
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:491
 device_add+0xb09/0x1c10 drivers/base/core.c:2700
 usb_set_configuration+0xf05/0x18a0 drivers/usb/core/message.c:2032
 usb_generic_driver_probe+0xba/0xf2 drivers/usb/core/generic.c:239
 usb_probe_device+0xd9/0x250 drivers/usb/core/driver.c:272
 really_probe+0x291/0xc90 drivers/base/dd.c:520
 driver_probe_device+0x26b/0x3d0 drivers/base/dd.c:696
 __device_attach_driver+0x1d1/0x290 drivers/base/dd.c:802
 bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:431
 __device_attach+0x28d/0x430 drivers/base/dd.c:868
 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:491
 device_add+0xb09/0x1c10 drivers/base/core.c:2700
 usb_new_device.cold+0x71d/0xfd4 drivers/usb/core/hub.c:2554
 hub_port_connect drivers/usb/core/hub.c:5208 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5348 [inline]
 port_event drivers/usb/core/hub.c:5494 [inline]
 hub_event+0x2361/0x4390 drivers/usb/core/hub.c:5576
 process_one_work+0x94c/0x15f0 kernel/workqueue.c:2269
 worker_thread+0x64c/0x1120 kernel/workqueue.c:2415
 kthread+0x392/0x470 kernel/kthread.c:291
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293

Allocated by task 138:
 save_stack+0x1b/0x40 mm/kasan/common.c:48
 set_track mm/kasan/common.c:56 [inline]
 __kasan_kmalloc.constprop.0+0xc2/0xd0 mm/kasan/common.c:494
 kmalloc include/linux/slab.h:560 [inline]
 kzalloc include/linux/slab.h:669 [inline]
 usb_parse_interface drivers/usb/core/config.c:571 [inline]
 usb_parse_configuration drivers/usb/core/config.c:795 [inline]
 usb_get_configuration+0x13d7/0x3a50 drivers/usb/core/config.c:944
 usb_enumerate_device drivers/usb/core/hub.c:2387 [inline]
 usb_new_device+0x42c/0x7a0 drivers/usb/core/hub.c:2523
 hub_port_connect drivers/usb/core/hub.c:5208 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5348 [inline]
 port_event drivers/usb/core/hub.c:5494 [inline]
 hub_event+0x2361/0x4390 drivers/usb/core/hub.c:5576
 process_one_work+0x94c/0x15f0 kernel/workqueue.c:2269
 worker_thread+0x64c/0x1120 kernel/workqueue.c:2415
 kthread+0x392/0x470 kernel/kthread.c:291
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293

Freed by task 16:
 save_stack+0x1b/0x40 mm/kasan/common.c:48
 set_track mm/kasan/common.c:56 [inline]
 kasan_set_free_info mm/kasan/common.c:316 [inline]
 __kasan_slab_free+0x116/0x160 mm/kasan/common.c:455
 slab_free_hook mm/slub.c:1474 [inline]
 slab_free_freelist_hook+0x53/0x140 mm/slub.c:1507
 slab_free mm/slub.c:3072 [inline]
 kfree+0xbc/0x2c0 mm/slub.c:4052
 seccomp_filter_free kernel/seccomp.c:573 [inline]
 seccomp_filter_free kernel/seccomp.c:569 [inline]
 __put_seccomp_filter+0xb3/0xf0 kernel/seccomp.c:583
 free_task+0x76/0x110 kernel/fork.c:476
 __put_task_struct+0x21c/0x3a0 kernel/fork.c:756
 put_task_struct include/linux/sched/task.h:126 [inline]
 delayed_put_task_struct+0x21c/0x360 kernel/exit.c:172
 rcu_do_batch kernel/rcu/tree.c:2414 [inline]
 rcu_core+0x506/0x1840 kernel/rcu/tree.c:2641
 __do_softirq+0x222/0x95b kernel/softirq.c:292

The buggy address belongs to the object at ffff8881cc0c8500
 which belongs to the cache kmalloc-192 of size 192
The buggy address is located 163 bytes inside of
 192-byte region [ffff8881cc0c8500, ffff8881cc0c85c0)
The buggy address belongs to the page:
page:ffffea0007303200 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0
flags: 0x200000000000200(slab)
raw: 0200000000000200 ffffea00073e28c0 0000000400000004 ffff8881da002a00
raw: 0000000000000000 0000000080100010 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8881cc0c8480: fb fb fb fb fb fb fb fb fc fc fc fc fc fc fc fc
 ffff8881cc0c8500: 00 00 00 00 00 

Crashes (8):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/07/30 11:36 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing e3ee0e740c38 b0947553 .config console log report syz C ci2-upstream-usb
2020/08/30 11:38 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 3ed8e1c2ac99 d5a3ae1f .config console log report ci2-upstream-usb
2020/08/26 00:14 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing cb06b385d536 344da168 .config console log report ci2-upstream-usb
2020/08/16 19:15 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 449dc8c97089 5ce13532 .config console log report ci2-upstream-usb
2020/08/06 16:27 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 47ec5303d73e 4ca1c0ea .config console log report ci2-upstream-usb
2020/08/05 21:44 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing e3ee0e740c38 0487ea6f .config console log report ci2-upstream-usb
2020/07/30 14:04 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing e3ee0e740c38 b0947553 .config console log report ci2-upstream-usb
2020/07/30 11:28 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing e3ee0e740c38 b0947553 .config console log report ci2-upstream-usb
* Struck through repros no longer work on HEAD.