syzbot

======================================================
WARNING: possible circular locking dependency detected
6.14.0-rc1-syzkaller-00020-g0de63bb7d919 #0 Not tainted
------------------------------------------------------
acpid/5178 is trying to acquire lock:
ffff888046c39e20 (&hdev->ll_open_lock){+.+.}-{4:4}, at: hid_hw_open+0x25/0x170 drivers/hid/hid-core.c:2387

but task is already holding lock:
ffff8880365892c0 (&dev->mutex#2){+.+.}-{4:4}, at: class_mutex_intr_constructor include/linux/mutex.h:203 [inline]
ffff8880365892c0 (&dev->mutex#2){+.+.}-{4:4}, at: input_open_device+0x5c/0x390 drivers/input/input.c:582

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (
&dev->mutex#2){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xb10 kernel/locking/mutex.c:730
       class_mutex_constructor include/linux/mutex.h:201 [inline]
       input_disconnect_device drivers/input/input.c:702 [inline]
       __input_unregister_device+0x24/0x470 drivers/input/input.c:2219
       input_unregister_device+0xb9/0x100 drivers/input/input.c:2452
       steam_sensors_unregister.part.0+0x10c/0x2c0 drivers/hid/hid-steam.c:935
       steam_sensors_unregister drivers/hid/hid-steam.c:924 [inline]
       steam_client_ll_open+0xbc/0x100 drivers/hid/hid-steam.c:1120
       hid_hw_open+0xe2/0x170 drivers/hid/hid-core.c:2392
       hidraw_open+0x274/0x7e0 drivers/hid/hidraw.c:308
       chrdev_open+0x237/0x6a0 fs/char_dev.c:414
       do_dentry_open+0x735/0x1c40 fs/open.c:955
       vfs_open+0x82/0x3f0 fs/open.c:1085
       do_open fs/namei.c:3830 [inline]
       path_openat+0x1e88/0x2d80 fs/namei.c:3989
       do_filp_open+0x20c/0x470 fs/namei.c:4016
       do_sys_openat2+0x17a/0x1e0 fs/open.c:1427
       do_sys_open fs/open.c:1442 [inline]
       __do_sys_openat fs/open.c:1458 [inline]
       __se_sys_openat fs/open.c:1453 [inline]
       __x64_sys_openat+0x175/0x210 fs/open.c:1453
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&hdev->ll_open_lock){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3163 [inline]
       check_prevs_add kernel/locking/lockdep.c:3282 [inline]
       validate_chain kernel/locking/lockdep.c:3906 [inline]
       __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228
       lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xb10 kernel/locking/mutex.c:730
       hid_hw_open+0x25/0x170 drivers/hid/hid-core.c:2387
       input_open_device+0x230/0x390 drivers/input/input.c:600
       mousedev_open_device+0xe0/0x140 drivers/input/mousedev.c:430
       mousedev_open+0x2ff/0x580 drivers/input/mousedev.c:556
       chrdev_open+0x237/0x6a0 fs/char_dev.c:414
       do_dentry_open+0x735/0x1c40 fs/open.c:955
       vfs_open+0x82/0x3f0 fs/open.c:1085
       do_open fs/namei.c:3830 [inline]
       path_openat+0x1e88/0x2d80 fs/namei.c:3989
       do_filp_open+0x20c/0x470 fs/namei.c:4016
       do_sys_openat2+0x17a/0x1e0 fs/open.c:1427
       do_sys_open fs/open.c:1442 [inline]
       __do_sys_openat fs/open.c:1458 [inline]
       __se_sys_openat fs/open.c:1453 [inline]
       __x64_sys_openat+0x175/0x210 fs/open.c:1453
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&dev->mutex#2);
                               lock(&hdev->ll_open_lock);
                               lock(&dev->mutex#2);
  lock(&hdev->ll_open_lock);

 *** DEADLOCK ***

2 locks held by acpid/5178:
 #0: ffff888012cb6160 (&mousedev->mutex#2){+.+.}-{4:4}, at: mousedev_open_device+0x23/0x140 drivers/input/mousedev.c:423
 #1: ffff8880365892c0 (&dev->mutex#2){+.+.}-{4:4}, at: class_mutex_intr_constructor include/linux/mutex.h:203 [inline]
 #1: ffff8880365892c0 (&dev->mutex#2){+.+.}-{4:4}, at: input_open_device+0x5c/0x390 drivers/input/input.c:582

stack backtrace:
CPU: 1 UID: 0 PID: 5178 Comm: acpid Not tainted 6.14.0-rc1-syzkaller-00020-g0de63bb7d919 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x490/0x760 kernel/locking/lockdep.c:2076
 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2208
 check_prev_add kernel/locking/lockdep.c:3163 [inline]
 check_prevs_add kernel/locking/lockdep.c:3282 [inline]
 validate_chain kernel/locking/lockdep.c:3906 [inline]
 __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228
 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851
 __mutex_lock_common kernel/locking/mutex.c:585 [inline]
 __mutex_lock+0x19b/0xb10 kernel/locking/mutex.c:730
 hid_hw_open+0x25/0x170 drivers/hid/hid-core.c:2387
 input_open_device+0x230/0x390 drivers/input/input.c:600
 mousedev_open_device+0xe0/0x140 drivers/input/mousedev.c:430
 mousedev_open+0x2ff/0x580 drivers/input/mousedev.c:556
 chrdev_open+0x237/0x6a0 fs/char_dev.c:414
 do_dentry_open+0x735/0x1c40 fs/open.c:955
 vfs_open+0x82/0x3f0 fs/open.c:1085
 do_open fs/namei.c:3830 [inline]
 path_openat+0x1e88/0x2d80 fs/namei.c:3989
 do_filp_open+0x20c/0x470 fs/namei.c:4016
 do_sys_openat2+0x17a/0x1e0 fs/open.c:1427
 do_sys_open fs/open.c:1442 [inline]
 __do_sys_openat fs/open.c:1458 [inline]
 __se_sys_openat fs/open.c:1453 [inline]
 __x64_sys_openat+0x175/0x210 fs/open.c:1453
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f04de7499a4
Code: 24 20 48 8d 44 24 30 48 89 44 24 28 64 8b 04 25 18 00 00 00 85 c0 75 2c 44 89 e2 48 89 ee bf 9c ff ff ff b8 01 01 00 00 0f 05 <48> 3d 00 f0 ff ff 76 60 48 8b 15 55 a4 0d 00 f7 d8 64 89 02 48 83
RSP: 002b:00007ffd24510730 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007ffd24510a18 RCX: 00007f04de7499a4
RDX: 0000000000080800 RSI: 00007ffd24510918 RDI: 00000000ffffff9c
RBP: 00007ffd24510918 R08: 00000000000000f4 R09: 00007ffd24510918
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000080800
R13: 0000000000000040 R14: 00007ffd24510a18 R15: 00007ffd24510918
 </TASK>