syzbot


possible deadlock in hid_hw_open

Status: upstream: reported on 2024/08/18 09:24
Subsystems: input usb
[Documentation on labels]
Reported-by: syzbot+2313ca2498b9554beeba@syzkaller.appspotmail.com
First crash: 29d, last: 7h52m
Discussions (2)
Title Replies (including bot) Last reply
[syzbot] Monthly input report (Sep 2024) 0 (1) 2024/09/02 08:17
[syzbot] [input?] [usb?] possible deadlock in hid_hw_open 0 (1) 2024/08/18 09:24

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.11.0-rc7-syzkaller-00117-g761fd871015f #0 Not tainted
------------------------------------------------------
acpid/2531 is trying to acquire lock:
ffff88810a7e1e20 (&hdev->ll_open_lock){+.+.}-{3:3}, at: hid_hw_open+0x25/0x170 drivers/hid/hid-core.c:2361

but task is already holding lock:
ffff888100f552c0 (&dev->mutex#2){+.+.}-{3:3}, at: input_open_device+0x4f/0x320 drivers/input/input.c:597

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&dev->mutex#2){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752
       input_disconnect_device drivers/input/input.c:724 [inline]
       __input_unregister_device+0x24/0x450 drivers/input/input.c:2273
       input_unregister_device+0xb9/0x100 drivers/input/input.c:2514
       steam_input_unregister+0x10c/0x2c0 drivers/hid/hid-steam.c:917
       steam_client_ll_open+0xc9/0x100 drivers/hid/hid-steam.c:1121
       hid_hw_open+0xe2/0x170 drivers/hid/hid-core.c:2366
       hidraw_open+0x274/0x7e0 drivers/hid/hidraw.c:296
       chrdev_open+0x26d/0x6f0 fs/char_dev.c:414
       do_dentry_open+0x957/0x1490 fs/open.c:959
       vfs_open+0x82/0x3f0 fs/open.c:1089
       do_open fs/namei.c:3727 [inline]
       path_openat+0x2141/0x2d20 fs/namei.c:3886
       do_filp_open+0x1dc/0x430 fs/namei.c:3913
       do_sys_openat2+0x17a/0x1e0 fs/open.c:1416
       do_sys_open fs/open.c:1431 [inline]
       __do_sys_openat fs/open.c:1447 [inline]
       __se_sys_openat fs/open.c:1442 [inline]
       __x64_sys_openat+0x175/0x210 fs/open.c:1442
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&hdev->ll_open_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3133 [inline]
       check_prevs_add kernel/locking/lockdep.c:3252 [inline]
       validate_chain kernel/locking/lockdep.c:3868 [inline]
       __lock_acquire+0x24ed/0x3cb0 kernel/locking/lockdep.c:5142
       lock_acquire kernel/locking/lockdep.c:5759 [inline]
       lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5724
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752
       hid_hw_open+0x25/0x170 drivers/hid/hid-core.c:2361
       input_open_device+0x1c9/0x320 drivers/input/input.c:617
       evdev_open_device drivers/input/evdev.c:391 [inline]
       evdev_open+0x533/0x6a0 drivers/input/evdev.c:478
       chrdev_open+0x26d/0x6f0 fs/char_dev.c:414
       do_dentry_open+0x957/0x1490 fs/open.c:959
       vfs_open+0x82/0x3f0 fs/open.c:1089
       do_open fs/namei.c:3727 [inline]
       path_openat+0x2141/0x2d20 fs/namei.c:3886
       do_filp_open+0x1dc/0x430 fs/namei.c:3913
       do_sys_openat2+0x17a/0x1e0 fs/open.c:1416
       do_sys_open fs/open.c:1431 [inline]
       __do_sys_openat fs/open.c:1447 [inline]
       __se_sys_openat fs/open.c:1442 [inline]
       __x64_sys_openat+0x175/0x210 fs/open.c:1442
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&dev->mutex#2);
                               lock(&hdev->ll_open_lock);
                               lock(&dev->mutex#2);
  lock(&hdev->ll_open_lock);

 *** DEADLOCK ***

2 locks held by acpid/2531:
 #0: ffff888119504110 (&evdev->mutex){+.+.}-{3:3}, at: evdev_open_device drivers/input/evdev.c:384 [inline]
 #0: ffff888119504110 (&evdev->mutex){+.+.}-{3:3}, at: evdev_open+0x2ee/0x6a0 drivers/input/evdev.c:478
 #1: ffff888100f552c0 (&dev->mutex#2){+.+.}-{3:3}, at: input_open_device+0x4f/0x320 drivers/input/input.c:597

stack backtrace:
CPU: 0 UID: 0 PID: 2531 Comm: acpid Not tainted 6.11.0-rc7-syzkaller-00117-g761fd871015f #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:93 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:119
 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2186
 check_prev_add kernel/locking/lockdep.c:3133 [inline]
 check_prevs_add kernel/locking/lockdep.c:3252 [inline]
 validate_chain kernel/locking/lockdep.c:3868 [inline]
 __lock_acquire+0x24ed/0x3cb0 kernel/locking/lockdep.c:5142
 lock_acquire kernel/locking/lockdep.c:5759 [inline]
 lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5724
 __mutex_lock_common kernel/locking/mutex.c:608 [inline]
 __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752
 hid_hw_open+0x25/0x170 drivers/hid/hid-core.c:2361
 input_open_device+0x1c9/0x320 drivers/input/input.c:617
 evdev_open_device drivers/input/evdev.c:391 [inline]
 evdev_open+0x533/0x6a0 drivers/input/evdev.c:478
 chrdev_open+0x26d/0x6f0 fs/char_dev.c:414
 do_dentry_open+0x957/0x1490 fs/open.c:959
 vfs_open+0x82/0x3f0 fs/open.c:1089
 do_open fs/namei.c:3727 [inline]
 path_openat+0x2141/0x2d20 fs/namei.c:3886
 do_filp_open+0x1dc/0x430 fs/namei.c:3913
 do_sys_openat2+0x17a/0x1e0 fs/open.c:1416
 do_sys_open fs/open.c:1431 [inline]
 __do_sys_openat fs/open.c:1447 [inline]
 __se_sys_openat fs/open.c:1442 [inline]
 __x64_sys_openat+0x175/0x210 fs/open.c:1442
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f92fb9c39a4
Code: 24 20 48 8d 44 24 30 48 89 44 24 28 64 8b 04 25 18 00 00 00 85 c0 75 2c 44 89 e2 48 89 ee bf 9c ff ff ff b8 01 01 00 00 0f 05 <48> 3d 00 f0 ff ff 76 60 48 8b 15 55 a4 0d 00 f7 d8 64 89 02 48 83
RSP: 002b:00007ffc32d60850 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007ffc32d60b38 RCX: 00007f92fb9c39a4
RDX: 0000000000080800 RSI: 00007ffc32d60a38 RDI: 00000000ffffff9c
RBP: 00007ffc32d60a38 R08: 00000000000000f4 R09: 00007ffc32d60a38
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000080800
R13: 0000000000000040 R14: 00007ffc32d60b38 R15: 00007ffc32d60a38
 </TASK>

Crashes (15):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/09/12 05:59 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 761fd871015f d94c83d8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/09/10 12:25 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing f299cd11f753 784df80e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/09/09 04:08 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c0c11bb87b0 9750182a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/09/08 20:45 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c0c11bb87b0 9750182a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/09/04 10:56 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing d40ae4cdd9a4 9d47f20a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/09/03 05:35 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing fc88bb116179 8045124c .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/08/29 14:52 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing fc88bb116179 9bd464fc .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/08/29 09:41 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing fc88bb116179 ef3de9e8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/08/28 11:56 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing fc88bb116179 6c853ff9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/08/27 21:53 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing fc88bb116179 6c853ff9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/08/27 03:58 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing fc88bb116179 9aee4e0b .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/08/26 19:00 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing fc88bb116179 9aee4e0b .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/08/18 18:35 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 82313624b2ae dbc93b08 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/08/15 12:40 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 82313624b2ae e4bacdaf .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
2024/08/14 09:19 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 82313624b2ae 07a4d4ad .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb possible deadlock in hid_hw_open
* Struck through repros no longer work on HEAD.