syzbot

======================================================
WARNING: possible circular locking dependency detected
6.12.0-rc1-syzkaller-00114-g3840cbe24cf0 #0 Not tainted
------------------------------------------------------
acpid/4665 is trying to acquire lock:
ffff8880590c5e20 (&hdev->ll_open_lock){+.+.}-{3:3}, at: hid_hw_open+0x25/0x170 drivers/hid/hid-core.c:2386

but task is already holding lock:
ffff88807a1132c0 (&dev->mutex#2){+.+.}-{3:3}, at: input_open_device+0x4f/0x320 drivers/input/input.c:597

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&dev->mutex#2){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752
       input_disconnect_device drivers/input/input.c:724 [inline]
       __input_unregister_device+0x24/0x450 drivers/input/input.c:2270
       input_unregister_device+0xb9/0x100 drivers/input/input.c:2511
       steam_input_unregister+0x10c/0x2c0 drivers/hid/hid-steam.c:917
       steam_client_ll_open+0xc9/0x100 drivers/hid/hid-steam.c:1121
       hid_hw_open+0xe5/0x170 drivers/hid/hid-core.c:2391
       hidraw_open+0x274/0x7e0 drivers/hid/hidraw.c:308
       chrdev_open+0x23a/0x6a0 fs/char_dev.c:414
       do_dentry_open+0x6cd/0x1530 fs/open.c:958
       vfs_open+0x82/0x3f0 fs/open.c:1088
       do_open fs/namei.c:3774 [inline]
       path_openat+0x1e6a/0x2d60 fs/namei.c:3933
       do_filp_open+0x1dc/0x430 fs/namei.c:3960
       do_sys_openat2+0x17a/0x1e0 fs/open.c:1415
       do_sys_open fs/open.c:1430 [inline]
       __do_sys_openat fs/open.c:1446 [inline]
       __se_sys_openat fs/open.c:1441 [inline]
       __x64_sys_openat+0x175/0x210 fs/open.c:1441
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&hdev->ll_open_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain kernel/locking/lockdep.c:3904 [inline]
       __lock_acquire+0x250b/0x3ce0 kernel/locking/lockdep.c:5202
       lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5825
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752
       hid_hw_open+0x25/0x170 drivers/hid/hid-core.c:2386
       input_open_device+0x1cc/0x320 drivers/input/input.c:617
       mousedev_open_device+0xe0/0x140 drivers/input/mousedev.c:430
       mousedev_open+0x302/0x580 drivers/input/mousedev.c:556
       chrdev_open+0x23a/0x6a0 fs/char_dev.c:414
       do_dentry_open+0x6cd/0x1530 fs/open.c:958
       vfs_open+0x82/0x3f0 fs/open.c:1088
       do_open fs/namei.c:3774 [inline]
       path_openat+0x1e6a/0x2d60 fs/namei.c:3933
       do_filp_open+0x1dc/0x430 fs/namei.c:3960
       do_sys_openat2+0x17a/0x1e0 fs/open.c:1415
       do_sys_open fs/open.c:1430 [inline]
       __do_sys_openat fs/open.c:1446 [inline]
       __se_sys_openat fs/open.c:1441 [inline]
       __x64_sys_openat+0x175/0x210 fs/open.c:1441
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&dev->mutex#2);
                               lock(&hdev->ll_open_lock);
                               lock(&dev->mutex#2);
  lock(&hdev->ll_open_lock);

 *** DEADLOCK ***

2 locks held by acpid/4665:
 #0: ffff88806ed0a158 (&mousedev->mutex#2){+.+.}-{3:3}, at: mousedev_open_device+0x23/0x140 drivers/input/mousedev.c:423
 #1: ffff88807a1132c0 (&dev->mutex#2){+.+.}-{3:3}, at: input_open_device+0x4f/0x320 drivers/input/input.c:597

stack backtrace:
CPU: 1 UID: 0 PID: 4665 Comm: acpid Not tainted 6.12.0-rc1-syzkaller-00114-g3840cbe24cf0 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x41c/0x610 kernel/locking/lockdep.c:2074
 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain kernel/locking/lockdep.c:3904 [inline]
 __lock_acquire+0x250b/0x3ce0 kernel/locking/lockdep.c:5202
 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5825
 __mutex_lock_common kernel/locking/mutex.c:608 [inline]
 __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752
 hid_hw_open+0x25/0x170 drivers/hid/hid-core.c:2386
 input_open_device+0x1cc/0x320 drivers/input/input.c:617
 mousedev_open_device+0xe0/0x140 drivers/input/mousedev.c:430
 mousedev_open+0x302/0x580 drivers/input/mousedev.c:556
 chrdev_open+0x23a/0x6a0 fs/char_dev.c:414
 do_dentry_open+0x6cd/0x1530 fs/open.c:958
 vfs_open+0x82/0x3f0 fs/open.c:1088
 do_open fs/namei.c:3774 [inline]
 path_openat+0x1e6a/0x2d60 fs/namei.c:3933
 do_filp_open+0x1dc/0x430 fs/namei.c:3960
 do_sys_openat2+0x17a/0x1e0 fs/open.c:1415
 do_sys_open fs/open.c:1430 [inline]
 __do_sys_openat fs/open.c:1446 [inline]
 __se_sys_openat fs/open.c:1441 [inline]
 __x64_sys_openat+0x175/0x210 fs/open.c:1441
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fbdebcd19a4
Code: 24 20 48 8d 44 24 30 48 89 44 24 28 64 8b 04 25 18 00 00 00 85 c0 75 2c 44 89 e2 48 89 ee bf 9c ff ff ff b8 01 01 00 00 0f 05 <48> 3d 00 f0 ff ff 76 60 48 8b 15 55 a4 0d 00 f7 d8 64 89 02 48 83
RSP: 002b:00007ffea30149d0 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007ffea3014cb8 RCX: 00007fbdebcd19a4
RDX: 0000000000080800 RSI: 00007ffea3014bb8 RDI: 00000000ffffff9c
RBP: 00007ffea3014bb8 R08: 00000000000000f4 R09: 00007ffea3014bb8
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000080800
R13: 0000000000000040 R14: 00007ffea3014cb8 R15: 00007ffea3014bb8
 </TASK>