syzbot


KASAN: slab-out-of-bounds Write in bitmap_ip_del

Status: fixed on 2020/02/22 22:27
Subsystems: netfilter
[Documentation on labels]
Reported-by: syzbot+24d0577de55b8b8f6975@syzkaller.appspotmail.com
Fix commit: 32c72165dbd0 netfilter: ipset: use bitmap infrastructure completely
First crash: 1606d, last: 1604d
Cause bisection: introduced by (bisect log) :
commit 0f93242d96ff5a04fe02c4978e8dddb014235971
Author: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue Jul 9 02:53:08 2019 +0000

  nfp: tls: ignore queue limits for delete commands

Crash: general protection fault in send_hsr_supervision_frame (log)
Repro: C syz .config
  
Fix bisection: fixed by (bisect log) :
commit 32c72165dbd0e246e69d16a3ad348a4851afd415
Author: Kadlecsik Jรณzsef <kadlec@blackhole.kfki.hu>
Date: Sun Jan 19 21:06:49 2020 +0000

  netfilter: ipset: use bitmap infrastructure completely

  
Discussions (1)
Title Replies (including bot) Last reply
KASAN: slab-out-of-bounds Write in bitmap_ip_del 0 (3) 2020/02/21 19:05

Sample crash report:
==================================================================
BUG: KASAN: slab-out-of-bounds in test_and_clear_bit include/asm-generic/bitops/instrumented-atomic.h:83 [inline]
BUG: KASAN: slab-out-of-bounds in bitmap_ip_do_del net/netfilter/ipset/ip_set_bitmap_ip.c:89 [inline]
BUG: KASAN: slab-out-of-bounds in bitmap_ip_del+0xdb/0x380 net/netfilter/ipset/ip_set_bitmap_gen.h:182
Write of size 8 at addr ffff8880a787ac80 by task syz-executor285/10373

CPU: 0 PID: 10373 Comm: syz-executor285 Not tainted 5.5.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x197/0x210 lib/dump_stack.c:118
 print_address_description.constprop.0.cold+0xd4/0x30b mm/kasan/report.c:374
 __kasan_report.cold+0x1b/0x41 mm/kasan/report.c:506
 kasan_report+0x12/0x20 mm/kasan/common.c:639
 check_memory_region_inline mm/kasan/generic.c:185 [inline]
 check_memory_region+0x134/0x1a0 mm/kasan/generic.c:192
 __kasan_check_write+0x14/0x20 mm/kasan/common.c:101
 test_and_clear_bit include/asm-generic/bitops/instrumented-atomic.h:83 [inline]
 bitmap_ip_do_del net/netfilter/ipset/ip_set_bitmap_ip.c:89 [inline]
 bitmap_ip_del+0xdb/0x380 net/netfilter/ipset/ip_set_bitmap_gen.h:182
 bitmap_ip_uadt+0x73e/0xa10 net/netfilter/ipset/ip_set_bitmap_ip.c:186
 call_ad+0x1a0/0x5a0 net/netfilter/ipset/ip_set_core.c:1716
 ip_set_ad.isra.0+0x572/0xb20 net/netfilter/ipset/ip_set_core.c:1804
 ip_set_udel+0x3a/0x50 net/netfilter/ipset/ip_set_core.c:1838
 nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229
 netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477
 nfnetlink_rcv+0x1ba/0x460 net/netfilter/nfnetlink.c:563
 netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
 netlink_unicast+0x58c/0x7d0 net/netlink/af_netlink.c:1328
 netlink_sendmsg+0x91c/0xea0 net/netlink/af_netlink.c:1917
 sock_sendmsg_nosec net/socket.c:639 [inline]
 sock_sendmsg+0xd7/0x130 net/socket.c:659
 ____sys_sendmsg+0x753/0x880 net/socket.c:2330
 ___sys_sendmsg+0x100/0x170 net/socket.c:2384
 __sys_sendmsg+0x105/0x1d0 net/socket.c:2417
 __do_sys_sendmsg net/socket.c:2426 [inline]
 __se_sys_sendmsg net/socket.c:2424 [inline]
 __x64_sys_sendmsg+0x78/0xb0 net/socket.c:2424
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x440689
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffeeb6954a8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440689
RDX: 0000000000000000 RSI: 0000000020000080 RDI: 0000000000000004
RBP: 00000000006ca018 R08: 000000000000001c R09: 00000000004002c8
R10: 0000000000000001 R11: 0000000000000246 R12: 0000000000401f10
R13: 0000000000401fa0 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 10373:
 save_stack+0x23/0x90 mm/kasan/common.c:72
 set_track mm/kasan/common.c:80 [inline]
 __kasan_kmalloc mm/kasan/common.c:513 [inline]
 __kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:486
 kasan_kmalloc+0x9/0x10 mm/kasan/common.c:527
 __do_kmalloc mm/slab.c:3656 [inline]
 __kmalloc+0x163/0x770 mm/slab.c:3665
 kmalloc include/linux/slab.h:561 [inline]
 kzalloc include/linux/slab.h:670 [inline]
 ip_set_alloc+0x38/0x5e net/netfilter/ipset/ip_set_core.c:255
 init_map_ip net/netfilter/ipset/ip_set_bitmap_ip.c:223 [inline]
 bitmap_ip_create+0x6ec/0xc20 net/netfilter/ipset/ip_set_bitmap_ip.c:327
 ip_set_create+0x6f1/0x1500 net/netfilter/ipset/ip_set_core.c:1111
 nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229
 netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477
 nfnetlink_rcv+0x1ba/0x460 net/netfilter/nfnetlink.c:563
 netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
 netlink_unicast+0x58c/0x7d0 net/netlink/af_netlink.c:1328
 netlink_sendmsg+0x91c/0xea0 net/netlink/af_netlink.c:1917
 sock_sendmsg_nosec net/socket.c:639 [inline]
 sock_sendmsg+0xd7/0x130 net/socket.c:659
 ____sys_sendmsg+0x753/0x880 net/socket.c:2330
 ___sys_sendmsg+0x100/0x170 net/socket.c:2384
 __sys_sendmsg+0x105/0x1d0 net/socket.c:2417
 __do_sys_sendmsg net/socket.c:2426 [inline]
 __se_sys_sendmsg net/socket.c:2424 [inline]
 __x64_sys_sendmsg+0x78/0xb0 net/socket.c:2424
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 10139:
 save_stack+0x23/0x90 mm/kasan/common.c:72
 set_track mm/kasan/common.c:80 [inline]
 kasan_set_free_info mm/kasan/common.c:335 [inline]
 __kasan_slab_free+0x102/0x150 mm/kasan/common.c:474
 kasan_slab_free+0xe/0x10 mm/kasan/common.c:483
 __cache_free mm/slab.c:3426 [inline]
 kfree+0x10a/0x2c0 mm/slab.c:3757
 tomoyo_path_perm+0x24e/0x430 security/tomoyo/file.c:842
 tomoyo_inode_getattr+0x1d/0x30 security/tomoyo/tomoyo.c:129
 security_inode_getattr+0xf2/0x150 security/security.c:1222
 vfs_getattr+0x25/0x70 fs/stat.c:115
 vfs_statx+0x157/0x200 fs/stat.c:191
 vfs_stat include/linux/fs.h:3249 [inline]
 __do_sys_newstat+0xa4/0x130 fs/stat.c:341
 __se_sys_newstat fs/stat.c:337 [inline]
 __x64_sys_newstat+0x54/0x80 fs/stat.c:337
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff8880a787ac80
 which belongs to the cache kmalloc-32 of size 32
The buggy address is located 0 bytes inside of
 32-byte region [ffff8880a787ac80, ffff8880a787aca0)
The buggy address belongs to the page:
page:ffffea00029e1e80 refcount:1 mapcount:0 mapping:ffff8880aa4001c0 index:0xffff8880a787afc1
raw: 00fffe0000000200 ffffea00026834c8 ffffea000279e0c8 ffff8880aa4001c0
raw: ffff8880a787afc1 ffff8880a787a000 0000000100000020 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8880a787ab80: 00 00 01 fc fc fc fc fc fb fb fb fb fc fc fc fc
 ffff8880a787ac00: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
>ffff8880a787ac80: 04 fc fc fc fc fc fc fc fb fb fb fb fc fc fc fc
                   ^
 ffff8880a787ad00: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
 ffff8880a787ad80: fb fb fb fb fc fc fc fc fb fb fb fb fc fc fc fc
==================================================================

Crashes (7):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/01/22 05:27 upstream d96d875ef5dd 8eda0b95 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/01/21 23:13 upstream d96d875ef5dd 8eda0b95 .config console log report syz C ci-upstream-kasan-gce-root
2020/01/21 01:38 upstream d96d875ef5dd d2557fb5 .config console log report syz C ci-upstream-kasan-gce
2020/01/20 21:55 upstream def9d2780727 d2557fb5 .config console log report syz C ci-upstream-kasan-gce-smack-root
2020/01/20 17:39 upstream def9d2780727 d2557fb5 .config console log report syz C ci-upstream-kasan-gce-386
2020/01/20 06:37 net-old 09d4f10a5e78 0342f8c7 .config console log report syz C ci-upstream-net-this-kasan-gce
2020/01/20 06:25 net-next-old 7f013edebaa4 0342f8c7 .config console log report syz C ci-upstream-net-kasan-gce
* Struck through repros no longer work on HEAD.