syzbot


possible deadlock in pipe_write (2)

Status: upstream: reported on 2025/02/05 22:22
Subsystems: autofs
[Documentation on labels]
Reported-by: syzbot+25dd3743576b83be4773@syzkaller.appspotmail.com
First crash: 54d, last: 47d
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [autofs?] possible deadlock in pipe_write (2) 0 (1) 2025/02/05 22:22
Similar bugs (3)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in pipe_write missing-backport origin:lts-only C done 106 353d 668d 0/3 auto-obsoleted due to no activity on 2024/10/06 23:47
linux-6.1 possible deadlock in pipe_write origin:upstream missing-backport C inconclusive 31 354d 724d 0/3 upstream: reported C repro on 2023/04/03 17:51
upstream possible deadlock in pipe_write fs C inconclusive 181 425d 1103d 25/28 fixed on 2024/01/30 15:47

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.14.0-rc1-syzkaller-00235-g9946eaf552b1 #0 Not tainted
------------------------------------------------------
syz.1.2288/14056 is trying to acquire lock:
ffff88802913b468 (&pipe->mutex){+.+.}-{4:4}, at: pipe_write+0x166/0x1b30 fs/pipe.c:456

but task is already holding lock:
ffff88807b93b140 (&sbi->pipe_mutex){+.+.}-{4:4}, at: autofs_write fs/autofs/waitq.c:55 [inline]
ffff88807b93b140 (&sbi->pipe_mutex){+.+.}-{4:4}, at: autofs_notify_daemon+0x499/0xd50 fs/autofs/waitq.c:164

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&sbi->pipe_mutex){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xb10 kernel/locking/mutex.c:730
       autofs_write fs/autofs/waitq.c:55 [inline]
       autofs_notify_daemon+0x499/0xd50 fs/autofs/waitq.c:164
       autofs_wait+0x10b5/0x1a30 fs/autofs/waitq.c:426
       autofs_mount_wait+0x132/0x380 fs/autofs/root.c:255
       autofs_d_automount+0x390/0x7f0 fs/autofs/root.c:401
       follow_automount fs/namei.c:1454 [inline]
       __traverse_mounts+0x192/0x760 fs/namei.c:1499
       traverse_mounts fs/namei.c:1528 [inline]
       handle_mounts fs/namei.c:1631 [inline]
       step_into+0x593/0x2220 fs/namei.c:1952
       walk_component+0xfc/0x5b0 fs/namei.c:2120
       lookup_last fs/namei.c:2612 [inline]
       path_lookupat+0x17f/0x770 fs/namei.c:2636
       filename_lookup+0x221/0x5f0 fs/namei.c:2665
       kern_path+0x35/0x50 fs/namei.c:2773
       lookup_bdev+0xd9/0x280 block/bdev.c:1163
       resume_store+0x1d8/0x460 kernel/power/hibernate.c:1247
       kobj_attr_store+0x55/0x80 lib/kobject.c:840
       sysfs_kf_write+0x117/0x170 fs/sysfs/file.c:139
       kernfs_fop_write_iter+0x33d/0x500 fs/kernfs/file.c:334
       new_sync_write fs/read_write.c:586 [inline]
       vfs_write+0x5ae/0x1150 fs/read_write.c:679
       ksys_write+0x12b/0x250 fs/read_write.c:731
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&of->mutex){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xb10 kernel/locking/mutex.c:730
       kernfs_fop_write_iter+0x27b/0x500 fs/kernfs/file.c:325
       iter_file_splice_write+0x90f/0x10b0 fs/splice.c:743
       do_splice_from fs/splice.c:941 [inline]
       do_splice+0x146a/0x1f70 fs/splice.c:1354
       __do_splice+0x327/0x360 fs/splice.c:1436
       __do_sys_splice fs/splice.c:1639 [inline]
       __se_sys_splice fs/splice.c:1621 [inline]
       __x64_sys_splice+0x187/0x250 fs/splice.c:1621
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&pipe->mutex){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3163 [inline]
       check_prevs_add kernel/locking/lockdep.c:3282 [inline]
       validate_chain kernel/locking/lockdep.c:3906 [inline]
       __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228
       lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xb10 kernel/locking/mutex.c:730
       pipe_write+0x166/0x1b30 fs/pipe.c:456
       __kernel_write_iter+0x71f/0xa90 fs/read_write.c:612
       __kernel_write+0xf6/0x140 fs/read_write.c:632
       autofs_write fs/autofs/waitq.c:57 [inline]
       autofs_notify_daemon+0x4ce/0xd50 fs/autofs/waitq.c:164
       autofs_wait+0x10b5/0x1a30 fs/autofs/waitq.c:426
       autofs_mount_wait+0x132/0x380 fs/autofs/root.c:255
       autofs_d_automount+0x390/0x7f0 fs/autofs/root.c:401
       follow_automount fs/namei.c:1454 [inline]
       __traverse_mounts+0x192/0x760 fs/namei.c:1499
       traverse_mounts fs/namei.c:1528 [inline]
       handle_mounts fs/namei.c:1631 [inline]
       step_into+0x593/0x2220 fs/namei.c:1952
       walk_component+0xfc/0x5b0 fs/namei.c:2120
       lookup_last fs/namei.c:2612 [inline]
       path_lookupat+0x17f/0x770 fs/namei.c:2636
       filename_lookup+0x221/0x5f0 fs/namei.c:2665
       kern_path+0x35/0x50 fs/namei.c:2773
       lookup_bdev+0xd9/0x280 block/bdev.c:1163
       resume_store+0x1d8/0x460 kernel/power/hibernate.c:1247
       kobj_attr_store+0x55/0x80 lib/kobject.c:840
       sysfs_kf_write+0x117/0x170 fs/sysfs/file.c:139
       kernfs_fop_write_iter+0x33d/0x500 fs/kernfs/file.c:334
       new_sync_write fs/read_write.c:586 [inline]
       vfs_write+0x5ae/0x1150 fs/read_write.c:679
       ksys_write+0x12b/0x250 fs/read_write.c:731
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &pipe->mutex --> &of->mutex --> &sbi->pipe_mutex

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sbi->pipe_mutex);
                               lock(&of->mutex);
                               lock(&sbi->pipe_mutex);
  lock(&pipe->mutex);

 *** DEADLOCK ***

5 locks held by syz.1.2288/14056:
 #0: ffff88801ce92d38 (&f->f_pos_lock){+.+.}-{4:4}, at: fdget_pos+0x267/0x390 fs/file.c:1192
 #1: ffff888024966420 (sb_writers#9){.+.+}-{0:0}, at: ksys_write+0x12b/0x250 fs/read_write.c:731
 #2: ffff88802887e088 (&of->mutex){+.+.}-{4:4}, at: kernfs_fop_write_iter+0x27b/0x500 fs/kernfs/file.c:325
 #3: ffff888140aca788 (kn->active#66){.+.+}-{0:0}, at: kernfs_fop_write_iter+0x29e/0x500 fs/kernfs/file.c:326
 #4: ffff88807b93b140 (&sbi->pipe_mutex){+.+.}-{4:4}, at: autofs_write fs/autofs/waitq.c:55 [inline]
 #4: ffff88807b93b140 (&sbi->pipe_mutex){+.+.}-{4:4}, at: autofs_notify_daemon+0x499/0xd50 fs/autofs/waitq.c:164

stack backtrace:
CPU: 0 UID: 0 PID: 14056 Comm: syz.1.2288 Not tainted 6.14.0-rc1-syzkaller-00235-g9946eaf552b1 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x490/0x760 kernel/locking/lockdep.c:2076
 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2208
 check_prev_add kernel/locking/lockdep.c:3163 [inline]
 check_prevs_add kernel/locking/lockdep.c:3282 [inline]
 validate_chain kernel/locking/lockdep.c:3906 [inline]
 __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228
 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851
 __mutex_lock_common kernel/locking/mutex.c:585 [inline]
 __mutex_lock+0x19b/0xb10 kernel/locking/mutex.c:730
 pipe_write+0x166/0x1b30 fs/pipe.c:456
 __kernel_write_iter+0x71f/0xa90 fs/read_write.c:612
 __kernel_write+0xf6/0x140 fs/read_write.c:632
 autofs_write fs/autofs/waitq.c:57 [inline]
 autofs_notify_daemon+0x4ce/0xd50 fs/autofs/waitq.c:164
 autofs_wait+0x10b5/0x1a30 fs/autofs/waitq.c:426
 autofs_mount_wait+0x132/0x380 fs/autofs/root.c:255
 autofs_d_automount+0x390/0x7f0 fs/autofs/root.c:401
 follow_automount fs/namei.c:1454 [inline]
 __traverse_mounts+0x192/0x760 fs/namei.c:1499
 traverse_mounts fs/namei.c:1528 [inline]
 handle_mounts fs/namei.c:1631 [inline]
 step_into+0x593/0x2220 fs/namei.c:1952
 walk_component+0xfc/0x5b0 fs/namei.c:2120
 lookup_last fs/namei.c:2612 [inline]
 path_lookupat+0x17f/0x770 fs/namei.c:2636
 filename_lookup+0x221/0x5f0 fs/namei.c:2665
 kern_path+0x35/0x50 fs/namei.c:2773
 lookup_bdev+0xd9/0x280 block/bdev.c:1163
 resume_store+0x1d8/0x460 kernel/power/hibernate.c:1247
 kobj_attr_store+0x55/0x80 lib/kobject.c:840
 sysfs_kf_write+0x117/0x170 fs/sysfs/file.c:139
 kernfs_fop_write_iter+0x33d/0x500 fs/kernfs/file.c:334
 new_sync_write fs/read_write.c:586 [inline]
 vfs_write+0x5ae/0x1150 fs/read_write.c:679
 ksys_write+0x12b/0x250 fs/read_write.c:731
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7ff76658cde9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff76737c038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007ff7667a5fa0 RCX: 00007ff76658cde9
RDX: 0000000000000012 RSI: 0000400000000040 RDI: 0000000000000003
RBP: 00007ff76660e2a0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007ff7667a5fa0 R15: 00007ffc4d5e4c08
 </TASK>
block device autoloading is deprecated and will be removed.
PM: Image not found (code -22)

Crashes (2):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/02/09 08:25 upstream 9946eaf552b1 ef44b750 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root possible deadlock in pipe_write
2025/02/01 22:20 upstream 69e858e0b8b2 0dff8567 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-smack-root possible deadlock in pipe_write
* Struck through repros no longer work on HEAD.