syzbot


possible deadlock in hfsplus_block_free (3)

Status: upstream: reported on 2025/02/16 19:51
Reported-by: syzbot+29722e72765863ebe740@syzkaller.appspotmail.com
First crash: 23d, last: 15d
Similar bugs (8)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in hfsplus_block_free (2) 4 277d 277d 0/3 auto-obsoleted due to no activity on 2024/09/15 13:42
linux-4.14 possible deadlock in hfsplus_block_free hfsplus 10 746d 831d 0/1 upstream: reported on 2022/12/01 19:36
linux-5.15 possible deadlock in hfsplus_block_free (3) 2 7d03h 8d22h 0/3 upstream: reported on 2025/03/03 05:44
linux-4.19 possible deadlock in hfsplus_block_free hfsplus 20 737d 828d 0/1 upstream: reported on 2022/12/04 19:32
upstream possible deadlock in hfsplus_block_free hfs C inconclusive error 275 3d15h 833d 0/28 upstream: reported C repro on 2022/11/29 08:32
linux-5.15 possible deadlock in hfsplus_block_free 20 505d 708d 0/3 auto-obsoleted due to no activity on 2024/01/31 18:41
linux-5.15 possible deadlock in hfsplus_block_free (2) 1 277d 277d 0/3 auto-obsoleted due to no activity on 2024/09/15 11:28
linux-6.1 possible deadlock in hfsplus_block_free 27 431d 695d 0/3 auto-obsoleted due to no activity on 2024/04/14 19:02

Sample crash report:
loop5: detected capacity change from 0 to 1024
hfsplus: xattr search failed
======================================================
WARNING: possible circular locking dependency detected
6.1.129-syzkaller #0 Not tainted
------------------------------------------------------
syz.5.335/5857 is trying to acquire lock:
ffff0000c6e018f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_free+0xcc/0x4b0 fs/hfsplus/bitmap.c:182

but task is already holding lock:
ffff0000dc12cb48 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x24c/0xa18 fs/hfsplus/extents.c:577

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       hfsplus_get_block+0x2c4/0x1168 fs/hfsplus/extents.c:260
       block_read_full_folio+0x2f4/0x98c fs/buffer.c:2271
       hfsplus_read_folio+0x28/0x38 fs/hfsplus/inode.c:28
       filemap_read_folio+0x14c/0x39c mm/filemap.c:2489
       do_read_cache_folio+0x24c/0x544 mm/filemap.c:3626
       do_read_cache_page mm/filemap.c:3668 [inline]
       read_cache_page+0x6c/0x180 mm/filemap.c:3677
       read_mapping_page include/linux/pagemap.h:791 [inline]
       hfsplus_block_allocate+0xe0/0x818 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0x770/0x14cc fs/hfsplus/extents.c:469
       hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x340/0x13b4 fs/buffer.c:1991
       __block_write_begin fs/buffer.c:2041 [inline]
       block_write_begin fs/buffer.c:2102 [inline]
       cont_write_begin+0x5c0/0x7d8 fs/buffer.c:2456
       hfsplus_write_begin+0x98/0xe4 fs/hfsplus/inode.c:52
       generic_perform_write+0x278/0x55c mm/filemap.c:3845
       __generic_file_write_iter+0x168/0x388 mm/filemap.c:3973
       generic_file_write_iter+0xb8/0x2b4 mm/filemap.c:4005
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x610/0x91c fs/read_write.c:584
       ksys_write+0x15c/0x26c fs/read_write.c:637
       __do_sys_write fs/read_write.c:649 [inline]
       __se_sys_write fs/read_write.c:646 [inline]
       __arm64_sys_write+0x7c/0x90 fs/read_write.c:646
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (&sbi->alloc_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       hfsplus_block_free+0xcc/0x4b0 fs/hfsplus/bitmap.c:182
       hfsplus_free_extents+0x148/0x8d4 fs/hfsplus/extents.c:363
       hfsplus_file_truncate+0x674/0xa18 fs/hfsplus/extents.c:592
       hfsplus_delete_inode+0x154/0x200
       hfsplus_unlink+0x414/0x6a0 fs/hfsplus/dir.c:405
       vfs_unlink+0x2f0/0x508 fs/namei.c:4322
       do_unlinkat+0x4cc/0x70c fs/namei.c:4390
       __do_sys_unlinkat fs/namei.c:4433 [inline]
       __se_sys_unlinkat fs/namei.c:4426 [inline]
       __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4426
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&sbi->alloc_mutex);

 *** DEADLOCK ***

5 locks held by syz.5.335/5857:
 #0: ffff0000dac5c460 (sb_writers#28){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393
 #1: ffff0000dc12c680 (&type->i_mutex_dir_key#12/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
 #1: ffff0000dc12c680 (&type->i_mutex_dir_key#12/1){+.+.}-{3:3}, at: do_unlinkat+0x2d0/0x70c fs/namei.c:4373
 #2: ffff0000dc12cd40 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff0000dc12cd40 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: vfs_unlink+0xd8/0x508 fs/namei.c:4311
 #3: ffff0000c6e01998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x144/0x6a0 fs/hfsplus/dir.c:370
 #4: ffff0000dc12cb48 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x24c/0xa18 fs/hfsplus/extents.c:577

stack backtrace:
CPU: 0 PID: 5857 Comm: syz.5.335 Not tainted 6.1.129-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
 __mutex_lock kernel/locking/mutex.c:747 [inline]
 mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
 hfsplus_block_free+0xcc/0x4b0 fs/hfsplus/bitmap.c:182
 hfsplus_free_extents+0x148/0x8d4 fs/hfsplus/extents.c:363
 hfsplus_file_truncate+0x674/0xa18 fs/hfsplus/extents.c:592
 hfsplus_delete_inode+0x154/0x200
 hfsplus_unlink+0x414/0x6a0 fs/hfsplus/dir.c:405
 vfs_unlink+0x2f0/0x508 fs/namei.c:4322
 do_unlinkat+0x4cc/0x70c fs/namei.c:4390
 __do_sys_unlinkat fs/namei.c:4433 [inline]
 __se_sys_unlinkat fs/namei.c:4426 [inline]
 __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4426
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

Crashes (3):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/02/25 03:59 linux-6.1.y 3a8358583626 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_block_free
2025/02/16 23:55 linux-6.1.y 0cbb5f65e52f 40a34ec9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_block_free
2025/02/16 19:50 linux-6.1.y 0cbb5f65e52f 40a34ec9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_block_free
* Struck through repros no longer work on HEAD.