syzbot


KASAN: use-after-free Read in snd_timer_resolution

Status: fixed on 2020/02/18 14:31
Subsystems: sound
[Documentation on labels]
Reported-by: syzbot+2b2ef983f973e5c40943@syzkaller.appspotmail.com
Fix commit: 60adcfde92fa ALSA: seq: Fix racy access for queue timer in proc read
First crash: 1641d, last: 1623d
Discussions (8)
Title Replies (including bot) Last reply
[PATCH 3.16 000/245] 3.16.83-rc1 review 260 (260) 2020/04/24 17:54
[PATCH 4.14 00/65] 4.14.167-stable review 73 (73) 2020/04/20 14:15
Re: KASAN: use-after-free Read in snd_timer_resolution 1 (1) 2020/02/03 06:43
KASAN: use-after-free Read in snd_timer_resolution 0 (2) 2020/02/02 12:56
[PATCH 5.4 000/222] 5.4.14-stable review 238 (238) 2020/01/26 16:57
[PATCH 4.19 000/103] 4.19.98-stable review 108 (108) 2020/01/22 20:53
[PATCH 4.4 00/76] 4.4.211-stable review 81 (81) 2020/01/22 20:52
[PATCH 4.9 00/97] 4.9.211-stable review 102 (102) 2020/01/22 20:52
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.19 KASAN: use-after-free Read in snd_timer_resolution C done 2 1637d 1637d 1/1 fixed on 2020/02/19 00:41
linux-4.14 KASAN: use-after-free Read in snd_timer_resolution C done 1 1634d 1634d 1/1 fixed on 2020/02/21 03:21

Sample crash report:
==================================================================
BUG: KASAN: use-after-free in snd_timer_resolution+0xf1/0x110 sound/core/timer.c:487
Read of size 8 at addr ffff88809e0f5a00 by task syz-executor911/9849

CPU: 1 PID: 9849 Comm: syz-executor911 Not tainted 5.5.0-rc6-next-20200116-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x197/0x210 lib/dump_stack.c:118
 print_address_description.constprop.0.cold+0xd4/0x30b mm/kasan/report.c:374
 __kasan_report.cold+0x1b/0x32 mm/kasan/report.c:506
 kasan_report+0x12/0x20 mm/kasan/common.c:641
 __asan_report_load8_noabort+0x14/0x20 mm/kasan/generic_report.c:135
 snd_timer_resolution+0xf1/0x110 sound/core/timer.c:487
 snd_seq_info_timer_read+0x95/0x2f1 sound/core/seq/seq_timer.c:480
 snd_info_seq_show+0xcb/0x120 sound/core/info.c:362
 seq_read+0x4ca/0x1170 fs/seq_file.c:229
 proc_reg_read+0x1f8/0x2b0 fs/proc/inode.c:223
 do_loop_readv_writev fs/read_write.c:714 [inline]
 do_loop_readv_writev fs/read_write.c:701 [inline]
 do_iter_read+0x4a4/0x660 fs/read_write.c:935
 vfs_readv+0xf0/0x160 fs/read_write.c:997
 do_preadv+0x1c4/0x280 fs/read_write.c:1089
 __do_sys_preadv fs/read_write.c:1139 [inline]
 __se_sys_preadv fs/read_write.c:1134 [inline]
 __x64_sys_preadv+0x9a/0xf0 fs/read_write.c:1134
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x441389
Code: e8 ac e8 ff ff 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 eb 08 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffc8aa7ce38 EFLAGS: 00000246 ORIG_RAX: 0000000000000127
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000441389
RDX: 0000000000000227 RSI: 00000000200017c0 RDI: 0000000000000004
RBP: 00007ffc8aa7ce50 R08: 000000000000000f R09: 00000000000000c2
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000402100
R13: 0000000000402190 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 9852:
 save_stack+0x23/0x90 mm/kasan/common.c:72
 set_track mm/kasan/common.c:80 [inline]
 __kasan_kmalloc mm/kasan/common.c:515 [inline]
 __kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:488
 kasan_kmalloc+0x9/0x10 mm/kasan/common.c:529
 kmem_cache_alloc_trace+0x158/0x790 mm/slab.c:3551
 kmalloc include/linux/slab.h:555 [inline]
 kzalloc include/linux/slab.h:669 [inline]
 snd_timer_instance_new+0x4a/0x300 sound/core/timer.c:142
 snd_seq_timer_open+0x1c0/0x590 sound/core/seq/seq_timer.c:275
 queue_use+0xf1/0x270 sound/core/seq/seq_queue.c:489
 snd_seq_queue_alloc+0x2c5/0x4d0 sound/core/seq/seq_queue.c:176
 snd_seq_ioctl_create_queue+0xb0/0x330 sound/core/seq/seq_clientmgr.c:1548
 snd_seq_kernel_client_ctl+0xf8/0x140 sound/core/seq/seq_clientmgr.c:2353
 alloc_seq_queue.isra.0+0xdc/0x180 sound/core/seq/oss/seq_oss_init.c:357
 snd_seq_oss_open+0x2ff/0x960 sound/core/seq/oss/seq_oss_init.c:215
 odev_open+0x70/0x90 sound/core/seq/oss/seq_oss.c:125
 soundcore_open+0x453/0x610 sound/sound_core.c:593
 chrdev_open+0x245/0x6b0 fs/char_dev.c:414
 do_dentry_open+0x4ca/0x1350 fs/open.c:797
 vfs_open+0xa0/0xd0 fs/open.c:914
 do_last fs/namei.c:3487 [inline]
 path_openat+0x12fd/0x34d0 fs/namei.c:3604
 do_filp_open+0x192/0x260 fs/namei.c:3634
 do_sys_openat2+0x633/0x840 fs/open.c:1151
 do_sys_open+0xfc/0x190 fs/open.c:1167
 __do_sys_openat fs/open.c:1181 [inline]
 __se_sys_openat fs/open.c:1176 [inline]
 __x64_sys_openat+0x9d/0x100 fs/open.c:1176
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 9852:
 save_stack+0x23/0x90 mm/kasan/common.c:72
 set_track mm/kasan/common.c:80 [inline]
 kasan_set_free_info mm/kasan/common.c:337 [inline]
 __kasan_slab_free+0x102/0x150 mm/kasan/common.c:476
 kasan_slab_free+0xe/0x10 mm/kasan/common.c:485
 __cache_free mm/slab.c:3426 [inline]
 kfree+0x10a/0x2c0 mm/slab.c:3757
 snd_timer_instance_free sound/core/timer.c:166 [inline]
 snd_timer_instance_free+0x7c/0xa0 sound/core/timer.c:160
 snd_seq_timer_close+0x99/0xe0 sound/core/seq/seq_timer.c:319
 queue_delete+0x52/0xb0 sound/core/seq/seq_queue.c:134
 snd_seq_queue_delete+0x4e/0x70 sound/core/seq/seq_queue.c:196
 snd_seq_ioctl_delete_queue+0x6a/0x90 sound/core/seq/seq_clientmgr.c:1570
 snd_seq_kernel_client_ctl+0xf8/0x140 sound/core/seq/seq_clientmgr.c:2353
 delete_seq_queue.part.0+0xb6/0x120 sound/core/seq/oss/seq_oss_init.c:376
 delete_seq_queue sound/core/seq/oss/seq_oss_init.c:372 [inline]
 snd_seq_oss_release+0x116/0x150 sound/core/seq/oss/seq_oss_init.c:421
 odev_release+0x54/0x80 sound/core/seq/oss/seq_oss.c:140
 __fput+0x2ff/0x890 fs/file_table.c:280
 ____fput+0x16/0x20 fs/file_table.c:313
 task_work_run+0x145/0x1c0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0xbcb/0x2f80 kernel/exit.c:801
 do_group_exit+0x135/0x360 kernel/exit.c:899
 __do_sys_exit_group kernel/exit.c:910 [inline]
 __se_sys_exit_group kernel/exit.c:908 [inline]
 __x64_sys_exit_group+0x44/0x50 kernel/exit.c:908
 do_syscall_64+0xfa/0x790 arch/x86/entry/common.c:294
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff88809e0f5a00
 which belongs to the cache kmalloc-256 of size 256
The buggy address is located 0 bytes inside of
 256-byte region [ffff88809e0f5a00, ffff88809e0f5b00)
The buggy address belongs to the page:
page:ffffea0002783d40 refcount:1 mapcount:0 mapping:ffff8880aa4008c0 index:0x0
flags: 0xfffe0000000200(slab)
raw: 00fffe0000000200 ffffea0002783948 ffffea00027872c8 ffff8880aa4008c0
raw: 0000000000000000 ffff88809e0f5000 0000000100000008 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88809e0f5900: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff88809e0f5980: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff88809e0f5a00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                   ^
 ffff88809e0f5a80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88809e0f5b00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================

Crashes (5):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/02/02 12:55 linux-next 2747d5fdab78 2274ad39 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2020/01/16 22:58 upstream f5ae2ea6347a 3de7aabb .config console log report ci-upstream-kasan-gce-selinux-root
2020/01/15 05:27 upstream e033e7d4a808 fa12bd3c .config console log report ci-upstream-kasan-gce-386
2020/01/29 02:24 linux-next 2747d5fdab78 c8e81ce4 .config console log report ci-upstream-linux-next-kasan-gce-root
2020/01/27 03:49 linux-next 2747d5fdab78 dd56146d .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.