syzbot


possible deadlock in attr_data_get_block

Status: upstream: reported C repro on 2022/10/17 07:43
Labels: ntfs3 (incorrect?)
Reported-by: syzbot+36bb70085ef6edc2ebb9@syzkaller.appspotmail.com
First crash: 228d, last: 7h07m

Cause bisection: failed (error log, bisect log)
Discussions (4)
Title Replies (including bot) Last reply
[syzbot] Monthly ntfs3 report (May 2023) 0 (1) 2023/05/29 08:47
[syzbot] Monthly ntfs3 report (Apr 2023) 0 (1) 2023/04/28 08:47
[syzbot] Monthly ntfs3 report 0 (1) 2023/03/27 17:38
[syzbot] possible deadlock in attr_data_get_block 0 (2) 2022/12/04 18:11
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in attr_data_get_block 27 1d19h 65d 0/3 upstream: reported on 2023/03/29 04:32
linux-5.15 possible deadlock in attr_data_get_block 54 1d09h 67d 0/3 upstream: reported on 2023/03/27 15:11
Last patch testing requests (1)
Created Duration User Patch Repo Result
2022/12/05 10:08 26m hdanton@sina.com patch https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c2bf05db6c78 OK log

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.4.0-rc1-syzkaller-00012-g16a8829130ca #0 Not tainted
------------------------------------------------------
syz-executor184/4990 is trying to acquire lock:
ffff888074ae7700 (&ni->ni_lock#2/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline]
ffff888074ae7700 (&ni->ni_lock#2/4){+.+.}-{3:3}, at: attr_data_get_block+0x46d/0x2da0 fs/ntfs3/attrib.c:918

but task is already holding lock:
ffff88802664f668 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:110 [inline]
ffff88802664f668 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x17c/0x410 mm/util.c:541

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&mm->mmap_lock){++++}-{3:3}:
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691
       __might_fault+0xba/0x120 mm/memory.c:5732
       _copy_to_user+0x2a/0xa0 lib/usercopy.c:36
       copy_to_user include/linux/uaccess.h:191 [inline]
       fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:144
       ni_fiemap+0x100b/0x1230 fs/ntfs3/frecord.c:1944
       ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1137
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x19ba/0x2b10 fs/ioctl.c:810
       __do_sys_ioctl fs/ioctl.c:868 [inline]
       __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&ni->ni_lock#2/4){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3108 [inline]
       check_prevs_add kernel/locking/lockdep.c:3227 [inline]
       validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3842
       __lock_acquire+0x1295/0x2000 kernel/locking/lockdep.c:5074
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691
       __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
       ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline]
       attr_data_get_block+0x46d/0x2da0 fs/ntfs3/attrib.c:918
       ntfs_file_mmap+0x453/0x7a0 fs/ntfs3/file.c:291
       call_mmap include/linux/fs.h:1873 [inline]
       mmap_region+0xe65/0x2250 mm/mmap.c:2652
       do_mmap+0x8c9/0xf70 mm/mmap.c:1394
       vm_mmap_pgoff+0x1db/0x410 mm/util.c:543
       ksys_mmap_pgoff+0x4f9/0x6d0 mm/mmap.c:1440
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&ni->ni_lock#2/4);
                               lock(&mm->mmap_lock);
  lock(&ni->ni_lock#2/4);

 *** DEADLOCK ***

1 lock held by syz-executor184/4990:
 #0: ffff88802664f668 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:110 [inline]
 #0: ffff88802664f668 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x17c/0x410 mm/util.c:541

stack backtrace:
CPU: 0 PID: 4990 Comm: syz-executor184 Not tainted 6.4.0-rc1-syzkaller-00012-g16a8829130ca #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2188
 check_prev_add kernel/locking/lockdep.c:3108 [inline]
 check_prevs_add kernel/locking/lockdep.c:3227 [inline]
 validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3842
 __lock_acquire+0x1295/0x2000 kernel/locking/lockdep.c:5074
 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5691
 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
 __mutex_lock kernel/locking/mutex.c:747 [inline]
 mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
 ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline]
 attr_data_get_block+0x46d/0x2da0 fs/ntfs3/attrib.c:918
 ntfs_file_mmap+0x453/0x7a0 fs/ntfs3/file.c:291
 call_mmap include/linux/fs.h:1873 [inline]
 mmap_region+0xe65/0x2250 mm/mmap.c:2652
 do_mmap+0x8c9/0xf70 mm/mmap.c:1394
 vm_mmap_pgoff+0x1db/0x410 mm/util.c:543
 ksys_mmap_pgoff+0x4f9/0x6d0 mm/mmap.c:1440
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f4b4d822d19
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd50ef9d38 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: ffffffffffffffda RBX: 0030656c69662f2e RCX: 00007f4b4d822d19
RDX: 0000000000800006 RSI: 000000000000a000 RDI: 0000000020001000
RBP: 00007f4b4d7e

Crashes (954):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Manager Title
2023/05/10 09:20 upstream 16a8829130ca 1964022b .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-smack-root possible deadlock in attr_data_get_block
2022/12/31 11:51 upstream c8451c141e07 ab32d508 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-root possible deadlock in attr_data_get_block
2022/12/04 18:11 upstream c2bf05db6c78 e080de16 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/12 22:04 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 14f8db1c0f9a ecca8a24 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-gce-arm64 possible deadlock in attr_data_get_block
2023/06/02 13:38 upstream c43a6ff9f93f a4ae4f42 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/06/02 09:19 upstream 1874a42a7d74 a4ae4f42 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/06/02 06:25 upstream 1874a42a7d74 a4ae4f42 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/06/01 23:30 upstream 1874a42a7d74 a4ae4f42 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/06/01 21:22 upstream 929ed21dfdb6 a4ae4f42 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/06/01 09:48 upstream 48b1320a674e babc4389 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/31 12:01 upstream afead42fdfca 09898419 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/31 04:39 upstream afead42fdfca 09898419 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/30 06:28 upstream 8b817fded42d cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/29 05:05 upstream 7877cb91f108 cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/28 17:40 upstream 7877cb91f108 cf184559 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in attr_data_get_block
2023/05/28 17:02 upstream 7877cb91f108 cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-smack-root possible deadlock in attr_data_get_block
2023/05/28 07:50 upstream 4e893b5aa4ac cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/28 04:11 upstream 4e893b5aa4ac cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/27 22:40 upstream 4e893b5aa4ac cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/27 16:01 upstream 49572d536129 cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-smack-root possible deadlock in attr_data_get_block
2023/05/27 08:48 upstream 49572d536129 cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/27 00:41 upstream 0d85b27b0cc6 cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root possible deadlock in attr_data_get_block
2023/05/26 08:19 upstream 9db898594c54 b40ef614 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/26 00:59 upstream 9db898594c54 0513b3e6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/25 05:37 upstream 933174ae28ba 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/25 03:05 upstream 9d646009f65d 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/23 13:23 upstream ae8373a5add4 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/23 10:37 upstream 421ca22e3138 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/23 00:48 upstream 421ca22e3138 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-smack-root possible deadlock in attr_data_get_block
2023/05/22 08:23 upstream e2065b8c1b01 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/21 17:17 upstream 0dd2a6fb1e34 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/21 06:42 upstream 0dd2a6fb1e34 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/20 08:16 upstream cbd6ac3837cd 96689200 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/20 01:56 upstream cbd6ac3837cd 96689200 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-smack-root possible deadlock in attr_data_get_block
2023/05/19 20:10 upstream cbd6ac3837cd 96689200 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/19 15:20 upstream 2d1bcbc6cd70 96689200 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/19 10:56 upstream 2d1bcbc6cd70 3bb7af1d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-smack-root possible deadlock in attr_data_get_block
2023/05/19 00:57 upstream 2d1bcbc6cd70 3bb7af1d .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/17 21:17 upstream 1b66c114d161 3bb7af1d .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/16 19:27 upstream f1fcbaa18b28 11c89444 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/16 10:22 upstream f1fcbaa18b28 71b00cfb .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/16 01:39 upstream f1fcbaa18b28 71b00cfb .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/15 21:58 upstream f1fcbaa18b28 c4d362e7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/15 10:43 upstream f1fcbaa18b28 c4d362e7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/14 23:21 upstream bb7c241fae62 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/14 13:05 upstream bb7c241fae62 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/14 11:33 upstream d4d58949a6ea 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/14 03:50 upstream d4d58949a6ea 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/14 01:28 upstream d4d58949a6ea 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/13 07:26 upstream 9a48d6046722 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/05/06 07:05 upstream 2e1e1337881b 90c93c40 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in attr_data_get_block
2023/05/18 17:19 upstream 4d6d4c7f541d 3bb7af1d .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in attr_data_get_block
2023/05/25 04:35 linux-next 715abedee4cd 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in attr_data_get_block
2023/05/25 14:41 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci f1fcbaa18b28 0513b3e6 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in attr_data_get_block
2023/05/13 23:30 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 14f8db1c0f9a 2b9ba477 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in attr_data_get_block
2022/10/17 06:53 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci bbed346d5a96 67cb024c .config console log report info [disk image] [vmlinux] ci-upstream-gce-arm64 possible deadlock in attr_data_get_block
* Struck through repros no longer work on HEAD.