syzbot


possible deadlock in attr_data_get_block

Status: upstream: reported C repro on 2022/10/17 07:43
Subsystems: ntfs3
[Documentation on labels]
Reported-by: syzbot+36bb70085ef6edc2ebb9@syzkaller.appspotmail.com
First crash: 419d, last: 37m
Cause bisection: failed (error log, bisect log)
  
Discussions (10)
Title Replies (including bot) Last reply
[syzbot] Monthly ntfs3 report (Dec 2023) 0 (1) 2023/12/02 14:45
[syzbot] Monthly ntfs3 report (Oct 2023) 0 (1) 2023/11/01 10:13
[syzbot] Monthly ntfs3 report (Sep 2023) 0 (1) 2023/10/02 09:42
[syzbot] Monthly ntfs3 report (Aug 2023) 0 (1) 2023/08/30 12:45
[syzbot] Monthly ntfs3 report (Jul 2023) 0 (1) 2023/07/30 13:16
[syzbot] Monthly ntfs3 report (Jun 2023) 0 (1) 2023/06/29 09:21
[syzbot] Monthly ntfs3 report (May 2023) 0 (1) 2023/05/29 08:47
[syzbot] Monthly ntfs3 report (Apr 2023) 0 (1) 2023/04/28 08:47
[syzbot] Monthly ntfs3 report 0 (1) 2023/03/27 17:38
[syzbot] possible deadlock in attr_data_get_block 0 (2) 2022/12/04 18:11
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in attr_data_get_block 46 21d 256d 0/3 upstream: reported on 2023/03/29 04:32
linux-5.15 possible deadlock in attr_data_get_block origin:lts-only C done 96 15d 257d 0/3 upstream: reported C repro on 2023/03/27 15:11
Last patch testing requests (1)
Created Duration User Patch Repo Result
2022/12/05 10:08 26m hdanton@sina.com patch https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c2bf05db6c78 OK log

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.7.0-rc1-syzkaller-00012-g9bacdd8996c7 #0 Not tainted
------------------------------------------------------
syz-executor106/5073 is trying to acquire lock:
ffff888079be4360 (&ni->ni_lock#2/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline]
ffff888079be4360 (&ni->ni_lock#2/4){+.+.}-{3:3}, at: attr_data_get_block+0x46d/0x2da0 fs/ntfs3/attrib.c:918

but task is already holding lock:
ffff88804a17d720 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:124 [inline]
ffff88804a17d720 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x181/0x420 mm/util.c:544

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&mm->mmap_lock){++++}-{3:3}:
       lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5753
       __might_fault+0xc1/0x120 mm/memory.c:5955
       _copy_to_user+0x2a/0xa0 lib/usercopy.c:36
       copy_to_user include/linux/uaccess.h:191 [inline]
       fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:145
       ni_fiemap+0x100b/0x1230 fs/ntfs3/frecord.c:1948
       ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1164
       ioctl_fiemap fs/ioctl.c:220 [inline]
       do_vfs_ioctl+0x19ea/0x2b40 fs/ioctl.c:811
       __do_sys_ioctl fs/ioctl.c:869 [inline]
       __se_sys_ioctl+0x81/0x170 fs/ioctl.c:857
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82
       entry_SYSCALL_64_after_hwframe+0x63/0x6b

-> #0 (&ni->ni_lock#2/4){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain+0x18e4/0x59f0 kernel/locking/lockdep.c:3868
       __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5136
       lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5753
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747
       ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline]
       attr_data_get_block+0x46d/0x2da0 fs/ntfs3/attrib.c:918
       ntfs_file_mmap+0x453/0x7a0 fs/ntfs3/file.c:292
       call_mmap include/linux/fs.h:2025 [inline]
       mmap_region+0xf47/0x1fa0 mm/mmap.c:2851
       do_mmap+0x76b/0xde0 mm/mmap.c:1379
       vm_mmap_pgoff+0x1e2/0x420 mm/util.c:546
       ksys_mmap_pgoff+0x4ff/0x6d0 mm/mmap.c:1425
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82
       entry_SYSCALL_64_after_hwframe+0x63/0x6b

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&ni->ni_lock#2/4);
                               lock(&mm->mmap_lock);
  lock(&ni->ni_lock#2/4);

 *** DEADLOCK ***

1 lock held by syz-executor106/5073:
 #0: ffff88804a17d720 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:124 [inline]
 #0: ffff88804a17d720 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x181/0x420 mm/util.c:544

stack backtrace:
CPU: 0 PID: 5073 Comm: syz-executor106 Not tainted 6.7.0-rc1-syzkaller-00012-g9bacdd8996c7 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x366/0x490 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain+0x18e4/0x59f0 kernel/locking/lockdep.c:3868
 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5136
 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5753
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747
 ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline]
 attr_data_get_block+0x46d/0x2da0 fs/ntfs3/attrib.c:918
 ntfs_file_mmap+0x453/0x7a0 fs/ntfs3/file.c:292
 call_mmap include/linux/fs.h:2025 [inline]
 mmap_region+0xf47/0x1fa0 mm/mmap.c:2851
 do_mmap+0x76b/0xde0 mm/mmap.c:1379
 vm_mmap_pgoff+0x1e2/0x420 mm/util.c:546
 ksys_mmap_pgoff+0x4ff/0x6d0 mm/mmap.c:1425
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82
 entry_SYSCALL_64_after_hwframe+0x63/0x6b
RIP: 0033:0x7f44f880c639
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 81 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f44f87a8208 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: ffffffffffffffda RBX: 00007f44f88b3618 RCX: 00007f44f880c639
RDX: 00000000027fffff RSI: 0000000000600000 RDI: 0000000020000000
RBP: 00007f44f88b3610 R08: 0000000000000004 R09: 0000000000000000
R10: 0000000004002011 R11: 0000000000000246 R12: 00007f44f887fb5c
R13: 00007f44f88600c0 R14: 6465646165726874 R15: 0030656c69662f2e
 </TASK>

Crashes (1485):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/11/14 08:25 upstream 9bacdd8996c7 cb976f63 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/14 07:22 upstream 9bacdd8996c7 cb976f63 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/10/28 12:24 upstream 56567a20b22b 3c418d72 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/10/15 21:27 upstream 9a3dad63edbe 6388bc36 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-smack-root possible deadlock in attr_data_get_block
2023/06/29 01:42 upstream e8f75c0270d9 8064cb02 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-selinux-root possible deadlock in attr_data_get_block
2023/05/10 09:20 upstream 16a8829130ca 1964022b .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-smack-root possible deadlock in attr_data_get_block
2022/12/31 11:51 upstream c8451c141e07 ab32d508 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-gce-root possible deadlock in attr_data_get_block
2022/12/04 18:11 upstream c2bf05db6c78 e080de16 .config strace log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/12 00:26 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 8de1e7afcc1c 6d6dbf8a .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-gce-arm64 possible deadlock in attr_data_get_block
2023/05/12 22:04 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 14f8db1c0f9a ecca8a24 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-gce-arm64 possible deadlock in attr_data_get_block
2023/11/14 09:55 upstream 9bacdd8996c7 cb976f63 .config console log report syz [disk image] [vmlinux] [kernel image] [mounted in repro #1] [mounted in repro #2] ci-upstream-kasan-gce-selinux-root possible deadlock in attr_data_get_block
2023/12/10 09:17 upstream b10a3ccaf6e3 28b24332 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/10 06:17 upstream b10a3ccaf6e3 28b24332 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/09 22:13 upstream b10a3ccaf6e3 28b24332 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/09 17:06 upstream f2e8a57ee903 28b24332 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/09 11:01 upstream f2e8a57ee903 28b24332 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/09 01:04 upstream 5e3f5b81de80 28b24332 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/08 13:29 upstream 5e3f5b81de80 28b24332 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/08 00:03 upstream 9ace34a8e446 28b24332 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/07 11:31 upstream bee0e7762ad2 0a02ce36 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/06 18:40 upstream bee0e7762ad2 e3299f55 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/06 14:10 upstream bee0e7762ad2 e3299f55 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/06 13:06 upstream bee0e7762ad2 858d62d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/06 10:55 upstream bee0e7762ad2 858d62d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/05 22:14 upstream bee0e7762ad2 858d62d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/05 19:04 upstream bee0e7762ad2 858d62d1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/05 17:54 upstream bee0e7762ad2 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/05 12:20 upstream bee0e7762ad2 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/05 10:09 upstream bee0e7762ad2 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/05 07:58 upstream bee0e7762ad2 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/05 04:42 upstream bee0e7762ad2 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/04 23:55 upstream bee0e7762ad2 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/04 16:39 upstream 33cc938e65a9 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/04 11:45 upstream 33cc938e65a9 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/03 14:55 upstream 33cc938e65a9 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/03 00:59 upstream 1b8af6552cb7 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/02 15:15 upstream 815fb87b7530 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/01 14:13 upstream 994d5c58e50e f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/12/01 00:52 upstream e8f60209d6cf f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/30 12:43 upstream 3b47bc037bd4 f819d6f7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/29 23:55 upstream 3b47bc037bd4 6e78f9ce .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/29 17:35 upstream 3b47bc037bd4 6e78f9ce .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/29 12:35 upstream 18d46e76d7c2 6e78f9ce .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/28 21:13 upstream 18d46e76d7c2 1adfb6f6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/28 07:13 upstream df60cee26a2e 9fe51b7c .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/28 05:12 upstream df60cee26a2e 7ec6c044 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/28 03:19 upstream 2cc14f52aeb7 7ec6c044 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/28 01:34 upstream 2cc14f52aeb7 7ec6c044 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/27 21:13 upstream 2cc14f52aeb7 7ec6c044 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/27 15:44 upstream 2cc14f52aeb7 7ec6c044 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/27 11:12 upstream 2cc14f52aeb7 5b429f39 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/26 21:22 upstream d2da77f431ac 5b429f39 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/26 19:02 upstream 090472ed9c92 5b429f39 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/26 08:37 upstream 090472ed9c92 5b429f39 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/26 07:37 upstream 090472ed9c92 5b429f39 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in attr_data_get_block
2023/11/14 04:30 upstream b85ea95d0864 cb976f63 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-smack-root possible deadlock in attr_data_get_block
2023/10/22 22:29 upstream fe3cfe869d5e 361b23dc .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root possible deadlock in attr_data_get_block
2023/10/18 22:10 upstream dd72f9c7e512 342b9c55 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in attr_data_get_block
2023/07/24 08:05 upstream 269f4a4b85a1 27cbe77f .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in attr_data_get_block
2023/08/23 01:24 upstream 53663f4103ff b81ca3f6 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in attr_data_get_block
2023/11/27 09:07 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci 8de1e7afcc1c 5b429f39 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in attr_data_get_block
2023/05/25 04:35 linux-next 715abedee4cd 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in attr_data_get_block
2022/10/17 06:53 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci bbed346d5a96 67cb024c .config console log report info [disk image] [vmlinux] ci-upstream-gce-arm64 possible deadlock in attr_data_get_block
* Struck through repros no longer work on HEAD.