syzbot

======================================================
WARNING: possible circular locking dependency detected
6.13.0-syzkaller-07644-gc2da8b3f914f #0 Not tainted
------------------------------------------------------
syz.0.0/5327 is trying to acquire lock:
ffff8880531022e0 (&oi->ip_alloc_sem){++++}-{4:4}, at: ocfs2_xattr_ibody_set+0x12c/0xd00 fs/ocfs2/xattr.c:2783

but task is already holding lock:
ffff888034016950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1e94/0x2110 fs/jbd2/transaction.c:448

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851
       start_this_handle+0x1eb4/0x2110 fs/jbd2/transaction.c:448
       jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:505
       jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:544
       ocfs2_start_trans+0x3c9/0x700 fs/ocfs2/journal.c:352
       ocfs2_modify_bh+0xed/0x4d0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x158f/0x19f0 fs/ocfs2/quota_local.c:771
       dquot_load_quota_sb+0x762/0xbb0 fs/quota/dquot.c:2459
       dquot_load_quota_inode+0x320/0x600 fs/quota/dquot.c:2496
       ocfs2_enable_quotas+0x169/0x450 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x4ca1/0x5760 fs/ocfs2/super.c:1141
       mount_bdev+0x20a/0x2d0 fs/super.c:1693
       legacy_get_tree+0xee/0x190 fs/fs_context.c:662
       vfs_get_tree+0x90/0x2b0 fs/super.c:1814
       do_new_mount+0x2be/0xb40 fs/namespace.c:3560
       do_mount fs/namespace.c:3900 [inline]
       __do_sys_mount fs/namespace.c:4111 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4088
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851
       down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524
       ocfs2_start_trans+0x3be/0x700 fs/ocfs2/journal.c:350
       ocfs2_modify_bh+0xed/0x4d0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x158f/0x19f0 fs/ocfs2/quota_local.c:771
       dquot_load_quota_sb+0x762/0xbb0 fs/quota/dquot.c:2459
       dquot_load_quota_inode+0x320/0x600 fs/quota/dquot.c:2496
       ocfs2_enable_quotas+0x169/0x450 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x4ca1/0x5760 fs/ocfs2/super.c:1141
       mount_bdev+0x20a/0x2d0 fs/super.c:1693
       legacy_get_tree+0xee/0x190 fs/fs_context.c:662
       vfs_get_tree+0x90/0x2b0 fs/super.c:1814
       do_new_mount+0x2be/0xb40 fs/namespace.c:3560
       do_mount fs/namespace.c:3900 [inline]
       __do_sys_mount fs/namespace.c:4111 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4088
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#2){.+.+}-{0:0}:
       reacquire_held_locks+0x3eb/0x690 kernel/locking/lockdep.c:5376
       __lock_release kernel/locking/lockdep.c:5565 [inline]
       lock_release+0x396/0xa30 kernel/locking/lockdep.c:5872
       up_write+0x79/0x590 kernel/locking/rwsem.c:1629
       inode_unlock include/linux/fs.h:870 [inline]
       ocfs2_free_ac_resource fs/ocfs2/suballoc.c:130 [inline]
       ocfs2_free_alloc_context+0x95/0x1a0 fs/ocfs2/suballoc.c:144
       ocfs2_write_begin_nolock+0x4ec0/0x5060 fs/ocfs2/aops.c:1823
       ocfs2_dio_wr_get_block+0xc3b/0x18d0 fs/ocfs2/aops.c:2237
       get_more_blocks fs/direct-io.c:648 [inline]
       do_direct_IO fs/direct-io.c:936 [inline]
       __blockdev_direct_IO+0x1c87/0x4890 fs/direct-io.c:1243
       ocfs2_direct_IO+0x255/0x2c0 fs/ocfs2/aops.c:2464
       generic_file_direct_write+0x1e6/0x400 mm/filemap.c:4055
       __generic_file_write_iter+0x126/0x230 mm/filemap.c:4219
       ocfs2_file_write_iter+0x19af/0x2180 fs/ocfs2/file.c:2469
       do_iter_readv_writev+0x71a/0x9d0
       vfs_writev+0x38b/0xbc0 fs/read_write.c:1050
       do_pwritev fs/read_write.c:1146 [inline]
       __do_sys_pwritev2 fs/read_write.c:1204 [inline]
       __se_sys_pwritev2+0x196/0x2b0 fs/read_write.c:1195
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_alloc_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3163 [inline]
       check_prevs_add kernel/locking/lockdep.c:3282 [inline]
       validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3906
       __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5228
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851
       down_write+0x99/0x220 kernel/locking/rwsem.c:1577
       ocfs2_xattr_ibody_set+0x12c/0xd00 fs/ocfs2/xattr.c:2783
       __ocfs2_xattr_set_handle+0x128/0x10a0 fs/ocfs2/xattr.c:3322
       ocfs2_xattr_set+0x128c/0x1930 fs/ocfs2/xattr.c:3650
       __vfs_setxattr+0x468/0x4a0 fs/xattr.c:200
       __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234
       vfs_setxattr+0x221/0x430 fs/xattr.c:321
       do_setxattr fs/xattr.c:636 [inline]
       filename_setxattr+0x2af/0x430 fs/xattr.c:665
       path_setxattrat+0x440/0x510 fs/xattr.c:713
       __do_sys_lsetxattr fs/xattr.c:754 [inline]
       __se_sys_lsetxattr fs/xattr.c:750 [inline]
       __x64_sys_lsetxattr+0xbf/0xe0 fs/xattr.c:750
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_alloc_sem --> &journal->j_trans_barrier --> jbd2_handle

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(jbd2_handle);
                               lock(&journal->j_trans_barrier);
                               lock(jbd2_handle);
  lock(&oi->ip_alloc_sem);

 *** DEADLOCK ***

7 locks held by syz.0.0/5327:
 #0: ffff88803f5ae420 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:547
 #1: ffff888053102640 (&sb->s_type->i_mutex_key#21){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:865 [inline]
 #1: ffff888053102640 (&sb->s_type->i_mutex_key#21){+.+.}-{4:4}, at: vfs_setxattr+0x1e1/0x430 fs/xattr.c:320
 #2: ffff888053102378 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x633/0x1930 fs/ocfs2/xattr.c:3583
 #3: ffff8880530e1800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:865 [inline]
 #3: ffff8880530e1800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x192/0x4e70 fs/ocfs2/suballoc.c:786
 #4: ffff88803f5ae610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_xattr_set+0x1192/0x1930 fs/ocfs2/xattr.c:3643
 #5: ffff8880432788e8 (&journal->j_trans_barrier){.+.+}-{4:4}, at: ocfs2_start_trans+0x3be/0x700 fs/ocfs2/journal.c:350
 #6: ffff888034016950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1e94/0x2110 fs/jbd2/transaction.c:448

stack backtrace:
CPU: 0 UID: 0 PID: 5327 Comm: syz.0.0 Not tainted 6.13.0-syzkaller-07644-gc2da8b3f914f #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2076
 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2208
 check_prev_add kernel/locking/lockdep.c:3163 [inline]
 check_prevs_add kernel/locking/lockdep.c:3282 [inline]
 validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3906
 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5228
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851
 down_write+0x99/0x220 kernel/locking/rwsem.c:1577
 ocfs2_xattr_ibody_set+0x12c/0xd00 fs/ocfs2/xattr.c:2783
 __ocfs2_xattr_set_handle+0x128/0x10a0 fs/ocfs2/xattr.c:3322
 ocfs2_xattr_set+0x128c/0x1930 fs/ocfs2/xattr.c:3650
 __vfs_setxattr+0x468/0x4a0 fs/xattr.c:200
 __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234
 vfs_setxattr+0x221/0x430 fs/xattr.c:321
 do_setxattr fs/xattr.c:636 [inline]
 filename_setxattr+0x2af/0x430 fs/xattr.c:665
 path_setxattrat+0x440/0x510 fs/xattr.c:713
 __do_sys_lsetxattr fs/xattr.c:754 [inline]
 __se_sys_lsetxattr fs/xattr.c:750 [inline]
 __x64_sys_lsetxattr+0xbf/0xe0 fs/xattr.c:750
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f127d98cd29
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1279dd4038 EFLAGS: 00000246 ORIG_RAX: 00000000000000bd
RAX: ffffffffffffffda RBX: 00007f127dba6080 RCX: 00007f127d98cd29
RDX: 0000000000000000 RSI: 0000000020000180 RDI: 0000000020000140
RBP: 00007f127da0e2a0 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f127dba6080 R15: 00007ffd77ae8628
 </TASK>