syzbot


WARNING in mptcp_pm_nl_set_flags

Status: fixed on 2024/10/22 11:57
Subsystems: mptcp
[Documentation on labels]
Reported-by: syzbot+455d38ecd5f655fc45cf@syzkaller.appspotmail.com
Fix commit: 9366922adc6a mptcp: pm: fix ID 0 endp usage after multiple re-creations
First crash: 101d, last: 100d
Cause bisection: introduced by (bisect log) :
commit 322ea3778965da72862cca2a0c50253aacf65fe6
Author: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Date: Mon Aug 19 19:45:26 2024 +0000

  mptcp: pm: only mark 'subflow' endp as available

Crash: WARNING in mptcp_pm_nl_set_flags (log)
Repro: syz .config
  
Discussions (3)
Title Replies (including bot) Last reply
[PATCH net v2 00/15] mptcp: more fixes for the in-kernel PM 3 (3) 2024/08/29 09:00
[PATCH net 00/15] mptcp: more fixes for the in-kernel PM 4 (4) 2024/08/27 08:22
[syzbot] [mptcp?] WARNING in mptcp_pm_nl_set_flags 1 (2) 2024/08/26 11:57

Sample crash report:
------------[ cut here ]------------
WARNING: CPU: 0 PID: 5463 at net/mptcp/pm_netlink.c:1467 __mark_subflow_endp_available net/mptcp/pm_netlink.c:1467 [inline]
WARNING: CPU: 0 PID: 5463 at net/mptcp/pm_netlink.c:1467 mptcp_pm_nl_fullmesh net/mptcp/pm_netlink.c:1948 [inline]
WARNING: CPU: 0 PID: 5463 at net/mptcp/pm_netlink.c:1467 mptcp_nl_set_flags net/mptcp/pm_netlink.c:1971 [inline]
WARNING: CPU: 0 PID: 5463 at net/mptcp/pm_netlink.c:1467 mptcp_pm_nl_set_flags+0x926/0xd50 net/mptcp/pm_netlink.c:2032
Modules linked in:
CPU: 0 UID: 0 PID: 5463 Comm: syz.2.17 Not tainted 6.11.0-rc4-syzkaller-00138-g8af174ea863c #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
RIP: 0010:__mark_subflow_endp_available net/mptcp/pm_netlink.c:1467 [inline]
RIP: 0010:mptcp_pm_nl_fullmesh net/mptcp/pm_netlink.c:1948 [inline]
RIP: 0010:mptcp_nl_set_flags net/mptcp/pm_netlink.c:1971 [inline]
RIP: 0010:mptcp_pm_nl_set_flags+0x926/0xd50 net/mptcp/pm_netlink.c:2032
Code: 00 00 00 49 89 c5 e8 29 b4 ef f5 e9 08 fd ff ff e8 1f b4 ef f5 4c 89 f7 be 03 00 00 00 e8 02 1c 0d f9 eb a0 e8 0b b4 ef f5 90 <0f> 0b 90 e9 14 ff ff ff 89 d9 80 e1 07 38 c1 0f 8c 19 fd ff ff 48
RSP: 0018:ffffc900030b72a0 EFLAGS: 00010293
RAX: ffffffff8ba3d735 RBX: 1ffff1100fa578aa RCX: ffff888022188000
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: ffffc900030b7470 R08: ffffffff8ba3d621 R09: 1ffff1100fa578ab
R10: dffffc0000000000 R11: ffffed100fa578ac R12: ffff88807d2bc508
R13: ffff88807d2bbac0 R14: 0000000000000000 R15: ffff88807d2bc550
FS:  00007f2a0527c6c0(0000) GS:ffff8880b9200000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2a03fbbfb8 CR3: 000000002c742000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 genl_family_rcv_msg_doit net/netlink/genetlink.c:1115 [inline]
 genl_family_rcv_msg net/netlink/genetlink.c:1195 [inline]
 genl_rcv_msg+0xb14/0xec0 net/netlink/genetlink.c:1210
 netlink_rcv_skb+0x1e3/0x430 net/netlink/af_netlink.c:2550
 genl_rcv+0x28/0x40 net/netlink/genetlink.c:1219
 netlink_unicast_kernel net/netlink/af_netlink.c:1331 [inline]
 netlink_unicast+0x7f6/0x990 net/netlink/af_netlink.c:1357
 netlink_sendmsg+0x8e4/0xcb0 net/netlink/af_netlink.c:1901
 sock_sendmsg_nosec net/socket.c:730 [inline]
 __sock_sendmsg+0x221/0x270 net/socket.c:745
 ____sys_sendmsg+0x525/0x7d0 net/socket.c:2597
 ___sys_sendmsg net/socket.c:2651 [inline]
 __sys_sendmsg+0x2b0/0x3a0 net/socket.c:2680
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f2a04579e79
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2a0527c038 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f2a04715f80 RCX: 00007f2a04579e79
RDX: 0000000000000000 RSI: 0000000020000480 RDI: 000000000000000a
RBP: 00007f2a045e793e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f2a04715f80 R15: 00007ffc7a233418
 </TASK>

Crashes (3):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/08/26 09:42 net 8af174ea863c d7d32352 .config console log report syz / log [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce WARNING in mptcp_pm_nl_set_flags
2024/08/25 18:42 net 8af174ea863c d7d32352 .config console log report syz / log [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce WARNING in mptcp_pm_nl_set_flags
2024/08/25 15:17 net 8af174ea863c d7d32352 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce WARNING in mptcp_pm_nl_set_flags
* Struck through repros no longer work on HEAD.